[Openlp-core] [Bug 1660480] Re: Filetype OSZL is not named in Windows Registry

2019-05-13 Thread Phill
** Changed in: openlp
 Assignee: (unassigned) => Raoul Snyman (raoul-snyman)

** Branch linked: lp:~raoul-snyman/openlp/wix-packaging

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1660480

Title:
  Filetype OSZL is not named in Windows Registry

Status in OpenLP:
  New

Bug description:
  Platform:
  OS: Windows 10 Home
  OpenLP: 2.4.4
  Severity: Super Minor

  What happened:
  In Windows Explorer, I noticed that OSZ files are called "OpenLP Service" in 
the Type column.  OSZL files are called "OSZL File".  It seems that Reg Key 
HKEY_CLASSES_ROOT\.oszl (default) doesn't get set properly during install.

  What I expected to happen:
  I expected the (default) key for HKEY_CLASSES_ROOT\.oszl to be set to "OpenLP 
Service", similar to the OSZ filetype.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1660480/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Bug 1266270] Re: OpenLP hides dialogs whe using "play slides in loop" on OSX

2019-05-13 Thread Phill
** Changed in: openlp/trunk
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1266270

Title:
  OpenLP hides dialogs whe using "play slides in loop" on OSX

Status in OpenLP:
  Fix Released
Status in OpenLP 2.0 series:
  Won't Fix
Status in OpenLP trunk series:
  Fix Released

Bug description:
  OpenLP 2.0.3 on OSX 10.6.8

  Tested on Ubuntu 13.10 and appears fine.

  Send a group of images live and start the images looping using the
  "play slides in loop" then click on "Save as". The "Save as" dialogue
  disappears when the live image changes.

  The first time that this happened OpenLP crashed with the following
  log: http://pastebin.com/MY3NnUWK

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1266270/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Bug 1168493] Re: disappearing dialog 'Select Presentation(s)' on OSX

2019-05-13 Thread Phill
2.4.x is running PyQt5 could somebody test if this bug still exists?

** Changed in: openlp
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1168493

Title:
  disappearing dialog 'Select Presentation(s)' on OSX

Status in OpenLP:
  Fix Released

Bug description:
  With the development version on OS X I'm not able to load images or
  any media since dialog 'Select Presentation(s)' and similar dialogs by
  media and image plugins disappear immediately without any time to be
  able to select any file.

  - It happens mostly when the powerpoint integration is disabled.
  - also last time it happened even with presentations plugin disabled.
  - so it seems it's not related to the powerpoint integration

  My guess would be that something is stealing focus of the openlp
  window or pyqt generates any signals that causes this dialog to
  disappear.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1168493/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v07 into lp:openlp

2019-05-13 Thread Phill
Review: Needs Fixing

You have quite a few "assert (chk == E_NO_AUTHENTICATION), ''" the brackets 
are not needed.

Also you're "@patch.object(openlp.core.projectors.pjlinkcommands, 'log')" a 
lot, have you considered putting it in the setUp method?

Other than that looks good to me!
-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v07/+merge/367304
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp