[Openlp-core] [Merge] lp:~johnmfl/openlp/developer_readme into lp:openlp

2019-08-07 Thread Johnthan
The proposal to merge lp:~johnmfl/openlp/developer_readme into lp:openlp has 
been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~johnmfl/openlp/developer_readme/+merge/371011
-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~johnmfl/openlp/developer_readme into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~johnmfl/openlp/developer_readme into lp:openlp

2019-08-07 Thread Johnthan
This should be put on Hold until superfly can be involved.
-- 
https://code.launchpad.net/~johnmfl/openlp/developer_readme/+merge/371011
Your team OpenLP Core is requested to review the proposed merge of 
lp:~johnmfl/openlp/developer_readme into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Bug 1600510] Re: Deleting a songbook throws "song" attribute exception

2019-08-07 Thread Phill
** Changed in: openlp/trunk
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1600510

Title:
  Deleting a songbook throws "song" attribute exception

Status in OpenLP:
  Fix Committed
Status in OpenLP trunk series:
  Fix Committed

Bug description:
  Bug reported via support system:
  https://support.openlp.org/scp/tickets.php?id=3592

  
  **OpenLP Bug Report** 
  Version: {'version': '2.4.2', 'build': None, 'full': '2.4.2'} 

  --- Details of the Exception. ---

  After Importing songs with Songbeamer importer he added two Song books with
  nearly the same title. So I wanted to rename one to the same title of the
  second to merge them but an exception occured. So I tried to delete the
  Songbook i wnated to rename but the same exception - the actual exception -
  occured.

   --- Exception Traceback --- 
  Traceback (most recent call last): 
File "openlp\plugins\songs\forms\songmaintenanceform.py", line 493, in
  on_delete_book_button_clicked 
File "openlp\plugins\songs\forms\songmaintenanceform.py", line 110, in
  _delete_item 
  AttributeError: 'Book' object has no attribute 'songs' 

  --- System information --- 
  Plattform: Windows-10-10.0.10586-SP0 

  --- Library Versions --- 
  Python: 3.4.4 
  Qt5: 5.5.1 
  PyQt5: 5.5.1 
  QtWebkit: 538.1 
  SQLAlchemy: 1.0.13 
  SQLAlchemy Migrate: - 
  BeautifulSoup: 4.4.1 
  lxml: 3.4.4 
  Chardet: 2.3.0 
  PyEnchant: 1.6.6 
  Mako: 1.0.3 
  pyICU: 1.9.2 
  pyUNO bridge: - 
  VLC: -

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1600510/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Bug 1832942] Re: version 2880 advanced setting alignment

2019-08-07 Thread Phill
** Changed in: openlp
   Status: In Progress => Fix Committed

** Changed in: openlp
Milestone: None => 2.9.1

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1832942

Title:
  version 2880 advanced setting alignment

Status in OpenLP:
  Fix Committed

Bug description:
  Windows 10 32 bit
  Trunk Version 2880
  startup command python run_openlp.py

  The checkbox for hiding the mouse is not aligned with the left of the
  UI boxlooks to be aligned with the dropdown menu above it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1832942/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Bug 1673113] Re: "Save & Preview" Button in Song Editor behaves in a strange way

2019-08-07 Thread Phill
** Changed in: openlp
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1673113

Title:
  "Save & Preview" Button in Song Editor behaves in a strange way

Status in OpenLP:
  Fix Committed

Bug description:
  When you get to the Song Editor by pressing the "edit and reload song
  preview" button in the Preview Section, you get three button to
  process the form "Save & Preview", "Save" and "Cancel".

  My issue is with the first. Upon pressing it apparently nothing happens. The 
editor remains open.
  In fact the "Save" button behaves in the way you would expect the "Save & 
Preview" button behaves. Upon clicking it, the editor closes and the preview is 
refreshed. (Note this does not happen if you press "Save" when accessing the 
Editor from any other place)

  Can I remove the Save & Preview button and all related code?

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1673113/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Bug 1799005] Re: Searching for Bible Book of "Job" in Brazilian Portuguese (Jo) returns the wrong book. Returns Joshua.

2019-08-07 Thread Phill
** Changed in: openlp
   Status: In Progress => Fix Committed

** Changed in: openlp
Milestone: None => 2.9.1

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1799005

Title:
  Searching for Bible Book of "Job" in Brazilian Portuguese (Jo) returns
  the wrong book. Returns Joshua.

Status in OpenLP:
  Fix Committed

Bug description:
  In PT-BR, The book of Job is spelled "Jo", when selecting the search
  and searching for Jo 1, OpenLP returns Joshua (Josué 1). This only
  happens on the Fast Search. Does not happen in Advanced search.
  Happens in any bible version tested.

  OpenLP Version: 2.4.6
  Windows 7

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1799005/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~johnmfl/openlp/developer_readme into lp:openlp

2019-08-07 Thread Phill
I'm not sure about this. This is the page that will show up on GitLab? Has it 
been discussed in IRC? There seems to be some duplication with the wiki. Will 
this be removed from the wiki?
-- 
https://code.launchpad.net/~johnmfl/openlp/developer_readme/+merge/371011
Your team OpenLP Core is requested to review the proposed merge of 
lp:~johnmfl/openlp/developer_readme into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-IV into lp:openlp

2019-08-07 Thread noreply
The proposal to merge lp:~phill-ridout/openlp/fixes-IV into lp:openlp has been 
updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/fixes-IV/+merge/371023
-- 
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes-IV into lp:openlp

2019-08-07 Thread Tim Bentley
Review: Approve


-- 
https://code.launchpad.net/~phill-ridout/openlp/fixes-IV/+merge/371023
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp