Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
The proposal to merge lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0 has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
The proposal to merge lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0 has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
Review: Needs Fixing Can you either append the new line at the end of the previous, or indent it once, to show that it is part of the previous line, and not a new item in the list. -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/178393 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
Phill has proposed merging lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #1184869 in OpenLP: Webbible import fails https://bugs.launchpad.net/openlp/+bug/1184869 For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 Fixes #1184869 Ensures that there is text in the anchor tag -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. === modified file 'openlp/plugins/bibles/lib/http.py' --- openlp/plugins/bibles/lib/http.py 2013-08-03 20:26:46 + +++ openlp/plugins/bibles/lib/http.py 2013-08-12 18:21:22 + @@ -377,6 +377,7 @@ content = content.findAll(u'li') return [ book.contents[0].contents[0] for book in content +if len(book.contents[0].contents) ] ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/178393 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
Phill has proposed merging lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1184869 in OpenLP: Webbible import fails https://bugs.launchpad.net/openlp/+bug/1184869 For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/178393 Fixes #1184869 Ensures that there is text in the anchor tag -- https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/178393 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0. === modified file 'openlp/plugins/bibles/lib/http.py' --- openlp/plugins/bibles/lib/http.py 2012-12-30 19:41:24 + +++ openlp/plugins/bibles/lib/http.py 2013-08-02 21:55:33 + @@ -375,6 +375,7 @@ content = content.findAll(u'li') return [ book.contents[0].contents[0] for book in content +if len(book.contents[0].contents) ] ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
