Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/verse_order into lp:openlp

2010-10-09 Thread Tim Bentley 
Review: Needs Fixing
Do not full understand what this is doing so example please

self.RepeatVerses should be self.repeatVerses
-- 
https://code.launchpad.net/~phill-ridout/openlp/verse_order/+merge/38033
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/verse_order into lp:openlp

2010-10-09 Thread phill 
At the moment, in the preview and live controllers, the verses and choruses are 
repeated as per the verse order. For example in the live controller it might be 
displayed as:

V1
C1
V2
C1
V3
C1
V4
C1

With the added option enabled, this stop C1 from being repeated, so now the 
live controller will show:

V1
C1
V2
V3
V4

This would work better in our church, as the worship leaders do not just follow 
the verse order, but sometimes jump about all over the place. Also it reduces 
the need to scroll in the live controller for most songs!

-- 
https://code.launchpad.net/~phill-ridout/openlp/verse_order/+merge/38033
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/verse_order into lp:openlp

2010-10-09 Thread Jonathan Corwin 
Umm, so change the verse order to V1 C1 V2 V3 V4 then?
-- 
https://code.launchpad.net/~phill-ridout/openlp/verse_order/+merge/38033
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/verse_order into lp:openlp

2010-10-09 Thread Raoul Snyman 
Review: Disapprove
I do not see the need for this. As Jonathan said, if you don't want it in a 
specific order, don't order it.
-- 
https://code.launchpad.net/~phill-ridout/openlp/verse_order/+merge/38040
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp