[Openobject-italia-core-devs] [Bug 1335867] Re: wrong undeductible tax
** Branch linked: lp:~zeroincombenze/openobject-italia/7.0 -- You received this bug notification because you are a member of OpenERP Italia core devs, which is subscribed to OpenERP Italia. https://bugs.launchpad.net/bugs/1335867 Title: wrong undeductible tax Status in OpenERP Italia: Incomplete Bug description: Randomly, software report follow wrong error message: The taxes %s have different rates As in example file, undeductible tax has 2 sub codes, first with suffix a for undeductible rate and last with suffix b for deductible rate. The last one has type = 'balance' in order to receive all residual amount. The wrong code at line 35, property '_have_same_rate' does not check for this condition and returns a unpredictable value, as is randomly recorded. Suggested correction: code for account_tax in account_taxes: # - Code un changed if account_tax.type != 'balance': # Check for balance type if rate is None: # - code unchanged /code To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-italia/+bug/1335867/+subscriptions ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Merge] lp:~zeroincombenze/openobject-italia/7.0 into lp:openobject-italia/7.0
Review: Approve code review LGTM Thanks! -- https://code.launchpad.net/~zeroincombenze/openobject-italia/7.0/+merge/225138 Your team OpenERP Italia core devs is subscribed to branch lp:openobject-italia/7.0. ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Merge] lp:~zeroincombenze/openobject-italia/7.0 into lp:openobject-italia/7.0
Review: Approve code review, no test -- https://code.launchpad.net/~zeroincombenze/openobject-italia/7.0/+merge/225138 Your team OpenERP Italia core devs is subscribed to branch lp:openobject-italia/7.0. ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
[Openobject-italia-core-devs] [Bug 1335867] Re: wrong undeductible tax
Hi. The bug and the merge proposal have each one their own status. The bug here has been set to incomplete by Lorenzo. The merge proposal has two positive votes by Davide and Lorenzo and has not been merged yet. So it usually needs a third approval and someone to actually do the merge. -- You received this bug notification because you are a member of OpenERP Italia core devs, which is subscribed to OpenERP Italia. https://bugs.launchpad.net/bugs/1335867 Title: wrong undeductible tax Status in OpenERP Italia: Incomplete Bug description: Randomly, software report follow wrong error message: The taxes %s have different rates As in example file, undeductible tax has 2 sub codes, first with suffix a for undeductible rate and last with suffix b for deductible rate. The last one has type = 'balance' in order to receive all residual amount. The wrong code at line 35, property '_have_same_rate' does not check for this condition and returns a unpredictable value, as is randomly recorded. Suggested correction: code for account_tax in account_taxes: # - Code un changed if account_tax.type != 'balance': # Check for balance type if rate is None: # - code unchanged /code To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-italia/+bug/1335867/+subscriptions ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Bug 1335867] Re: wrong undeductible tax
Il 03/07/2014 09:40, Leonardo Pistone - camptocamp ha scritto: Hi. The bug and the merge proposal have each one their own status. The bug here has been set to incomplete by Lorenzo. The merge proposal has two positive votes by Davide and Lorenzo and has not been merged yet. So it usually needs a third approval and someone to actually do the merge. Thx for clear exposition! -- Antonio M. Vigliotti (Presidente Chief Technical Officer) *SHS-AV s.r.l. (impresa innovativa) zeroincombenze® * Via Domodossola, 64 - 10145 TORINO - ITALY Tel. (+39) 011.0566929(2) www.shs-av.com PEC shs...@legalmail.it -- You received this bug notification because you are a member of OpenERP Italia core devs, which is subscribed to OpenERP Italia. https://bugs.launchpad.net/bugs/1335867 Title: wrong undeductible tax Status in OpenERP Italia: Incomplete Bug description: Randomly, software report follow wrong error message: The taxes %s have different rates As in example file, undeductible tax has 2 sub codes, first with suffix a for undeductible rate and last with suffix b for deductible rate. The last one has type = 'balance' in order to receive all residual amount. The wrong code at line 35, property '_have_same_rate' does not check for this condition and returns a unpredictable value, as is randomly recorded. Suggested correction: code for account_tax in account_taxes: # - Code un changed if account_tax.type != 'balance': # Check for balance type if rate is None: # - code unchanged /code To manage notifications about this bug go to: https://bugs.launchpad.net/openobject-italia/+bug/1335867/+subscriptions ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
