Re: [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing
Ciao Lorenzo,
they aren't mutually exclusive, in this way only one of them is needed.
But it would be better to set field days invisibile if months are set.
2014-06-04 8:03 GMT+02:00 Lorenzo Battistini - Agile BG
lorenzo.battist...@agilebg.com:
On 06/03/2014 10:35 PM, Sergio Corato wrote:
Hi Nicola, Lorenzo, Holger,
what about delete commercial_month field and put this code instead?
if line.months != 0:
And in the view set the field days required if months if false and
viceversa:
field name=months attrs={'required':[('days','=',False)]}/
and
xpath expr=/form/group/group/field[@name='days']
position=attributes
attribute
name=attrs{'required':[('months','=',False)]}/attribute
/xpath
Ciao Sergio,
this means a user could fill both the 'months' and 'days' fields at the
same time, despite they are mutually exclusive.
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team OpenERP Italia core devs is subscribed to branch
lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month.
___
Mailing list: https://launchpad.net/~openobject-italia-core-devs
Post to : openobject-italia-core-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
More help : https://help.launchpad.net/ListHelp
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team OpenERP Italia core devs is subscribed to branch
lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month.
___
Mailing list: https://launchpad.net/~openobject-italia-core-devs
Post to : openobject-italia-core-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing
In everyway, I overwritten the function (instead of overriden) and cover
the case of 'days' too (for other purposes).
2014-06-04 8:12 GMT+02:00 Sergio Corato sergiocor...@gmail.com:
Ciao Lorenzo,
they aren't mutually exclusive, in this way only one of them is needed.
But it would be better to set field days invisibile if months are set.
2014-06-04 8:03 GMT+02:00 Lorenzo Battistini - Agile BG
lorenzo.battist...@agilebg.com:
On 06/03/2014 10:35 PM, Sergio Corato wrote:
Hi Nicola, Lorenzo, Holger,
what about delete commercial_month field and put this code instead?
if line.months != 0:
And in the view set the field days required if months if false and
viceversa:
field name=months attrs={'required':[('days','=',False)]}/
and
xpath expr=/form/group/group/field[@name='days']
position=attributes
attribute
name=attrs{'required':[('months','=',False)]}/attribute
/xpath
Ciao Sergio,
this means a user could fill both the 'months' and 'days' fields at the
same time, despite they are mutually exclusive.
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team OpenERP Italia core devs is subscribed to branch
lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month.
___
Mailing list: https://launchpad.net/~openobject-italia-core-devs
Post to : openobject-italia-core-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
More help : https://help.launchpad.net/ListHelp
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team OpenERP Italia core devs is subscribed to branch
lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month.
___
Mailing list: https://launchpad.net/~openobject-italia-core-devs
Post to : openobject-italia-core-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing
Hi Nicola, Lorenzo, Holger,
what about delete commercial_month field and put this code instead?
if line.months != 0:
And in the view set the field days required if months if false and
viceversa:
field name=months attrs={'required':[('days','=',False)]}/
and
xpath expr=/form/group/group/field[@name='days'] position=attributes
attribute name=attrs{'required':[('months','=',False)]}/attribute
/xpath
--
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team OpenERP Italia core devs is subscribed to branch
lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month.
___
Mailing list: https://launchpad.net/~openobject-italia-core-devs
Post to : openobject-italia-core-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing
Review: Approve Sorry, review type was approve not resubmit (Lorenzo told me the difference :) ) -- https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400 Your team OpenERP Italia core devs is subscribed to branch lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month. ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
Re: [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing
Review: Needs Fixing #197ff, #202ff missing spaces at end of strings @218ff can't you avoid code duplication and breaking inheritance by using super's result and simply adding the months as applicable? -- https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400 Your team OpenERP Italia core devs is subscribed to branch lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month. ___ Mailing list: https://launchpad.net/~openobject-italia-core-devs Post to : openobject-italia-core-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~openobject-italia-core-devs More help : https://help.launchpad.net/ListHelp
