Re: [Openocd-development] how to push patch series to gerrit?

2011-10-11 Thread Peter Stuge
Øyvind Harboe wrote:
 How do I push a patch series to gerrit?

Put the commits in a branch rooted in the main openocd.git repo
master branch, then push that branch into refs/for/master in gerrit.
(With Spencer's default config you will push it if it is currently
checked out and you run git push review)


 Does gerrit have a concept of patch series or are all patches
 islands?

If you push a series of commits to gerrit as per above then gerrit
will record dependency between the commits.


//Peter
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] how to push patch series to gerrit?

2011-10-11 Thread Øyvind Harboe
 Does gerrit have a concept of patch series or are all patches
 islands?

 If you push a series of commits to gerrit as per above then gerrit
 will record dependency between the commits.

I did git am -s on two patches and tried  using Spencer's config:

 git push review
Counting objects: 16, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 1.44 KiB, done.
Total 11 (delta 9), reused 0 (delta 0)
remote: Resolving deltas:   0% (0/9)
remote: ERROR: missing Change-Id in commit message
remote: Suggestion for commit message:
remote: breakpoint : indentation
remote:
remote: Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com
remote:
remote: Change-Id: Icdb8f72dbb516cd0dfc612c3d61b6801f6382be6



-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] how to push patch series to gerrit?

2011-10-11 Thread Øyvind Harboe
Ah gotit.

I need a unique id per patch, I thought the id had to be unique per series.

I thought that patches would be displayed as series within the same
patch id rather
than this depends on scheme.

-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development