[devel] [PATCH 0 of 1] Review Request for log: wong condition check that might cause incorrectly configured logsv [#1596]

[Vu Minh Nguyen]

Summary: log: wong condition check that might cause incorrectly configured 
logsv[#1596]
Review request for Trac Ticket(s): #1596
Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com; 
giang.t...@dektech.com.au
Pull request to: Lennart
Affected branch(es): 4.7 & default
Development branch: <>


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
 <>

changeset e2593a942f66afc716ce50fa26eed393b2272474
Author: Vu Minh Nguyen 
Date:   Mon, 16 Nov 2015 13:06:33 +0700

log: wong condition check that might cause incorrectly configured log
service [#1596]

Fix wrong condition checking for `logMaxApplicationStreams` that might 
cause
incorrect configured log service at startup.


Complete diffstat:
--
 osaf/services/saf/logsv/lgs/lgs_config.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Testing Commands:
-
 <>


Testing, Expected Results:
--
 <>


Conditions of Submission:
-
 Get ack from peer reviewers or one week is expired.


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 0 of 1] Review Request for log: fix not check special characters from saLogStreamFileName value [#1421]

[Vu Minh Nguyen]

Hi Mathi,

Have you had time to look at this?

If you have no feedback by this Thursday, I will ask Lennart to push the
patch. 

Thanks.

Regards, Vu.

>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Wednesday, November 04, 2015 3:32 PM
>To: mathi.naic...@oracle.com; lennart.l...@ericsson.com;
>giang.t...@dektech.com.au
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: [devel] [PATCH 0 of 1] Review Request for log: fix not check
special
>characters from saLogStreamFileName value [#1421]
>
>Summary: log: fix not check special characters from saLogStreamFileName
value
>[#1421]
>Review request for Trac Ticket(s): #1421
>Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com;
>giang.t...@dektech.com.au
>Pull request to: Lennart
>Affected branch(es): All
>Development branch: <>
>
>
>Impacted area   Impact y/n
>
> Docsn
> Build systemn
> RPM/packaging   n
> Configuration files n
> Startup scripts n
> SAF servicesy
> OpenSAF servicesn
> Core libraries  n
> Samples n
> Tests   n
> Other   n
>
>
>Comments (indicate scope for each "y" above):
>-
> <>
>
>changeset 4e1fe66e277894c89282243d9c26e3fe2f4dfade
>Author:Vu Minh Nguyen 
>Date:  Wed, 04 Nov 2015 15:23:51 +0700
>
>   log: fix not check special characters from saLogStreamFileName value
>[#1421]
>
>   logsv did not check if the created/modified the attribute value was
a
>valid
>   file name or not.
>
>   To fix this, add validation - guarantee that forward slash '/' is
not in
>the
>   file name:
>
>
>Complete diffstat:
>--
> osaf/services/saf/logsv/lgs/lgs_evt.c  |   7 +++
> osaf/services/saf/logsv/lgs/lgs_imm.c  |  11 ++-
> osaf/services/saf/logsv/lgs/lgs_util.c |  57
>+
> osaf/services/saf/logsv/lgs/lgs_util.h |   1 +
> tests/logsv/tet_LogOiOps.c |  40
>
> tests/logsv/tet_saLogStreamOpen_2.c|  51
>+++
> 6 files changed, 166 insertions(+), 1 deletions(-)
>
>
>Testing Commands:
>-
>02 new added test cases. Run following test cases
>logtest 2 49
>logtest 5 16
>
>
>Testing, Expected Results:
>--
>All tests PASS
>
>Conditions of Submission:
>-
> Get ack from peer reviewers
>
>
>Arch  Built StartedLinux distro
>---
>mipsn  n
>mips64  n  n
>x86 n  n
>x86_64  n  n
>powerpc n  n
>powerpc64   n  n
>
>
>Reviewer Checklist:
>---
>[Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
>Your checkin has not passed review because (see checked entries):
>
>___ Your RR template is generally incomplete; it has too many blank entries
>that need proper data filled in.
>
>___ You have failed to nominate the proper persons for review and push.
>
>___ Your patches do not have proper short+long header
>
>___ You have grammar/spelling in your header that is unacceptable.
>
>___ You have exceeded a sensible line length in your headers/comments/text.
>
>___ You have failed to put in a proper Trac Ticket # into your commits.
>
>___ You have incorrectly put/left internal data in your comments/files
>(i.e. internal bug tracking tool IDs, product names etc)
>
>___ You have not given any evidence of testing beyond basic build tests.
>Demonstrate some level of runtime or other sanity testing.
>
>___ You have ^M present in some of your files. These have to be removed.
>
>___ You have needlessly changed whitespace or added whitespace crimes
>like trailing spaces, or spaces before tabs.
>
>___ You have mixed real technical changes with whitespace and other
>cosmetic code cleanup changes. These have to be separate commits.
>
>___ You need to refactor your submission into logical chunks; there is
>too much content into a single commit.
>
>___ You have extraneous garbage in your review (merge commits etc)
>
>___ You have giant attachments which should never have been sent;
>Instead you should place your content in a public tree to be pulled.
>
>___ You have too many commits attached to an e-mail; resend as threaded
>commits, or place in a public tree for a pull.
>
>___ You have resent this content multiple times without a clear indication
>of what has changed between each re-send.
>
>___ You have failed to adequately and individually address all of the
>comments and change requests that were proposed in the initial review.
>
>___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>