Re: [devel] [PATCH 1/1] ntf: correct return code is returned [#2039]

2017-10-02 Thread Srinivas Mangipudy 
Hi Minh,

Please find below my comments inline.

Thank you
Srinivas

-Original Message-
From: minh chau [mailto:minh.c...@dektech.com.au] 
Sent: Thursday, September 28, 2017 6:49 AM
To: Srinivas 
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: correct return code is returned [#2039]

Hi Srinivas,

ack with minor comments.

Thanks
Minh

On 15/09/17 21:10, Srinivas wrote:
> ---
>   src/ntf/apitest/tet_scOutage_reinitializeHandle.c | 18 --
>   1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/src/ntf/apitest/tet_scOutage_reinitializeHandle.c 
> b/src/ntf/apitest/tet_scOutage_reinitializeHandle.c
> index 63dfae9..4af22ef 100644
> --- a/src/ntf/apitest/tet_scOutage_reinitializeHandle.c
> +++ b/src/ntf/apitest/tet_scOutage_reinitializeHandle.c
> @@ -100,6 +100,7 @@ static SaNtfObjectCreateDeleteNotificationT 
> myObjCrDelNotification;
>   static SaNtfAttributeChangeNotificationT myAttrChangeNotification;
>   static SaNtfStateChangeNotificationT myStateChangeNotification;
>   static SaNtfSecurityAlarmNotificationT mySecAlarmNotification;
> +static SaAisErrorT global_error_id = SA_AIS_OK;
>   
>   extern int gl_tag_mode;
>   
> @@ -147,7 +148,7 @@ static SaAisErrorT check_errors()
>   errors = 0;
>   glob_errors += errors;
>   if (glob_errors) {
> - rc = SA_AIS_ERR_FAILED_OPERATION;
> + rc = global_error_id;
>   fprintf_v(stdout, "num of failed notifications: %d\n",
> glob_errors);
>   }
> @@ -156,8 +157,10 @@ static SaAisErrorT check_errors()
>   
>   void saferror(SaAisErrorT rc, SaAisErrorT exp)
>   {
> - if (rc != exp)
> + if (rc != exp){
>   glob_errors++;
> + global_error_id = rc;
> + }
>   }
>   
>   static void resetCounters()
> @@ -170,6 +173,7 @@ static void resetCounters()
>   ntfRecieved.objectCreateDeleteFilterHandle = 0;
>   ntfRecieved.securityAlarmFilterHandle = 0;
>   ntfRecieved.stateChangeFilterHandle = 0;
> + global_error_id = SA_AIS_OK;
>   }
>   
>   /**
> @@ -825,10 +829,12 @@ void producer_life_cycle(int test_api)
>);
>   saferror(rc, SA_AIS_OK);
>   
> - rc = scoutage_saNtfPtrValAllocate(
> - ,
> - myAlarmNotification.notificationHandle);
> - saferror(rc, SA_AIS_OK);
> + if (glob_errors == 0) {
> + rc = scoutage_saNtfPtrValAllocate(
> + ,
> + myAlarmNotification.notificationHandle);
> + saferror(rc, SA_AIS_OK);
> + }
[Minh]: Do we need this change in producer_life_cycle? I think this patch let 
all api(s) called as currently and only memorize the last error code if any
[Srinivas]: Without this condition, the process was dumping core.
The reason for core dump was scoutage_saNtfAlarmNotificationAllocate() returned 
error and myAlarmNotification was not initialized properly.
Below is the backtrace:
(gdb) where
#0  0x800ad68e in scoutage_saNtfPtrValAllocate ()
#1  0x800ae18d in producer_life_cycle ()
#2  0x800ae509 in test_sc_outage_producer_1 ()
#3  0x800c24a9 in run_test_case ()
#4  0x800c2a28 in test_run ()
#5  0x800912db in main ()

>   
>   /* Create security alarm notification */
>   rc = scoutage_saNtfSecurityAlarmNotificationAllocate(


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 0/1] Review Request for pyosaf: Invalid exception used in ImmObject (object.py) [#1410]

2017-10-02 Thread Hieu Nguyen 
Summary: pyosaf: Invalid exception used in ImmObject (object.py) [#1410]
Review request for Ticket(s): 1410
Peer Reviewer(s): Hans/Anders
Pull request to: Hans
Affected branch(es): develop
Development branch: ticket-1410
Base revision: bc497981905f39aaa5b63cdf85b7557972650d94
Personal repository: git://git.code.sf.net/u/dhiengu/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesn
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   y


Comments (indicate scope for each "y" above):
-


revision 0cdec4f977048b789e75294216cfb47fdf420bab
Author: Hieu Nguyen 
Date:   Tue, 3 Oct 2017 10:37:20 +0700

pyosaf: Invalid exception used in ImmObject (object.py) [#1410]



Complete diffstat:
--
 python/pyosaf/utils/immom/object.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Testing Commands:
-



Testing, Expected Results:
--



Conditions of Submission:
-
Ack from reviewers.



Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  y  y
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1/1] pyosaf: Invalid exception used in ImmObject (object.py) [#1410]

2017-10-02 Thread Hieu Nguyen 
---
 python/pyosaf/utils/immom/object.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/pyosaf/utils/immom/object.py 
b/python/pyosaf/utils/immom/object.py
index c2924d3..30cd63c 100644
--- a/python/pyosaf/utils/immom/object.py
+++ b/python/pyosaf/utils/immom/object.py
@@ -59,7 +59,7 @@ class ImmObject(object):
 self.class_desc[class_name] = \
 pyosaf.utils.immom.class_description_get(class_name)
 else:
-raise
+raise Exception("ERROR: class and attributes are None")
 
 self.__dict__["rdn_attribute"] = \
 pyosaf.utils.immom.get_rdn_attribute_for_class(class_name)
-- 
2.7.4


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1/1] log: corrected parsing of command logtest with option -e [#2121]

2017-10-02 Thread Vu Minh Nguyen 
Hi,

>  1 file changed, 14 insertions(+), 26 deletions(-)
>  mode change 100644 => 100755 src/log/apitest/logtest.c

Any reason of changing the file permission?

Regards, Vu

> -Original Message-
> From: Srinivas [mailto:srinivas.mangip...@oracle.com]
> Sent: Thursday, September 21, 2017 5:38 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Srinivas
> 
> Subject: [PATCH 1/1] log: corrected parsing of command logtest with option
> -e [#2121]
> 
> ---
>  src/log/apitest/logtest.c | 40 ++--
>  1 file changed, 14 insertions(+), 26 deletions(-)
>  mode change 100644 => 100755 src/log/apitest/logtest.c
> 
> diff --git a/src/log/apitest/logtest.c b/src/log/apitest/logtest.c
> old mode 100644
> new mode 100755
> index 2564957..6777549
> --- a/src/log/apitest/logtest.c
> +++ b/src/log/apitest/logtest.c
> @@ -420,9 +420,6 @@ int main(int argc, char **argv)
>   int suite = ALL_SUITES, tcase = ALL_TESTS;
>   int opt_val = 0;
>   bool etst_flg = false;
> - int i = 0;
> - char *opt_str_ptr;
> - char *tok_str_ptr = NULL;
> 
>   if (setenv("SA_ENABLE_EXTENDED_NAMES", "1", 1) != 0) {
>   fprintf(stderr, "Failed to set SA_ENABLE_EXTENDED_NAMES
> (%s)",
> @@ -468,31 +465,22 @@ int main(int argc, char **argv)
>   test_list();
>   exit(0);
>   case 'e':
> - opt_str_ptr = argv[optind - 1];
> -
> - tok_str_ptr = strtok(opt_str_ptr, " ");
> - for (i = 0; i < 2; i++) {
> - if (tok_str_ptr == NULL)
> - break;
> -
> - if (i == 0) {
> - suite = atoi(tok_str_ptr);
> - if (suite == 0) {
> - /* Argument is not numeric
> or 0
> -  */
> - err_exit();
> - }
> - } else {
> - tcase = atoi(tok_str_ptr);
> - if (tcase == 0) {
> - /* Argument is not numeric
> or 0
> -  */
> - err_exit();
> - }
> + if (argv[optind - 1] != NULL) {
> + suite = atoi(argv[optind - 1]);
> + if (suite == 0) {
> + /* Argument is not numeric or 0
> +  */
> + err_exit();
>   }
> - tok_str_ptr = strtok(NULL, " ");
> + } else
> + err_exit();
> + if (optind < argc && argv[optind] != NULL)
> + tcase = atoi(argv[optind]);
> + if (tcase == 0) {
> + /* Argument is not numeric or 0
> +  */
> + err_exit();
>   }
> -
>   etst_flg = true;
>   add_suite_9();
>   add_suite_10();
> --
> 2.7.4



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1/1] log: corrected parsing of command logtest with option -e [#2121]

2017-10-02 Thread Lennart Lund 
Ack

/Lennart

> -Original Message-
> From: Srinivas [mailto:srinivas.mangip...@oracle.com]
> Sent: den 21 september 2017 12:38
> To: Lennart Lund ; Vu Minh Nguyen
> 
> Cc: opensaf-devel@lists.sourceforge.net; Srinivas
> 
> Subject: [PATCH 1/1] log: corrected parsing of command logtest with option -
> e [#2121]
> 
> ---
>  src/log/apitest/logtest.c | 40 ++--
>  1 file changed, 14 insertions(+), 26 deletions(-)
>  mode change 100644 => 100755 src/log/apitest/logtest.c
> 
> diff --git a/src/log/apitest/logtest.c b/src/log/apitest/logtest.c
> old mode 100644
> new mode 100755
> index 2564957..6777549
> --- a/src/log/apitest/logtest.c
> +++ b/src/log/apitest/logtest.c
> @@ -420,9 +420,6 @@ int main(int argc, char **argv)
>   int suite = ALL_SUITES, tcase = ALL_TESTS;
>   int opt_val = 0;
>   bool etst_flg = false;
> - int i = 0;
> - char *opt_str_ptr;
> - char *tok_str_ptr = NULL;
> 
>   if (setenv("SA_ENABLE_EXTENDED_NAMES", "1", 1) != 0) {
>   fprintf(stderr, "Failed to set SA_ENABLE_EXTENDED_NAMES
> (%s)",
> @@ -468,31 +465,22 @@ int main(int argc, char **argv)
>   test_list();
>   exit(0);
>   case 'e':
> - opt_str_ptr = argv[optind - 1];
> -
> - tok_str_ptr = strtok(opt_str_ptr, " ");
> - for (i = 0; i < 2; i++) {
> - if (tok_str_ptr == NULL)
> - break;
> -
> - if (i == 0) {
> - suite = atoi(tok_str_ptr);
> - if (suite == 0) {
> - /* Argument is not numeric
> or 0
> -  */
> - err_exit();
> - }
> - } else {
> - tcase = atoi(tok_str_ptr);
> - if (tcase == 0) {
> - /* Argument is not numeric
> or 0
> -  */
> - err_exit();
> - }
> + if (argv[optind - 1] != NULL) {
> + suite = atoi(argv[optind - 1]);
> + if (suite == 0) {
> + /* Argument is not numeric or 0
> +  */
> + err_exit();
>   }
> - tok_str_ptr = strtok(NULL, " ");
> + } else
> + err_exit();
> + if (optind < argc && argv[optind] != NULL)
> + tcase = atoi(argv[optind]);
> + if (tcase == 0) {
> + /* Argument is not numeric or 0
> +  */
> + err_exit();
>   }
> -
>   etst_flg = true;
>   add_suite_9();
>   add_suite_10();
> --
> 2.7.4


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1/1] clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message [#2590]

2017-10-02 Thread Anders Widell 

Ack with comments:

1) Add a final comma to the end of the command-line parameter for the 
scale-out script. The reason why there should be a final comma is to 
make sure the script (which may be modified by the user) is 
backwards-compatible with future enhancements where we add more 
parameters. By adding a comma after the final parameter, new parameters 
added in the future are less likely to cause compatibility problems for 
the user-modified script.


2) Add a vetting function that checks that the user data doesn't contain 
illegal characters. If the user data contains illegal characters we 
shall treat it in the same way as if the file was missing. At least the 
comma character shall be considered illegal. I think we can be even more 
restrictive - maybe only allow printable ASCII characters (including 
space). It is easy to remove restrictions later on without impacting 
backwards compatibility. Adding restrictions later on will on the other 
hand not be backwards compatible.


3) Use the vetting function also for the IP address that was added in 
ticket [#2489] (I forgot this :-).


4) The name of the file: "user_data" does not describe the purpose so 
well. Maybe change it to "clm_node_info"? At least I think the name 
should mention "CLM". Since it is only used for scaling it could perhaps 
be called "clm_scale_out_info", although in the future we may use it 
even when there is no scaling.


/ Anders W


On 09/25/2017 04:32 PM, Hans Nordeback wrote:

---
  src/clm/README |  8 +---
  src/clm/clmd/clms_evt.c| 11 +--
  src/clm/clmd/clms_mds.c| 11 +++
  src/clm/clmnd/cb.h |  1 +
  src/clm/clmnd/main.c   | 28 +++-
  src/clm/common/clmsv_msg.h |  1 +
  6 files changed, 54 insertions(+), 6 deletions(-)

diff --git a/src/clm/README b/src/clm/README
index dee3e64f2..10e60849b 100644
--- a/src/clm/README
+++ b/src/clm/README
@@ -65,10 +65,12 @@ and if so add the necessary IMM objects so that the node 
will be able to join
  the next time it tries. The script will be called with one or more 
command-line
  arguments, where each argument is a comma-separated list of properties of a 
node
  that wishes to join the cluster. Currently, the comma-separated list in each
-command-line argument contains only two entries, but the script should be
-forwards compatible with future extensions where more entries may be added to
+command-line argument contains four entries, node-id, node-name, 
node-ipaddress, user-data.
+But the script should be forwards compatible with future extensions where more 
entries may be added to
  the comma-separated list. The first entry in the list is the node id 
represented
-as a decimal number. The second entry in the list is the name of the node.
+as a decimal number. The second entry in the list is the name of the node. The 
third entry is the
+IP address of the node. The fourth entry is optional user data that can be 
entered in a file named
+/etc/opensaf/user_data, up to 256 characters can be given.
  
  NOTE: the script must be idempotent, i.e. it must be harmless to call it more

  than one time with the same parameters. The second call should do nothing 
since
diff --git a/src/clm/clmd/clms_evt.c b/src/clm/clmd/clms_evt.c
index 84e7b3c6d..eb771c105 100644
--- a/src/clm/clmd/clms_evt.c
+++ b/src/clm/clmd/clms_evt.c
@@ -453,6 +453,7 @@ static void scale_out_node(CLMS_CB *cb,
   const clmsv_clms_node_up_info_t *nodeup_info)
  {
char node_name[SA_MAX_NAME_LENGTH];
+   char user_data[SA_MAX_NAME_LENGTH];
  
  	TRACE_ENTER();

size_t name_len = nodeup_info->node_name.length < SA_MAX_NAME_LENGTH
@@ -461,6 +462,12 @@ static void scale_out_node(CLMS_CB *cb,
memcpy(node_name, nodeup_info->node_name.value, name_len);
node_name[name_len] = '\0';
  
+	size_t user_data_len = nodeup_info->user_data.length < SA_MAX_NAME_LENGTH

+ ? nodeup_info->user_data.length
+ : (SA_MAX_NAME_LENGTH - 1);
+   memcpy(user_data, nodeup_info->user_data.value, user_data_len);
+   user_data[user_data_len] = '\0';
+
osaf_mutex_lock_ordie(>scale_out_data_mutex);
size_t no_of_pending_nodes = cb->no_of_pending_nodes;
size_t no_of_inprogress_nodes = cb->no_of_inprogress_nodes;
@@ -497,8 +504,8 @@ static void scale_out_node(CLMS_CB *cb,
memcpy(node_address, nodeup_info->address.value, addr_len);
node_address[addr_len] = '\0';
char *strp;
-   if (asprintf(, "%" PRIu32 ",%s,%s,", nodeup_info->node_id,
-node_name, node_address) != -1) {
+   if (asprintf(, "%" PRIu32 ",%s,%s,%s", 
nodeup_info->node_id,
+node_name, node_address, user_data) != -1) {
LOG_NO("Queuing request to scale out node 0x%" PRIx32
   " (%s)",

Re: [devel] [PATCH 1/1] imm: Don't call exit() in IMM library [#2604]

2017-10-02 Thread Zoran Milinkovic 
Hi Hung,

Ack from me.

Thanks,
Zoran

-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] 
Sent: den 2 oktober 2017 08:47
To: Zoran Milinkovic 
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen 

Subject: [PATCH 1/1] imm: Don't call exit() in IMM library [#2604]

When PBE loses connection with IMMND, we don't call exit() in IMM library.
Instead, we mark the handle as exposed and then PBE will exit when it fails to 
call saImmOmDispatch.
---
 src/imm/agent/imma_db.cc | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/imm/agent/imma_db.cc b/src/imm/agent/imma_db.cc index 
cc771f7..d0e3682 100644
--- a/src/imm/agent/imma_db.cc
+++ b/src/imm/agent/imma_db.cc
@@ -685,11 +685,6 @@ void imma_mark_clients_stale(IMMA_CB *cb, bool 
mark_exposed) {
 temp_hdl = clnode->handle;
 temp_ptr = _hdl;
 
-if (clnode->isPbe) {
-  LOG_WA("PBE lost contact with parent IMMND - Exiting");
-  exit(1);
-}
-
 /* Process OM side CCBs */
 while ((ccb_node = (IMMA_CCB_NODE *)ncs_patricia_tree_getnext(
 >ccb_tree, (uint8_t *)ccb_temp_ptr))) { @@ -728,7 +723,11 
@@ void imma_mark_clients_stale(IMMA_CB *cb, bool mark_exposed) {
   continue;
 } /* No need to stale dispatched on this
  handle when already exposed. */
-if (mark_exposed) {
+if (clnode->isPbe) {
+  /* saImmOmDispatch will return ERR_BAD_HANDLE and PBE will exit */
+  LOG_WA("PBE lost contact with parent IMMND - marking handle as exposed");
+  clnode->exposed = true;
+} else if (mark_exposed) {
   clnode->exposed = true;
   LOG_WA("marking handle as exposed");
 } else if (clnode->isImmA2x12 && clnode->clmExposed) {
--
2.7.4


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1/1] imm: Don't call exit() in IMM library [#2604]

2017-10-02 Thread Hung Nguyen 
When PBE loses connection with IMMND, we don't call exit() in IMM library.
Instead, we mark the handle as exposed and then PBE will exit when it fails to 
call saImmOmDispatch.
---
 src/imm/agent/imma_db.cc | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/imm/agent/imma_db.cc b/src/imm/agent/imma_db.cc
index cc771f7..d0e3682 100644
--- a/src/imm/agent/imma_db.cc
+++ b/src/imm/agent/imma_db.cc
@@ -685,11 +685,6 @@ void imma_mark_clients_stale(IMMA_CB *cb, bool 
mark_exposed) {
 temp_hdl = clnode->handle;
 temp_ptr = _hdl;
 
-if (clnode->isPbe) {
-  LOG_WA("PBE lost contact with parent IMMND - Exiting");
-  exit(1);
-}
-
 /* Process OM side CCBs */
 while ((ccb_node = (IMMA_CCB_NODE *)ncs_patricia_tree_getnext(
 >ccb_tree, (uint8_t *)ccb_temp_ptr))) {
@@ -728,7 +723,11 @@ void imma_mark_clients_stale(IMMA_CB *cb, bool 
mark_exposed) {
   continue;
 } /* No need to stale dispatched on this
  handle when already exposed. */
-if (mark_exposed) {
+if (clnode->isPbe) {
+  /* saImmOmDispatch will return ERR_BAD_HANDLE and PBE will exit */
+  LOG_WA("PBE lost contact with parent IMMND - marking handle as exposed");
+  clnode->exposed = true;
+} else if (mark_exposed) {
   clnode->exposed = true;
   LOG_WA("marking handle as exposed");
 } else if (clnode->isImmA2x12 && clnode->clmExposed) {
-- 
2.7.4


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 0/1] Review Request for imm: Dont call exit() in IMM library [#2604]

2017-10-02 Thread Hung Nguyen 
Summary: imm: Don't call exit() in IMM library [#2604]
Review request for Ticket(s): 2604
Peer Reviewer(s): Zoran
Pull request to: 
Affected branch(es): develop, release
Development branch: ticket-2604
Base revision: ffbeba61513e28ce862eaa735ed75e8243f881b8
Personal repository: git://git.code.sf.net/u/xhunngu/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-


revision bc497981905f39aaa5b63cdf85b7557972650d94
Author: Hung Nguyen 
Date:   Mon, 2 Oct 2017 13:28:40 +0700

imm: Don't call exit() in IMM library [#2604]

When PBE loses connection with IMMND, we don't call exit() in IMM library.
Instead, we mark the handle as exposed and then PBE will exit when it fails to 
call saImmOmDispatch.



Complete diffstat:
--
 src/imm/agent/imma_db.cc | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)


Testing Commands:
-



Testing, Expected Results:
--



Conditions of Submission:
-
Ack from reviewers.


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel