[devel] [PATCH 1/1] imm: fix racing in sending discard-node during network split [#3012]
At the time of spliting the cluster into 02 partitions but keeping a node
such as PL-3 connecting with both partitions, just IMMND on PL-3 will get
discard-node messages from both active IMMD on partition #1 and from standby
IMMD on partition #2.
That race later on caused IMMND on PL-3 crashed due to the mismatch
found at finalize-sync.
This patch makes a minor change at standby IMMD - rather then sending the
discard-node message even in standby role, will put the message in queue
and only broadcast it when the standby is assigned to active.
---
src/imm/immd/immd_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c
index c16232d2d..69e23f2d3 100644
--- a/src/imm/immd/immd_proc.c
+++ b/src/imm/immd/immd_proc.c
@@ -778,7 +778,7 @@ uint32_t immd_process_immnd_down(IMMD_CB *cb,
IMMD_IMMND_INFO_NODE *immnd_info,
}
}
- if (active || !cb->immd_remote_up) {
+ if (active) {
/*
** HAFE - Let IMMND subscribe for IMMND up/down events instead?
** ABT - Not for now. IMMND up/down are only subscribed by
--
2.19.2
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0/1] Review Request for imm: fix racing in sending discard-node during network split [#3012]
Summary: imm: fix racing in sending discard-node during network split [#3012] Review request for Ticket(s): 3012 Peer Reviewer(s): Lennart, Hans, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3012 Base revision: 91806d17b2d79138f68ff3eb3449a9a6ba3dfbf0 Personal repository: git://git.code.sf.net/u/winhvu/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 827a1d4c9c4708776cb67dd27e984368c089f232 Author: Vu Minh Nguyen Date: Mon, 25 Feb 2019 14:27:33 +0700 imm: fix racing in sending discard-node during network split [#3012] At the time of spliting the cluster into 02 partitions but keeping a node such as PL-3 connecting with both partitions, just IMMND on PL-3 will get discard-node messages from both active IMMD on partition #1 and from standby IMMD on partition #2. That race later on caused IMMND on PL-3 crashed due to the mismatch found at finalize-sync. This patch makes a minor change at standby IMMD - rather then sending the discard-node message even in standby role, will put the message in queue and only broadcast it when the standby is assigned to active. Complete diffstat: -- src/imm/immd/immd_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Testing Commands: - Refer to the ticket description. Testing, Expected Results: -- No coredump is generated. Conditions of Submission: - Ack from peer reviewers. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]
Hi Thang,
ACK for code review.
Best Regards,
ThuanTr
-Original Message-
From: thang.d.nguyen
Sent: Monday, February 25, 2019 1:25 PM
To: lennart.l...@ericsson.com; thuan.t...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; thang.d.nguyen
Subject: [PATCH 1/1] smf: clear old attributes before re-filling if ccb
abort to sync [#3010]
During single step install, the ccb is aborted to sync. The old attributes
in object creator/modifier must be erased before re-filling.
---
src/smf/smfd/SmfImmOperation.h | 6 ++
src/smf/smfd/SmfUtils.cc | 3 +++
2 files changed, 9 insertions(+)
diff --git a/src/smf/smfd/SmfImmOperation.h b/src/smf/smfd/SmfImmOperation.h
index bc91431..04b4455 100644
--- a/src/smf/smfd/SmfImmOperation.h
+++ b/src/smf/smfd/SmfImmOperation.h
@@ -113,6 +113,12 @@ class SmfImmOperation {
LOG_NO("addValue must be specialised");
}
+ // Delete all attribute of object_create_ or object_modify_ void
+ DeleteAttributes() {
+object_create_.attributes.clear();
+object_modify_.modifications.clear();
+ }
+
// Create and add a new attribute if the attribute does not already
// exist (based on name). If an attribute with the given name already
exist
// no attribute is created but the value (i_value) is added (multivalue).
diff --git a/src/smf/smfd/SmfUtils.cc b/src/smf/smfd/SmfUtils.cc index
c2931c8..882a3e6 100644
--- a/src/smf/smfd/SmfUtils.cc
+++ b/src/smf/smfd/SmfUtils.cc
@@ -698,6 +698,9 @@ SaAisErrorT SmfImmUtils::doImmOperations(
}
}
+// Delete all attributes in the create/modify descriptor before fill
+imm_operation->DeleteAttributes();
+
// Verify the create descriptor for this operation and fill in the
// attributes
result = imm_operation->Execute(rollbackData);
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0/1] Review Request for smf: clear old attributes before re-filling if ccb abort to sync [#3010] V1
Summary: smf: clear old attributes before re-filling if ccb abort to sync [#3010] Review request for Ticket(s): 3010 Peer Reviewer(s): Lennart, Thuan Pull request to: Vu Affected branch(es): develop Development branch: ticket-3010 Base revision: 91806d17b2d79138f68ff3eb3449a9a6ba3dfbf0 Personal repository: git://git.code.sf.net/u/thangng/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 69e4079c46d3b47ab717843a5f899a91e8d3f70f Author: thang.d.nguyen Date: Mon, 25 Feb 2019 13:02:00 +0700 smf: clear old attributes before re-filling if ccb abort to sync [#3010] During single step install, the ccb is aborted to sync. The old attributes in object creator/modifier must be erased before re-filling. Complete diffstat: -- src/smf/smfd/SmfImmOperation.h | 6 ++ src/smf/smfd/SmfUtils.cc | 3 +++ 2 files changed, 9 insertions(+) Testing Commands: - N/A. Testing, Expected Results: -- N/A. Conditions of Submission: - Acked from reviwer. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]
During single step install, the ccb is aborted
to sync. The old attributes in object creator/modifier
must be erased before re-filling.
---
src/smf/smfd/SmfImmOperation.h | 6 ++
src/smf/smfd/SmfUtils.cc | 3 +++
2 files changed, 9 insertions(+)
diff --git a/src/smf/smfd/SmfImmOperation.h b/src/smf/smfd/SmfImmOperation.h
index bc91431..04b4455 100644
--- a/src/smf/smfd/SmfImmOperation.h
+++ b/src/smf/smfd/SmfImmOperation.h
@@ -113,6 +113,12 @@ class SmfImmOperation {
LOG_NO("addValue must be specialised");
}
+ // Delete all attribute of object_create_ or object_modify_
+ void DeleteAttributes() {
+object_create_.attributes.clear();
+object_modify_.modifications.clear();
+ }
+
// Create and add a new attribute if the attribute does not already
// exist (based on name). If an attribute with the given name already exist
// no attribute is created but the value (i_value) is added (multivalue).
diff --git a/src/smf/smfd/SmfUtils.cc b/src/smf/smfd/SmfUtils.cc
index c2931c8..882a3e6 100644
--- a/src/smf/smfd/SmfUtils.cc
+++ b/src/smf/smfd/SmfUtils.cc
@@ -698,6 +698,9 @@ SaAisErrorT SmfImmUtils::doImmOperations(
}
}
+// Delete all attributes in the create/modify descriptor before fill
+imm_operation->DeleteAttributes();
+
// Verify the create descriptor for this operation and fill in the
// attributes
result = imm_operation->Execute(rollbackData);
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]
Hi Thuan,
I correct my comment.
B.R
/Thang
-Original Message-
From: Thang Nguyen
Sent: Monday, February 25, 2019 11:31 AM
To: 'Tran Thuan' ; 'lennart.l...@ericsson.com'
; 'thua...@users.sourceforge.net'
Cc: 'opensaf-devel@lists.sourceforge.net'
Subject: RE: [devel] [PATCH 1/1] smf: clear old attributes before re-filling
if ccb abort to sync [#3010]
Hi Thuan,
See my comment inline.
B.R
/Thang
-Original Message-
From: Tran Thuan
Sent: Monday, February 25, 2019 11:20 AM
To: 'thang.d.nguyen' ;
lennart.l...@ericsson.com; thua...@users.sourceforge.net
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] smf: clear old attributes before re-filling
if ccb abort to sync [#3010]
Hi Thang,
See one comment inline [Thuan]
Best Regards,
ThuanTr
-Original Message-
From: thang.d.nguyen
Sent: Monday, February 25, 2019 11:04 AM
To: lennart.l...@ericsson.com; thua...@users.sourceforge.net
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if
ccb abort to sync [#3010]
During single step install, the ccb is aborted to sync. The old attributes
in object creator must be erased before re-filling.
---
src/smf/smfd/SmfImmOperation.h | 5 +
src/smf/smfd/SmfUtils.cc | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/smf/smfd/SmfImmOperation.h b/src/smf/smfd/SmfImmOperation.h
index bc91431..c2c1be3 100644
--- a/src/smf/smfd/SmfImmOperation.h
+++ b/src/smf/smfd/SmfImmOperation.h
@@ -113,6 +113,11 @@ class SmfImmOperation {
LOG_NO("addValue must be specialised");
}
+ // Delete all attribute of object_create_ void DeleteAttributes() {
+object_create_.attributes.clear();
[Thuan] I think we need check "imm_operation_" is "Create" to do
"object_create_.attributes.clear();"
[Thang]: No need b/c it is only for create. In this case, attributes of
modificaiton also need to clear.
I will update in next PS.
+ }
+
// Create and add a new attribute if the attribute does not already
// exist (based on name). If an attribute with the given name already
exist
// no attribute is created but the value (i_value) is added (multivalue).
diff --git a/src/smf/smfd/SmfUtils.cc b/src/smf/smfd/SmfUtils.cc index
c2931c8..dfe9953 100644
--- a/src/smf/smfd/SmfUtils.cc
+++ b/src/smf/smfd/SmfUtils.cc
@@ -698,6 +698,9 @@ SaAisErrorT SmfImmUtils::doImmOperations(
}
}
+// Delete all attributes in the create descriptor before fill
+imm_operation->DeleteAttributes();
+
// Verify the create descriptor for this operation and fill in the
// attributes
result = imm_operation->Execute(rollbackData);
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]
Hi Thuan,
See my comment inline.
B.R
/Thang
-Original Message-
From: Tran Thuan
Sent: Monday, February 25, 2019 11:20 AM
To: 'thang.d.nguyen' ;
lennart.l...@ericsson.com; thua...@users.sourceforge.net
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] smf: clear old attributes before re-filling
if ccb abort to sync [#3010]
Hi Thang,
See one comment inline [Thuan]
Best Regards,
ThuanTr
-Original Message-
From: thang.d.nguyen
Sent: Monday, February 25, 2019 11:04 AM
To: lennart.l...@ericsson.com; thua...@users.sourceforge.net
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if
ccb abort to sync [#3010]
During single step install, the ccb is aborted to sync. The old attributes
in object creator must be erased before re-filling.
---
src/smf/smfd/SmfImmOperation.h | 5 +
src/smf/smfd/SmfUtils.cc | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/smf/smfd/SmfImmOperation.h b/src/smf/smfd/SmfImmOperation.h
index bc91431..c2c1be3 100644
--- a/src/smf/smfd/SmfImmOperation.h
+++ b/src/smf/smfd/SmfImmOperation.h
@@ -113,6 +113,11 @@ class SmfImmOperation {
LOG_NO("addValue must be specialised");
}
+ // Delete all attribute of object_create_ void DeleteAttributes() {
+object_create_.attributes.clear();
[Thuan] I think we need check "imm_operation_" is "Create" to do
"object_create_.attributes.clear();"
[Thang]: I will update in next version.
+ }
+
// Create and add a new attribute if the attribute does not already
// exist (based on name). If an attribute with the given name already
exist
// no attribute is created but the value (i_value) is added (multivalue).
diff --git a/src/smf/smfd/SmfUtils.cc b/src/smf/smfd/SmfUtils.cc index
c2931c8..dfe9953 100644
--- a/src/smf/smfd/SmfUtils.cc
+++ b/src/smf/smfd/SmfUtils.cc
@@ -698,6 +698,9 @@ SaAisErrorT SmfImmUtils::doImmOperations(
}
}
+// Delete all attributes in the create descriptor before fill
+imm_operation->DeleteAttributes();
+
// Verify the create descriptor for this operation and fill in the
// attributes
result = imm_operation->Execute(rollbackData);
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]
Hi Thang,
See one comment inline [Thuan]
Best Regards,
ThuanTr
-Original Message-
From: thang.d.nguyen
Sent: Monday, February 25, 2019 11:04 AM
To: lennart.l...@ericsson.com; thua...@users.sourceforge.net
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if
ccb abort to sync [#3010]
During single step install, the ccb is aborted to sync. The old attributes
in object creator must be erased before re-filling.
---
src/smf/smfd/SmfImmOperation.h | 5 +
src/smf/smfd/SmfUtils.cc | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/smf/smfd/SmfImmOperation.h b/src/smf/smfd/SmfImmOperation.h
index bc91431..c2c1be3 100644
--- a/src/smf/smfd/SmfImmOperation.h
+++ b/src/smf/smfd/SmfImmOperation.h
@@ -113,6 +113,11 @@ class SmfImmOperation {
LOG_NO("addValue must be specialised");
}
+ // Delete all attribute of object_create_ void DeleteAttributes() {
+object_create_.attributes.clear();
[Thuan] I think we need check "imm_operation_" is "Create" to do
"object_create_.attributes.clear();"
+ }
+
// Create and add a new attribute if the attribute does not already
// exist (based on name). If an attribute with the given name already
exist
// no attribute is created but the value (i_value) is added (multivalue).
diff --git a/src/smf/smfd/SmfUtils.cc b/src/smf/smfd/SmfUtils.cc index
c2931c8..dfe9953 100644
--- a/src/smf/smfd/SmfUtils.cc
+++ b/src/smf/smfd/SmfUtils.cc
@@ -698,6 +698,9 @@ SaAisErrorT SmfImmUtils::doImmOperations(
}
}
+// Delete all attributes in the create descriptor before fill
+imm_operation->DeleteAttributes();
+
// Verify the create descriptor for this operation and fill in the
// attributes
result = imm_operation->Execute(rollbackData);
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]
During single step install, the ccb is aborted
to sync. The old attributes in object creator
must be erased before re-filling.
---
src/smf/smfd/SmfImmOperation.h | 5 +
src/smf/smfd/SmfUtils.cc | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/smf/smfd/SmfImmOperation.h b/src/smf/smfd/SmfImmOperation.h
index bc91431..c2c1be3 100644
--- a/src/smf/smfd/SmfImmOperation.h
+++ b/src/smf/smfd/SmfImmOperation.h
@@ -113,6 +113,11 @@ class SmfImmOperation {
LOG_NO("addValue must be specialised");
}
+ // Delete all attribute of object_create_
+ void DeleteAttributes() {
+object_create_.attributes.clear();
+ }
+
// Create and add a new attribute if the attribute does not already
// exist (based on name). If an attribute with the given name already exist
// no attribute is created but the value (i_value) is added (multivalue).
diff --git a/src/smf/smfd/SmfUtils.cc b/src/smf/smfd/SmfUtils.cc
index c2931c8..dfe9953 100644
--- a/src/smf/smfd/SmfUtils.cc
+++ b/src/smf/smfd/SmfUtils.cc
@@ -698,6 +698,9 @@ SaAisErrorT SmfImmUtils::doImmOperations(
}
}
+// Delete all attributes in the create descriptor before fill
+imm_operation->DeleteAttributes();
+
// Verify the create descriptor for this operation and fill in the
// attributes
result = imm_operation->Execute(rollbackData);
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0/1] Review Request for smf: clear old attributes before re-filling if ccb abort to sync [#3010]
Summary: smf: clear old attributes before re-filling if ccb abort to sync [#3010] Review request for Ticket(s): 3010 Peer Reviewer(s): Lennart, Thuan Pull request to: Vu Affected branch(es): develop Development branch: ticket-3010 Base revision: 91806d17b2d79138f68ff3eb3449a9a6ba3dfbf0 Personal repository: git://git.code.sf.net/u/thangng/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 999ed5f3fb3d25b79a742cae1088ccbaf5bf69b6 Author: thang.d.nguyen Date: Mon, 25 Feb 2019 10:44:38 +0700 smf: clear old attributes before re-filling if ccb abort to sync [#3010] During single step install, the ccb is aborted to sync. The old attributes in object creator must be erased before re-filling. Complete diffstat: -- src/smf/smfd/SmfImmOperation.h | 5 + src/smf/smfd/SmfUtils.cc | 3 +++ 2 files changed, 8 insertions(+) Testing Commands: - N/A. Testing, Expected Results: -- N/A. Conditions of Submission: - Acked from reviewer. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0/1] Review Request for amf: fix Comp stuck in RESTARTING presence state [#3011]
Summary: amf: fix Comp stuck in RESTARTING presence state [#3011] Review request for Ticket(s): 3011 Peer Reviewer(s): Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3011 Base revision: 91806d17b2d79138f68ff3eb3449a9a6ba3dfbf0 Personal repository: git://git.code.sf.net/u/thuantr/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - N/A revision fb4e32e78372dfb7b138b6cfa4ff8f040b88391d Author: thuan.tran Date: Mon, 25 Feb 2019 09:53:38 +0700 amf: fix Comp stuck in RESTARTING presence state [#3011] During SU (many COMPs) restart recovery, if any COMP finish instantiated then crash while other COMPs are still instantiating, AMF recovery it by restarting but AMF only cleanup without re-instantiation because AMF see the COMP is not eligible for instantiation. The error COMP is stuck in RESTARTING without further action from AMF. AMF should allow COMP re-instantiation if SU state is INSTANTIATING and error COMP state is RESTARTING. Complete diffstat: -- src/amf/amfnd/clc.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Testing Commands: - N/A Testing, Expected Results: -- N/A Conditions of Submission: - *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1/1] amf: fix Comp stuck in RESTARTING presence state [#3011]
During SU (many COMPs) restart recovery, if any COMP finish instantiated
then crash while other COMPs are still instantiating, AMF recovery it by
restarting but AMF only cleanup without re-instantiation because AMF see
the COMP is not eligible for instantiation. The error COMP is stuck in
RESTARTING without further action from AMF.
AMF should allow COMP re-instantiation if SU state is INSTANTIATING and
error COMP state is RESTARTING.
---
src/amf/amfnd/clc.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amf/amfnd/clc.cc b/src/amf/amfnd/clc.cc
index 463c5de..7a62a56 100644
--- a/src/amf/amfnd/clc.cc
+++ b/src/amf/amfnd/clc.cc
@@ -1805,7 +1805,8 @@ static bool
is_failed_comp_eligible_for_instantiation(AVND_COMP *comp) {
/*During surestart recovery, after cleanup of all components, amfnd
starts
instantiation of components. A component may fault at this stage. Such
a
component is eligible for instantiation.*/
- if ((comp->pres == SA_AMF_PRESENCE_INSTANTIATING) &&
+ if (((comp->pres == SA_AMF_PRESENCE_RESTARTING) ||
+ (comp->pres == SA_AMF_PRESENCE_INSTANTIATING)) &&
(comp->su->pres == SA_AMF_PRESENCE_INSTANTIATING))
return true;
--
2.7.4
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
