date:20200227

[devel] [PATCH 1/1] imm: imm_list tool add new option --delimiter [#3155]

2020-02-27 Thread phuc.h.chau

Make delimiter of multiple attribute value from immlist configurable
Update option --pretty-print will not support print with option --atribute
---
 src/imm/tools/imm_list.c | 78 +++-
 1 file changed, 64 insertions(+), 14 deletions(-)

diff --git a/src/imm/tools/imm_list.c b/src/imm/tools/imm_list.c
index d1dc422..09222de 100644
--- a/src/imm/tools/imm_list.c
+++ b/src/imm/tools/imm_list.c
@@ -72,13 +72,18 @@ static void usage(const char *progname)
printf("\t-h, --help - display this help and exit\n");
printf(
"\t-p, --pretty-print= - select pretty print, default 
yes\n");
+   printf(
+   "\tdo not support pretty print with option -a, --attribute=NAME\n");
+   printf(
+   "\t-d, --delimiter= - format multi attribute value\n");
printf("\t-t, --timeout \n");
printf("\t\tutility timeout in seconds\n");
 
printf("\nEXAMPLE\n");
printf("\timmlist -a saAmfApplicationAdminState safApp=OpenSAF\n");
printf("\timmlist safApp=myApp1 safApp=myApp2\n");
-   printf("\timmlist --pretty-print=no -a saAmfAppType safApp=OpenSAF\n");
+   printf("\timmlist --pretty-print=no safApp=OpenSAF\n");
+   printf("\timmlist -d '|' safApp=OpenSAF\n");
 }
 
 static void print_attr_value_raw(SaImmValueTypeT attrValueType,
@@ -141,19 +146,19 @@ static void print_attr_value(SaImmValueTypeT 
attrValueType,
 {
switch (attrValueType) {
case SA_IMM_ATTR_SAINT32T:
-   printf("%d (0x%x) ", *((SaInt32T *)attrValue),
+   printf("%d (0x%x)", *((SaInt32T *)attrValue),
   *((SaInt32T *)attrValue));
break;
case SA_IMM_ATTR_SAUINT32T:
-   printf("%u (0x%x) ", *((SaUint32T *)attrValue),
+   printf("%u (0x%x)", *((SaUint32T *)attrValue),
   *((SaUint32T *)attrValue));
break;
case SA_IMM_ATTR_SAINT64T:
-   printf("%lld (0x%llx) ", *((SaInt64T *)attrValue),
+   printf("%lld (0x%llx)", *((SaInt64T *)attrValue),
   *((SaInt64T *)attrValue));
break;
case SA_IMM_ATTR_SAUINT64T:
-   printf("%llu (0x%llx) ", *((SaUint64T *)attrValue),
+   printf("%llu (0x%llx)", *((SaUint64T *)attrValue),
   *((SaUint64T *)attrValue));
break;
case SA_IMM_ATTR_SATIMET: {
@@ -163,24 +168,24 @@ static void print_attr_value(SaImmValueTypeT 
attrValueType,
 
ctime_r(, buf);
buf[strlen(buf) - 1] = '\0'; /* Remove new line */
-   printf("%llu (0x%llx, %s) ", *((SaTimeT *)attrValue),
+   printf("%llu (0x%llx, %s)", *((SaTimeT *)attrValue),
   *((SaTimeT *)attrValue), buf);
break;
}
case SA_IMM_ATTR_SAFLOATT:
-   printf("%.8g ", *((SaFloatT *)attrValue));
+   printf("%.8g", *((SaFloatT *)attrValue));
break;
case SA_IMM_ATTR_SADOUBLET:
-   printf("%.17g ", *((SaDoubleT *)attrValue));
+   printf("%.17g", *((SaDoubleT *)attrValue));
break;
case SA_IMM_ATTR_SANAMET: {
SaNameT *myNameT = (SaNameT *)attrValue;
-   printf("%s (%zu) ", saAisNameBorrow(myNameT),
+   printf("%s (%zu)", saAisNameBorrow(myNameT),
   strlen(saAisNameBorrow(myNameT)));
break;
}
case SA_IMM_ATTR_SASTRINGT:
-   printf("%s ", *((char **)attrValue));
+   printf("%s", *((char **)attrValue));
break;
case SA_IMM_ATTR_SAANYT: {
SaAnyT *anyp = (SaAnyT *)attrValue;
@@ -404,6 +409,8 @@ static void display_class_definition(const SaImmClassNameT 
className,
 static void display_object(const char *name,
   SaImmAccessorHandleT accessorHandle,
   int pretty_print,
+  int delimiter_print,
+  char *character,
   const SaImmAttrNameT *attributeNames)
 {
int i = 0, j;
@@ -411,6 +418,7 @@ static void display_object(const char *name,
SaNameT objectName;
SaAisErrorT error;
SaImmAttrValuesT_2 **attributes;
+   char *seperate_character = "";
 
saAisNameLend(name, );
 
@@ -428,6 +436,14 @@ static void display_object(const char *name,
exit(EXIT_FAILURE);
}
 
+   if (delimiter_print)
+   seperate_character = character;
+   else
+   if (pretty_print)
+   seperate_character = " ";
+   else
+   seperate_character = ":";
+
if (pretty_print) {
printf("%-50s %-12s Value(s)\n", "Name", "Type");
printf(
@@ -436,9 +452,13 @@ static void display_object(const char

[devel] [PATCH 0/1] Review Request for imm: make delimiter of multiple attribute value from immlist configurable [#3155] V3

2020-02-27 Thread phuc.h.chau

Summary: imm: imm_list tool add new option --delimiter [#3155]
Review request for Ticket(s): 3155
Peer Reviewer(s): Thuan, Vu
Pull request to: Thuan
Affected branch(es): develop
Development branch: ticket-3155
Base revision: 5daf899f4ce44d6fd56cc228ad384803712dbf48
Personal repository: git://git.code.sf.net/u/zchxphc/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesn
 OpenSAF servicesy
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision ff8b3780cc360c854cb5a38ae2b438aa4dec708b
Author: phuc.h.chau 
Date:   Fri, 28 Feb 2020 13:12:41 +0700

imm: imm_list tool add new option --delimiter [#3155]

Make delimiter of multiple attribute value from immlist configurable
Update option --pretty-print will not support print with option --atribute



Complete diffstat:
--
 src/imm/tools/imm_list.c | 78 +++-
 1 file changed, 64 insertions(+), 14 deletions(-)


Testing Commands:
-
Call `immlist -d "|" dn=1`


Testing, Expected Results:
--
Expected:
macAddress  SA_STRING_T  x1:x2:x3:x4|x1:x2:x3:x4


Conditions of Submission:
-
Ack from reviewers

Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  y  y
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.



___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1/1] log: standby node is rebooted when nfs is unresponsive [#3161]

2020-02-27 Thread Vu Minh Nguyen

Hi Thien,

Ack.

Thanks, Vu

From: Thien Minh Huynh 
Sent: Friday, February 28, 2020 10:17 AM
To: Vu Minh Nguyen 
Cc: opensaf-devel@lists.sourceforge.net ; 
Thien Minh Huynh 
Subject: [PATCH 1/1] log: standby node is rebooted when nfs is unresponsive 
[#3161]

Adding 3 checkpoint messages: `CkptPushAsync`, `CkptPopAsync`
and `CkptPopAndWriteAsync` into `lgsv_ckpt_msg_v9_t`

Rename file lgs_mbcsv_cache.cc,h to lgs_mbcsv_v8.cc,h
---
 src/log/Makefile.am   |  4 ++--
 src/log/logd/lgs_cache.cc |  2 +-
 src/log/logd/lgs_cache.h  |  2 +-
 src/log/logd/lgs_mbcsv.cc |  2 +-
 .../{lgs_mbcsv_cache.cc => lgs_mbcsv_v8.cc}   |  2 +-
 .../{lgs_mbcsv_cache.h => lgs_mbcsv_v8.h} |  6 +++---
 src/log/logd/lgs_mbcsv_v9.cc  | 19 +++
 src/log/logd/lgs_mbcsv_v9.h   |  4 
 8 files changed, 32 insertions(+), 9 deletions(-)
 rename src/log/logd/{lgs_mbcsv_cache.cc => lgs_mbcsv_v8.cc} (99%)
 rename src/log/logd/{lgs_mbcsv_cache.h => lgs_mbcsv_v8.h} (96%)

diff --git a/src/log/Makefile.am b/src/log/Makefile.am
index 2dad3cfb1..df061e6eb 100644
--- a/src/log/Makefile.am
+++ b/src/log/Makefile.am
@@ -98,7 +98,7 @@ noinst_HEADERS += \
 src/log/logd/lgs_common.h \
 src/log/logd/lgs_amf.h \
 src/log/logd/lgs_cache.h \
-   src/log/logd/lgs_mbcsv_cache.h
+   src/log/logd/lgs_mbcsv_v8.h


 bin_PROGRAMS += bin/saflogger
@@ -162,7 +162,7 @@ bin_osaflogd_SOURCES = \
 src/log/logd/lgs_nildest.cc \
 src/log/logd/lgs_unixsock_dest.cc \
 src/log/logd/lgs_cache.cc \
-   src/log/logd/lgs_mbcsv_cache.cc
+   src/log/logd/lgs_mbcsv_v8.cc

 bin_osaflogd_LDADD = \
 lib/libosaf_common.la \
diff --git a/src/log/logd/lgs_cache.cc b/src/log/logd/lgs_cache.cc
index 81f64225d..d6a282e48 100644
--- a/src/log/logd/lgs_cache.cc
+++ b/src/log/logd/lgs_cache.cc
@@ -18,7 +18,7 @@
 #include "log/logd/lgs_cache.h"

 #include "log/logd/lgs_dest.h"
-#include "log/logd/lgs_mbcsv_cache.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "log/logd/lgs_evt.h"
 #include "log/logd/lgs_evt.h"
 #include "log/logd/lgs_mbcsv.h"
diff --git a/src/log/logd/lgs_cache.h b/src/log/logd/lgs_cache.h
index 9d2d29726..a5d6181fb 100644
--- a/src/log/logd/lgs_cache.h
+++ b/src/log/logd/lgs_cache.h
@@ -26,7 +26,7 @@
 #include 

 #include "log/logd/lgs.h"
-#include "log/logd/lgs_mbcsv_cache.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "base/macros.h"

 // This atomic variable stores the readiness status of file hdle thread.
diff --git a/src/log/logd/lgs_mbcsv.cc b/src/log/logd/lgs_mbcsv.cc
index 7150e74dd..6ec004f0a 100644
--- a/src/log/logd/lgs_mbcsv.cc
+++ b/src/log/logd/lgs_mbcsv.cc
@@ -24,12 +24,12 @@
 #include "osaf/immutil/immutil.h"
 #include "log/logd/lgs_dest.h"
 #include "log/logd/lgs_mbcsv_v9.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "log/logd/lgs_mbcsv_v6.h"
 #include "log/logd/lgs_mbcsv_v5.h"
 #include "log/logd/lgs_mbcsv_v3.h"
 #include "log/logd/lgs_mbcsv_v2.h"
 #include "log/logd/lgs_mbcsv_v1.h"
-#include "log/logd/lgs_mbcsv_cache.h"
 #include "log/logd/lgs_recov.h"
 #include "log/logd/lgs_cache.h"
 /*
diff --git a/src/log/logd/lgs_mbcsv_cache.cc b/src/log/logd/lgs_mbcsv_v8.cc
similarity index 99%
rename from src/log/logd/lgs_mbcsv_cache.cc
rename to src/log/logd/lgs_mbcsv_v8.cc
index b190c5bea..289a4f610 100644
--- a/src/log/logd/lgs_mbcsv_cache.cc
+++ b/src/log/logd/lgs_mbcsv_v8.cc
@@ -15,7 +15,7 @@
  *
  */

-#include "log/logd/lgs_mbcsv_cache.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "log/logd/lgs_cache.h"

 uint32_t EncodeDecodePushAsync(EDU_HDL* edu_hdl, EDU_TKN* edu_tkn,
diff --git a/src/log/logd/lgs_mbcsv_cache.h b/src/log/logd/lgs_mbcsv_v8.h
similarity index 96%
rename from src/log/logd/lgs_mbcsv_cache.h
rename to src/log/logd/lgs_mbcsv_v8.h
index a6f5f440b..b07222962 100644
--- a/src/log/logd/lgs_mbcsv_cache.h
+++ b/src/log/logd/lgs_mbcsv_v8.h
@@ -15,8 +15,8 @@
  *
  */

-#ifndef LOG_LOGD_LGS_MBCSV_CACHE_H_
-#define LOG_LOGD_LGS_MBCSV_CACHE_H_
+#ifndef LOG_LOGD_LGS_MBCSV_V8_H_
+#define LOG_LOGD_LGS_MBCSV_V8_H_

 #include "log/logd/lgs_mbcsv_v2.h"
 #include "log/logd/lgs_mbcsv_v3.h"
@@ -107,4 +107,4 @@ void Dump(const CkptPushAsync* data);
 extern uint32_t test_counter;
 #endif

-#endif  // LOG_LOGD_LGS_MBCSV_CACHE_H_
+#endif  // LOG_LOGD_LGS_MBCSV_V8_H_
diff --git a/src/log/logd/lgs_mbcsv_v9.cc b/src/log/logd/lgs_mbcsv_v9.cc
index 9829ecb31..b1e2d637e 100644
--- a/src/log/logd/lgs_mbcsv_v9.cc
+++ b/src/log/logd/lgs_mbcsv_v9.cc
@@ -218,6 +218,25 @@ uint32_t edp_ed_ckpt_msg_v9(EDU_HDL *edu_hdl, EDU_TKN 
*edu_tkn, NCSCONTEXT ptr,
(reinterpret_cast(0))->ckpt_rec.lgs_cfg,
0, nullptr},

+  /* Push a write async */
+  {EDU_EXEC, EncodeDecodePushAsync, 0, 0, static_cast(EDU_EXIT),
+   (int64_t) &
+   (reinterpret_cast(0))->ckpt_rec.push_async,
+   0, nullptr},
+
+  /* Pop a

[devel] [PATCH 1/1] log: standby node is rebooted when nfs is unresponsive [#3161]

2020-02-27 Thread thien.m.huynh

Adding 3 checkpoint messages: `CkptPushAsync`, `CkptPopAsync`
and `CkptPopAndWriteAsync` into `lgsv_ckpt_msg_v9_t`

Rename file lgs_mbcsv_cache.cc,h to lgs_mbcsv_v8.cc,h
---
 src/log/Makefile.am   |  4 ++--
 src/log/logd/lgs_cache.cc |  2 +-
 src/log/logd/lgs_cache.h  |  2 +-
 src/log/logd/lgs_mbcsv.cc |  2 +-
 .../{lgs_mbcsv_cache.cc => lgs_mbcsv_v8.cc}   |  2 +-
 .../{lgs_mbcsv_cache.h => lgs_mbcsv_v8.h} |  6 +++---
 src/log/logd/lgs_mbcsv_v9.cc  | 19 +++
 src/log/logd/lgs_mbcsv_v9.h   |  4 
 8 files changed, 32 insertions(+), 9 deletions(-)
 rename src/log/logd/{lgs_mbcsv_cache.cc => lgs_mbcsv_v8.cc} (99%)
 rename src/log/logd/{lgs_mbcsv_cache.h => lgs_mbcsv_v8.h} (96%)

diff --git a/src/log/Makefile.am b/src/log/Makefile.am
index 2dad3cfb1..df061e6eb 100644
--- a/src/log/Makefile.am
+++ b/src/log/Makefile.am
@@ -98,7 +98,7 @@ noinst_HEADERS += \
src/log/logd/lgs_common.h \
src/log/logd/lgs_amf.h \
src/log/logd/lgs_cache.h \
-   src/log/logd/lgs_mbcsv_cache.h
+   src/log/logd/lgs_mbcsv_v8.h
 
 
 bin_PROGRAMS += bin/saflogger
@@ -162,7 +162,7 @@ bin_osaflogd_SOURCES = \
src/log/logd/lgs_nildest.cc \
src/log/logd/lgs_unixsock_dest.cc \
src/log/logd/lgs_cache.cc \
-   src/log/logd/lgs_mbcsv_cache.cc
+   src/log/logd/lgs_mbcsv_v8.cc
 
 bin_osaflogd_LDADD = \
lib/libosaf_common.la \
diff --git a/src/log/logd/lgs_cache.cc b/src/log/logd/lgs_cache.cc
index 81f64225d..d6a282e48 100644
--- a/src/log/logd/lgs_cache.cc
+++ b/src/log/logd/lgs_cache.cc
@@ -18,7 +18,7 @@
 #include "log/logd/lgs_cache.h"
 
 #include "log/logd/lgs_dest.h"
-#include "log/logd/lgs_mbcsv_cache.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "log/logd/lgs_evt.h"
 #include "log/logd/lgs_evt.h"
 #include "log/logd/lgs_mbcsv.h"
diff --git a/src/log/logd/lgs_cache.h b/src/log/logd/lgs_cache.h
index 9d2d29726..a5d6181fb 100644
--- a/src/log/logd/lgs_cache.h
+++ b/src/log/logd/lgs_cache.h
@@ -26,7 +26,7 @@
 #include 
 
 #include "log/logd/lgs.h"
-#include "log/logd/lgs_mbcsv_cache.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "base/macros.h"
 
 // This atomic variable stores the readiness status of file hdle thread.
diff --git a/src/log/logd/lgs_mbcsv.cc b/src/log/logd/lgs_mbcsv.cc
index 7150e74dd..6ec004f0a 100644
--- a/src/log/logd/lgs_mbcsv.cc
+++ b/src/log/logd/lgs_mbcsv.cc
@@ -24,12 +24,12 @@
 #include "osaf/immutil/immutil.h"
 #include "log/logd/lgs_dest.h"
 #include "log/logd/lgs_mbcsv_v9.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "log/logd/lgs_mbcsv_v6.h"
 #include "log/logd/lgs_mbcsv_v5.h"
 #include "log/logd/lgs_mbcsv_v3.h"
 #include "log/logd/lgs_mbcsv_v2.h"
 #include "log/logd/lgs_mbcsv_v1.h"
-#include "log/logd/lgs_mbcsv_cache.h"
 #include "log/logd/lgs_recov.h"
 #include "log/logd/lgs_cache.h"
 /*
diff --git a/src/log/logd/lgs_mbcsv_cache.cc b/src/log/logd/lgs_mbcsv_v8.cc
similarity index 99%
rename from src/log/logd/lgs_mbcsv_cache.cc
rename to src/log/logd/lgs_mbcsv_v8.cc
index b190c5bea..289a4f610 100644
--- a/src/log/logd/lgs_mbcsv_cache.cc
+++ b/src/log/logd/lgs_mbcsv_v8.cc
@@ -15,7 +15,7 @@
  *
  */
 
-#include "log/logd/lgs_mbcsv_cache.h"
+#include "log/logd/lgs_mbcsv_v8.h"
 #include "log/logd/lgs_cache.h"
 
 uint32_t EncodeDecodePushAsync(EDU_HDL* edu_hdl, EDU_TKN* edu_tkn,
diff --git a/src/log/logd/lgs_mbcsv_cache.h b/src/log/logd/lgs_mbcsv_v8.h
similarity index 96%
rename from src/log/logd/lgs_mbcsv_cache.h
rename to src/log/logd/lgs_mbcsv_v8.h
index a6f5f440b..b07222962 100644
--- a/src/log/logd/lgs_mbcsv_cache.h
+++ b/src/log/logd/lgs_mbcsv_v8.h
@@ -15,8 +15,8 @@
  *
  */
 
-#ifndef LOG_LOGD_LGS_MBCSV_CACHE_H_
-#define LOG_LOGD_LGS_MBCSV_CACHE_H_
+#ifndef LOG_LOGD_LGS_MBCSV_V8_H_
+#define LOG_LOGD_LGS_MBCSV_V8_H_
 
 #include "log/logd/lgs_mbcsv_v2.h"
 #include "log/logd/lgs_mbcsv_v3.h"
@@ -107,4 +107,4 @@ void Dump(const CkptPushAsync* data);
 extern uint32_t test_counter;
 #endif
 
-#endif  // LOG_LOGD_LGS_MBCSV_CACHE_H_
+#endif  // LOG_LOGD_LGS_MBCSV_V8_H_
diff --git a/src/log/logd/lgs_mbcsv_v9.cc b/src/log/logd/lgs_mbcsv_v9.cc
index 9829ecb31..b1e2d637e 100644
--- a/src/log/logd/lgs_mbcsv_v9.cc
+++ b/src/log/logd/lgs_mbcsv_v9.cc
@@ -218,6 +218,25 @@ uint32_t edp_ed_ckpt_msg_v9(EDU_HDL *edu_hdl, EDU_TKN 
*edu_tkn, NCSCONTEXT ptr,
(reinterpret_cast(0))->ckpt_rec.lgs_cfg,
0, nullptr},
 
+  /* Push a write async */
+  {EDU_EXEC, EncodeDecodePushAsync, 0, 0, static_cast(EDU_EXIT),
+   (int64_t) &
+   (reinterpret_cast(0))->ckpt_rec.push_async,
+   0, nullptr},
+
+  /* Pop a write async */
+  {EDU_EXEC, EncodeDecodePopAsync, 0, 0, static_cast(EDU_EXIT),
+   (int64_t) &
+   (reinterpret_cast(0))->ckpt_rec.pop_async,
+   0, nullptr},
+
+  /* Pop a write a sync and after done processing the write  request */
+  {EDU_EXEC,

[devel] [PATCH 0/1] Review Request for log: standby node is rebooted when nfs is unresponsive [#3161]

2020-02-27 Thread thien.m.huynh

Summary: log: standby node is rebooted when nfs is unresponsive [#3161]
Review request for Ticket(s): 3161
Peer Reviewer(s): Vu
Pull request to: Vu
Affected branch(es): develop
Development branch: ticket-3161
Base revision: 4bb1251589c5ccfab166b7dc69a4419f9e80571d
Personal repository: git://git.code.sf.net/u/thienhuynh/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesn
 OpenSAF servicesy
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 52ccbd18d8eefc0ef17776a60cccd476611ee64c
Author: thien.m.huynh 
Date:   Thu, 27 Feb 2020 15:32:52 +0700

log: standby node is rebooted when nfs is unresponsive [#3161]

Adding 3 checkpoint messages: `CkptPushAsync`, `CkptPopAsync`
and `CkptPopAndWriteAsync` into `lgsv_ckpt_msg_v9_t`

Rename file lgs_mbcsv_cache.cc,h to lgs_mbcsv_v8.cc,h



Complete diffstat:
--
 src/log/Makefile.am  |  4 ++--
 src/log/logd/lgs_cache.cc|  2 +-
 src/log/logd/lgs_cache.h |  2 +-
 src/log/logd/lgs_mbcsv.cc|  2 +-
 src/log/logd/{lgs_mbcsv_cache.cc => lgs_mbcsv_v8.cc} |  2 +-
 src/log/logd/{lgs_mbcsv_cache.h => lgs_mbcsv_v8.h}   |  6 +++---
 src/log/logd/lgs_mbcsv_v9.cc | 19 +++
 src/log/logd/lgs_mbcsv_v9.h  |  4 
 8 files changed, 32 insertions(+), 9 deletions(-)


Testing Commands:
-
N/A

Testing, Expected Results:
--
N/A

Conditions of Submission:
-
ACK from reviewer

Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  y  y
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.



___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1/1] imm: imm_list tool add new option --delimiter [#3155]

[devel] [PATCH 0/1] Review Request for imm: make delimiter of multiple attribute value from immlist configurable [#3155] V3

Re: [devel] [PATCH 1/1] log: standby node is rebooted when nfs is unresponsive [#3161]

[devel] [PATCH 1/1] log: standby node is rebooted when nfs is unresponsive [#3161]

[devel] [PATCH 0/1] Review Request for log: standby node is rebooted when nfs is unresponsive [#3161]

5 matches

Site Navigation

Mail list logo

Footer information