Re: [devel] [PATCH 0/1] Review Request for ckpt: add timeout handling for test_ckptOverwrite [#2624]

2017-10-16 Thread Vo Minh Hoang 
Dear Alex,

If there is no further comment, would you please help me push the patch.
Because I do not have the push privilege.

Thank you very much for your kindness.
Sincerely,
Hoang

-Original Message-
From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au] 
Sent: Thursday, October 12, 2017 6:26 PM
To: 'Alex Jones' <alex.jo...@genband.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0/1] Review Request for ckpt: add timeout
handling for test_ckptOverwrite [#2624]

Dear Alex,

 

Thank you very much for your very fast response.

 

Because this is test code, I think we should push it to release also, test
environment should be consistent even it is really not important.

If not, release branch might fail sometimes then cost extra effort for
verifying much more important code.

 

Sincerely,

Hoang

 

From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Thursday, October 12, 2017 6:01 PM
To: Hoang Vo <hoang.m...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/1] Review Request for ckpt: add timeout handling for
test_ckptOverwrite [#2624]

 

Hi Hoang,

 

  Ack from me. Is there a reason this needs to go on the release branch?
It's just test code.

 

Alex

  _  

From: Hoang Vo <hoang.m...@dektech.com.au <mailto:hoang.m...@dektech.com.au>
>
Sent: Thursday, October 12, 2017 6:13:44 AM
To: Alex Jones
Cc: opensaf-devel@lists.sourceforge.net
<mailto:opensaf-devel@lists.sourceforge.net> ; Hoang Vo
Subject: [PATCH 0/1] Review Request for ckpt: add timeout handling for
test_ckptOverwrite [#2624] 

 

  _  

NOTICE: This email was received from an EXTERNAL sender

  _  


Summary: ckpt: add timeout handling for test_ckptOverwrite [#2624] Review
request for Ticket(s): 2624 Peer Reviewer(s): ajo...@genband.com
<mailto:ajo...@genband.com> Pull request to: ajo...@genband.com
<mailto:ajo...@genband.com> Affected branch(es): develop, release
Development branch: ticket-2624 Base revision:
4fbc3261d53914242bdbc5c300caecc53b88365a
Personal repository: git://git.code.sf.net/u/swgerai/review


Impacted area Impact y/n

Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 38ebcac386e4cfda5c0b17feabaa609c526651d9
Author: Hoang Vo <hoang.m...@dektech.com.au
<mailto:hoang.m...@dektech.com.au> >
Date: Thu, 12 Oct 2017 16:53:24 +0700

ckpt: add timeout handling for test_ckptOverwrite [#2624]

test_ckptOverwrite verify overwrite behavior and should handle
SA_AIS_ERR_TIMEOUT by retrying operation.



Complete diffstat:
--
src/ckpt/apitest/test_cpa_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


Testing Commands:
-
ckpttest 20 1

Testing, Expected Results:
--
test case pass even in delay network situation

Conditions of Submission:
-
ACK from maintainer

Arch Built Started Linux distro
---
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files (i.e.
internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes like
trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other cosmetic
code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is too
much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent; Instead
you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or plac

Re: [devel] [PATCH 0/1] Review Request for ckpt: add timeout handling for test_ckptOverwrite [#2624]

2017-10-12 Thread Vo Minh Hoang 
Dear Alex,

 

Thank you very much for your very fast response.

 

Because this is test code, I think we should push it to release also, test
environment should be consistent even it is really not important.

If not, release branch might fail sometimes then cost extra effort for
verifying much more important code.

 

Sincerely,

Hoang

 

From: Alex Jones [mailto:alex.jo...@genband.com] 
Sent: Thursday, October 12, 2017 6:01 PM
To: Hoang Vo 
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/1] Review Request for ckpt: add timeout handling for
test_ckptOverwrite [#2624]

 

Hi Hoang,

 

  Ack from me. Is there a reason this needs to go on the release branch?
It's just test code.

 

Alex

  _  

From: Hoang Vo 
>
Sent: Thursday, October 12, 2017 6:13:44 AM
To: Alex Jones
Cc: opensaf-devel@lists.sourceforge.net
 ; Hoang Vo
Subject: [PATCH 0/1] Review Request for ckpt: add timeout handling for
test_ckptOverwrite [#2624] 

 

  _  

NOTICE: This email was received from an EXTERNAL sender

  _  


Summary: ckpt: add timeout handling for test_ckptOverwrite [#2624]
Review request for Ticket(s): 2624
Peer Reviewer(s): ajo...@genband.com  
Pull request to: ajo...@genband.com  
Affected branch(es): develop, release
Development branch: ticket-2624
Base revision: 4fbc3261d53914242bdbc5c300caecc53b88365a
Personal repository: git://git.code.sf.net/u/swgerai/review


Impacted area Impact y/n

Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 38ebcac386e4cfda5c0b17feabaa609c526651d9
Author: Hoang Vo  >
Date: Thu, 12 Oct 2017 16:53:24 +0700

ckpt: add timeout handling for test_ckptOverwrite [#2624]

test_ckptOverwrite verify overwrite behavior and should
handle SA_AIS_ERR_TIMEOUT by retrying operation.



Complete diffstat:
--
src/ckpt/apitest/test_cpa_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


Testing Commands:
-
ckpttest 20 1

Testing, Expected Results:
--
test case pass even in delay network situation

Conditions of Submission:
-
ACK from maintainer

Arch Built Started Linux distro
---
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email
etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service

Re: [devel] [PATCH 0/1] Review Request for ckpt: add timeout handling for test_ckptOverwrite [#2624]

2017-10-12 Thread Alex Jones 
Hi Hoang,


  Ack from me. Is there a reason this needs to go on the release branch? It's 
just test code.


Alex


From: Hoang Vo 
Sent: Thursday, October 12, 2017 6:13:44 AM
To: Alex Jones
Cc: opensaf-devel@lists.sourceforge.net; Hoang Vo
Subject: [PATCH 0/1] Review Request for ckpt: add timeout handling for 
test_ckptOverwrite [#2624]


NOTICE: This email was received from an EXTERNAL sender


Summary: ckpt: add timeout handling for test_ckptOverwrite [#2624]
Review request for Ticket(s): 2624
Peer Reviewer(s): ajo...@genband.com
Pull request to: ajo...@genband.com
Affected branch(es): develop, release
Development branch: ticket-2624
Base revision: 4fbc3261d53914242bdbc5c300caecc53b88365a
Personal repository: git://git.code.sf.net/u/swgerai/review


Impacted area Impact y/n

Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 38ebcac386e4cfda5c0b17feabaa609c526651d9
Author: Hoang Vo 
Date: Thu, 12 Oct 2017 16:53:24 +0700

ckpt: add timeout handling for test_ckptOverwrite [#2624]

test_ckptOverwrite verify overwrite behavior and should
handle SA_AIS_ERR_TIMEOUT by retrying operation.



Complete diffstat:
--
src/ckpt/apitest/test_cpa_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


Testing Commands:
-
ckpttest 20 1

Testing, Expected Results:
--
test case pass even in delay network situation

Conditions of Submission:
-
ACK from maintainer

Arch Built Started Linux distro
---
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 0/1] Review Request for ckpt: add timeout handling for test_ckptOverwrite [#2624]

2017-10-12 Thread Hoang Vo 
Summary: ckpt: add timeout handling for test_ckptOverwrite [#2624]
Review request for Ticket(s): 2624
Peer Reviewer(s): ajo...@genband.com
Pull request to: ajo...@genband.com
Affected branch(es): develop, release
Development branch: ticket-2624
Base revision: 4fbc3261d53914242bdbc5c300caecc53b88365a
Personal repository: git://git.code.sf.net/u/swgerai/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesn
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   y
 Other   n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 38ebcac386e4cfda5c0b17feabaa609c526651d9
Author: Hoang Vo 
Date:   Thu, 12 Oct 2017 16:53:24 +0700

ckpt: add timeout handling for test_ckptOverwrite [#2624]

test_ckptOverwrite verify overwrite behavior and should
handle SA_AIS_ERR_TIMEOUT by retrying operation.



Complete diffstat:
--
 src/ckpt/apitest/test_cpa_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Testing Commands:
-
ckpttest 20 1

Testing, Expected Results:
--
test case pass even in delay network situation

Conditions of Submission:
-
ACK from maintainer

Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  y  y
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel