Re: [devel] [PATCH 0/2] Review Request for amf: Handle the excessive assigments for 2N, Nway Active, NoRed due to split brain V2 [#2929]
Hi Minh ack (review only). Perhaps you could remove the TRACE_LEAVE() though. Thanks Gary On 16/10/18 09:16, Minh Chau wrote: Summary: amf: Add new susi fsm EXCESSIVE state to handle excessive assignment due to splitbrain V2 [#2929] Review request for Ticket(s): 2929 Peer Reviewer(s): Hans, Gary, Nagu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2929 Base revision: 9442e2bfc9c883a10bca1a88816da9ff6fda2921 Personal repository: git://git.code.sf.net/u/minh-chau/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 1677c8129803c69411a69d20f03ee881cc28adb7 Author: Minh Chau Date: Tue, 16 Oct 2018 08:58:17 +1100 amfd: Remove sending node reboot in 2N SG for duplicated assignment [#2929] The first part of #2929 which has introduced EXCESSIVE susi fms state, it also handles the duplicated 2N assignments so that the node that has duplicated assignments will be reboot. This patch removes the sending node reboot in avd_sg_2n_act_susi(), or amfd will send multiple node reboot to the same node otherwise. This patch also checks the duplicated QUIESCED assignments. revision 8bdce6a88fc339f20f4dc71d6695044a8997 Author: Minh Chau Date: Tue, 16 Oct 2018 08:56:48 +1100 amf: Add new susi fsm EXCESSIVE state to handle excessive assignment due to splitbrain V2 [#2929] Once splitbrain happens, we have multiple partitions, in which AMF will continue assignments to the spare SUs in each partitions. When network merge, these partitions join into one cluster and the assignments of SU become excessive. This patch adds a new susi fsm EXCESSIVE state, which is marked for the excessive assignments that AMF detects after multiple partitions join. For 2N SG: Any excessive assignment exists, the SU that has 2N assignment has its hosting node reboot For NWay Active, NoRed: Remove the excessive assignment only. For NpM, Nway: not supported Complete diffstat: -- src/amf/amfd/cluster.cc| 5 src/amf/amfd/sg.cc | 33 + src/amf/amfd/sg.h | 9 +- src/amf/amfd/sg_2n_fsm.cc | 46 +++--- src/amf/amfd/sg_nored_fsm.cc | 19 src/amf/amfd/sg_nwayact_fsm.cc | 19 src/amf/amfd/sgproc.cc | 34 +- src/amf/amfd/si.cc | 11 +++ src/amf/amfd/si.h | 1 + src/amf/amfd/siass.cc | 65 ++ src/amf/amfd/susi.h| 5 +++- 11 files changed, 191 insertions(+), 56 deletions(-) Testing Commands: - Repeat the tests described in #2926, #2920, #2929 Testing, Expected Results: -- For 2N: Node has involved any excessive 2N assignments will be reboot For NwayActive, NoRed: Excessive assignment is removed only Conditions of Submission: - ack Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your
[devel] [PATCH 0/2] Review Request for amf: Handle the excessive assigments for 2N, Nway Active, NoRed due to split brain V2 [#2929]
Summary: amf: Add new susi fsm EXCESSIVE state to handle excessive assignment due to splitbrain V2 [#2929] Review request for Ticket(s): 2929 Peer Reviewer(s): Hans, Gary, Nagu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2929 Base revision: 9442e2bfc9c883a10bca1a88816da9ff6fda2921 Personal repository: git://git.code.sf.net/u/minh-chau/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 1677c8129803c69411a69d20f03ee881cc28adb7 Author: Minh Chau Date: Tue, 16 Oct 2018 08:58:17 +1100 amfd: Remove sending node reboot in 2N SG for duplicated assignment [#2929] The first part of #2929 which has introduced EXCESSIVE susi fms state, it also handles the duplicated 2N assignments so that the node that has duplicated assignments will be reboot. This patch removes the sending node reboot in avd_sg_2n_act_susi(), or amfd will send multiple node reboot to the same node otherwise. This patch also checks the duplicated QUIESCED assignments. revision 8bdce6a88fc339f20f4dc71d6695044a8997 Author: Minh Chau Date: Tue, 16 Oct 2018 08:56:48 +1100 amf: Add new susi fsm EXCESSIVE state to handle excessive assignment due to splitbrain V2 [#2929] Once splitbrain happens, we have multiple partitions, in which AMF will continue assignments to the spare SUs in each partitions. When network merge, these partitions join into one cluster and the assignments of SU become excessive. This patch adds a new susi fsm EXCESSIVE state, which is marked for the excessive assignments that AMF detects after multiple partitions join. For 2N SG: Any excessive assignment exists, the SU that has 2N assignment has its hosting node reboot For NWay Active, NoRed: Remove the excessive assignment only. For NpM, Nway: not supported Complete diffstat: -- src/amf/amfd/cluster.cc| 5 src/amf/amfd/sg.cc | 33 + src/amf/amfd/sg.h | 9 +- src/amf/amfd/sg_2n_fsm.cc | 46 +++--- src/amf/amfd/sg_nored_fsm.cc | 19 src/amf/amfd/sg_nwayact_fsm.cc | 19 src/amf/amfd/sgproc.cc | 34 +- src/amf/amfd/si.cc | 11 +++ src/amf/amfd/si.h | 1 + src/amf/amfd/siass.cc | 65 ++ src/amf/amfd/susi.h| 5 +++- 11 files changed, 191 insertions(+), 56 deletions(-) Testing Commands: - Repeat the tests described in #2926, #2920, #2929 Testing, Expected Results: -- For 2N: Node has involved any excessive 2N assignments will be reboot For NwayActive, NoRed: Excessive assignment is removed only Conditions of Submission: - ack Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have
