Re: [devel] [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951]
Hi Hans, Vu, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in - Original Message - Subject: RE: [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951] From: mo...@hasolutions.in Date: 11/15/18 5:39 pm To: vu.m.ngu...@dektech.com.au, hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" Hi Hans, Vu, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in - Original Message - Subject: [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951] From: "Mohan Kanakam" Date: 11/1/18 1:57 pm To: vu.m.ngu...@dektech.com.au, hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" Summary: imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951] Review request for Ticket(s): 2951 Peer Reviewer(s): vu.m.nguyen, Hans Nordebck Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2951 Base revision: 39928c976dfce75f69892f717df3ea128ef835aa Personal repository: git://git.code.sf.net/u/mohan-hasoln/review Impacted area Impact y/n Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c911b14077deab58eda68f7f5786bd030b2687fb Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:41:50 +0530 imm: add new test case of API saImmOmFinalize() of apitest [#2951] revision edae9e76d7f286fa400de1cd4c51a0ccc225de8c Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:32:04 +0530 imm: add new test case of API saImmOmDispatch() of apitest [#2951] revision 1fceef2f35a08c2490c11c9329725b58a6377e79 Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:15:40 +0530 imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951] Complete diffstat: -- src/imm/apitest/management/test_saImmOmDispatch.c | 72 ++ src/imm/apitest/management/test_saImmOmFinalize.c | 15 + .../apitest/management/test_saImmOmInitialize.c | 51 +++ .../management/test_saImmOmSelectionObjectGet.c | 15 + 4 files changed, 153 insertions(+) Testing Commands: - ./immomtest 1 Testing, Expected Results: -- 14 PASSED saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - uninitlized handle 15 PASSED saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - finalized handle 20 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_ONE 21 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_ONE 22 PASSED saImmOmDispatch - SA_AIS_OK SA_DISPATCH_BLOCKING 23 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle SA_DISPATCH_ALL 24 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_ALL 25 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_ALL 26 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle SA_DISPATCH_BLOCKING 27 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_BLOCKING 28 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_BLOCKING 31 PASSED saImmOmFinalize - SA_AIS_ERR_BAD_HANDLE - finalized handle 32 PASSED saImmOmFinalize - SA_AIS_ERR_BAD_HANDLE - uninitlized handle Conditions of Submission: - Ack from maintainers Arch Built Started Linux distro --- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You
Re: [devel] [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951]
Hi Hans, Vu, Polite remainder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in - Original Message - Subject: [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951] From: "Mohan Kanakam" Date: 11/1/18 1:57 pm To: vu.m.ngu...@dektech.com.au, hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net, "Mohan Kanakam" Summary: imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951] Review request for Ticket(s): 2951 Peer Reviewer(s): vu.m.nguyen, Hans Nordebck Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2951 Base revision: 39928c976dfce75f69892f717df3ea128ef835aa Personal repository: git://git.code.sf.net/u/mohan-hasoln/review Impacted area Impact y/n Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c911b14077deab58eda68f7f5786bd030b2687fb Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:41:50 +0530 imm: add new test case of API saImmOmFinalize() of apitest [#2951] revision edae9e76d7f286fa400de1cd4c51a0ccc225de8c Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:32:04 +0530 imm: add new test case of API saImmOmDispatch() of apitest [#2951] revision 1fceef2f35a08c2490c11c9329725b58a6377e79 Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:15:40 +0530 imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951] Complete diffstat: -- src/imm/apitest/management/test_saImmOmDispatch.c | 72 ++ src/imm/apitest/management/test_saImmOmFinalize.c | 15 + .../apitest/management/test_saImmOmInitialize.c | 51 +++ .../management/test_saImmOmSelectionObjectGet.c | 15 + 4 files changed, 153 insertions(+) Testing Commands: - ./immomtest 1 Testing, Expected Results: -- 14 PASSED saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - uninitlized handle 15 PASSED saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - finalized handle 20 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_ONE 21 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_ONE 22 PASSED saImmOmDispatch - SA_AIS_OK SA_DISPATCH_BLOCKING 23 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle SA_DISPATCH_ALL 24 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_ALL 25 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_ALL 26 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle SA_DISPATCH_BLOCKING 27 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_BLOCKING 28 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_BLOCKING 31 PASSED saImmOmFinalize - SA_AIS_ERR_BAD_HANDLE - finalized handle 32 PASSED saImmOmFinalize - SA_AIS_ERR_BAD_HANDLE - uninitlized handle Conditions of Submission: - Ack from maintainers Arch Built Started Linux distro --- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content
[devel] [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951]
Summary: imm: add new test cases of API saImmOmClassCreate_2() of apitest [#2951] Review request for Ticket(s): 2951_1 Peer Reviewer(s):vu.m.nguyen, Hans Nordeb??ck Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2951_1 Base revision: 39928c976dfce75f69892f717df3ea128ef835aa Personal repository: git://git.code.sf.net/u/mohan-hasoln/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesn OpenSAF servicesn Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision e758cddffa03f863a6d17d9b407d3bc28a2763c1 Author: Mohan Kanakam Date: Fri, 2 Nov 2018 12:25:49 +0530 imm: add new test case of API saImmOmClassDelete() of apitest [#2951] revision 6602336dcfeabaa66ef06c223aa9fe9d6c19b55e Author: Mohan Kanakam Date: Fri, 2 Nov 2018 12:15:52 +0530 imm: add new test case of API saImmOmClassDescriptionGet_2() of apitest [#2951] revision daf9d096912e822044cbe82a65704ebed4fe8afc Author: Mohan Kanakam Date: Fri, 2 Nov 2018 12:03:23 +0530 imm: add new test cases of API saImmOmClassCreate_2() of apitest [#2951] Complete diffstat: -- .../apitest/management/test_saImmOmClassCreate_2.c | 92 ++ .../apitest/management/test_saImmOmClassDelete.c | 19 + .../management/test_saImmOmClassDescriptionGet_2.c | 25 ++ 3 files changed, 136 insertions(+) Testing Commands: - ./immomtest 2 Testing, Expected Results: -- 19 PASSED saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE CONFIG CLASS 20 PASSED saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE CONFIG CLASS UNINITLIZED HANDLE 21 PASSED saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE RUNTIME CLASS UNINTILIZED HANDLE 22 PASSED saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE CONFIG CLASS FINALIZED HANDLE 23 PASSED saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE RUNTIME CLASS FINALLIZED HANDLE 31 PASSED saImmOmClassDescriptionGet_2 - SA_AIS_ERR_INVALID_PARAM 39 PASSED saImmOmClassDelete_2 - SA_AIS_ERR_NOT_EXIST Conditions of Submission: - Ack from maintainers Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your
[devel] [PATCH 0/3] Review Request for imm: add new test cases of apitest [#2951]
Summary: imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951] Review request for Ticket(s): 2951 Peer Reviewer(s): vu.m.nguyen, Hans Nordeb??ck Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2951 Base revision: 39928c976dfce75f69892f717df3ea128ef835aa Personal repository: git://git.code.sf.net/u/mohan-hasoln/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesn OpenSAF servicesn Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c911b14077deab58eda68f7f5786bd030b2687fb Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:41:50 +0530 imm: add new test case of API saImmOmFinalize() of apitest [#2951] revision edae9e76d7f286fa400de1cd4c51a0ccc225de8c Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:32:04 +0530 imm: add new test case of API saImmOmDispatch() of apitest [#2951] revision 1fceef2f35a08c2490c11c9329725b58a6377e79 Author: Mohan Kanakam Date: Thu, 1 Nov 2018 13:15:40 +0530 imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951] Complete diffstat: -- src/imm/apitest/management/test_saImmOmDispatch.c | 72 ++ src/imm/apitest/management/test_saImmOmFinalize.c | 15 + .../apitest/management/test_saImmOmInitialize.c| 51 +++ .../management/test_saImmOmSelectionObjectGet.c| 15 + 4 files changed, 153 insertions(+) Testing Commands: - ./immomtest 1 Testing, Expected Results: -- 14 PASSED saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - uninitlized handle 15 PASSED saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - finalized handle 20 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_ONE 21 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_ONE 22 PASSED saImmOmDispatch - SA_AIS_OK SA_DISPATCH_BLOCKING 23 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle SA_DISPATCH_ALL 24 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_ALL 25 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_ALL 26 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - invalid handle SA_DISPATCH_BLOCKING 27 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - uninitilized handle SA_DISPATCH_BLOCKING 28 PASSED saImmOmDispatch - SA_AIS_ERR_BAD_HANDLE - finalized handle SA_DISPATCH_BLOCKING 31 PASSED saImmOmFinalize - SA_AIS_ERR_BAD_HANDLE - finalized handle 32 PASSED saImmOmFinalize - SA_AIS_ERR_BAD_HANDLE - uninitlized handle Conditions of Submission: - Ack from maintainers Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public