Summary: amfd: Respond with TRY_AGAIN to admin ops during a controller
switch-over [#821]
Review request for Trac Ticket(s): 821
Peer Reviewer(s): Hans N, Nagendra, Praveen, Hans F
Pull request to:
Affected branch(es): default, 4.4
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset ed011a4d972f515395c9be7b3ed06b3ffdda5934
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 23 Apr 2014 11:08:28 +1000
amfd: Respond with TRY_AGAIN to admin ops during a controller
switch-over
[#821]
It has been found that an admin operation (other than controller switch-
over) can be started after a controller switch-over has been initiated.
The result of this can be that the admin operation response gets lost.
The
reason for it to get lost is that an IMM admin response has to be
responded
on the same node where it was initiated.
The change is to disallow new admin operations when controller
switch-over
is in progress. This will result in TRYAGAIN to the issuing program
which
should stop once the AMF implementer has connected and the controller
switch-over has finished.
credit: Hans Feldt
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/imm.cc | 13 ++++++++++++-
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 8 +-------
2 files changed, 13 insertions(+), 8 deletions(-)
Testing Commands:
-----------------
1) Install amf_demo
2) Trigger a controller switch-over
amf-adm si-swap safSi=SC-2N,safApp=OpenSAF
3) Issue an admin op to restart amf_demo
amf-adm restart safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
Testing, Expected Results:
--------------------------
amf-adm should automatically retry within the default timeout period,
and not return TIMEOUT
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
