Summary: NTF: Support DNs longer than 255 bytes [#873] V2
Review request for Trac Ticket(s): [#873]
Peer Reviewer(s): AndersW, HansF, Praveen, Mathi, Zoran, AndersBj
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This is patch series version 2:
- Fix bugs in NTF common library
- Adapt NTF tools to support long DNs
- Add test cases for ntftest (testsuite 35)
changeset 95f86bfa9ce44e0d54c6bc366a4705a727bccc28
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
NTF: Adapt NTF tools (ntfread, ntfsend, ntfsubscribe) to support long
DNs
[#873]
changeset 745302d173e2b2149b8d7b18ee30d3c97dc54076
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
NTF: Adapt NTF osaf service to support long DNs [#873]
changeset 2617d179148fdc65e2c460c27f674ffe9337d335
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
NTF: Adapt NTFIMCND to support long DNs [#873]
changeset 04a3957641bf1da7ee374fb65f70b7497a912054
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
NTF: Add ntftest test cases for notification with long dn objects [#873]
changeset 741dec0e28d58e9c3ffa636a65653220a3f7e831
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
NTF: Adapt NTF common library to support long DNs [#873] v2
(1)Fix big endian issue in ntfs_sanamet_length. (2)Simplify
ntfs_sanamet_strdup. (3)Fix memory bug in ntfsv_filter_header_free.
changeset f65bf3b4570d95d411970a6247b7ba1ab3d64f3c
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
NTF: Adapt NTF API to support long DNs [#873]
changeset 3d9821f070896d3d835cf92869aa77f7dbfd201d
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Wed, 09 Jul 2014 14:35:06 +1000
Temporary patch to solve compilation dependency
This patch is not part of #873, it's made to solve the dependency since
NTF
is using immutil.c and saflog.c. NOTE that it will not be pushed
together
with #873
Added Files:
------------
tests/ntfsv/tet_longDnObject_notification.c
Complete diffstat:
------------------
osaf/libs/agents/saf/ntfa/Makefile.am | 1 +
osaf/libs/agents/saf/ntfa/ntfa_api.c | 25 +-
osaf/libs/common/ntfsv/Makefile.am | 1 +
osaf/libs/common/ntfsv/include/ntfsv_mem.h | 7 +
osaf/libs/common/ntfsv/ntfsv_enc_dec.c | 37 ++-
osaf/libs/common/ntfsv/ntfsv_mem.c | 152 ++++++++++++-
osaf/libs/saf/libSaNtf/Makefile.am | 1 +
osaf/services/saf/ntfsv/ntfimcnd/Makefile.am | 2 +
osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_imm.c | 91 ++++---
osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_notifier.c | 54 ++--
osaf/services/saf/ntfsv/ntfs/Makefile.am | 1 +
osaf/services/saf/ntfsv/ntfs/NtfFilter.cc | 34 +-
osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 5 +-
osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 5 +-
osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 5 +
osaf/tools/safimm/src/immutil.c | 57 ++--
osaf/tools/saflog/src/saflog.c | 10 +-
osaf/tools/safntf/include/ntfclient.h | 1 +
osaf/tools/safntf/ntfread/Makefile.am | 6 +-
osaf/tools/safntf/ntfread/ntfread.c | 23 +-
osaf/tools/safntf/ntfsend/Makefile.am | 6 +-
osaf/tools/safntf/ntfsend/ntfsend.c | 29 +-
osaf/tools/safntf/ntfsubscribe/Makefile.am | 6 +-
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 4 +
osaf/tools/safntf/src/Makefile.am | 1 +
osaf/tools/safntf/src/ntfclient.c | 53 ++--
tests/ntfsv/Makefile.am | 3 +-
tests/ntfsv/tet_longDnObject_notification.c | 784
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/unit_test_fw/inc/util.h | 7 +-
tests/unit_test_fw/src/Makefile.am | 1 +
tests/unit_test_fw/src/util.c | 14 +-
31 files changed, 1189 insertions(+), 237 deletions(-)
Testing Commands:
-----------------
ntftest
Testing, Expected Results:
--------------------------
All tests pass (plus testsuite 35)
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
