Re: [devel] [PATCH 1 of 1] immtool: Don't finalize admo if it hasn't been initialized [#2107]

2016-10-12 Thread Neelakanta Reddy
Hi Hung,

Reviewed and tested the patch.
Ack.

/Neel.

On 2016/10/11 09:27 AM, Hung Nguyen wrote:
>   osaf/tools/safimm/immcfg/imm_cfg.c |  2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> Don't finalize admo if it hasn't been initialized.
>
> diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c 
> b/osaf/tools/safimm/immcfg/imm_cfg.c
> --- a/osaf/tools/safimm/immcfg/imm_cfg.c
> +++ b/osaf/tools/safimm/immcfg/imm_cfg.c
> @@ -1703,7 +1703,7 @@ static int imm_operation(int argc, char
>   }
>   }
>   
> - if(useAdminOwner) {
> + if(useAdminOwner && adminOwnerName) {
>   error = immutil_saImmOmAdminOwnerFinalize(ownerHandle);
>   if (SA_AIS_OK != error) {
>   fprintf(stderr, "error - 
> saImmOmAdminOwnerFinalize FAILED: %s\n", saf_error(error));


--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel


Re: [devel] [PATCH 1 of 1] immtool: Don't finalize admo if it hasn't been initialized [#2107]

2016-10-11 Thread Zoran Milinkovic
Hi Hung,

Reviewed, but not tested.
Ack from me.

Thanks,
Zoran

-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] 
Sent: den 11 oktober 2016 05:57
To: Zoran Milinkovic ; 
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immtool: Don't finalize admo if it hasn't been 
initialized [#2107]

 osaf/tools/safimm/immcfg/imm_cfg.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Don't finalize admo if it hasn't been initialized.

diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c 
b/osaf/tools/safimm/immcfg/imm_cfg.c
--- a/osaf/tools/safimm/immcfg/imm_cfg.c
+++ b/osaf/tools/safimm/immcfg/imm_cfg.c
@@ -1703,7 +1703,7 @@ static int imm_operation(int argc, char 
}
}
 
-   if(useAdminOwner) {
+   if(useAdminOwner && adminOwnerName) {
error = immutil_saImmOmAdminOwnerFinalize(ownerHandle);
if (SA_AIS_OK != error) {
fprintf(stderr, "error - 
saImmOmAdminOwnerFinalize FAILED: %s\n", saf_error(error));

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel


[devel] [PATCH 1 of 1] immtool: Don't finalize admo if it hasn't been initialized [#2107]

2016-10-10 Thread Hung Nguyen
 osaf/tools/safimm/immcfg/imm_cfg.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Don't finalize admo if it hasn't been initialized.

diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c 
b/osaf/tools/safimm/immcfg/imm_cfg.c
--- a/osaf/tools/safimm/immcfg/imm_cfg.c
+++ b/osaf/tools/safimm/immcfg/imm_cfg.c
@@ -1703,7 +1703,7 @@ static int imm_operation(int argc, char 
}
}
 
-   if(useAdminOwner) {
+   if(useAdminOwner && adminOwnerName) {
error = immutil_saImmOmAdminOwnerFinalize(ownerHandle);
if (SA_AIS_OK != error) {
fprintf(stderr, "error - 
saImmOmAdminOwnerFinalize FAILED: %s\n", saf_error(error));

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel