Re: [devel] [PATCH 1 of 1] mds: Improve log message [#2193]

[A V Mahesh]

Hi HansN,

ACK , Not tested.

-AVM


On 11/17/2016 12:59 PM, Hans Nordeback wrote:
>   osaf/libs/core/mds/mds_dt_tipc.c |  7 +--
>   1 files changed, 5 insertions(+), 2 deletions(-)
>
>
> diff --git a/osaf/libs/core/mds/mds_dt_tipc.c 
> b/osaf/libs/core/mds/mds_dt_tipc.c
> --- a/osaf/libs/core/mds/mds_dt_tipc.c
> +++ b/osaf/libs/core/mds/mds_dt_tipc.c
> @@ -2497,7 +2497,7 @@ static uint32_t mdtm_sendto(uint8_t *buf
>   {
>   /* Can be made as macro even */
>   struct sockaddr_tipc server_addr;
> - int send_len = 0;
> + ssize_t send_len = 0;
>   #ifdef MDS_CHECKSUM_ENABLE_FLAG
>   uint16_t checksum = 0;
>   #endif
> @@ -2524,8 +2524,11 @@ static uint32_t mdtm_sendto(uint8_t *buf
>   if (send_len == buff_len) {
>   m_MDS_LOG_INFO("MDTM: Successfully sent message");
>   return NCSCC_RC_SUCCESS;
> + } else if (send_len == -1) {
> + m_MDS_LOG_ERR("MDTM: Failed to send message err :%s", 
> strerror(errno));
> + return NCSCC_RC_FAILURE;
>   } else {
> - m_MDS_LOG_ERR("MDTM: Failed to send message err :%s", 
> strerror(errno));
> + m_MDS_LOG_ERR("MDTM: Failed to send message send_len :%zd", 
> send_len);
>   return NCSCC_RC_FAILURE;
>   }
>   }


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1 of 1] mds: Improve log message [#2193]

[Hans Nordeback]

 osaf/libs/core/mds/mds_dt_tipc.c |  7 +--
 1 files changed, 5 insertions(+), 2 deletions(-)


diff --git a/osaf/libs/core/mds/mds_dt_tipc.c b/osaf/libs/core/mds/mds_dt_tipc.c
--- a/osaf/libs/core/mds/mds_dt_tipc.c
+++ b/osaf/libs/core/mds/mds_dt_tipc.c
@@ -2497,7 +2497,7 @@ static uint32_t mdtm_sendto(uint8_t *buf
 {
/* Can be made as macro even */
struct sockaddr_tipc server_addr;
-   int send_len = 0;
+   ssize_t send_len = 0;
 #ifdef MDS_CHECKSUM_ENABLE_FLAG
uint16_t checksum = 0;
 #endif
@@ -2524,8 +2524,11 @@ static uint32_t mdtm_sendto(uint8_t *buf
if (send_len == buff_len) {
m_MDS_LOG_INFO("MDTM: Successfully sent message");
return NCSCC_RC_SUCCESS;
+   } else if (send_len == -1) {
+   m_MDS_LOG_ERR("MDTM: Failed to send message err :%s", 
strerror(errno));
+   return NCSCC_RC_FAILURE;
} else {
-   m_MDS_LOG_ERR("MDTM: Failed to send message err :%s", 
strerror(errno));
+   m_MDS_LOG_ERR("MDTM: Failed to send message send_len :%zd", 
send_len);
return NCSCC_RC_FAILURE;
}
 }

--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel