Re: [devel] [PATCH 3/5] ntf: add new test case of API saNtfDispatch() of apitest [#2958]

2018-11-13 Thread Minh Hon Chau 

Hi Mohan,

A minor comment, I think you meant to add saNtfDispatch_04.

Thanks

Minh

On 9/11/18 11:55 pm, Mohan Kanakam wrote:

---
  src/ntf/apitest/tet_saNtfDispatch.cc | 10 ++
  1 file changed, 10 insertions(+)

diff --git a/src/ntf/apitest/tet_saNtfDispatch.cc 
b/src/ntf/apitest/tet_saNtfDispatch.cc
index 5fea4ef..81a722c 100644
--- a/src/ntf/apitest/tet_saNtfDispatch.cc
+++ b/src/ntf/apitest/tet_saNtfDispatch.cc
@@ -40,6 +40,14 @@ void saNtfDispatch_03(void) {
test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
  }
  
+void saNtfDispatch_04(void) {

+  safassert(NtfTest::saNtfInitialize(, , ),
+  SA_AIS_OK);
+  safassert(NtfTest::saNtfFinalize(ntfHandle), SA_AIS_OK);
+  rc = NtfTest::saNtfDispatch(ntfHandle, SA_DISPATCH_ALL);
+  test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
+}
+
  __attribute__((constructor)) static void saNtfDispatch_constructor(void) {
test_suite_add(4, "Life cycle, dispatch, API 4");
test_case_add(4, saNtfDispatch_01,
@@ -48,4 +56,6 @@ __attribute__((constructor)) static void 
saNtfDispatch_constructor(void) {
"saNtfDispatch - invalid handle SA_AIS_ERR_BAD_HANDLE");
test_case_add(4, saNtfDispatch_03,
"saNtfDispatch - zero flag SA_AIS_ERR_INVALID_PARAM");
+  test_case_add(4, saNtfDispatch_03,
+  "saNtfDispatch - Fianlized handle SA_AIS_ERR_BAD_HANDLE");
  }



___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 3/5] ntf: add new test case of API saNtfDispatch() of apitest [#2958]

2018-11-09 Thread Mohan Kanakam 
---
 src/ntf/apitest/tet_saNtfDispatch.cc | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/src/ntf/apitest/tet_saNtfDispatch.cc 
b/src/ntf/apitest/tet_saNtfDispatch.cc
index 5fea4ef..81a722c 100644
--- a/src/ntf/apitest/tet_saNtfDispatch.cc
+++ b/src/ntf/apitest/tet_saNtfDispatch.cc
@@ -40,6 +40,14 @@ void saNtfDispatch_03(void) {
   test_validate(rc, SA_AIS_ERR_INVALID_PARAM);
 }
 
+void saNtfDispatch_04(void) {
+  safassert(NtfTest::saNtfInitialize(, , ),
+  SA_AIS_OK);
+  safassert(NtfTest::saNtfFinalize(ntfHandle), SA_AIS_OK);
+  rc = NtfTest::saNtfDispatch(ntfHandle, SA_DISPATCH_ALL);
+  test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
+}
+
 __attribute__((constructor)) static void saNtfDispatch_constructor(void) {
   test_suite_add(4, "Life cycle, dispatch, API 4");
   test_case_add(4, saNtfDispatch_01,
@@ -48,4 +56,6 @@ __attribute__((constructor)) static void 
saNtfDispatch_constructor(void) {
   "saNtfDispatch - invalid handle SA_AIS_ERR_BAD_HANDLE");
   test_case_add(4, saNtfDispatch_03,
   "saNtfDispatch - zero flag SA_AIS_ERR_INVALID_PARAM");
+  test_case_add(4, saNtfDispatch_03,
+  "saNtfDispatch - Fianlized handle SA_AIS_ERR_BAD_HANDLE");
 }
-- 
2.7.4



___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel