Re: [devel] [PATCH 1/1] imm: fix coredump generated during roaming test [#2943]
Hi Vu,
Ack.
Note1: Not tested.
Note2: This function is doing too much and its dependencies is very
hard to understand so I cannot confirm that this will solve the problem
or add any new problems within the time I can use on this review.
Thanks
Lennart
On tis, 2018-10-23 at 11:31 +0700, Vu Minh Nguyen wrote:
> The fix of ticket [#2934] was not covered the roaming SC case.
> With roaming, IMMND veteran could run on system controller node type.
>
> Instead of going to accept_node directly in previous fix, it should
> go to
> update_node_type.
> ---
> src/imm/immd/immd_evt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c
> index 9cd82da64..a0f632b7e 100644
> --- a/src/imm/immd/immd_evt.c
> +++ b/src/imm/immd/immd_evt.c
> @@ -1814,7 +1814,7 @@ static uint32_t
> immd_evt_proc_immnd_intro(IMMD_CB *cb, IMMD_EVT *evt,
> cb->ccb_id_count,
> msg->ccb_id_count,
> cb->impl_count, msg-
> >impl_count);
> }
> - goto accept_node;
> + goto update_node_type;
> }
>
> if (cb->fevsSendCount < evt-
> >info.ctrl_msg.fevs_count) {
> @@ -1887,6 +1887,7 @@ static uint32_t
> immd_evt_proc_immnd_intro(IMMD_CB *cb, IMMD_EVT *evt,
> }
> }
>
> +update_node_type:
> /* Determine type of node. */
> if (sinfo->dest == cb->loc_immnd_dest) {
> node_info->isOnController = true;
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1/1] imm: fix coredump generated during roaming test [#2943]
Hi all,
Do you have any comment for this patch? Thanks.
Regards, Vu
> -Original Message-
> From: Vu Minh Nguyen
> Sent: Tuesday, October 23, 2018 11:31 AM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com;
> gary@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
>
> Subject: [PATCH 1/1] imm: fix coredump generated during roaming test
> [#2943]
>
> The fix of ticket [#2934] was not covered the roaming SC case.
> With roaming, IMMND veteran could run on system controller node type.
>
> Instead of going to accept_node directly in previous fix, it should go to
> update_node_type.
> ---
> src/imm/immd/immd_evt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c
> index 9cd82da64..a0f632b7e 100644
> --- a/src/imm/immd/immd_evt.c
> +++ b/src/imm/immd/immd_evt.c
> @@ -1814,7 +1814,7 @@ static uint32_t
> immd_evt_proc_immnd_intro(IMMD_CB *cb, IMMD_EVT *evt,
> cb->ccb_id_count, msg-
> >ccb_id_count,
> cb->impl_count,
msg->impl_count);
> }
> - goto accept_node;
> + goto update_node_type;
> }
>
> if (cb->fevsSendCount <
evt->info.ctrl_msg.fevs_count)
> {
> @@ -1887,6 +1887,7 @@ static uint32_t
> immd_evt_proc_immnd_intro(IMMD_CB *cb, IMMD_EVT *evt,
> }
> }
>
> +update_node_type:
> /* Determine type of node. */
> if (sinfo->dest == cb->loc_immnd_dest) {
> node_info->isOnController = true;
> --
> 2.18.0
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
