[tickets] [opensaf:tickets] #2269 amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way Active model.

2017-08-31 Thread Gary Lee via Opensaf-tickets 
- **status**: review --> fixed



---

** [tickets:#2269] amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way 
Active model.**

**Status:** fixed
**Milestone:** 5.17.10
**Created:** Wed Jan 18, 2017 06:08 AM UTC by Praveen
**Last Updated:** Fri Sep 01, 2017 05:36 AM UTC
**Owner:** Praveen
**Attachments:**

- 
[AppConfig-nwayactive_3SUs_1SIs.xml](https://sourceforge.net/p/opensaf/tickets/2269/attachment/AppConfig-nwayactive_3SUs_1SIs.xml)
 (13.7 kB; text/xml)


AMF assigns more SUs than the configured vaue of saAmfSGNumPrefAssignedSUs in 
N-Way Active model.
Issue can be reproduced by brining up the attached configurration.
In the application saAmfSGNumPrefAssignedSUs is set to 2:
 immlist safSg=NWay_Active\,safApp=NWay_Active | grep -i prefass
saAmfSGNumPrefAssignedSUs  SA_UINT32_T  2 (0x2)

But AMF is giving assignmets to all the three SUs:
safSISU=safSu=SU2\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)

Since this attribute is valid for N-Way model also, issue is applicable to 
N-Way model also.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2269 amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way Active model.

2017-08-31 Thread Gary Lee via Opensaf-tickets 
develop:

commit 8b8c6beafa045affe2bfa34dc71ab3f9c7536c11
Author: Gary Lee 
Date:   Fri Sep 1 15:34:16 2017 +1000

amfd: update SI assignment state when SU is added or removed [#2269]

release:

commit 2afc8b61a01f3c5c4cc3cfcc4f21544f6564bf65
Author: Gary Lee 
Date:   Fri Sep 1 15:34:16 2017 +1000

amfd: update SI assignment state when SU is added or removed [#2269]






---

** [tickets:#2269] amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way 
Active model.**

**Status:** review
**Milestone:** 5.17.10
**Created:** Wed Jan 18, 2017 06:08 AM UTC by Praveen
**Last Updated:** Fri Sep 01, 2017 04:51 AM UTC
**Owner:** Praveen
**Attachments:**

- 
[AppConfig-nwayactive_3SUs_1SIs.xml](https://sourceforge.net/p/opensaf/tickets/2269/attachment/AppConfig-nwayactive_3SUs_1SIs.xml)
 (13.7 kB; text/xml)


AMF assigns more SUs than the configured vaue of saAmfSGNumPrefAssignedSUs in 
N-Way Active model.
Issue can be reproduced by brining up the attached configurration.
In the application saAmfSGNumPrefAssignedSUs is set to 2:
 immlist safSg=NWay_Active\,safApp=NWay_Active | grep -i prefass
saAmfSGNumPrefAssignedSUs  SA_UINT32_T  2 (0x2)

But AMF is giving assignmets to all the three SUs:
safSISU=safSu=SU2\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)

Since this attribute is valid for N-Way model also, issue is applicable to 
N-Way model also.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2568 amfnd: invalid read in cbq.cc

2017-08-31 Thread Gary Lee via Opensaf-tickets 



---

** [tickets:#2568] amfnd: invalid read in cbq.cc**

**Status:** unassigned
**Milestone:** 5.17.10
**Created:** Fri Sep 01, 2017 05:31 AM UTC by Gary Lee
**Last Updated:** Fri Sep 01, 2017 05:31 AM UTC
**Owner:** nobody


Noticed when running valgrind.

==195== Invalid read of size 8
==195==at 0x118F70: avnd_evt_tmr_cbk_resp_evh(avnd_cb_tag*, avnd_evt_tag*) 
(cbq.cc:636)
==195==by 0x142DEA: avnd_evt_process (main.cc:658)
==195==by 0x142DEA: avnd_main_process() (main.cc:610)
==195==by 0x116B81: main (main.cc:203)
==195==  Address 0x800b1c0 is 64 bytes inside a block of size 112 free'd
==195==at 0x4C2F24B: operator delete(void*) (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==195==by 0x118CBE: avnd_comp_cbq_rec_pop_and_del(avnd_cb_tag*, 
avnd_comp_tag*, avnd_cbk_tag*, bool) (cbq.cc:930)
==195==by 0x118F6F: avnd_evt_tmr_cbk_resp_evh(avnd_cb_tag*, avnd_evt_tag*) 
(cbq.cc:636)
==195==by 0x142DEA: avnd_evt_process (main.cc:658)
==195==by 0x142DEA: avnd_main_process() (main.cc:610)
==195==by 0x116B81: main (main.cc:203)
==195==  Block was alloc'd at
==195==at 0x4C2E0EF: operator new(unsigned long) (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==195==by 0x11AD18: avnd_comp_cbq_rec_add(avnd_cb_tag*, avnd_comp_tag*, 
avsv_amf_cbk_info_tag*, unsigned long*, long long) (cbq.cc:955)
==195==by 0x11AE85: avnd_comp_cbq_send(avnd_cb_tag*, avnd_comp_tag*, 
unsigned long*, unsigned long long, avsv_amf_cbk_info_tag*, long long) 
(cbq.cc:715)
==195==by 0x128162: avnd_comp_cbk_send(avnd_cb_tag*, avnd_comp_tag*, 
avsv_amf_cbk_type, avnd_hc_rec_tag*, avnd_comp_csi_rec*) (comp.cc:2164)
==195==by 0x123558: avnd_comp_clc_inst_restart_hdler(avnd_cb_tag*, 
avnd_comp_tag*) (clc.cc:2218)
==195==by 0x124B5C: avnd_comp_clc_fsm_run(avnd_cb_tag*, avnd_comp_tag*, 
avnd_comp_clc_pres_fsm_ev) (clc.cc:861)
==195==by 0x12C1BF: comp_restart_initiate(avnd_comp_tag*) (comp.cc:2767)
==195==by 0x12C4EB: avnd_evt_comp_admin_op_req(avnd_cb_tag*, avnd_evt_tag*) 
(comp.cc:2822)
==195==by 0x1361AA: avnd_evt_avd_admin_op_req_evh(avnd_cb_tag*, 
avnd_evt_tag*) (di.cc:1583)
==195==by 0x142DEA: avnd_evt_process (main.cc:658)
==195==by 0x142DEA: avnd_main_process() (main.cc:610)
==195==by 0x116B81: main (main.cc:203)


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2567 log: duplicated code in lga_client and lga_stream

2017-08-31 Thread Vu Minh Nguyen via Opensaf-tickets 
- **status**: assigned --> review



---

** [tickets:#2567] log: duplicated code in lga_client and lga_stream**

**Status:** review
**Milestone:** 5.17.10
**Created:** Thu Aug 31, 2017 01:15 PM UTC by Vu Minh Nguyen
**Last Updated:** Thu Aug 31, 2017 01:15 PM UTC
**Owner:** Vu Minh Nguyen


LogClient and LogStreamInfo class have same three methods with same code, they 
are:

```c++
int32_t FetchAndIncreaseRefCounter(bool* updated);
int32_t FetchAndDecreaseRefCounter(bool* updated);
void RestoreRefCounter(RefCounterDegree value, bool updated);
```

It is better to create independent RefCounter class with these methods.






---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2269 amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way Active model.

2017-08-31 Thread Gary Lee via Opensaf-tickets 
- **status**: unassigned --> review



---

** [tickets:#2269] amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way 
Active model.**

**Status:** review
**Milestone:** 5.17.10
**Created:** Wed Jan 18, 2017 06:08 AM UTC by Praveen
**Last Updated:** Fri Sep 01, 2017 01:29 AM UTC
**Owner:** Praveen
**Attachments:**

- 
[AppConfig-nwayactive_3SUs_1SIs.xml](https://sourceforge.net/p/opensaf/tickets/2269/attachment/AppConfig-nwayactive_3SUs_1SIs.xml)
 (13.7 kB; text/xml)


AMF assigns more SUs than the configured vaue of saAmfSGNumPrefAssignedSUs in 
N-Way Active model.
Issue can be reproduced by brining up the attached configurration.
In the application saAmfSGNumPrefAssignedSUs is set to 2:
 immlist safSg=NWay_Active\,safApp=NWay_Active | grep -i prefass
saAmfSGNumPrefAssignedSUs  SA_UINT32_T  2 (0x2)

But AMF is giving assignmets to all the three SUs:
safSISU=safSu=SU2\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)

Since this attribute is valid for N-Way model also, issue is applicable to 
N-Way model also.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2269 amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way Active model.

2017-08-31 Thread Gary Lee via Opensaf-tickets 
- **status**: fixed --> unassigned
- **Comment**:

There are still problems with saAmfSIAssignmentState if SUs are added or 
removed. It is not updated.



---

** [tickets:#2269] amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way 
Active model.**

**Status:** unassigned
**Milestone:** 5.17.10
**Created:** Wed Jan 18, 2017 06:08 AM UTC by Praveen
**Last Updated:** Thu Aug 31, 2017 06:49 AM UTC
**Owner:** Praveen
**Attachments:**

- 
[AppConfig-nwayactive_3SUs_1SIs.xml](https://sourceforge.net/p/opensaf/tickets/2269/attachment/AppConfig-nwayactive_3SUs_1SIs.xml)
 (13.7 kB; text/xml)


AMF assigns more SUs than the configured vaue of saAmfSGNumPrefAssignedSUs in 
N-Way Active model.
Issue can be reproduced by brining up the attached configurration.
In the application saAmfSGNumPrefAssignedSUs is set to 2:
 immlist safSg=NWay_Active\,safApp=NWay_Active | grep -i prefass
saAmfSGNumPrefAssignedSUs  SA_UINT32_T  2 (0x2)

But AMF is giving assignmets to all the three SUs:
safSISU=safSu=SU2\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)

Since this attribute is valid for N-Way model also, issue is applicable to 
N-Way model also.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2567 log: duplicated code in lga_client and lga_stream

2017-08-31 Thread Vu Minh Nguyen via Opensaf-tickets 



---

** [tickets:#2567] log: duplicated code in lga_client and lga_stream**

**Status:** assigned
**Milestone:** 5.17.10
**Created:** Thu Aug 31, 2017 01:15 PM UTC by Vu Minh Nguyen
**Last Updated:** Thu Aug 31, 2017 01:15 PM UTC
**Owner:** Vu Minh Nguyen


LogClient and LogStreamInfo class have same three methods with same code, they 
are:

```c++
int32_t FetchAndIncreaseRefCounter(bool* updated);
int32_t FetchAndDecreaseRefCounter(bool* updated);
void RestoreRefCounter(RefCounterDegree value, bool updated);
```

It is better to create independent RefCounter class with these methods.






---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2566 amfd: Segfaults in su/node_ccb_completed_delete_hdlr

2017-08-31 Thread Gary Lee via Opensaf-tickets 
This problem exists in most completed/apply callback handlers.


---

** [tickets:#2566] amfd: Segfaults in su/node_ccb_completed_delete_hdlr**

**Status:** accepted
**Milestone:** 5.17.07
**Created:** Thu Aug 31, 2017 08:34 AM UTC by Hoa Le
**Last Updated:** Thu Aug 31, 2017 10:21 AM UTC
**Owner:** Gary Lee
**Attachments:**

- 
[Log-2017-08-31_14-31-44.tar.gz](https://sourceforge.net/p/opensaf/tickets/2566/attachment/Log-2017-08-31_14-31-44.tar.gz)
 (4.2 MB; application/gzip)
- 
[core.1504164660.osafamfd.246.SC-2.txt](https://sourceforge.net/p/opensaf/tickets/2566/attachment/core.1504164660.osafamfd.246.SC-2.txt)
 (20.5 kB; text/plain)
- 
[core.1504164674.osafamfd.246.SC-2.txt](https://sourceforge.net/p/opensaf/tickets/2566/attachment/core.1504164674.osafamfd.246.SC-2.txt)
 (18.7 kB; text/plain)


The issue observed is that if an object in IMM is deleted right before Standby 
AMFD reading configuration to generate its own data, the callback Stanby AMFD 
receives afterward may cause Segmentation fault when AMFD tries to delete the 
already deleted object.

**Steps to reproduce:**
1. Modify avd_standby_role_initialization() function as below:
~~~
diff --git a/src/amf/amfd/role.cc b/src/amf/amfd/role.cc
index ec13c3b..5486ff7 100644
--- a/src/amf/amfd/role.cc
+++ b/src/amf/amfd/role.cc
@@ -299,6 +299,10 @@ uint32_t avd_standby_role_initialization(AVD_CL_CB *cb) {
 goto done;
   }
 
+  LOG_NO("### 1. Waiting ");
+  sleep(10);
+  LOG_NO("### 2. Waiting ");
+
   if (avd_imm_config_get() != NCSCC_RC_SUCCESS) {
 LOG_ER("avd_imm_config_get FAILED, AMF will not start.");
 goto done;
~~~

2. Start SC-1 then SC-2. SC-1 will become the active SC and SC-2 is on standby

3. Observe syslogs on SC-2, when the first "Waiting" log appears, run the 
following command on SC-1:
*immcfg -d safSu=PL-3,safSg=NoRed,safApp=OpenSAF
*
4. osafamfd on SC-2 will crash and then get rebooted.
2017-08-*31 14:30:50.828 SC-2 osafamfd[246]: NO ### 1. Waiting 
2017-08-31 14:30:53.780 SC-2 osafimmnd[206]: NO Ccb 2 COMMITTED (immcfgSC-1491)
2017-08-31 14:31:00.828 SC-2 osafamfd[246]: NO ### 2. Waiting 
2017-08-31 14:31:00.938 SC-2 osafamfd[246]: src/amf/amfd/su.cc:1664: 
succbcompleteddeletehdlr: Assertion 'su != nullptr' failed.
2017-08-31 14:31:00.942 SC-2 osafamfnd[256]: ER AMFD has unexpectedly crashed. 
Rebooting node*

5. Observe syslogs on SC-2, when the first "Waiting" log appears this time, run 
the following commands on SC-1:
*amf-adm lock safAmfNode=PL-3,safAmfCluster=myAmfCluster
amf-adm lock-in safAmfNode=PL-3,safAmfCluster=myAmfCluster
immcfg -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster 
safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
immcfg -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster 
safAmfNodeGroup=AllNodes,safAmfCluster=myAmfCluster
immcfg -d safAmfNode=PL-3,safAmfCluster=myAmfCluster
*
6. osafamfd on SC-2 will crash again.
2*017-08-31 14:31:04.448 SC-2 osafamfd[246]: NO ### 1. Waiting 
2017-08-31 14:31:07.904 SC-2 osafimmnd[206]: NO Ccb 3 COMMITTED (immcfgSC-1516)
2017-08-31 14:31:08.016 SC-2 osafimmnd[206]: NO Ccb 4 COMMITTED (immcfgSC-1519)
2017-08-31 14:31:08.141 SC-2 osafimmnd[206]: NO Ccb 5 COMMITTED (immcfgSC-1522)
2017-08-31 14:31:14.448 SC-2 osafamfd[246]: NO ### 2. Waiting 
2017-08-31 14:31:14.583 SC-2 osafamfnd[256]: ER AMFD has unexpectedly crashed. 
Rebooting node
2017-08-31 14:31:14.584 SC-2 osafamfnd[256]: Rebooting OpenSAF NodeId = 131599 
EE Name = , Reason: AMFD has unexpectedly crashed. Rebooting node, OwnNodeId = 
131599, SupervisionTime = 60*

Attached are backtraces, logs and traces of these two Segmentation faults



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2566 amfd: Segfaults in su/node_ccb_completed_delete_hdlr

2017-08-31 Thread Gary Lee via Opensaf-tickets 
- **status**: unassigned --> accepted
- **assigned_to**: Gary Lee



---

** [tickets:#2566] amfd: Segfaults in su/node_ccb_completed_delete_hdlr**

**Status:** accepted
**Milestone:** 5.17.07
**Created:** Thu Aug 31, 2017 08:34 AM UTC by Hoa Le
**Last Updated:** Thu Aug 31, 2017 08:41 AM UTC
**Owner:** Gary Lee
**Attachments:**

- 
[Log-2017-08-31_14-31-44.tar.gz](https://sourceforge.net/p/opensaf/tickets/2566/attachment/Log-2017-08-31_14-31-44.tar.gz)
 (4.2 MB; application/gzip)
- 
[core.1504164660.osafamfd.246.SC-2.txt](https://sourceforge.net/p/opensaf/tickets/2566/attachment/core.1504164660.osafamfd.246.SC-2.txt)
 (20.5 kB; text/plain)
- 
[core.1504164674.osafamfd.246.SC-2.txt](https://sourceforge.net/p/opensaf/tickets/2566/attachment/core.1504164674.osafamfd.246.SC-2.txt)
 (18.7 kB; text/plain)


The issue observed is that if an object in IMM is deleted right before Standby 
AMFD reading configuration to generate its own data, the callback Stanby AMFD 
receives afterward may cause Segmentation fault when AMFD tries to delete the 
already deleted object.

**Steps to reproduce:**
1. Modify avd_standby_role_initialization() function as below:
~~~
diff --git a/src/amf/amfd/role.cc b/src/amf/amfd/role.cc
index ec13c3b..5486ff7 100644
--- a/src/amf/amfd/role.cc
+++ b/src/amf/amfd/role.cc
@@ -299,6 +299,10 @@ uint32_t avd_standby_role_initialization(AVD_CL_CB *cb) {
 goto done;
   }
 
+  LOG_NO("### 1. Waiting ");
+  sleep(10);
+  LOG_NO("### 2. Waiting ");
+
   if (avd_imm_config_get() != NCSCC_RC_SUCCESS) {
 LOG_ER("avd_imm_config_get FAILED, AMF will not start.");
 goto done;
~~~

2. Start SC-1 then SC-2. SC-1 will become the active SC and SC-2 is on standby

3. Observe syslogs on SC-2, when the first "Waiting" log appears, run the 
following command on SC-1:
*immcfg -d safSu=PL-3,safSg=NoRed,safApp=OpenSAF
*
4. osafamfd on SC-2 will crash and then get rebooted.
2017-08-*31 14:30:50.828 SC-2 osafamfd[246]: NO ### 1. Waiting 
2017-08-31 14:30:53.780 SC-2 osafimmnd[206]: NO Ccb 2 COMMITTED (immcfgSC-1491)
2017-08-31 14:31:00.828 SC-2 osafamfd[246]: NO ### 2. Waiting 
2017-08-31 14:31:00.938 SC-2 osafamfd[246]: src/amf/amfd/su.cc:1664: 
succbcompleteddeletehdlr: Assertion 'su != nullptr' failed.
2017-08-31 14:31:00.942 SC-2 osafamfnd[256]: ER AMFD has unexpectedly crashed. 
Rebooting node*

5. Observe syslogs on SC-2, when the first "Waiting" log appears this time, run 
the following commands on SC-1:
*amf-adm lock safAmfNode=PL-3,safAmfCluster=myAmfCluster
amf-adm lock-in safAmfNode=PL-3,safAmfCluster=myAmfCluster
immcfg -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster 
safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
immcfg -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster 
safAmfNodeGroup=AllNodes,safAmfCluster=myAmfCluster
immcfg -d safAmfNode=PL-3,safAmfCluster=myAmfCluster
*
6. osafamfd on SC-2 will crash again.
2*017-08-31 14:31:04.448 SC-2 osafamfd[246]: NO ### 1. Waiting 
2017-08-31 14:31:07.904 SC-2 osafimmnd[206]: NO Ccb 3 COMMITTED (immcfgSC-1516)
2017-08-31 14:31:08.016 SC-2 osafimmnd[206]: NO Ccb 4 COMMITTED (immcfgSC-1519)
2017-08-31 14:31:08.141 SC-2 osafimmnd[206]: NO Ccb 5 COMMITTED (immcfgSC-1522)
2017-08-31 14:31:14.448 SC-2 osafamfd[246]: NO ### 2. Waiting 
2017-08-31 14:31:14.583 SC-2 osafamfnd[256]: ER AMFD has unexpectedly crashed. 
Rebooting node
2017-08-31 14:31:14.584 SC-2 osafamfnd[256]: Rebooting OpenSAF NodeId = 131599 
EE Name = , Reason: AMFD has unexpectedly crashed. Rebooting node, OwnNodeId = 
131599, SupervisionTime = 60*

Attached are backtraces, logs and traces of these two Segmentation faults



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2566 amfd: Segfaults in su/node_ccb_completed_delete_hdlr

2017-08-31 Thread Hoa Le via Opensaf-tickets 
- **Blocker**: False --> True



---

** [tickets:#2566] amfd: Segfaults in su/node_ccb_completed_delete_hdlr**

**Status:** unassigned
**Milestone:** 5.17.07
**Created:** Thu Aug 31, 2017 08:34 AM UTC by Hoa Le
**Last Updated:** Thu Aug 31, 2017 08:34 AM UTC
**Owner:** nobody
**Attachments:**

- 
[Log-2017-08-31_14-31-44.tar.gz](https://sourceforge.net/p/opensaf/tickets/2566/attachment/Log-2017-08-31_14-31-44.tar.gz)
 (4.2 MB; application/gzip)
- 
[core.1504164660.osafamfd.246.SC-2.txt](https://sourceforge.net/p/opensaf/tickets/2566/attachment/core.1504164660.osafamfd.246.SC-2.txt)
 (20.5 kB; text/plain)
- 
[core.1504164674.osafamfd.246.SC-2.txt](https://sourceforge.net/p/opensaf/tickets/2566/attachment/core.1504164674.osafamfd.246.SC-2.txt)
 (18.7 kB; text/plain)


The issue observed is that if an object in IMM is deleted right before Standby 
AMFD reading configuration to generate its own data, the callback Stanby AMFD 
receives afterward may cause Segmentation fault when AMFD tries to delete the 
already deleted object.

**Steps to reproduce:**
1. Modify avd_standby_role_initialization() function as below:
~~~
diff --git a/src/amf/amfd/role.cc b/src/amf/amfd/role.cc
index ec13c3b..5486ff7 100644
--- a/src/amf/amfd/role.cc
+++ b/src/amf/amfd/role.cc
@@ -299,6 +299,10 @@ uint32_t avd_standby_role_initialization(AVD_CL_CB *cb) {
 goto done;
   }
 
+  LOG_NO("### 1. Waiting ");
+  sleep(10);
+  LOG_NO("### 2. Waiting ");
+
   if (avd_imm_config_get() != NCSCC_RC_SUCCESS) {
 LOG_ER("avd_imm_config_get FAILED, AMF will not start.");
 goto done;
~~~

2. Start SC-1 then SC-2. SC-1 will become the active SC and SC-2 is on standby

3. Observe syslogs on SC-2, when the first "Waiting" log appears, run the 
following command on SC-1:
*immcfg -d safSu=PL-3,safSg=NoRed,safApp=OpenSAF
*
4. osafamfd on SC-2 will crash and then get rebooted.
2017-08-*31 14:30:50.828 SC-2 osafamfd[246]: NO ### 1. Waiting 
2017-08-31 14:30:53.780 SC-2 osafimmnd[206]: NO Ccb 2 COMMITTED (immcfgSC-1491)
2017-08-31 14:31:00.828 SC-2 osafamfd[246]: NO ### 2. Waiting 
2017-08-31 14:31:00.938 SC-2 osafamfd[246]: src/amf/amfd/su.cc:1664: 
succbcompleteddeletehdlr: Assertion 'su != nullptr' failed.
2017-08-31 14:31:00.942 SC-2 osafamfnd[256]: ER AMFD has unexpectedly crashed. 
Rebooting node*

5. Observe syslogs on SC-2, when the first "Waiting" log appears this time, run 
the following commands on SC-1:
*amf-adm lock safAmfNode=PL-3,safAmfCluster=myAmfCluster
amf-adm lock-in safAmfNode=PL-3,safAmfCluster=myAmfCluster
immcfg -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster 
safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
immcfg -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster 
safAmfNodeGroup=AllNodes,safAmfCluster=myAmfCluster
immcfg -d safAmfNode=PL-3,safAmfCluster=myAmfCluster
*
6. osafamfd on SC-2 will crash again.
2*017-08-31 14:31:04.448 SC-2 osafamfd[246]: NO ### 1. Waiting 
2017-08-31 14:31:07.904 SC-2 osafimmnd[206]: NO Ccb 3 COMMITTED (immcfgSC-1516)
2017-08-31 14:31:08.016 SC-2 osafimmnd[206]: NO Ccb 4 COMMITTED (immcfgSC-1519)
2017-08-31 14:31:08.141 SC-2 osafimmnd[206]: NO Ccb 5 COMMITTED (immcfgSC-1522)
2017-08-31 14:31:14.448 SC-2 osafamfd[246]: NO ### 2. Waiting 
2017-08-31 14:31:14.583 SC-2 osafamfnd[256]: ER AMFD has unexpectedly crashed. 
Rebooting node
2017-08-31 14:31:14.584 SC-2 osafamfnd[256]: Rebooting OpenSAF NodeId = 131599 
EE Name = , Reason: AMFD has unexpectedly crashed. Rebooting node, OwnNodeId = 
131599, SupervisionTime = 60*

Attached are backtraces, logs and traces of these two Segmentation faults



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2553 dtm: Convert DTM to C++

2017-08-31 Thread Anders Widell via Opensaf-tickets 
- **status**: review --> fixed
- **Comment**:

commit 2b65ecdaac6d0b80073149f137b0744aeeb6582b (HEAD -> develop, 
origin/develop, ticket-2553)
Author: Anders Widell 
Date:   Thu Aug 31 09:09:02 2017 +0200

dtm: Re-indent DTM after conversion to C++ [#2553]

Re-indent the DTM code according to the Google C++ style guide. Whitespace
change only.

commit 1c3b184b7a84ccd537b71bf21da4df2405c39e7d
Author: Anders Widell 
Date:   Thu Aug 31 09:09:02 2017 +0200

dtm: Convert DTM to C++ [#2553]

Convert DTM source files to C++, and perform some simple refactoring steps:

* 0 -> nullptr
* old style cast -> new style cast




---

** [tickets:#2553] dtm: Convert DTM to C++**

**Status:** fixed
**Milestone:** 5.17.10
**Created:** Wed Aug 16, 2017 08:56 AM UTC by Anders Widell
**Last Updated:** Tue Aug 22, 2017 02:12 PM UTC
**Owner:** Anders Widell


To simplify the implementation of [#2551], convert DTM to C++. This will allow 
us to use STL containers instead of the more primitive patricia tree 
implementation in OpenSAF.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2269 amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way Active model.

2017-08-31 Thread Gary Lee via Opensaf-tickets 
release:

commit 637d762cccdee3d994d28cc3d112155a1ab01fc1
Author: Gary Lee 
Date:   Thu Aug 31 15:55:10 2017 +1000

amfd: honor PrefAssignedSU in nway and nway active model during assignments 
[#2269]

commit dcb310c08c84ff33e6508237f52a16e82c819be9
Author: Praveen 
Date:   Thu Aug 31 10:56:36 2017 +0530

amfd: honor PrefAssignedSU in nway and nway active model during assignments 
[#2269]

SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way 
Active model.
AMF is assigning more than saAmfSGNumPrefAssignedSUs in both N-Way and 
N-Way Active model.

Patch fixes this problem.



---

** [tickets:#2269] amf: saAmfSGNumPrefAssignedSUs is not honored in N-Way 
Active model.**

**Status:** fixed
**Milestone:** 5.17.10
**Created:** Wed Jan 18, 2017 06:08 AM UTC by Praveen
**Last Updated:** Thu Aug 31, 2017 05:58 AM UTC
**Owner:** Praveen
**Attachments:**

- 
[AppConfig-nwayactive_3SUs_1SIs.xml](https://sourceforge.net/p/opensaf/tickets/2269/attachment/AppConfig-nwayactive_3SUs_1SIs.xml)
 (13.7 kB; text/xml)


AMF assigns more SUs than the configured vaue of saAmfSGNumPrefAssignedSUs in 
N-Way Active model.
Issue can be reproduced by brining up the attached configurration.
In the application saAmfSGNumPrefAssignedSUs is set to 2:
 immlist safSg=NWay_Active\,safApp=NWay_Active | grep -i prefass
saAmfSGNumPrefAssignedSUs  SA_UINT32_T  2 (0x2)

But AMF is giving assignmets to all the three SUs:
safSISU=safSu=SU2\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)

Since this attribute is valid for N-Way model also, issue is applicable to 
N-Way model also.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets