[tickets] [opensaf:tickets] #2578 amf: amf_demo program compilation error

2017-09-08 Thread Hans Nordebäck via Opensaf-tickets 



---

** [tickets:#2578] amf: amf_demo program compilation error**

**Status:** review
**Milestone:** 5.17.10
**Created:** Fri Sep 08, 2017 12:42 PM UTC by Hans Nordebäck
**Last Updated:** Fri Sep 08, 2017 12:42 PM UTC
**Owner:** Hans Nordebäck


/home/uabhano/work/opensaf-code/samples/amf/sa_aware/amf_demo.c:40:10: fatal 
error: saAmf.h: No such file or directory
 



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2577 amfd: Compilation error with gcc version > 6.3

2017-09-08 Thread Hans Nordebäck via Opensaf-tickets 



---

** [tickets:#2577] amfd: Compilation error with gcc version > 6.3**

**Status:** review
**Milestone:** 5.17.10
**Created:** Fri Sep 08, 2017 12:11 PM UTC by Hans Nordebäck
**Last Updated:** Fri Sep 08, 2017 12:11 PM UTC
**Owner:** Hans Nordebäck


Compilation error with gcc version > 6.3

src/amf/amfd/sg_nway_fsm.cc: In function ‘uint32_t 
avd_sg_nway_si_assign(AVD_CL_CB*, AVD_SG*)’:
src/amf/amfd/sg_nway_fsm.cc:1496:7: error: this ‘if’ clause does not guard... 
[-Werror=misleading-indentation]
   if (avd_su_susi_find(cb, curr_su, curr_si->name) != AVD_SU_SI_REL_NULL)
   ^~
src/amf/amfd/sg_nway_fsm.cc:1499:9: note: ...this statement, but the latter is 
misleadingly indented as if it were guarded by the ‘if’
 if ((sg->pref_assigned_sus() == sg->curr_assigned_sus()) &&



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2462 amf: Stop opensafd on one payload causes 2N SI partially assigned

2017-09-08 Thread Ravi Sekhar Reddy via Opensaf-tickets 
- **status**: accepted --> review



---

** [tickets:#2462] amf: Stop opensafd on one payload causes 2N SI partially 
assigned**

**Status:** review
**Milestone:** 5.17.10
**Labels:** 2N app 5 SUs 
**Created:** Wed May 17, 2017 03:52 AM UTC by Minh Hon Chau
**Last Updated:** Fri Sep 01, 2017 11:41 AM UTC
**Owner:** Ravi Sekhar Reddy
**Attachments:**

- 
[app3_twon5su3si.xml](https://sourceforge.net/p/opensaf/tickets/2462/attachment/app3_twon5su3si.xml)
 (18.0 kB; text/xml)
- 
[log_trace.tgz](https://sourceforge.net/p/opensaf/tickets/2462/attachment/log_trace.tgz)
 (1.2 MB; application/x-gzip-compressed)


Step to reproduce:
- Load the attached model, 2N app, 5 SUs hosted on each node of a 5 nodes 
cluster, i.e. SU1, SU2, SU3, SU4, SU5 are hosted on SC1, SC2, PL3, PL4, PL5
- Unlock-in/Unlock all SUs, so SU1, SU2 get Active/Standby assignment 
respectively
- Lock SU1, SU2. SU3, SU4 gets Active/Standby assignment
- Issue opensafd stop on PL3. SU4 gets Active assignment.

Observation:
Only SU4 gets active assignment, there's no Standby assignment for SU5 as it 
should.

safSu=SU1,safSg=AmfDemoTwon,safApp=AmfDemoTwon
saAmfSUAdminState=LOCKED(2)
saAmfSUOperState=ENABLED(1)
saAmfSUPresenceState=INSTANTIATED(3)
saAmfSUReadinessState=OUT-OF-SERVICE(1)
safSu=SU2,safSg=AmfDemoTwon,safApp=AmfDemoTwon
saAmfSUAdminState=LOCKED(2)
saAmfSUOperState=ENABLED(1)
saAmfSUPresenceState=UNINSTANTIATED(1)
saAmfSUReadinessState=OUT-OF-SERVICE(1)
safSu=SU3,safSg=AmfDemoTwon,safApp=AmfDemoTwon
saAmfSUAdminState=UNLOCKED(1)
saAmfSUOperState=DISABLED(2)
saAmfSUPresenceState=UNINSTANTIATED(1)
saAmfSUReadinessState=OUT-OF-SERVICE(1)
safSu=SU4,safSg=AmfDemoTwon,safApp=AmfDemoTwon
saAmfSUAdminState=UNLOCKED(1)
saAmfSUOperState=ENABLED(1)
saAmfSUPresenceState=INSTANTIATED(3)
saAmfSUReadinessState=IN-SERVICE(2)
safSu=SU5,safSg=AmfDemoTwon,safApp=AmfDemoTwon
saAmfSUAdminState=UNLOCKED(1)
saAmfSUOperState=ENABLED(1)
saAmfSUPresenceState=UNINSTANTIATED(1)
saAmfSUReadinessState=OUT-OF-SERVICE(1)

safSi=AmfDemoTwon,safApp=AmfDemoTwon
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=PARTIALLY_ASSIGNED(3)
safSi=AmfDemoTwonDep1,safApp=AmfDemoTwon
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=PARTIALLY_ASSIGNED(3)
safSi=AmfDemoTwonDep2,safApp=AmfDemoTwon
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=PARTIALLY_ASSIGNED(3)


Note that if the test replaces "Lock SU1, SU2" by "Reboot SC1, SC2", SI gets 
fully assigned, SU5 is instantiated.

Attached files are models, and collected log/trace


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2571 imm: OiAdminOperationResult doesn't check for validity of input invocation

2017-09-08 Thread Hung Nguyen via Opensaf-tickets 
- **status**: review --> fixed
- **Comment**:

develop (5.17.10) [code:10a835]

~~~
commit 10a83558372bbeae8b2d09e0fefd55cbc11dbd5d
Author: Hung Nguyen 
Date:   Wed Sep 6 17:10:47 2017 +0700

imm: Validate input invocation for saImmOiAdminOperationResult [#2571]

Add new set to IMMA_CLIENT_NODE to store the invocations.
The invocation is added to the set when dispatching the callback
and is removed from the set in saImmOiAdminOperationResult.
~~~

release [code:31ac0f]
~~~
commit 31ac0f2febebb8212286baba298cad6d2539a5e5
Author: Hung Nguyen 
Date:   Wed Sep 6 17:10:47 2017 +0700

imm: Validate input invocation for saImmOiAdminOperationResult [#2571]

Add new set to IMMA_CLIENT_NODE to store the invocations.
The invocation is added to the set when dispatching the callback
and is removed from the set in saImmOiAdminOperationResult.

~~~



---

** [tickets:#2571] imm: OiAdminOperationResult doesn't check for validity of 
input invocation**

**Status:** fixed
**Milestone:** 5.17.10
**Created:** Tue Sep 05, 2017 11:53 AM UTC by Hung Nguyen
**Last Updated:** Wed Sep 06, 2017 11:43 AM UTC
**Owner:** Hung Nguyen


When using OiAdminOperationResult() with invalid value of invocation, it 
returns OK.

saImmOiAdminOperationResult(immOiHandle, -1, SA_AIS_OK);

It should return ERR_INVALID_PARAM in this case.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2576 imm: Admin owner name is overwritten when committing modification

2017-09-08 Thread Hung Nguyen via Opensaf-tickets 



---

** [tickets:#2576] imm: Admin owner name is overwritten when committing 
modification**

**Status:** accepted
**Milestone:** 5.17.10
**Created:** Fri Sep 08, 2017 07:12 AM UTC by Hung Nguyen
**Last Updated:** Fri Sep 08, 2017 07:12 AM UTC
**Owner:** Hung Nguyen
**Attachments:**

- 
[reproduce_n_logs.tgz](https://sourceforge.net/p/opensaf/tickets/2576/attachment/reproduce_n_logs.tgz)
 (14.7 kB; application/x-compressed)


Steps to reproduce:


* Create an object to test. The xml file can be found attached in this ticket.
~~~
# immcfg -f /hostfs/TestClass_simple.xml
# immcfg -c Test test=1
~~~

* Delay the CcbCompleted callback of pbe to simulate IO/disk latency.
The gdb file can be found in attachments of this ticket.
~~~
# gdb --command=pbe_delay_committing.gdb /usr/local/lib/opensaf/osafimmpbed 
$(pidof osafimmpbed)
~~~

* Run the test. The source code of the test can be found attached to this 
ticket.
~~~
# ccb_modify_test
~~~

* Now check the admo name of the object, it will show **"admo1"** (it should be 
**"admo2"**).
~~~
# immlist -a SaImmAttrAdminOwnerName test=1
SaImmAttrAdminOwnerName=admo1
~~~


-


Here's what the test does:


* Create a CCB and modify **"test=1"**. The admo name is **"admo1"**.
~~~cpp
saImmOmInitialize(, NULL, );
saImmOmAdminOwnerInitialize(handle, "admo1", SA_TRUE, _handle);
saImmOmAdminOwnerSet(owner_handle, {"test=1"}, SA_IMM_ONE);
saImmOmCcbInitialize(owner_handle, 0, _handle);
saImmOmCcbObjectModify_2(ccb_handle, "test=1", attr_mods);
~~~

* saImmOmCcbApply returns ERR_TIMEOUT as we delay PBE.
~~~cpp
saImmOmCcbApply(ccb_handle);
~~~

* Finalize the handle
~~~cpp
saImmOmFinalize(handle);
~~~

* Initialize new admo and set to the same object **"test=1"**. **ROF** is 
**FALSE**.

~~~cpp
saImmOmInitialize(, NULL, );
saImmOmAdminOwnerInitialize(handle, "admo2", SA_FALSE, _handle);
saImmOmAdminOwnerSet(owner_handle, object_names, SA_IMM_ONE);
saImmOmFinalize(handle);
~~~

* At this time the admo that is set to the object is **"admo2"**.
* But when the ccb is committed, the admo name (**"admo2"**) is overwritten by 
the admo name in the after image (**"admo1"**).

~~~
11:39:49 SC-1 osafimmnd[214]: NO Ccb 3 COMMITTED ()
~~~



~~~cpp
11:39:49.132941 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:6096] >> ccbCommit 
11:39:49.132946 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:6103] T5 Commit 
CCB 3
11:39:49.132950 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:6109] T5 Ccb 3 
comitted by PBE now in state:9
11:39:49.132954 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:6111] T5 Comitting 
Ccb 3 in IMMND
11:39:49.132959 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:5934] >> 
commitModify 
11:39:49.132964 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:5935] T5 COMMITING 
MODIFY of test=1
11:39:49.132989 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:6027] << 
commitModify 
11:39:49.133893 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:6194] NO Ccb 3 
COMMITTED ()
11:39:49.133929 osafimmnd [214:214:src/imm/immnd/ImmModel.cc:] << ccbCommit


for (oavi = afterImage->mAttrValueMap.begin();
 oavi != afterImage->mAttrValueMap.end(); ++oavi) {
  AttrMap::iterator i4 = classInfo->mAttrMap.find(oavi->first);
  osafassert(i4 != classInfo->mAttrMap.end());
  osafassert(i4->second->mFlags & SA_IMM_ATTR_CONFIG);
  beforeImage->mAttrValueMap[oavi->first] = oavi->second;
  if (oavi->first == std::string(SA_IMM_ATTR_ADMIN_OWNER_NAME)) {
beforeImage->mAdminOwnerAttrVal = oavi->second;
  }
}
~~~










---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets