[tickets] [opensaf:tickets] #2255 amf: change saAmfCompCmdEnv attribute to writable

2017-01-10 Thread Long HB Nguyen
- **assigned_to**: Long HB Nguyen --> Nguyen TK Luu



---

** [tickets:#2255] amf: change saAmfCompCmdEnv attribute to writable**

**Status:** assigned
**Milestone:** 5.2.FC
**Created:** Mon Jan 09, 2017 10:29 AM UTC by Long HB Nguyen
**Last Updated:** Tue Jan 10, 2017 02:06 AM UTC
**Owner:** Nguyen TK Luu


Description:
Current OpenSAF implementation defines the attribute saAmfCompCmdEnv in the 
SaAmfComp object as non-writable according to last AMF specification. This 
restriction doesn’t allow to upgrade environment attributes defined at 
component instance and, to remove it, the attribute was made writable in an 
errata to the model. OpenSAF should comply to this definition in the errata 
(www.saforum.org/HOA/assn16627/images/SAI-IM-XMI-A.04.02.errata.xml.zip) of the 
AMF specification to enable the upgrade of environment attributes defined at 
component instance level.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2255 amf: change saAmfCompCmdEnv attribute to writable

2017-01-09 Thread Long HB Nguyen
- **status**: unassigned --> assigned
- **assigned_to**: Long HB Nguyen



---

** [tickets:#2255] amf: change saAmfCompCmdEnv attribute to writable**

**Status:** assigned
**Milestone:** 5.2.FC
**Created:** Mon Jan 09, 2017 10:29 AM UTC by Long HB Nguyen
**Last Updated:** Mon Jan 09, 2017 10:29 AM UTC
**Owner:** Long HB Nguyen


Description:
Current OpenSAF implementation defines the attribute saAmfCompCmdEnv in the 
SaAmfComp object as non-writable according to last AMF specification. This 
restriction doesn’t allow to upgrade environment attributes defined at 
component instance and, to remove it, the attribute was made writable in an 
errata to the model. OpenSAF should comply to this definition in the errata 
(www.saforum.org/HOA/assn16627/images/SAI-IM-XMI-A.04.02.errata.xml.zip) of the 
AMF specification to enable the upgrade of environment attributes defined at 
component instance level.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2255 amf: change saAmfCompCmdEnv attribute to writable

2017-01-09 Thread Long HB Nguyen



---

** [tickets:#2255] amf: change saAmfCompCmdEnv attribute to writable**

**Status:** unassigned
**Milestone:** 5.2.FC
**Created:** Mon Jan 09, 2017 10:29 AM UTC by Long HB Nguyen
**Last Updated:** Mon Jan 09, 2017 10:29 AM UTC
**Owner:** nobody


Description:
Current OpenSAF implementation defines the attribute saAmfCompCmdEnv in the 
SaAmfComp object as non-writable according to last AMF specification. This 
restriction doesn’t allow to upgrade environment attributes defined at 
component instance and, to remove it, the attribute was made writable in an 
errata to the model. OpenSAF should comply to this definition in the errata 
(www.saforum.org/HOA/assn16627/images/SAI-IM-XMI-A.04.02.errata.xml.zip) of the 
AMF specification to enable the upgrade of environment attributes defined at 
component instance level.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2190 amfd: si-swap timeout during multiple switchover test

2016-11-15 Thread Long HB Nguyen
- **status**: unassigned --> assigned



---

** [tickets:#2190] amfd: si-swap timeout during multiple switchover test**

**Status:** assigned
**Milestone:** 5.0.2
**Created:** Wed Nov 16, 2016 07:35 AM UTC by Long HB Nguyen
**Last Updated:** Wed Nov 16, 2016 07:35 AM UTC
**Owner:** nobody
**Attachments:**

- 
[trace.zip](https://sourceforge.net/p/opensaf/tickets/2190/attachment/trace.zip)
 (1.6 MB; application/x-zip-compressed)


- Description:
Perform multiple si-swap: amf-adm si-swap safSi=SC-2N,safApp=OpenSAF
Sometimes amf-adm failed:error - saImmOmAdminOperationInvoke_2 FAILED: 
SA_AIS_ERR_TIMEOUT (5)




---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2190 amfd: si-swap timeout during multiple switchover test

2016-11-15 Thread Long HB Nguyen



---

** [tickets:#2190] amfd: si-swap timeout during multiple switchover test**

**Status:** unassigned
**Milestone:** 5.0.2
**Created:** Wed Nov 16, 2016 07:35 AM UTC by Long HB Nguyen
**Last Updated:** Wed Nov 16, 2016 07:35 AM UTC
**Owner:** nobody
**Attachments:**

- 
[trace.zip](https://sourceforge.net/p/opensaf/tickets/2190/attachment/trace.zip)
 (1.6 MB; application/x-zip-compressed)


- Description:
Perform multiple si-swap: amf-adm si-swap safSi=SC-2N,safApp=OpenSAF
Sometimes amf-adm failed:error - saImmOmAdminOperationInvoke_2 FAILED: 
SA_AIS_ERR_TIMEOUT (5)




---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2169 amf: su containing proxy comps is not working properly after a su restart recovery

2016-11-13 Thread Long HB Nguyen
Hi Nagu,

In case you want to fix for that case. You can open a ticket yourself.

Best regards,
Long Nguyen.


---

** [tickets:#2169] amf: su containing proxy comps is not working properly after 
a su restart recovery**

**Status:** fixed
**Milestone:** 5.0.2
**Created:** Fri Nov 04, 2016 09:45 AM UTC by Long HB Nguyen
**Last Updated:** Mon Nov 14, 2016 07:38 AM UTC
**Owner:** Nagendra Kumar
**Attachments:**

- 
[osaftestLog-2016-11-04_14-55-08.tgz](https://sourceforge.net/p/opensaf/tickets/2169/attachment/osaftestLog-2016-11-04_14-55-08.tgz)
 (1.2 MB; application/x-gzip-compressed)


- Description:
When a proxy component restart is escalated to a su restart, then the SU is not 
working properly after that (e.g. lock failed).

- Reproduction:
1) Use the proxy demo in amf samples.
2) Unlock-in/unlock proxy SU, proxied SU.
3) Kill the proxy process some times to take the recovery escalation from comp 
restart to su restart.
4) Lock the proxy SU => timeout.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2169 amf: su containing proxy comps is not working properly after a su restart recovery

2016-11-13 Thread Long HB Nguyen
Hi Nagu,

Originally, I only tested the case that a proxy component and a proxied 
component are not in the same SU (i.e. samples/amf/proxy). However, when 
looking into the code, I think that it may have the same problem with the case 
that a proxy and a proxied component are in the same SU. That is the reason I 
asked. However, I have not tested that case with your code. 

Thanks,
Long Nguyen.


---

** [tickets:#2169] amf: su containing proxy comps is not working properly after 
a su restart recovery**

**Status:** fixed
**Milestone:** 5.0.2
**Created:** Fri Nov 04, 2016 09:45 AM UTC by Long HB Nguyen
**Last Updated:** Mon Nov 14, 2016 07:08 AM UTC
**Owner:** Nagendra Kumar
**Attachments:**

- 
[osaftestLog-2016-11-04_14-55-08.tgz](https://sourceforge.net/p/opensaf/tickets/2169/attachment/osaftestLog-2016-11-04_14-55-08.tgz)
 (1.2 MB; application/x-gzip-compressed)


- Description:
When a proxy component restart is escalated to a su restart, then the SU is not 
working properly after that (e.g. lock failed).

- Reproduction:
1) Use the proxy demo in amf samples.
2) Unlock-in/unlock proxy SU, proxied SU.
3) Kill the proxy process some times to take the recovery escalation from comp 
restart to su restart.
4) Lock the proxy SU => timeout.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2169 amf: su containing proxy comps is not working properly after a su restart recovery

2016-11-08 Thread Long HB Nguyen
Hi Nagu,

I have tested the patch. It is working fine and the proxy component gets 
CLEANUP. 
In your patch, you have fixed for the case that Proxy and Proxied comp are not 
in the same SU. In the case, they are in the same SU, the behavior is different 
(i.e. still return immediately). Could you share the idea behind that?

Thanks,
Long Nguyen.


Attachments:

- 
[2169.zip](https://sourceforge.net/p/opensaf/tickets/_discuss/thread/47908ac2/980f/attachment/2169.zip)
 (1.8 kB; application/x-zip-compressed)


---

** [tickets:#2169] amf: su containing proxy comps is not working properly after 
a su restart recovery**

**Status:** review
**Milestone:** 5.0.2
**Created:** Fri Nov 04, 2016 09:45 AM UTC by Long HB Nguyen
**Last Updated:** Tue Nov 08, 2016 09:19 AM UTC
**Owner:** Nagendra Kumar
**Attachments:**

- 
[osaftestLog-2016-11-04_14-55-08.tgz](https://sourceforge.net/p/opensaf/tickets/2169/attachment/osaftestLog-2016-11-04_14-55-08.tgz)
 (1.2 MB; application/x-gzip-compressed)


- Description:
When a proxy component restart is escalated to a su restart, then the SU is not 
working properly after that (e.g. lock failed).

- Reproduction:
1) Use the proxy demo in amf samples.
2) Unlock-in/unlock proxy SU, proxied SU.
3) Kill the proxy process some times to take the recovery escalation from comp 
restart to su restart.
4) Lock the proxy SU => timeout.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2169 amf: su containing proxy comps is not working properly after a su restart recovery

2016-11-07 Thread Long HB Nguyen
Hi Nagu,

The changeset is 8272. I used the proxy demo and the config file (.xml) in 
samples/amf/proxy.


---

** [tickets:#2169] amf: su containing proxy comps is not working properly after 
a su restart recovery**

**Status:** assigned
**Milestone:** 5.0.2
**Created:** Fri Nov 04, 2016 09:45 AM UTC by Long HB Nguyen
**Last Updated:** Tue Nov 08, 2016 06:05 AM UTC
**Owner:** Nagendra Kumar
**Attachments:**

- 
[osaftestLog-2016-11-04_14-55-08.tgz](https://sourceforge.net/p/opensaf/tickets/2169/attachment/osaftestLog-2016-11-04_14-55-08.tgz)
 (1.2 MB; application/x-gzip-compressed)


- Description:
When a proxy component restart is escalated to a su restart, then the SU is not 
working properly after that (e.g. lock failed).

- Reproduction:
1) Use the proxy demo in amf samples.
2) Unlock-in/unlock proxy SU, proxied SU.
3) Kill the proxy process some times to take the recovery escalation from comp 
restart to su restart.
4) Lock the proxy SU => timeout.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2169 amf: su containing proxy comps is not working properly after a su restart recovery

2016-11-04 Thread Long HB Nguyen



---

** [tickets:#2169] amf: su containing proxy comps is not working properly after 
a su restart recovery**

**Status:** unassigned
**Milestone:** 5.0.2
**Created:** Fri Nov 04, 2016 09:45 AM UTC by Long HB Nguyen
**Last Updated:** Fri Nov 04, 2016 09:45 AM UTC
**Owner:** nobody
**Attachments:**

- 
[osaftestLog-2016-11-04_14-55-08.tgz](https://sourceforge.net/p/opensaf/tickets/2169/attachment/osaftestLog-2016-11-04_14-55-08.tgz)
 (1.2 MB; application/x-gzip-compressed)


- Description:
When a proxy component restart is escalated to a su restart, then the SU is not 
working properly after that (e.g. lock failed).

- Reproduction:
1) Use the proxy demo in amf samples.
2) Unlock-in/unlock proxy SU, proxied SU.
3) Kill the proxy process some times to take the recovery escalation from comp 
restart to su restart.
4) Lock the proxy SU => timeout.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2150 amfd: standby amfd crash while decoding node info during cold sync period

2016-11-01 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -2,7 +2,7 @@
   When standby cold sync occurs, there may have a chance that 
   node creation information is missed in standby node. Active node sending
   node information to standby node (checkpointing) will lead to a standby amfd 
crash.
-  One way to get over this situation is to re-read node info when the node 
info is null.
+  One way to get over this situation is to create node when the node is null.
   
 - Reproduction:
 1) Start a cluster (e.g. 5 nodes).



- **status**: accepted --> review



---

** [tickets:#2150] amfd: standby amfd crash while decoding node info during 
cold sync period**

**Status:** review
**Milestone:** 5.0.2
**Created:** Mon Oct 31, 2016 03:47 AM UTC by Long HB Nguyen
**Last Updated:** Mon Oct 31, 2016 04:17 AM UTC
**Owner:** Long HB Nguyen
**Attachments:**

- 
[logs.zip](https://sourceforge.net/p/opensaf/tickets/2150/attachment/logs.zip) 
(537.0 kB; application/x-zip-compressed)


- Description:
  When standby cold sync occurs, there may have a chance that 
  node creation information is missed in standby node. Active node sending
  node information to standby node (checkpointing) will lead to a standby amfd 
crash.
  One way to get over this situation is to create node when the node is null.
  
- Reproduction:
1) Start a cluster (e.g. 5 nodes).
2) On Standby controller, add a sleep (e.g. 5 seconds) to main.cc:
3) Reboot standby controller.
4) Use the script scale_opensaf in python/samples directory to add a node (e.g. 
PL-6) while standby is rebooting.
5) Observe a coredump on standby node.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1571 AMF: Use std::maps instead of Patricia trees

2016-11-01 Thread Long HB Nguyen
- **Milestone**: 5.2.FC --> never



---

** [tickets:#1571] AMF: Use std::maps instead of Patricia trees**

**Status:** invalid
**Milestone:** never
**Created:** Wed Oct 28, 2015 02:39 AM UTC by Long HB Nguyen
**Last Updated:** Tue Aug 30, 2016 03:28 AM UTC
**Owner:** Long HB Nguyen


Use std::maps instead of Patricia trees, see also [#1520].
This enhancement has been included in [#1642].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1558 amf: use nullptr instead of NULL macros

2016-11-01 Thread Long HB Nguyen
- **Milestone**: 5.2.FC --> never



---

** [tickets:#1558] amf: use nullptr instead of NULL macros**

**Status:** invalid
**Milestone:** never
**Created:** Fri Oct 23, 2015 04:28 AM UTC by Long HB Nguyen
**Last Updated:** Tue Aug 30, 2016 03:25 AM UTC
**Owner:** Long HB Nguyen


Using nullptr instead of NULL macros. This is a part of ticket [#1520].
This ticket was replaced by [#1547] and [#1551].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2150 amfd: standby amfd crash while decoding node info during cold sync period

2016-10-30 Thread Long HB Nguyen
- **status**: unassigned --> accepted
- **assigned_to**: Long HB Nguyen



---

** [tickets:#2150] amfd: standby amfd crash while decoding node info during 
cold sync period**

**Status:** accepted
**Milestone:** 5.0.2
**Created:** Mon Oct 31, 2016 03:47 AM UTC by Long HB Nguyen
**Last Updated:** Mon Oct 31, 2016 03:47 AM UTC
**Owner:** Long HB Nguyen
**Attachments:**

- 
[logs.zip](https://sourceforge.net/p/opensaf/tickets/2150/attachment/logs.zip) 
(537.0 kB; application/x-zip-compressed)


- Description:
  When standby cold sync occurs, there may have a chance that 
  node creation information is missed in standby node. Active node sending
  node information to standby node (checkpointing) will lead to a standby amfd 
crash.
  One way to get over this situation is to re-read node info when the node info 
is null.
  
- Reproduction:
1) Start a cluster (e.g. 5 nodes).
2) On Standby controller, add a sleep (e.g. 5 seconds) to main.cc:
3) Reboot standby controller.
4) Use the script scale_opensaf in python/samples directory to add a node (e.g. 
PL-6) while standby is rebooting.
5) Observe a coredump on standby node.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
The Command Line: Reinvented for Modern Developers
Did the resurgence of CLI tooling catch you by surprise?
Reconnect with the command line and become more productive. 
Learn the new .NET and ASP.NET CLI. Get your free copy!
http://sdm.link/telerik___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2150 amfd: standby amfd crash while decoding node info during cold sync period

2016-10-30 Thread Long HB Nguyen



---

** [tickets:#2150] amfd: standby amfd crash while decoding node info during 
cold sync period**

**Status:** unassigned
**Milestone:** 5.0.2
**Created:** Mon Oct 31, 2016 03:47 AM UTC by Long HB Nguyen
**Last Updated:** Mon Oct 31, 2016 03:47 AM UTC
**Owner:** nobody
**Attachments:**

- 
[logs.zip](https://sourceforge.net/p/opensaf/tickets/2150/attachment/logs.zip) 
(537.0 kB; application/x-zip-compressed)


- Description:
  When standby cold sync occurs, there may have a chance that 
  node creation information is missed in standby node. Active node sending
  node information to standby node (checkpointing) will lead to a standby amfd 
crash.
  One way to get over this situation is to re-read node info when the node info 
is null.
  
- Reproduction:
1) Start a cluster (e.g. 5 nodes).
2) On Standby controller, add a sleep (e.g. 5 seconds) to main.cc:
3) Reboot standby controller.
4) Use the script scale_opensaf in python/samples directory to add a node (e.g. 
PL-6) while standby is rebooting.
5) Observe a coredump on standby node.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
The Command Line: Reinvented for Modern Developers
Did the resurgence of CLI tooling catch you by surprise?
Reconnect with the command line and become more productive. 
Learn the new .NET and ASP.NET CLI. Get your free copy!
http://sdm.link/telerik___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1897 Incorrect ER messages in syslog

2016-10-18 Thread Long HB Nguyen
- **status**: review --> fixed
- **Comment**:

default: [staging:1f7da3]
changeset:   8242:1f7da38c884b
parent:  8239:b0d4fb1ac1a1
user:Long Nguyen 
date:Wed Oct 19 14:43:55 2016 +1100
summary: amfd: fix incorrect ER messages in sg_2n_fsm.cc [#1897]

opensaf-5.1.x: [staging:965818]
changeset:   8243:9658183440ce
branch:  opensaf-5.1.x
parent:  8240:08c741038adf
user:Long Nguyen 
date:Wed Oct 19 14:44:38 2016 +1100
summary: amfd: fix incorrect ER messages in sg_2n_fsm.cc [#1897]

opensaf-5.0.x: [staging:439400]
changeset:   8244:4394005ebe24
branch:  opensaf-5.0.x
tag: tip
parent:  8241:914ffbc1a71c
user:Long Nguyen 
date:Wed Oct 19 14:47:06 2016 +1100
summary: amfd: fix incorrect ER messages in sg_2n_fsm.cc [#1897]




---

** [tickets:#1897] Incorrect ER messages in syslog**

**Status:** fixed
**Milestone:** 5.0.2
**Created:** Tue Jun 28, 2016 07:51 AM UTC by elunlen
**Last Updated:** Mon Oct 10, 2016 04:32 AM UTC
**Owner:** nobody


Several incorrectly prioritized syslog messages found in SG_2N::si_swap in 
sg_2n_fsm.cc
LOG_ER is used when problem is easily recoverable e.g. return value is 
SA_AIS_ERR_TRY_AGAIN


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1897 Incorrect ER messages in syslog

2016-10-09 Thread Long HB Nguyen
- **status**: assigned --> review



---

** [tickets:#1897] Incorrect ER messages in syslog**

**Status:** review
**Milestone:** 5.0.2
**Created:** Tue Jun 28, 2016 07:51 AM UTC by elunlen
**Last Updated:** Fri Oct 07, 2016 03:21 AM UTC
**Owner:** nobody


Several incorrectly prioritized syslog messages found in SG_2N::si_swap in 
sg_2n_fsm.cc
LOG_ER is used when problem is easily recoverable e.g. return value is 
SA_AIS_ERR_TRY_AGAIN


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1897 Incorrect ER messages in syslog

2016-10-06 Thread Long HB Nguyen
- **status**: unassigned --> assigned
- **Comment**:

I think amfd should use LOG_NO in this case since it returns TRY_AGAIN. 
It is also to be consistent to si_swap() function in sg_nway_fsm.cc.



---

** [tickets:#1897] Incorrect ER messages in syslog**

**Status:** assigned
**Milestone:** 5.0.2
**Created:** Tue Jun 28, 2016 07:51 AM UTC by elunlen
**Last Updated:** Tue Sep 20, 2016 06:01 PM UTC
**Owner:** nobody


Several incorrectly prioritized syslog messages found in SG_2N::si_swap in 
sg_2n_fsm.cc
LOG_ER is used when problem is easily recoverable e.g. return value is 
SA_AIS_ERR_TRY_AGAIN


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1997 IMM: immnd fails to update si while bringing up opensaf with 2PBE

2016-09-21 Thread Long HB Nguyen
If there is no comment so far, I will set the ticket to "invalid" tomorrow.


---

** [tickets:#1997] IMM: immnd fails to update si while bringing up opensaf with 
2PBE**

**Status:** assigned
**Milestone:** 5.1.1
**Created:** Fri Sep 02, 2016 11:46 AM UTC by Chani Srivastava
**Last Updated:** Tue Sep 20, 2016 05:37 PM UTC
**Owner:** Long HB Nguyen
**Attachments:**

- 
[LogAMF.zip](https://sourceforge.net/p/opensaf/tickets/1997/attachment/LogAMF.zip)
 (432.4 kB; application/zip)


setup:
Version - OpenSAF 5.1.FC : changeset - 7997
4-Node cluster
2PBE enabled

Bring up opensaf on a controller with 2PBE enable. IMMND throwing error
Attachments: syslog, amfd and immnd traces

Sep  2 16:54:13 SLOT1 osafimmpbed: WA Start prepare for ccb: 
10004/4294967300 towards slave PBE returned: '12' from Immsv
Sep  2 16:54:13 SLOT1 osafimmpbed: WA PBE-A failed to prepare PRTA update 
Ccb:10004/4294967300 towards PBE-B
Sep  2 16:54:13 SLOT1 osafimmpbed: NO 2PBE Error (18) in PRTA update 
(ccbId:10004)
**Sep  2 16:54:13 SLOT1 osafimmnd[3632]: WA update of PERSISTENT runtime 
attributes in object 'safSi=NoRed3,safApp=OpenSAF' REVERTED. PBE rc:18
Sep  2 16:54:13 SLOT1 osafamfd[3698]: ER exec: update FAILED 18**
Sep  2 16:54:14 SLOT1 osafimmnd[3632]: NO PBE-OI established on this SC. 
Dumping incrementally to file imm.db

Note- 1. OpenSAF is successfully started
 2. Issue not seen with 1PBE

Once controller is up, amf-state si gives

safSi=SC-2N,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=PARTIALLY_ASSIGNED(3)
safSi=NoRed4,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)
safSi=NoRed1,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=FULLY_ASSIGNED(2)
safSi=NoRed2,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)
safSi=NoRed3,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)




---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1997 IMM: immnd fails to update si while bringing up opensaf with 2PBE

2016-09-20 Thread Long HB Nguyen
Hi, 

As AMF perspective, if IMM returns TRY_AGAIN, AMF tries to update attributes 
again as indicated by the amfd trace:
Sep  2 16:54:09.294319 osafamfd [3698:imm.cc:0396] >> execute 
Sep  2 16:54:09.294319 osafamfd [3698:imm.cc:0212] >> exec: Update 
'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus
Sep  2 16:54:09.294319 osafamfd [3698:imma_oi_api.c:2446] >> 
rt_object_update_common 
Sep  2 16:54:09.294569 osafamfd [3698:imma_oi_api.c:2719] << 
rt_object_update_common 
Sep  2 16:54:09.294583 osafamfd [3698:imm.cc:0226] TR TRY-AGAIN
Sep  2 16:54:09.294589 osafamfd [3698:imm.cc:0241] << exec 
Sep  2 16:54:09.294595 osafamfd [3698:imm.cc:0400] << execute: 2
However, after AMF tried AGAIN several times in this case, IMM returned 18 
(SA_AIS_ERR_NO_RESOURCES). AMF prints it as an error as expected.

As I understand, you only started opensaf on SC-1. This is not the recommended 
configuration for 2PBE enabled as noted by IMM "With 2PBE, *both* PBEs must be 
available for the imm to be persistent-writable. If one or both PBEs are 
unavailable (or unresponsive) then persistent writes
(CCBs, PRT operations, class changes) will fail.".


---

** [tickets:#1997] IMM: immnd fails to update si while bringing up opensaf with 
2PBE**

**Status:** assigned
**Milestone:** 5.1.RC2
**Created:** Fri Sep 02, 2016 11:46 AM UTC by Chani Srivastava
**Last Updated:** Mon Sep 19, 2016 07:46 AM UTC
**Owner:** Long HB Nguyen
**Attachments:**

- 
[LogAMF.zip](https://sourceforge.net/p/opensaf/tickets/1997/attachment/LogAMF.zip)
 (432.4 kB; application/zip)


setup:
Version - OpenSAF 5.1.FC : changeset - 7997
4-Node cluster
2PBE enabled

Bring up opensaf on a controller with 2PBE enable. IMMND throwing error
Attachments: syslog, amfd and immnd traces

Sep  2 16:54:13 SLOT1 osafimmpbed: WA Start prepare for ccb: 
10004/4294967300 towards slave PBE returned: '12' from Immsv
Sep  2 16:54:13 SLOT1 osafimmpbed: WA PBE-A failed to prepare PRTA update 
Ccb:10004/4294967300 towards PBE-B
Sep  2 16:54:13 SLOT1 osafimmpbed: NO 2PBE Error (18) in PRTA update 
(ccbId:10004)
**Sep  2 16:54:13 SLOT1 osafimmnd[3632]: WA update of PERSISTENT runtime 
attributes in object 'safSi=NoRed3,safApp=OpenSAF' REVERTED. PBE rc:18
Sep  2 16:54:13 SLOT1 osafamfd[3698]: ER exec: update FAILED 18**
Sep  2 16:54:14 SLOT1 osafimmnd[3632]: NO PBE-OI established on this SC. 
Dumping incrementally to file imm.db

Note- 1. OpenSAF is successfully started
 2. Issue not seen with 1PBE

Once controller is up, amf-state si gives

safSi=SC-2N,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=PARTIALLY_ASSIGNED(3)
safSi=NoRed4,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)
safSi=NoRed1,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=FULLY_ASSIGNED(2)
safSi=NoRed2,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)
safSi=NoRed3,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)




---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1997 IMM: immnd fails to update si while bringing up opensaf with 2PBE

2016-09-19 Thread Long HB Nguyen
- **status**: unassigned --> assigned
- **assigned_to**: Long HB Nguyen



---

** [tickets:#1997] IMM: immnd fails to update si while bringing up opensaf with 
2PBE**

**Status:** assigned
**Milestone:** 5.1.RC2
**Created:** Fri Sep 02, 2016 11:46 AM UTC by Chani Srivastava
**Last Updated:** Wed Sep 14, 2016 02:09 AM UTC
**Owner:** Long HB Nguyen
**Attachments:**

- 
[LogAMF.zip](https://sourceforge.net/p/opensaf/tickets/1997/attachment/LogAMF.zip)
 (432.4 kB; application/zip)


setup:
Version - OpenSAF 5.1.FC : changeset - 7997
4-Node cluster
2PBE enabled

Bring up opensaf on a controller with 2PBE enable. IMMND throwing error
Attachments: syslog, amfd and immnd traces

Sep  2 16:54:13 SLOT1 osafimmpbed: WA Start prepare for ccb: 
10004/4294967300 towards slave PBE returned: '12' from Immsv
Sep  2 16:54:13 SLOT1 osafimmpbed: WA PBE-A failed to prepare PRTA update 
Ccb:10004/4294967300 towards PBE-B
Sep  2 16:54:13 SLOT1 osafimmpbed: NO 2PBE Error (18) in PRTA update 
(ccbId:10004)
**Sep  2 16:54:13 SLOT1 osafimmnd[3632]: WA update of PERSISTENT runtime 
attributes in object 'safSi=NoRed3,safApp=OpenSAF' REVERTED. PBE rc:18
Sep  2 16:54:13 SLOT1 osafamfd[3698]: ER exec: update FAILED 18**
Sep  2 16:54:14 SLOT1 osafimmnd[3632]: NO PBE-OI established on this SC. 
Dumping incrementally to file imm.db

Note- 1. OpenSAF is successfully started
 2. Issue not seen with 1PBE

Once controller is up, amf-state si gives

safSi=SC-2N,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=PARTIALLY_ASSIGNED(3)
safSi=NoRed4,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)
safSi=NoRed1,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=FULLY_ASSIGNED(2)
safSi=NoRed2,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)
safSi=NoRed3,safApp=OpenSAF
saAmfSIAdminState=UNLOCKED(1)
saAmfSIAssignmentState=UNASSIGNED(1)




---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1991 AMF: Existing PG tracking should not be stopped for CURRENT flag

2016-09-15 Thread Long HB Nguyen
- **status**: accepted --> review



---

** [tickets:#1991] AMF: Existing PG tracking should not be stopped  for CURRENT 
flag**

**Status:** review
**Milestone:** 5.1.RC2
**Created:** Wed Aug 31, 2016 09:44 AM UTC by Srikanth R
**Last Updated:** Wed Sep 14, 2016 04:32 AM UTC
**Owner:** Long HB Nguyen


5.1.FC : changeset - 6997

Issue : Existing PG tracking should not be stopped  for CURRENT call


Steps performed :

-> Call saAmfInitialize_4()
-> Call saAmfProtectionGroupTrack_4() with SA_TRACK_CURRENT flag.
-> Call saAmfProtectionGroupTrack_4() with SA_TRACK_CHANGES flag.
-> Call saAmfProtectionGroupTrack_4() with SA_TRACK_CURRENT flag.
-> Call saAmfProtectionGroupTrackStop()


Observed output :

TrackStop returns ERR_NOT_EXIST, indicating that tracking is not started 
earlier. 


Expected output:

   TrackStop() api should  return SA_AIS_OK and in the earlier release, api is 
returning SA_AIS_OK.
 
 According to the B04.01 spec 7.11.1 page 318 ,  Tracking should not be stopped 
untill TrackStop() is called explicitly.

Once saAmfProtectionGroupTrack_4() has been called with trackFlags
containing either SA_TRACK_CHANGES or SA_TRACK_CHANGES_ONLY, notification
callbacks can only be stopped by an invocation of
saAmfProtectionGroupTrackStop().



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1991 AMF: Existing PG tracking should not be stopped for CURRENT flag

2016-09-13 Thread Long HB Nguyen
- **status**: unassigned --> accepted
- **assigned_to**: Long HB Nguyen



---

** [tickets:#1991] AMF: Existing PG tracking should not be stopped  for CURRENT 
flag**

**Status:** accepted
**Milestone:** 5.1.RC2
**Created:** Wed Aug 31, 2016 09:44 AM UTC by Srikanth R
**Last Updated:** Tue Sep 13, 2016 10:09 AM UTC
**Owner:** Long HB Nguyen


5.1.FC : changeset - 6997

Issue : Existing PG tracking should not be stopped  for CURRENT call


Steps performed :

-> Call saAmfInitialize_4()
-> Call saAmfProtectionGroupTrack_4() with SA_TRACK_CURRENT flag.
-> Call saAmfProtectionGroupTrack_4() with SA_TRACK_CHANGES flag.
-> Call saAmfProtectionGroupTrack_4() with SA_TRACK_CURRENT flag.
-> Call saAmfProtectionGroupTrackStop()


Observed output :

TrackStop returns ERR_NOT_EXIST, indicating that tracking is not started 
earlier. 


Expected output:

   TrackStop() api should  return SA_AIS_OK and in the earlier release, api is 
returning SA_AIS_OK.
 
 According to the B04.01 spec 7.11.1 page 318 ,  Tracking should not be stopped 
untill TrackStop() is called explicitly.

Once saAmfProtectionGroupTrack_4() has been called with trackFlags
containing either SA_TRACK_CHANGES or SA_TRACK_CHANGES_ONLY, notification
callbacks can only be stopped by an invocation of
saAmfProtectionGroupTrackStop().



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2019 amf: Unit tests fail to build

2016-09-12 Thread Long HB Nguyen
- **status**: accepted --> review



---

** [tickets:#2019] amf: Unit tests fail to build**

**Status:** review
**Milestone:** 5.1.RC1
**Created:** Fri Sep 09, 2016 01:08 PM UTC by Anders Widell
**Last Updated:** Mon Sep 12, 2016 03:22 AM UTC
**Owner:** Long HB Nguyen


"make check" fails (32-bit system, GCC version 6.1.1, googletest version 
48ee8e98abc950abd8541e15550b18f8f6cfb3a9):

~~~
make[8]: Entering directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfd/tests'
  CXX  testamfd-test_ckpt_enc_dec.o
In file included from test_ckpt_enc_dec.cc:22:0:
/home/opensaf/googletest/googletest/include/gtest/gtest.h: In instantiation of 
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const 
char*, const T1&, const T2&) [with T1 = unsigned int; T2 = int]':
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1421:23:   required 
from 'static testing::AssertionResult 
testing::internal::EqHelper::Compare(const char*, const 
char*, const T1&, const T2&) [with T1 = unsigned int; T2 = int; bool 
lhs_is_null_literal = false]'
test_ckpt_enc_dec.cc:354:3:   required from here
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1392:11: error: 
comparison between signed and unsigned integer expressions 
[-Werror=sign-compare]
   if (lhs == rhs) {
   ^~
/home/opensaf/googletest/googletest/include/gtest/gtest.h: In instantiation of 
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const 
char*, const T1&, const T2&) [with T1 = long long unsigned int; T2 = long long 
int]':
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1421:23:   required 
from 'static testing::AssertionResult 
testing::internal::EqHelper::Compare(const char*, const 
char*, const T1&, const T2&) [with T1 = long long unsigned int; T2 = long long 
int; bool lhs_is_null_literal = false]'
test_ckpt_enc_dec.cc:362:3:   required from here
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1392:11: error: 
comparison between signed and unsigned integer expressions 
[-Werror=sign-compare]
cc1plus: all warnings being treated as errors
Makefile:814: recipe for target 'testamfd-test_ckpt_enc_dec.o' failed
make[8]: *** [testamfd-test_ckpt_enc_dec.o] Error 1
make[8]: Leaving directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfd/tests'
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2018 amf: Build failure on 32-bit system

2016-09-12 Thread Long HB Nguyen
- **status**: accepted --> review



---

** [tickets:#2018] amf: Build failure on 32-bit system**

**Status:** review
**Milestone:** 5.1.RC1
**Created:** Fri Sep 09, 2016 01:05 PM UTC by Anders Widell
**Last Updated:** Mon Sep 12, 2016 05:23 AM UTC
**Owner:** Long HB Nguyen


Build fails on 32-bit systems (GCC version 6.1.1):

~~~
make[7]: Entering directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfnd'
  CXX  osafamfnd-comp.o
In file included from ../../../../../osaf/libs/core/include/ncs_osprm.h:32:0,
 from ../../../../../osaf/libs/core/leap/include/ncsdlib.h:33,
 from ../../../../../osaf/libs/common/amf/include/amf.h:37,
 from 
../../../../../osaf/services/saf/amf/amfnd/include/avnd.h:38,
 from comp.cc:35:
comp.cc: In function 'uint32_t avnd_amfa_mds_info_evh(AVND_CB*, AVND_EVT*)':
../../../../../osaf/libs/core/common/include/logtrace.h:145:127: error: format 
'%lu' expects argument of type 'long unsigned int', but argument 6 has type 
'MDS_DEST {aka long long unsigned int}' [-Werror=format=]
 #define TRACE_ENTER2(format, args...) _logtrace_trace(__FILE__, __LINE__, 
CAT_TRACE_ENTER, "%s: " format, __FUNCTION__, ##args)

   ^
comp.cc:3016:3: note: in expansion of macro 'TRACE_ENTER2'
   TRACE_ENTER2("mds_dest :%lu, MDS version:%d",
   ^~~~
cc1plus: all warnings being treated as errors
Makefile:765: recipe for target 'osafamfnd-comp.o' failed
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2018 amf: Build failure on 32-bit system

2016-09-11 Thread Long HB Nguyen
Hi Praveen,

Yes, amf uses your that fix in some other places.

Thanks,
Long Nguyen.


---

** [tickets:#2018] amf: Build failure on 32-bit system**

**Status:** accepted
**Milestone:** 5.1.RC1
**Created:** Fri Sep 09, 2016 01:05 PM UTC by Anders Widell
**Last Updated:** Mon Sep 12, 2016 05:18 AM UTC
**Owner:** Long HB Nguyen


Build fails on 32-bit systems (GCC version 6.1.1):

~~~
make[7]: Entering directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfnd'
  CXX  osafamfnd-comp.o
In file included from ../../../../../osaf/libs/core/include/ncs_osprm.h:32:0,
 from ../../../../../osaf/libs/core/leap/include/ncsdlib.h:33,
 from ../../../../../osaf/libs/common/amf/include/amf.h:37,
 from 
../../../../../osaf/services/saf/amf/amfnd/include/avnd.h:38,
 from comp.cc:35:
comp.cc: In function 'uint32_t avnd_amfa_mds_info_evh(AVND_CB*, AVND_EVT*)':
../../../../../osaf/libs/core/common/include/logtrace.h:145:127: error: format 
'%lu' expects argument of type 'long unsigned int', but argument 6 has type 
'MDS_DEST {aka long long unsigned int}' [-Werror=format=]
 #define TRACE_ENTER2(format, args...) _logtrace_trace(__FILE__, __LINE__, 
CAT_TRACE_ENTER, "%s: " format, __FUNCTION__, ##args)

   ^
comp.cc:3016:3: note: in expansion of macro 'TRACE_ENTER2'
   TRACE_ENTER2("mds_dest :%lu, MDS version:%d",
   ^~~~
cc1plus: all warnings being treated as errors
Makefile:765: recipe for target 'osafamfnd-comp.o' failed
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2019 amf: Unit tests fail to build

2016-09-11 Thread Long HB Nguyen
- **status**: unassigned --> accepted
- **assigned_to**: Long HB Nguyen



---

** [tickets:#2019] amf: Unit tests fail to build**

**Status:** accepted
**Milestone:** 5.1.RC1
**Created:** Fri Sep 09, 2016 01:08 PM UTC by Anders Widell
**Last Updated:** Fri Sep 09, 2016 01:08 PM UTC
**Owner:** Long HB Nguyen


"make check" fails (32-bit system, GCC version 6.1.1, googletest version 
48ee8e98abc950abd8541e15550b18f8f6cfb3a9):

~~~
make[8]: Entering directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfd/tests'
  CXX  testamfd-test_ckpt_enc_dec.o
In file included from test_ckpt_enc_dec.cc:22:0:
/home/opensaf/googletest/googletest/include/gtest/gtest.h: In instantiation of 
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const 
char*, const T1&, const T2&) [with T1 = unsigned int; T2 = int]':
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1421:23:   required 
from 'static testing::AssertionResult 
testing::internal::EqHelper::Compare(const char*, const 
char*, const T1&, const T2&) [with T1 = unsigned int; T2 = int; bool 
lhs_is_null_literal = false]'
test_ckpt_enc_dec.cc:354:3:   required from here
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1392:11: error: 
comparison between signed and unsigned integer expressions 
[-Werror=sign-compare]
   if (lhs == rhs) {
   ^~
/home/opensaf/googletest/googletest/include/gtest/gtest.h: In instantiation of 
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const 
char*, const T1&, const T2&) [with T1 = long long unsigned int; T2 = long long 
int]':
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1421:23:   required 
from 'static testing::AssertionResult 
testing::internal::EqHelper::Compare(const char*, const 
char*, const T1&, const T2&) [with T1 = long long unsigned int; T2 = long long 
int; bool lhs_is_null_literal = false]'
test_ckpt_enc_dec.cc:362:3:   required from here
/home/opensaf/googletest/googletest/include/gtest/gtest.h:1392:11: error: 
comparison between signed and unsigned integer expressions 
[-Werror=sign-compare]
cc1plus: all warnings being treated as errors
Makefile:814: recipe for target 'testamfd-test_ckpt_enc_dec.o' failed
make[8]: *** [testamfd-test_ckpt_enc_dec.o] Error 1
make[8]: Leaving directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfd/tests'
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2018 amf: Build failure on 32-bit system

2016-09-11 Thread Long HB Nguyen
- **status**: unassigned --> accepted
- **assigned_to**: Long HB Nguyen



---

** [tickets:#2018] amf: Build failure on 32-bit system**

**Status:** accepted
**Milestone:** 5.1.RC1
**Created:** Fri Sep 09, 2016 01:05 PM UTC by Anders Widell
**Last Updated:** Fri Sep 09, 2016 01:05 PM UTC
**Owner:** Long HB Nguyen


Build fails on 32-bit systems (GCC version 6.1.1):

~~~
make[7]: Entering directory 
'/home/opensaf/opensaf-staging/osaf/services/saf/amf/amfnd'
  CXX  osafamfnd-comp.o
In file included from ../../../../../osaf/libs/core/include/ncs_osprm.h:32:0,
 from ../../../../../osaf/libs/core/leap/include/ncsdlib.h:33,
 from ../../../../../osaf/libs/common/amf/include/amf.h:37,
 from 
../../../../../osaf/services/saf/amf/amfnd/include/avnd.h:38,
 from comp.cc:35:
comp.cc: In function 'uint32_t avnd_amfa_mds_info_evh(AVND_CB*, AVND_EVT*)':
../../../../../osaf/libs/core/common/include/logtrace.h:145:127: error: format 
'%lu' expects argument of type 'long unsigned int', but argument 6 has type 
'MDS_DEST {aka long long unsigned int}' [-Werror=format=]
 #define TRACE_ENTER2(format, args...) _logtrace_trace(__FILE__, __LINE__, 
CAT_TRACE_ENTER, "%s: " format, __FUNCTION__, ##args)

   ^
comp.cc:3016:3: note: in expansion of macro 'TRACE_ENTER2'
   TRACE_ENTER2("mds_dest :%lu, MDS version:%d",
   ^~~~
cc1plus: all warnings being treated as errors
Makefile:765: recipe for target 'osafamfnd-comp.o' failed
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1998 amf: protection group track non existing csi returns SA_AIS_ERR_INIT

2016-09-06 Thread Long HB Nguyen
- **status**: review --> fixed
- **Comment**:

default: [staging:36f63c]
changeset:   8005:36f63cf5aa4d
parent:  8003:4dfd86ce806e
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Tue Sep 06 17:10:19 2016 +1000
summary: amfa: fix pg track returns SA_AIS_ERR_INIT [#1998]

opensaf-5.1.x: [staging:f8bc9f]
changeset:   8006:f8bc9f897235
branch:  opensaf-5.1.x
tag: tip
parent:  8004:a7ed45608a5b
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Tue Sep 06 17:12:58 2016 +1000
summary: amfa: fix pg track returns SA_AIS_ERR_INIT [#1998]




---

** [tickets:#1998] amf: protection group track non existing csi returns 
SA_AIS_ERR_INIT**

**Status:** fixed
**Milestone:** 5.1.RC1
**Created:** Mon Sep 05, 2016 07:22 AM UTC by Long HB Nguyen
**Last Updated:** Tue Sep 06, 2016 03:02 AM UTC
**Owner:** Long HB Nguyen


Steps to reproduce
--
- Use 2N model.
- Modify amf_demo.c as follow:
+ Initialze amf_demo with saAmfInitialize_4 or saAmfInitialize_o4.
+ Add a callback for protection group.
+ Call saAmfProtectionGroupTrack with a non-existing csi (e.g. "dummy" 
csi), the flag is SA_TRACK_CURRENT and notificationBuffer is NULL.

Observed behaviour
--
Before the patches for #1553 were pushed, the testcase had returned 
SA_AIS_ERR_NOT_EXIST return code.
After the patches for #1553 were pushed, the testcase has returned 
SA_AIS_ERR_INIT return code.


Initial investigation:
--
In the patches for #1553, Praveen added an internal callback structure 
(OsafAmfCallbacksT):
The structure divides protection track callback in two cases:
- SaAmfProtectionGroupTrackCallbackT for versions older than B.04.01.
- SaAmfProtectionGroupTrackCallbackT_4 for versions from B.04.01.

In the case that amf_demo is initialized with callbacks for B.04.01 (i.e. 
saAmfProtectionGroupTrackCallback_4 is set). When amf_demo call 
saAmfProtectionGroupTrack, amfa checks saAmfProtectionGroupTrackCallback (it is 
NULL now).
Then, amfa returns SA_AIS_ERR_INIT.

​


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1998 amf: protection group track non existing csi returns SA_AIS_ERR_INIT

2016-09-05 Thread Long HB Nguyen
- **status**: assigned --> review



---

** [tickets:#1998] amf: protection group track non existing csi returns 
SA_AIS_ERR_INIT**

**Status:** review
**Milestone:** 5.1.RC1
**Created:** Mon Sep 05, 2016 07:22 AM UTC by Long HB Nguyen
**Last Updated:** Mon Sep 05, 2016 10:02 AM UTC
**Owner:** Long HB Nguyen


Steps to reproduce
--
- Use 2N model.
- Modify amf_demo.c as follow:
+ Initialze amf_demo with saAmfInitialize_4 or saAmfInitialize_o4.
+ Add a callback for protection group.
+ Call saAmfProtectionGroupTrack with a non-existing csi (e.g. "dummy" 
csi), the flag is SA_TRACK_CURRENT and notificationBuffer is NULL.

Observed behaviour
--
Before the patches for #1553 were pushed, the testcase had returned 
SA_AIS_ERR_NOT_EXIST return code.
After the patches for #1553 were pushed, the testcase has returned 
SA_AIS_ERR_INIT return code.


Initial investigation:
--
In the patches for #1553, Praveen added an internal callback structure 
(OsafAmfCallbacksT):
The structure divides protection track callback in two cases:
- SaAmfProtectionGroupTrackCallbackT for versions older than B.04.01.
- SaAmfProtectionGroupTrackCallbackT_4 for versions from B.04.01.

In the case that amf_demo is initialized with callbacks for B.04.01 (i.e. 
saAmfProtectionGroupTrackCallback_4 is set). When amf_demo call 
saAmfProtectionGroupTrack, amfa checks saAmfProtectionGroupTrackCallback (it is 
NULL now).
Then, amfa returns SA_AIS_ERR_INIT.

​


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1998 amf: protection group track non existing csi returns SA_AIS_ERR_INIT

2016-09-05 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -1,4 +1,3 @@
-
 Steps to reproduce
 --
 - Use 2N model.



- **status**: unassigned --> assigned
- **assigned_to**: Long HB Nguyen



---

** [tickets:#1998] amf: protection group track non existing csi returns 
SA_AIS_ERR_INIT**

**Status:** assigned
**Milestone:** 5.1.RC1
**Created:** Mon Sep 05, 2016 07:22 AM UTC by Long HB Nguyen
**Last Updated:** Mon Sep 05, 2016 07:22 AM UTC
**Owner:** Long HB Nguyen


Steps to reproduce
--
- Use 2N model.
- Modify amf_demo.c as follow:
+ Initialze amf_demo with saAmfInitialize_4 or saAmfInitialize_o4.
+ Add a callback for protection group.
+ Call saAmfProtectionGroupTrack with a non-existing csi (e.g. "dummy" 
csi), the flag is SA_TRACK_CURRENT and notificationBuffer is NULL.

Observed behaviour
--
Before the patches for #1553 were pushed, the testcase had returned 
SA_AIS_ERR_NOT_EXIST return code.
After the patches for #1553 were pushed, the testcase has returned 
SA_AIS_ERR_INIT return code.


Initial investigation:
--
In the patches for #1553, Praveen added an internal callback structure 
(OsafAmfCallbacksT):
The structure divides protection track callback in two cases:
- SaAmfProtectionGroupTrackCallbackT for versions older than B.04.01.
- SaAmfProtectionGroupTrackCallbackT_4 for versions from B.04.01.

In the case that amf_demo is initialized with callbacks for B.04.01 (i.e. 
saAmfProtectionGroupTrackCallback_4 is set). When amf_demo call 
saAmfProtectionGroupTrack, amfa checks saAmfProtectionGroupTrackCallback (it is 
NULL now).
Then, amfa returns SA_AIS_ERR_INIT.

​


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1998 amf: protection group track non existing csi returns SA_AIS_ERR_INIT

2016-09-05 Thread Long HB Nguyen



---

** [tickets:#1998] amf: protection group track non existing csi returns 
SA_AIS_ERR_INIT**

**Status:** unassigned
**Milestone:** 5.1.RC1
**Created:** Mon Sep 05, 2016 07:22 AM UTC by Long HB Nguyen
**Last Updated:** Mon Sep 05, 2016 07:22 AM UTC
**Owner:** nobody



Steps to reproduce
--
- Use 2N model.
- Modify amf_demo.c as follow:
+ Initialze amf_demo with saAmfInitialize_4 or saAmfInitialize_o4.
+ Add a callback for protection group.
+ Call saAmfProtectionGroupTrack with a non-existing csi (e.g. "dummy" 
csi), the flag is SA_TRACK_CURRENT and notificationBuffer is NULL.

Observed behaviour
--
Before the patches for #1553 were pushed, the testcase had returned 
SA_AIS_ERR_NOT_EXIST return code.
After the patches for #1553 were pushed, the testcase has returned 
SA_AIS_ERR_INIT return code.


Initial investigation:
--
In the patches for #1553, Praveen added an internal callback structure 
(OsafAmfCallbacksT):
The structure divides protection track callback in two cases:
- SaAmfProtectionGroupTrackCallbackT for versions older than B.04.01.
- SaAmfProtectionGroupTrackCallbackT_4 for versions from B.04.01.

In the case that amf_demo is initialized with callbacks for B.04.01 (i.e. 
saAmfProtectionGroupTrackCallback_4 is set). When amf_demo call 
saAmfProtectionGroupTrack, amfa checks saAmfProtectionGroupTrackCallback (it is 
NULL now).
Then, amfa returns SA_AIS_ERR_INIT.

​


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1989 amfnd: Incorrect ER messages in syslog

2016-08-31 Thread Long HB Nguyen
- **status**: review --> fixed
- **Comment**:

default: [staging:4dfd86]
changeset:   8003:4dfd86ce806e
parent:  7999:3ea874f4d0d1
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Wed Aug 31 20:19:13 2016 +1000
summary: amfnd: Incorrect ER messages in syslog [#1989]

opensaf-5.1.x: [staging:a7ed45]
changeset:   8004:a7ed45608a5b
branch:  opensaf-5.1.x
tag: tip
parent:  8000:68dcfb53bee8
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Wed Aug 31 20:21:57 2016 +1000
summary: amfnd: Incorrect ER messages in syslog [#1989]




---

** [tickets:#1989] amfnd: Incorrect ER messages in syslog **

**Status:** fixed
**Milestone:** 5.1.RC1
**Created:** Wed Aug 31, 2016 03:17 AM UTC by Long HB Nguyen
**Last Updated:** Wed Aug 31, 2016 04:30 AM UTC
**Owner:** Long HB Nguyen


Hans fixed this issue in ticket [#1911] (changeset:   7792:55500835c0a9).
However, it has been reverted in [#1642] (changeset:   7927:abc37dbf39ff) by 
mistake when the code was rebased.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1989 amfnd: Incorrect ER messages in syslog

2016-08-30 Thread Long HB Nguyen
- **status**: assigned --> review



---

** [tickets:#1989] amfnd: Incorrect ER messages in syslog **

**Status:** review
**Milestone:** 5.1.RC1
**Created:** Wed Aug 31, 2016 03:17 AM UTC by Long HB Nguyen
**Last Updated:** Wed Aug 31, 2016 03:17 AM UTC
**Owner:** Long HB Nguyen


Hans fixed this issue in ticket [#1911] (changeset:   7792:55500835c0a9).
However, it has been reverted in [#1642] (changeset:   7927:abc37dbf39ff) by 
mistake when the code was rebased.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1989 amfnd: Incorrect ER messages in syslog

2016-08-30 Thread Long HB Nguyen



---

** [tickets:#1989] amfnd: Incorrect ER messages in syslog **

**Status:** assigned
**Milestone:** 5.1.RC1
**Created:** Wed Aug 31, 2016 03:17 AM UTC by Long HB Nguyen
**Last Updated:** Wed Aug 31, 2016 03:17 AM UTC
**Owner:** Long HB Nguyen


Hans fixed this issue in ticket [#1911] (changeset:   7792:55500835c0a9).
However, it has been reverted in [#1642] (changeset:   7927:abc37dbf39ff) by 
mistake when the code was rebased.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-30 Thread Long HB Nguyen
- **status**: review --> fixed



---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** fixed
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Tue Aug 30, 2016 07:32 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-30 Thread Long HB Nguyen
changeset:   7983:378920f71b18
user:minh-chau <minh.c...@dektech.com.au>
date:Tue Aug 30 15:33:45 2016 +1000
summary: AMF Demo: Remove unused var to build uml [#1642]

changeset:   7987:2fe70548ad87
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 30 15:58:59 2016 +1000
summary: amfd: fix cppcheck errors [#1642]

changeset:   7988:7c1bd4b6aa6b
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Tue Aug 30 16:01:43 2016 +1000
summary: amfnd: cppcheck warnings with severity error [#1642]

[staging:378920]
[staging:2fe705]
[staging:7c1bd4]


---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Tue Aug 30, 2016 05:44 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1571 AMF: Use std::maps instead of Patricia trees

2016-08-29 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -1 +1,2 @@
 Use std::maps instead of Patricia trees, see also [#1520].
+This enhancement has been included in [#1642].



- **status**: assigned --> invalid



---

** [tickets:#1571] AMF: Use std::maps instead of Patricia trees**

**Status:** invalid
**Milestone:** 5.2.FC
**Created:** Wed Oct 28, 2015 02:39 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 29, 2016 08:13 PM UTC
**Owner:** Long HB Nguyen


Use std::maps instead of Patricia trees, see also [#1520].
This enhancement has been included in [#1642].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1614 amfnd: replace internal use of SaNameT with std::string

2016-08-29 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -1 +1,2 @@
 Replace internal use of SaNameT with std::string in amfnd.
+This enhancement has been included in [#1642].



- **status**: assigned --> invalid



---

** [tickets:#1614] amfnd: replace internal use of SaNameT with std::string **

**Status:** invalid
**Milestone:** 5.2.FC
**Created:** Mon Nov 30, 2015 06:44 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 29, 2016 08:12 PM UTC
**Owner:** Long HB Nguyen


Replace internal use of SaNameT with std::string in amfnd.
This enhancement has been included in [#1642].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1558 amf: use nullptr instead of NULL macros

2016-08-29 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -1 +1,2 @@
 Using nullptr instead of NULL macros. This is a part of ticket [#1520].
+This ticket was replaced by [#1547] and [#1551].



- **status**: assigned --> invalid



---

** [tickets:#1558] amf: use nullptr instead of NULL macros**

**Status:** invalid
**Milestone:** 5.2.FC
**Created:** Fri Oct 23, 2015 04:28 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 29, 2016 08:13 PM UTC
**Owner:** Long HB Nguyen


Using nullptr instead of NULL macros. This is a part of ticket [#1520].
This ticket was replaced by [#1547] and [#1551].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1551 amfnd: convert NULL to nullptr

2016-08-29 Thread Long HB Nguyen
- **status**: assigned --> fixed



---

** [tickets:#1551] amfnd: convert NULL to nullptr **

**Status:** fixed
**Milestone:** 5.0.FC
**Created:** Tue Oct 20, 2015 09:36 AM UTC by Long HB Nguyen
**Last Updated:** Mon Nov 30, 2015 06:38 AM UTC
**Owner:** Long HB Nguyen


Convert NULL to nullptr for Anf Node Director. This is a part of ticket [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1547 amfd: convert NULL to nullptr

2016-08-29 Thread Long HB Nguyen
- **status**: assigned --> fixed



---

** [tickets:#1547] amfd: convert NULL to nullptr**

**Status:** fixed
**Milestone:** 5.0.FC
**Created:** Thu Oct 15, 2015 06:24 AM UTC by Long HB Nguyen
**Last Updated:** Mon Nov 30, 2015 06:37 AM UTC
**Owner:** Long HB Nguyen


Convert NULL to nullptr. This is a part of ticket 1520 [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1976 amf: cppcheck warnings with severity "error"

2016-08-29 Thread Long HB Nguyen
- **status**: unassigned --> invalid



---

** [tickets:#1976] amf: cppcheck warnings with severity "error"**

**Status:** invalid
**Milestone:** 5.1.FC
**Created:** Mon Aug 29, 2016 06:08 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 29, 2016 06:08 AM UTC
**Owner:** Long HB Nguyen


There are some cppcheck warnings with severity "error" in AMF:
[osaf/services/saf/amf/amfd/ndproc.cc:314]: (error) Using 'memcpy' on struct 
that contains a 'std::string'.
[osaf/services/saf/amf/amfd/ndproc.cc:358]: (error) Using 'memcpy' on struct 
that contains a 'std::string'.
[osaf/services/saf/amf/amfd/role.cc:560]: (error) Using 'memset' on struct that 
contains a 'std::string'.
[osaf/services/saf/amf/amfnd/cbq.cc:603]: (error) Using 'memset' on struct that 
contains a 'std::string'. ​


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1976 amf: cppcheck warnings with severity "error"

2016-08-29 Thread Long HB Nguyen



---

** [tickets:#1976] amf: cppcheck warnings with severity "error"**

**Status:** unassigned
**Milestone:** 5.1.FC
**Created:** Mon Aug 29, 2016 06:08 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 29, 2016 06:08 AM UTC
**Owner:** Long HB Nguyen


There are some cppcheck warnings with severity "error" in AMF:
[osaf/services/saf/amf/amfd/ndproc.cc:314]: (error) Using 'memcpy' on struct 
that contains a 'std::string'.
[osaf/services/saf/amf/amfd/ndproc.cc:358]: (error) Using 'memcpy' on struct 
that contains a 'std::string'.
[osaf/services/saf/amf/amfd/role.cc:560]: (error) Using 'memset' on struct that 
contains a 'std::string'.
[osaf/services/saf/amf/amfnd/cbq.cc:603]: (error) Using 'memset' on struct that 
contains a 'std::string'. ​


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-28 Thread Long HB Nguyen
- **status**: review --> fixed



---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** fixed
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 29, 2016 03:31 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-28 Thread Long HB Nguyen
changeset:   7957:da6a8d617b76
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Fri Aug 26 15:20:36 2016 +1000
summary: amf: add README file for long DN support [#1642]

changeset:   7960:e219fd4d84c7
tag: tip
user:Long Nguyen <long.hb.ngu...@dektech.com.au>
date:Mon Aug 29 12:17:13 2016 +1000
summary: AMFA: Fix memleak in longDN pg notification [#1642]


[staging:da6a8d]
[staging:e219fd]


---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Tue Aug 23, 2016 02:46 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-22 Thread Long HB Nguyen
changeset:   7912:f567b31f7c60
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:41:54 2016 +1000
summary: amfd: replace SaNameT with string in include dir [#1642]

changeset:   7913:6a3c8d5c96f0
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:41:57 2016 +1000
summary: amfd: replace SaNameT with string [#1642]

changeset:   7914:42ceef9fcbcb
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:01 2016 +1000
summary: amfd: replace SaNameT with string [#1642]

changeset:   7915:bbe17545d4a9
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:04 2016 +1000
summary: amfd: enable long DN support [#1642]

changeset:   7916:7f91232751e2
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:06 2016 +1000
summary: amfd: replace SaNameT with string [#1642]

changeset:   7917:707147c5ae97
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:08 2016 +1000
summary: amfd: handle SaNameT properly in avd_saImmOiRtObjectUpdate() 
[#1642]

changeset:   7918:0ab69f05b332
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:11 2016 +1000
summary: amfd: do not call memset on classes with string members [#1642]

changeset:   7919:15f5bd7a3450
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:13 2016 +1000
summary: amfd: fix double free [#1642]

changeset:   7920:77b94b6b3f00
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:15 2016 +1000
summary: amfd: add compare_sanamet() to emulate m_CMP_NORDER_SANAMET [#1642]

changeset:   7921:16e6ac16d63e
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:17 2016 +1000
summary: amfd: fix various CSI related problems [#1642]

changeset:   7922:0b9e1aa24d11
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:22 2016 +1000
summary: amfd: ensure long DNs are sent correctly in additional info [#1642]

changeset:   7923:9928d20c4eb5
user:Gary Lee <gary@dektech.com.au>
date:Tue Aug 23 10:42:25 2016 +1000
summary: amfd: add long DN support [#1642]

changeset:   7924:26218e03910a
user:Minh Hon Chau <minh.c...@dektech.com.au>
date:Tue Jun 21 14:54:53 2016 +0700
summary: amfa: enable long DN support [#1642]

changeset:   7925:7103ff4ff4a0
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Tue Jun 21 14:54:54 2016 +0700
summary: amfwdog: enable long DN support [#1642]

changeset:   7926:30d49272e7a6
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Tue Jun 21 14:54:55 2016 +0700
summary: amfpm: enable long DN support [#1642]

changeset:   7927:c51711e7fded
user:Hans Nordeback <hans.nordeb...@ericsson.com>
date:Tue Jun 21 14:54:57 2016 +0700
summary:     libs/common/amf: enable long DN support [#1642]

changeset:   7928:abc37dbf39ff
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Mon Jul 11 13:04:34 2016 +0700
summary: amfnd: enable long DN support [#1642]

changeset:   7929:1bd9fe74e608
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Mon Aug 15 14:28:54 2016 +0700
summary: amfnd: fix issue with environment variable [#1642]

changeset:   7930:ead22cb84362
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Mon Aug 22 14:13:58 2016 +0700
summary: amfnd: remove used code in util.cc [#1642]

changeset:   7931:c9986fbf0318
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Mon Aug 22 14:13:57 2016 +0700
summary: amfa: fixed freeing notification buff [#1642]

changeset:   7932:e7ed0fd83711
tag: tip
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Tue Jun 21 14:55:01 2016 +0700
summary: samples/amf: enable long DN support [#1642]



---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 22, 2016 08:46 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https

[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-22 Thread Long HB Nguyen
The remainng patches @22 Aug 2016.



Attachments:

- 
[patches_20160822_2.tgz](https://sourceforge.net/p/opensaf/tickets/_discuss/thread/90f84e2d/7854/attachment/patches_20160822_2.tgz)
 (116.8 kB; application/x-gzip-compressed)


---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Mon Aug 22, 2016 06:53 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-17 Thread Long HB Nguyen
Hi Praveen,

Please see my answers for 2, 3, 4.
2) OK. We should clean up the util.cc.
3) Because the memory allocation is now free'ed in the common libs (using C), 
we use calloc to avoid mismatching between 'new' (C++ style) anf 'free' (C 
style).
4) No, we should use the new file.

Thanks,
Long Nguyen.


---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Wed Aug 17, 2016 12:57 PM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-04 Thread Long HB Nguyen
Hi Praveen,

I have updated the ticket description.

Best regards,
Long Nguyen.


---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Fri Aug 05, 2016 03:46 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-08-04 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -1 +1,4 @@
 Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
+Moreover, this ticket also contains some enhancements:
+1) Refactor internal SaNameT to std::string in amfd, amfnd.
+2) Refactor PATRICIA trees to std::map in amfnd.






---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Thu Aug 04, 2016 01:17 PM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.
Moreover, this ticket also contains some enhancements:
1) Refactor internal SaNameT to std::string in amfd, amfnd.
2) Refactor PATRICIA trees to std::map in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-07-25 Thread Long HB Nguyen
AMFND part.


Attachments:

- 
[1642_amfnd.tgz](https://sourceforge.net/p/opensaf/tickets/_discuss/thread/90f84e2d/11a4/attachment/1642_amfnd.tgz)
 (76.6 kB; application/x-gzip-compressed)


---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Mon Jul 25, 2016 06:25 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1642 AMF: Support DNs longer than 255 bytes

2016-07-11 Thread Long HB Nguyen
- **status**: assigned --> review



---

** [tickets:#1642] AMF: Support DNs longer than 255 bytes**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue Dec 15, 2015 09:52 AM UTC by Long HB Nguyen
**Last Updated:** Mon Jul 11, 2016 07:50 AM UTC
**Owner:** Long HB Nguyen


Ticket [#191] introduced generic support in OpenSAF for DNs longer than 255 
bytes. Each individual OpenSAF service will also have to be adapted to support 
long DNs. This ticket is for AMF to support this feature.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Attend Shape: An AT Tech Expo July 15-16. Meet us at AT Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1614 amfnd: replace internal use of SaNameT with std::string

2015-11-29 Thread Long HB Nguyen
- Description has changed:

Diff:



--- old
+++ new
@@ -1 +1 @@
-Replace internal use of SaNameT with std::strin in amfnd.
+Replace internal use of SaNameT with std::string in amfnd.






---

** [tickets:#1614] amfnd: replace internal use of SaNameT with std::string **

**Status:** assigned
**Milestone:** 5.0.FC
**Created:** Mon Nov 30, 2015 06:44 AM UTC by Long HB Nguyen
**Last Updated:** Mon Nov 30, 2015 06:44 AM UTC
**Owner:** Long HB Nguyen


Replace internal use of SaNameT with std::string in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551=/4140___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1614 amfnd: replace internal use of SaNameT with std::string

2015-11-29 Thread Long HB Nguyen



---

** [tickets:#1614] amfnd: replace internal use of SaNameT with std::string **

**Status:** assigned
**Milestone:** 5.0.FC
**Created:** Mon Nov 30, 2015 06:44 AM UTC by Long HB Nguyen
**Last Updated:** Mon Nov 30, 2015 06:44 AM UTC
**Owner:** Long HB Nguyen


Replace internal use of SaNameT with std::strin in amfnd.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551=/4140___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1551 amfnd: convert NULL to nullptr

2015-11-29 Thread Long HB Nguyen
changeset:   7105:2b8e45a84a2b
user:Long HB Nguyen<long.hb.ngu...@dektech.com.au>
date:Tue Oct 20 14:08:29 2015 +0700
summary: amfnd: convert NULL to nullptr for amfnd.cc [#1551]



---

** [tickets:#1551] amfnd: convert NULL to nullptr **

**Status:** assigned
**Milestone:** 5.0.FC
**Created:** Tue Oct 20, 2015 09:36 AM UTC by Long HB Nguyen
**Last Updated:** Sun Nov 01, 2015 09:36 PM UTC
**Owner:** Long HB Nguyen


Convert NULL to nullptr for Anf Node Director. This is a part of ticket [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551=/4140___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1571 AMF: Use std::maps instead of Patricia trees

2015-10-27 Thread Long HB Nguyen



---

** [tickets:#1571] AMF: Use std::maps instead of Patricia trees**

**Status:** assigned
**Milestone:** 5.0
**Created:** Wed Oct 28, 2015 02:39 AM UTC by Long HB Nguyen
**Last Updated:** Wed Oct 28, 2015 02:39 AM UTC
**Owner:** Long HB Nguyen


Use std::maps instead of Patricia trees, see also [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1520 AMF: Refactoring for 5.0

2015-10-27 Thread Long HB Nguyen
- created #1558 amf: use nullptr instead of NULL macros.
- created #1571 AMF: Use std::maps instead of Patricia trees.


---

** [tickets:#1520] AMF: Refactoring for 5.0**

**Status:** unassigned
**Milestone:** 5.0
**Created:** Tue Oct 06, 2015 11:08 AM UTC by hano
**Last Updated:** Wed Oct 21, 2015 09:53 AM UTC
**Owner:** hano


This is a 5.0 ticket for continue code re-factoring of the AMF service for 4.6. 
The work started with #94 in 4.4
and continued in #713 in 4.5 and #1142 in 4.6.
This ticket is to continue the work started in #94, #713 and #1142 to get
a more maintainable, understandable and testable code base.
We should aim for many small changes instead of few big ones.
The Google C++ Style Guide is to be followed and Google's cpplint to be run on 
the code base.

An ordered list, (highest priority first), of things to work on, for each task 
sub tasks
can be added together with a separate ticket:

- Replace legacy data structures such as lists with STL std::vector (prefered), 
std::list etc. [#1543]
- Change SU::list_of_susi and SI:: list_of_sisu to std::vector HansN
   -
- Replace internal use of SaNameT with std::string [#1537]
- Use std::maps instead of Patricia trees.
- Reduce duplicate code.
- Improve cyclomatic complexity (McCabe) numbers.
- Simplify conditional statements. [#1538]
- Reduce the amount of 'nesting' in the code
- Split up long functions into smaller ones doing one things and not many.
- Convert model derived C structs to classes and change functions into methods.
- Use bool which is a native type in C++ (and remove SaBoolT)
- Write unit-test when refactoring code into units.
- Reduce number of casts in the code (introduced because of C++ files)
- Remove use of EDU and do direct encode/decode [#1544]
- Change macros to (inline) methods
- Use design patterns where appropriate.
- Change bit fields (flags) to boolean attributes (see 
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
 
**Investigations that can be done:
**- Use Boost libraries that requires only the boost header file, e.g 
multiindex.
- Introduce two builds, debug and product, e.g debug build can be used for 
various support during development, e.g. defensive programming , additional 
compiler options, e.g. -Weffc++ , etc.
- Investigate if pointers in data structure can be changed to a class 
(owns/uses relationships) that maintains referential integrity in the internal 
data structures.
**Non C++ related changes:
**- Use UML, (which tool?) to document parts of the design, sequence diagrams, 
state charts, etc.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1558 amf: use nullptr instead of NULL macros

2015-10-22 Thread Long HB Nguyen



---

** [tickets:#1558] amf: use nullptr instead of NULL macros**

**Status:** assigned
**Milestone:** 5.0
**Created:** Fri Oct 23, 2015 04:28 AM UTC by Long HB Nguyen
**Last Updated:** Fri Oct 23, 2015 04:28 AM UTC
**Owner:** Long HB Nguyen


Using nullptr instead of NULL macros. This is a part of ticket [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1520 AMF: Refactoring for 5.0

2015-10-21 Thread Long HB Nguyen
created #1551: amfnd: convert NULL to nullptr


---

** [tickets:#1520] AMF: Refactoring for 5.0**

**Status:** unassigned
**Milestone:** 5.0
**Created:** Tue Oct 06, 2015 11:08 AM UTC by hano
**Last Updated:** Thu Oct 15, 2015 06:25 AM UTC
**Owner:** hano


This is a 5.0 ticket for continue code re-factoring of the AMF service for 4.6. 
The work started with #94 in 4.4
and continued in #713 in 4.5 and #1142 in 4.6.
This ticket is to continue the work started in #94, #713 and #1142 to get
a more maintainable, understandable and testable code base.
We should aim for many small changes instead of few big ones.
The Google C++ Style Guide is to be followed and Google's cpplint to be run on 
the code base.

An ordered list, (highest priority first), of things to work on, for each task 
sub tasks
can be added together with a separate ticket:

- Replace legacy data structures such as lists with STL std::vector (prefered), 
std::list etc. [#1543]
- Change SU::list_of_susi and SI:: list_of_sisu to std::vector HansN
   -
- Replace internal use of SaNameT with std::string [#1537]
- Use std::maps instead of Patricia trees.
- Reduce duplicate code.
- Improve cyclomatic complexity (McCabe) numbers.
- Simplify conditional statements. [#1538]
- Reduce the amount of 'nesting' in the code
- Split up long functions into smaller ones doing one things and not many.
- Convert model derived C structs to classes and change functions into methods.
- Use bool which is a native type in C++ (and remove SaBoolT)
- Write unit-test when refactoring code into units.
- Reduce number of casts in the code (introduced because of C++ files)
- Remove use of EDU and do direct encode/decode [#1544]
- Change macros to (inline) methods
- Use design patterns where appropriate.
- Change bit fields (flags) to boolean attributes (see 
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
 
**Investigations that can be done:
**- Use Boost libraries that requires only the boost header file, e.g 
multiindex.
- Introduce two builds, debug and product, e.g debug build can be used for 
various support during development, e.g. defensive programming , additional 
compiler options, e.g. -Weffc++ , etc.
- Investigate if pointers in data structure can be changed to a class 
(owns/uses relationships) that maintains referential integrity in the internal 
data structures.
**Non C++ related changes:
**- Use UML, (which tool?) to document parts of the design, sequence diagrams, 
state charts, etc.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1551 amfnd: convert NULL to nullptr

2015-10-20 Thread Long HB Nguyen



---

** [tickets:#1551] amfnd: convert NULL to nullptr **

**Status:** assigned
**Milestone:** 5.0
**Created:** Tue Oct 20, 2015 09:36 AM UTC by Long HB Nguyen
**Last Updated:** Tue Oct 20, 2015 09:36 AM UTC
**Owner:** Long HB Nguyen


Convert NULL to nullptr for Anf Node Director. This is a part of ticket [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1520 AMF: Refactoring for 5.0

2015-10-15 Thread Long HB Nguyen
created #1547: amfd: convert NULL to nullptr


---

** [tickets:#1520] AMF: Refactoring for 5.0**

**Status:** unassigned
**Milestone:** 5.0
**Created:** Tue Oct 06, 2015 11:08 AM UTC by hano
**Last Updated:** Wed Oct 14, 2015 06:46 AM UTC
**Owner:** hano


This is a 5.0 ticket for continue code re-factoring of the AMF service for 4.6. 
The work started with #94 in 4.4
and continued in #713 in 4.5 and #1142 in 4.6.
This ticket is to continue the work started in #94, #713 and #1142 to get
a more maintainable, understandable and testable code base.
We should aim for many small changes instead of few big ones.
The Google C++ Style Guide is to be followed and Google's cpplint to be run on 
the code base.

An ordered list, (highest priority first), of things to work on, for each task 
sub tasks
can be added together with a separate ticket:

- Replace legacy data structures such as lists with STL std::vector (prefered), 
std::list etc. [#1543]
- Change SU::list_of_susi and SI:: list_of_sisu to std::vector HansN
   -
- Replace internal use of SaNameT with std::string [#1537]
- Use std::maps instead of Patricia trees.
- Reduce duplicate code.
- Improve cyclomatic complexity (McCabe) numbers.
- Simplify conditional statements. [#1538]
- Reduce the amount of 'nesting' in the code
- Split up long functions into smaller ones doing one things and not many.
- Convert model derived C structs to classes and change functions into methods.
- Use bool which is a native type in C++ (and remove SaBoolT)
- Write unit-test when refactoring code into units.
- Reduce number of casts in the code (introduced because of C++ files)
- Remove use of EDU and do direct encode/decode [#1544]
- Change macros to (inline) methods
- Use design patterns where appropriate.
- Change bit fields (flags) to boolean attributes (see 
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
 
**Investigations that can be done:
**- Use Boost libraries that requires only the boost header file, e.g 
multiindex.
- Introduce two builds, debug and product, e.g debug build can be used for 
various support during development, e.g. defensive programming , additional 
compiler options, e.g. -Weffc++ , etc.
- Investigate if pointers in data structure can be changed to a class 
(owns/uses relationships) that maintains referential integrity in the internal 
data structures.
**Non C++ related changes:
**- Use UML, (which tool?) to document parts of the design, sequence diagrams, 
state charts, etc.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1547 amfd: convert NULL to nullptr

2015-10-15 Thread Long HB Nguyen



---

** [tickets:#1547] amfd: convert NULL to nullptr**

**Status:** assigned
**Milestone:** 5.0
**Created:** Thu Oct 15, 2015 06:24 AM UTC by Long HB Nguyen
**Last Updated:** Thu Oct 15, 2015 06:24 AM UTC
**Owner:** Long HB Nguyen


Convert NULL to nullptr. This is a part of ticket 1520 [#1520].


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets