Re: [opensource-dev] Very Strange occurrence...

[Vadim Savchuk]

On 01/04/2011 08:07 AM, Anya Kanevsky wrote:
> Ponzu, I'm understandably very interested in finding out which xml 
> files ... Thanks!
inspect_avatar.xml: value="Grumpity ProductEngine with a long name"
inspect_avatar.xml:value="Grumpity ProductEngine"
inspect_group.xml:Grumpity's Grumpy Group of Moose
panel_activeim_row.xml:Grumpity ProductEngine

-- 
Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Very Strange occurrence...

[Boroondas Gupte]

On 01/04/2011 07:07 AM, Anya Kanevsky wrote:
> Ponzu, I'm understandably very interested in finding out which xml
> files ... Thanks!
> Getting IMs from people telling me to lay off other people I don't
> know and have never talked to is getting kind of old. 
> [...]
>
> 2010/12/31 Ponzu mailto:lee.po...@gmail.com>>
>
> I just thought of looking in the xml files, and indeed "Grumpity
> Productengine" shows up in a few of them, I assume as some sort of
> place holder left by a programmer.
>
> Maybe such "magic words" should be replace by something like
> "Unkown Resident" or some such.
>
*indra/newview/skins/default/xui/en/inspect_avatar.xml*
46: value="Grumpity ProductEngine with a long name"
57:value="Grumpity ProductEngine"

*indra/newview/skins/default/xui/en/panel_activeim_row.xml*
79:Grumpity ProductEngine

*indra/newview/skins/default/xui/en/inspect_group.xml*
34:Grumpity's Grumpy Group of Moose

*indra/newview/skins/default/xui/fr/inspect_avatar.xml*
13: 
14: 

*indra/newview/skins/default/xui/fr/panel_activeim_row.xml*
4:  Grumpity ProductEngine

*indra/newview/skins/default/xui/fr/inspect_group.xml*
20: Groupe grognon des Orignaux Grumpity

*indra/newview/skins/default/xui/de/inspect_avatar.xml*
14: 

*indra/newview/skins/default/xui/de/panel_activeim_row.xml*
4:  Grumpity ProductEngine

*indra/newview/skins/default/xui/de/inspect_group.xml*
20: Grumpitys schlecht gelaunte Elche

*indra/newview/skins/default/xui/es/inspect_avatar.xml*
13: 

*indra/newview/skins/default/xui/da/inspect_avatar.xml*
13: 

*indra/newview/skins/default/xui/pt/inspect_avatar.xml*
13: 

*indra/newview/skins/default/xui/ja/inspect_avatar.xml*
13: 

*indra/newview/skins/default/xui/ja/panel_activeim_row.xml*
4:  Grumpity ProductEngine

*indra/newview/skins/default/xui/ja/inspect_group.xml*
20: Grumpity's Grumpy Group of Moose

*indra/newview/skins/default/xui/pl/inspect_avatar.xml*
13: 

Extracted from current viewer-development

by ack  --xml "Grumpity".

Cheers,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Very Strange occurrence...

[WolfPup Lowenhar]

I had seen those as well and just figured they were in there as a ‘placed 
holder’ so that when the translation team gets a hold of the viewer they have 
some large name there so that they know not to use that space. I have also seen 
different Lindens names there as well on other areas.

 

From: opensource-dev-boun...@lists.secondlife.com 
[mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Boroondas 
Gupte
Sent: Tuesday, January 04, 2011 6:31 AM
To: Anya Kanevsky
Cc: opensource-dev
Subject: Re: [opensource-dev] Very Strange occurrence...

 

On 01/04/2011 07:07 AM, Anya Kanevsky wrote: 

Ponzu, I'm understandably very interested in finding out which xml files ... 
Thanks! 

Getting IMs from people telling me to lay off other people I don't know and 
have never talked to is getting kind of old. 

[...]

2010/12/31 Ponzu 

I just thought of looking in the xml files, and indeed "Grumpity Productengine" 
shows up in a few of them, I assume as some sort of place holder left by a 
programmer. 

 

Maybe such "magic words" should be replace by something like "Unkown Resident" 
or some such.

indra/newview/skins/default/xui/en/inspect_avatar.xml
46: value="Grumpity ProductEngine with a long name"
57:value="Grumpity ProductEngine"
 
indra/newview/skins/default/xui/en/panel_activeim_row.xml
79:Grumpity ProductEngine
 
indra/newview/skins/default/xui/en/inspect_group.xml
34:Grumpity's Grumpy Group of Moose
 
indra/newview/skins/default/xui/fr/inspect_avatar.xml
13: 
14: 
 
indra/newview/skins/default/xui/fr/panel_activeim_row.xml
4: Grumpity ProductEngine
 
indra/newview/skins/default/xui/fr/inspect_group.xml
20:Groupe grognon des Orignaux Grumpity
 
indra/newview/skins/default/xui/de/inspect_avatar.xml
14: 
 
indra/newview/skins/default/xui/de/panel_activeim_row.xml
4: Grumpity ProductEngine
 
indra/newview/skins/default/xui/de/inspect_group.xml
20:Grumpitys schlecht gelaunte Elche
 
indra/newview/skins/default/xui/es/inspect_avatar.xml
13: 
 
indra/newview/skins/default/xui/da/inspect_avatar.xml
13: 
 
indra/newview/skins/default/xui/pt/inspect_avatar.xml
13: 
 
indra/newview/skins/default/xui/ja/inspect_avatar.xml
13: 
 
indra/newview/skins/default/xui/ja/panel_activeim_row.xml
4: Grumpity ProductEngine
 
indra/newview/skins/default/xui/ja/inspect_group.xml
20:Grumpity's Grumpy Group of Moose
 
indra/newview/skins/default/xui/pl/inspect_avatar.xml
13: 

Extracted from current viewer-development 
  by 
ack   --xml "Grumpity".

Cheers,
Boroondas

  _  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1191 / Virus Database: 1435/3357 - Release Date: 01/03/11

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Inventory incremental search (VWR-23712)

[Satomi Ahn]

Hello and happy new year.

I hate spamming this list, but there is an easy bug I'd like to see
fixed in the viewer, and which seems to have been only taking dust in
the JIRA for two entire months.

This is about one of the bugs who contribute to the general feeling of
sluggishness in Viewer 2, so I believe you should really consider
inclusion in viewer-development ;-).

Enough spoken, everything is there, patch included:
https://jira.secondlife.com/browse/VWR-23712

-- 
Satomi Ahn
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Very Strange occurrence...

[Jonathan Welch]

This is actually a small symptom of a larger problem.

The text in those xml files is supposed to be replaced by some valid
string but that does not always happen.

I've often hovered over some object which would show it was for sale
for L$30,000 when it was not valued at that amount--a failure to
substitute in the proper value.

The real solution to this issue would be to fix the underlaying problem.

> Ponzu, I'm understandably very interested in finding out which xml files ...
> Thanks!
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24100 Settings.xml: redundant entries and unnecessary tag

[Jonathan Yap]

> On Dec. 16, 2010, 8:04 a.m., Aleric Inglewood wrote:
> > indra/newview/app_settings/settings.xml, line 1165
> > 
> >
> > Considering the setting name (CacheLocationTopFolder), isn't the 
> > deleted Comment string better than the one you left in? Thus, Controls the 
> > top folder location of the the local disk cache, rather than Controls the 
> > location of the local disk cache. Diff is ok with me, I just wondered if 
> > you saw that it wasn't an exact duplicate.

I adjusted the file per your observation.  Apparently this setting was cloned 
from the one above it (CacheLocation) twice and the comment only updated in one 
of the copies.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/#review32
---


On Dec. 23, 2010, 12:12 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/18/
> ---
> 
> (Updated Dec. 23, 2010, 12:12 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> I wrote two programs that use settings.xml to produce this massive table:
> http://wiki.secondlife.com/wiki/Debug_Settings
> 
> While doing this I found 4 places with duplicate entries and 1 entry that is 
> repeated 4 times.  There is also a pair of unnecessary tags.
> 
> Having these cleaned out would make running my program, and thus updating the 
> wiki table, easier.
> 
> I've erased all but the last entry for these redundant debug settings.
> 
> 
> This addresses bug vwr-24100.
> http://jira.secondlife.com/browse/vwr-24100
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 46a990f8296f 
> 
> Diff: http://codereview.secondlife.com/r/18/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Snowstorm Sprint Planning Meeting Canceled Today

[Sarah (Esbee) Kuehnle]

Happy New Year!

I've canceled the Snowstorm sprint planning meeting that was scheduled for
this afternoon. I think it's best to push that to first thing next week
which will give us all time to catch up on everything that's happened over
the holidays.

I'll get the team calendar updated with new times and dates shortly.

--Esbee
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] build 218026 silently failing

[Philippe (Merov) Bossut]

Hi,

On Mon, Jan 3, 2011 at 7:52 PM, Erin Mallory
wrote:

>  build 218026 seems to just continuously silently fail. it doesn;t seem to
> trigger any particular error and i cannot figure out what is triggering it,
> other then possibly a memory leak.
> It just is there one moment and gone the next, leaving behind two instances
> of SLplugin.  for a breif moment when this happens the
> secondlifedevelopement.exe file is still in the list usually taking up
> INSANE amounts of memory (more then 2 gig ram and 4 gig virtual), but only
> for a moment.  it doesn't even trigger the crash logger.
> It does seem to happen most when i am in the middle of typing something
> into an im window but i can't consistently repo it enough to determine if
> that has something to do with it.  I'm really frustrated and wondering if
> anyone else running this build or one from about the same timeframe is
> seeing this as well?
>

 Hmmm... This is concerning. I suppose you're using the Windows build
though, to avoid ambiguities, please mention the operating system you're
using in your future reports.

I certainly don't repro on Mac but I don't follow a very typical use
pattern.

Anyone else seeing this issue? On which platform?

Thanks for the report Erin.

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Philippe (Merov) Bossut]

Hi,

This seems spot on. Thanks Satomi.

On Tue, Jan 4, 2011 at 6:32 AM, Satomi Ahn  wrote:

>
> Enough spoken, everything is there, patch included:
> https://jira.secondlife.com/browse/VWR-23712


Bug report + patch = much much love from Snowstorms maintainers :)

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Scrum Cancelled

[Anya Kanevsky]

Due to griefing in hippotropolis, we're canceling the meeting today. Please
email me with your updates and I will send out a summary shortly.  Apologies
for the unpleasant experience, all.

anya
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] saved logins

[Henri Beauchamp]

On Mon, 3 Jan 2011 15:22:02 -0800, Philippe (Merov) Bossut wrote:

> Hi,
> 
> On Wed, Dec 29, 2010 at 2:46 PM, Lance Corrimal
> wrote:
> 
> > Am Mittwoch, 29. Dezember 2010 schrieb Aleric Inglewood:
> > > https://jira.secondlife.com/browse/SNOW-129
> >
> > that is one of the main things that are holding me back from going
> > live with dolphin viewer 2.x, the missing saved logins dropdown...
> 
> That was proposed as a port to Snowstorm:
> https://jira.secondlife.com/browse/SNOW-670
> 
> IIRC, OpenSim users didn't like some of the aspects of that implementation.
> An alternative proposal fixing those issues would be welcome.

The problem with Snowglobe's implementation is that it saves the login
info using the grid index number in the grids list, number which changes
for OpenSim grids as soon as you change the grids list, resulting in
messed up saved login info.

I fixed this issue in the Cool VL Viewer v1.25 (which is based off
Snowglobe v1.5), simply by using the grid name instead of the grid
index number...

This fix is part of the patch (for SG 1.5) available here:
http://sldev.free.fr/patches/12500/slviewer-0-v12500-MoreGridsDynamic_v7.patch.bz2

Henri.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/
---

(Updated Jan. 4, 2011, 12:38 p.m.)


Review request for Viewer.


Changes
---

- Added a boost::regex member variable not to translate the mask to a regex on 
every call to next().
- Moved iterator initialization and exceptions handling to the constructor.


Summary
---

Fixed LLDir unit test which failed for some complex wildcard combinations.
Added a class implementing directory entries iteration with pattern matching 
which is used in unit tests instead of LLDir::getNextFileInDir.

This code has been run on Linux only. It should be tested under other platforms 
and more test cases should be provided. For example changing directory contents 
while iterating through it.


This addresses bug STORM-550.
http://jira.secondlife.com/browse/STORM-550


Diffs (updated)
-

  indra/cmake/Boost.cmake 27dae7b01a81 
  indra/llvfs/CMakeLists.txt 27dae7b01a81 
  indra/llvfs/lldiriterator.h PRE-CREATION 
  indra/llvfs/lldiriterator.cpp PRE-CREATION 
  indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 

Diff: http://codereview.secondlife.com/r/32/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

[Seth ProductEngine]

> On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote:
> > indra/llvfs/lldiriterator.cpp, lines 152-155
> > 
> >
> > This method of tracking escapes and brackets isn't quite correct, I 
> > think... consider translating a string input containing an escaped 
> > backslash or an escaped bracket.
> >

Escaping characters like backslash or a square bracket seems to work as 
expected. 
For example the pattern "file[0-9].abc" used as a mask argument for 
iterator constructor will match files: "file\1.abc", "file\2.abc", etc.
The bracket can be escaped by a preceding double backslash "\\[".


> On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote:
> > indra/llvfs/lldiriterator.cpp, line 99
> > 
> >
> > There should be a unit test for this translation.

All unit tests for directory iterator depend on the result of this translation. 
Looks like most common cases are covered. Does it need some additional test 
cases? what kind of cases should be added?


> On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote:
> > indra/llvfs/lldiriterator.cpp, lines 67-80
> > 
> >
> > It would be better to make the boost::regex a member variable - rather 
> > than translate the mask to a regex on every call to next, translate it once 
> > in the constructor.

Updated in diff r3.


> On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote:
> > indra/llvfs/lldiriterator.h, lines 55-56
> > 
> >
> > Why not use '^' for the negation qualifier here?  It's more familiar 
> > (at least to unix users)

'!' is defined in pattern matching rules on glob(7) man page, but it could be 
easily replaced with '^' if it is needed.


- Seth


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/#review80
---


On Jan. 4, 2011, 12:38 p.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/32/
> ---
> 
> (Updated Jan. 4, 2011, 12:38 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed LLDir unit test which failed for some complex wildcard combinations.
> Added a class implementing directory entries iteration with pattern matching 
> which is used in unit tests instead of LLDir::getNextFileInDir.
> 
> This code has been run on Linux only. It should be tested under other 
> platforms and more test cases should be provided. For example changing 
> directory contents while iterating through it.
> 
> 
> This addresses bug STORM-550.
> http://jira.secondlife.com/browse/STORM-550
> 
> 
> Diffs
> -
> 
>   indra/cmake/Boost.cmake 27dae7b01a81 
>   indra/llvfs/CMakeLists.txt 27dae7b01a81 
>   indra/llvfs/lldiriterator.h PRE-CREATION 
>   indra/llvfs/lldiriterator.cpp PRE-CREATION 
>   indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/32/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Tuesday, January 4, 2011

[Anya Kanevsky]

 Tuesday, January 4, 2011 General Notes
--

   - Happy New Year!
   - Standup was cancelled today
   - MMOTD: Oz

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-825 : Reenable the LLMatrix3::orthogonalize test in
   llmath/tests/m3math_test.cpp : Tested on TC all platforms. Pass. Good to go
   IMO.
   - STORM-744 : Add unit tests to llkdu: Fixed code so that test passes in
   all circumstances (debug, release) on all platforms. Resubmitted to RB.
   Merged by Oz over the holidays.
   - STORM-828 : Texture Saving Does Not Work : Was able to repro that bug
   reported by Trilo. Likely my fault. Need to fix.
   - STORM-823 : Tab Key not working properly : Checked that fix (<3 @Vadim
   for it), moved it to Integration.

*FUTURE*

   - STORM-828 : Texture Saving Does Not Work
   - STORM-745 : Produce comprehensive perf baseline: Complete that work.

*IMPEDIMENTS*

   - None

Oz Linden
--

*PAST*

   - Tracking down viewer dependencies with sources, etc
   - Wiki updates
   - Merge Monkeying
   - Office Hours

*FUTURE*

   - Merge Monkey
   - Review autobuild documentation
   - More wiki updates...

*IMPEDIMENTS*

   - none

Q Linden
--

*PAST*

   - Vacation
   - Recover from vacation backlog
   - Long meeting this morning

*FUTURE*

   - STORM-2
   - More emails & Meetings

*IMPEDIMENTS*

   - None

Esbee Linden
--

*PAST*

   - Holiday
   - Review integration queue
   - Rejected STORM-797 and STORM-410 - does not pass stated acceptance
   criteria.
   - Rejected STORM-28 - It doesn't seem like the implementation has met the
   user story criteria at all. I can share calling cards, but how I do give my
   calling card to a Resident I meet?
   - Rejected STORM-702 - I'd like to see a test plan so I can properly
   review this fix and make sure we've really made it possible to wear a
   partial outfit.
   - Approved STORM-493, STORM-513, STORM-466, STORM-737, STORM-485,
   STORM-467, STORM-398, STORM-714, STORM-812

*FUTURE*

   - Get caught up
   - Reschedule upcoming Snowstorm team meetings
   - Review product owner and integration queues (STORM-34, -806, -438)

*IMPEDIMENTS*

   - None


Paul ProductEngine
--

   - OOO - vacation

Seth Productengine
--

*PAST*

   - TASK (STORM-797) Parcel SLURL rendering
  - Fixed
   - TASK (STORM-28) As a User, I want the ability to send my calling card
   to others
  - Fixed
   - BUG (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard
   combinations
  - Changes according to feedback from Oz

*FUTURE*

   - STORM-550
   - STORM-447 (User is not able to share multi selected objects using
   drag&drop)

*IMPEDIMENTS*

   - None.

Andrew Productengine
--

*PAST*

   - Reviewed Sergey's fixes for a couple of issues, built and tested on
   Windows.
   - Major bug STORM-823 (Tab Key not working properly).
  - Fixed and put on review.
   - Normal task STORM-2 (Customizable viewer layouts).
  - Working on found problems. Continued Investigation of bug with
  loading undocked sidetray tabs. Discussed with Sergey and Vadim. There is
  some progress at last, but problem seems to be not in my fix,
and is located
  quite deep.

*FUTURE*

   - Normal task STORM-2 (Customizable viewer layouts).
  - Estimate for current version of feature - 2 days.

*IMPEDIMENTS*

   - STORM-2. Waiting for Q's reply to letter about organization of layout
   saving.
   - STORM-2. Waiting for Esbee's answers to comments about layout design in
   STORM-753.
   - STORM-823. The issue is fixed, but in a way that may be not principally
   correct in future, so it would be good if Richard could say what he thinks
   about it.
   - Happy New Year!

Vadim Productengine
--

*PAST*

   - Investigating bug STORM-226 (Viewer 2 Floating Text aligns improperly).
  - Not assigning the ticket to myself because I'm not yet sure I can
  fix it (to not disturb ~200 voters and ~50 watchers).

*FUTURE*

   - Continue with STORM-226.

*IMPEDIMENTS*

   - Need a decision in STORM-702 (Make it possible to wear partial
   outfits).
   - What to do with VWR tickets assigned to ProductEngine Team?

https://jira.secondlife.com/secure/IssueNavigator.jspa?mode=hide&requestId=13071
 Andrey Productengine
--

*PAST*

   - tiding my emails up after vacation
   - integrated tickets verification against the latest v-d build
   - test plans design: URLs, Sharing Inventory Items
   - started review of Sidebar TP

*FUTURE*

   - finish with Sidebar TP

*IMPEDIMENTS*

   - None.

Jonathan Yap
--

*PAST*

   - VWR-18435 Up arrow icon on nearby chat/speak buttons
  - Researched. If this is taken in I will work on it.
   - VWR-24357 "Less" is not dis

[opensource-dev] about texture saving issues

[Erin Mallory]

is the issue with saving textures only on macs? I'm not getting it on any 
windows build ive tried recently.. 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/68/#review111
---


Those lines have been missing since a long time: the first version in hg is 
already missing them:
https://bitbucket.org/lindenlab/viewer-development/changeset/07304583316d

- Merov


On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/68/
> ---
> 
> (Updated Dec. 29, 2010, 3:42 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Environment: Windows, VS 2005 Express
> 
> Back in the days of v2.1 I was able to supply the following option to 
> develop.py, which would allow me to specify the location of
> msvcr80.dll
> msvcp80.dll
> Microsoft.VC80.CRT.manifest
> 
> -DMSVC_REDIST_PATH:PATH=E:/some/path
> 
> There was a similar code path for the debug files
> -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> This files cannot be found by the Express compiler so without a way of 
> telling the compiler where to find them they have to be dropped into the 
> build tree manually.
> 
> At some point Copy3rdPartyLibs.cmake was rewritten and this option was 
> dropped.
> 
> 
> This addresses bug vwr-24347.
> http://jira.secondlife.com/browse/vwr-24347
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake 27dae7b01a81 
> 
> Diff: http://codereview.secondlife.com/r/68/diff
> 
> 
> Testing
> ---
> 
> I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express 
> compiler and obtained the desired result. 
> 
> I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory incremental search (VWR-23712)

[Carlo Wood]

One reason that it's collecting dust might be that it isn't know
if the author of the patch signed the Contribution Argeement.

On Tue, Jan 04, 2011 at 03:32:45PM +0100, Satomi Ahn wrote:
> Hello and happy new year.
> 
> I hate spamming this list, but there is an easy bug I'd like to see
> fixed in the viewer, and which seems to have been only taking dust in
> the JIRA for two entire months.
> 
> This is about one of the bugs who contribute to the general feeling of
> sluggishness in Viewer 2, so I believe you should really consider
> inclusion in viewer-development ;-).
> 
> Enough spoken, everything is there, patch included:
> https://jira.secondlife.com/browse/VWR-23712
> 
> -- 
> Satomi Ahn
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

-- 
Carlo Wood 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges