Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review957 --- Ship it! I don't agree with your early return rationale, but let's just go with this. - Oz On Aug. 5, 2011, 1:34 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/432/ > --- > > (Updated Aug. 5, 2011, 1:34 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed a debug assertion triggered in the world map floater. > > Apparently, passing empty region name to the MapNameRequest makes server > return > empty name in MapBlockReply, which triggered the assertion. > > > Diffs > - > > indra/newview/llfloaterworldmap.cpp 0fd2a1181a96 > > Diff: http://codereview.secondlife.com/r/432/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Concerned about frequent crashes
This could be SH-2218, which was fixed in 2.8.1 HOTFIX release. At least for the Mac OS crashes. Try that build? We're actively investigating crashes, so thank you for following up on yours! grumpity 2011/8/7 Ardy Lay > Sounds like you folks are fighting with > https://jira.secondlife.com/browse/SH-1650 > (SH-1650) [PUBLIC_JIRA_USERS] Widespread crash-to-desktop via > llvertexbuffer.cpp(1005) - "memory allocation for vertex data failed" or > Render Pool 15 > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Collecting DIDN'T CRASH data
I just had a sort of strange idea, but maybe this is alrady common practice. Just thought I would ask. Collect data about viewers that didn't crash. After some time cutoff, send the didn't crash data (with permission of the user, of course) to a repository. Then, when you have a bunch of Crash Reports, you could compare them to the didn't crash reports from similar hardware/OS/Version, and maybe some pattern would pop out. Such as VBO *and* AA crashes, or whatever. Just a thought. Cannot stop my brain. Best I can do is to not inflict it on everyone else too often. You all owe me more than you know. 8-) ponzu ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review959 --- Ship it! > The assert will not be in issue for release builds. > Triggering it in debug builds help catching bugs, as in this case. > Besides, the assert was added in attempt to locate another bug (EXT-4568), so > I'd just leave it. Sounds reasonable. - Boroondas On Aug. 5, 2011, 1:34 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/432/ > --- > > (Updated Aug. 5, 2011, 1:34 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed a debug assertion triggered in the world map floater. > > Apparently, passing empty region name to the MapNameRequest makes server > return > empty name in MapBlockReply, which triggered the assertion. > > > Diffs > - > > indra/newview/llfloaterworldmap.cpp 0fd2a1181a96 > > Diff: http://codereview.secondlife.com/r/432/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/ --- (Updated Aug. 8, 2011, 10:51 a.m.) Review request for Viewer. Changes --- Fixed JIRA ticket reference. Summary --- Fixed a debug assertion triggered in the world map floater. Apparently, passing empty region name to the MapNameRequest makes server return empty name in MapBlockReply, which triggered the assertion. This addresses bug STORM-1427. http://jira.secondlife.com/browse/STORM-1427 Diffs - indra/newview/llfloaterworldmap.cpp 0fd2a1181a96 Diff: http://codereview.secondlife.com/r/432/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Compile Error llmeshrepository.cpp in 3.0.1
Using Ubuntu 32 11.04 GCC 4.5 building with ReleaseOS /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp: In member function ‘void LLPhysicsDecomp::setMeshData(LLCDMeshData&, bool)’: /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp:2921:80: error: no matching function for call to ‘LLConvexDecomposition::setMeshData(LLCDMeshData*, bool&)’ /home/mysty/sl004/viewer-development/build-linux-i686/packages/include/llconvexdecomposition.h:178:21: note: candidate is: virtual LLCDResult LLConvexDecomposition::setMeshData(const LLCDMeshData*) /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp: In member function ‘void LLPhysicsDecomp::doDecompositionSingleHull()’: /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp:3132:27: error: ‘class LLConvexDecomposition’ has no member named ‘buildSingleHull’ /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp:3149:10: error: ‘class LLConvexDecomposition’ has no member named ‘getSingleHull’ make[2]: *** [newview/CMakeFiles/secondlife-bin.dir/llmeshrepository.o] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [newview/CMakeFiles/secondlife-bin.dir/all] Error 2 make: *** [all] Error 2 ERROR: building default configuration returned 2 For more information: try re-running your command with --verbose or --debug ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Compile Error llmeshrepository.cpp in 3.0.1
Please till the Jira issues concerning llconvexdecomposition are done and accepted to the LL repositories please loacly build and use the following repository and also use the file url method to point to the package you generate. Repository URL: https://bitbucket.org/WolfpupL/llconvexdecompositionos/overview From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Mysty Saunders Sent: Monday, August 08, 2011 2:47 PM To: opensource-dev@lists.secondlife.com Subject: [opensource-dev] Compile Error llmeshrepository.cpp in 3.0.1 Using Ubuntu 32 11.04 GCC 4.5 building with ReleaseOS /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp: In member function 'void LLPhysicsDecomp::setMeshData(LLCDMeshData&, bool)': /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp:2921 :80: error: no matching function for call to 'LLConvexDecomposition::setMeshData(LLCDMeshData*, bool&)' /home/mysty/sl004/viewer-development/build-linux-i686/packages/include/llcon vexdecomposition.h:178:21: note: candidate is: virtual LLCDResult LLConvexDecomposition::setMeshData(const LLCDMeshData*) /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp: In member function 'void LLPhysicsDecomp::doDecompositionSingleHull()': /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp:3132 :27: error: 'class LLConvexDecomposition' has no member named 'buildSingleHull' /home/mysty/sl004/viewer-development/indra/newview/llmeshrepository.cpp:3149 :10: error: 'class LLConvexDecomposition' has no member named 'getSingleHull' make[2]: *** [newview/CMakeFiles/secondlife-bin.dir/llmeshrepository.o] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [newview/CMakeFiles/secondlife-bin.dir/all] Error 2 make: *** [all] Error 2 ERROR: building default configuration returned 2 For more information: try re-running your command with --verbose or --debug _ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1391 / Virus Database: 1520/3821 - Release Date: 08/08/11 ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/433/ --- Review request for Viewer. Summary --- Disallow showing URL-like avatar display names as Web links in the ShareItemsConfirmation notification. Updating the tag parsing regexp to enable multiple ... clauses in a single textbox. This addresses bug STORM-632. http://jira.secondlife.com/browse/STORM-632 Diffs - indra/llui/llurlentry.cpp 99a6889a65ec indra/newview/skins/default/xui/en/notifications.xml 99a6889a65ec Diff: http://codereview.secondlife.com/r/433/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
