[opensource-dev] Should these be Jira'd?

[Lee ponzu]

Viewer startup blindness

What happens:  Worst in a dark room.  Start the viewer.  White screen, ouch
it hurts my eyes, but then it goes black.  Then it is WHITE again.  Damn.
 Finally, stuff starts to appear, but there is still a lot of WHITE.

What should happen:  Not sure.  UX experts must know.  But maybe start
black and stay black where possible, or at least some subdued shade. Dark
in a bright room is not so bad.  Bright in a dark room is a killer.


Hiding  controls

On my Mac, command-shift-U hides the user interface controls.  It also
zoomz in, which is distracting and also defeats the purpose of making more
screen visible.

What I expect.  Controls disappear, nothing else changes.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Lee ponzu]

An audio glitch I hate...

Listening music in SL, I often turn the SL volume down quite a bit.  When I
exit SL, the music stream continues for a few seconds as SL closes, but AT
FULL VOLUME.

it wakes up the dog.

Ponzu

On Wed, Nov 23, 2011 at 5:59 AM, Jonathan Yap  wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
>   Review request for Viewer.
> By Jonathan Yap.
> Description
>
> Audio fading in has been added for when a music stream starts.  Audio fading 
> out has been added for when there is a change in the music stream that is 
> playing.
>
> Two dead files have been eliminated.
>
> An existing bug in how music was not being paused correctly has been fixed.
>
> When you are teleporting you will hear the music stream from the place you 
> are leaving.  This is a change in behavior; previously the music stream was 
> stopped when the teleport progress bar was being displayed.
>
> This code change affects several areas where music is started or stopped.  
> The new code has evolved significantly, so please look for things that might 
> not "make sense."
>
>   Testing
>
> See the massive test plan in the jira.
>
>   *Bugs: * STORM-591 
> Diffs
>
>- doc/contributions.txt (8b455c1b7a5e)
>- indra/newview/lloverlaybar.h (8b455c1b7a5e)
>- indra/newview/lloverlaybar.cpp (8b455c1b7a5e)
>- indra/newview/llpanelnearbymedia.h (8b455c1b7a5e)
>- indra/newview/llpanelnearbymedia.cpp (8b455c1b7a5e)
>- indra/newview/llvieweraudio.h (8b455c1b7a5e)
>- indra/newview/llvieweraudio.cpp (8b455c1b7a5e)
>- indra/newview/llviewermedia.cpp (8b455c1b7a5e)
>- indra/newview/llviewerparcelmgr.cpp (8b455c1b7a5e)
>
> View Diff 
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Should these be Jira'd?

[Oz Linden (Scott Lawrence)]

On 2011-12-01 10:51, Lee ponzu wrote:
> Viewer startup blindness
>
> What happens:  Worst in a dark room.  Start the viewer.  White screen, 
> ouch it hurts my eyes, but then it goes black.  Then it is WHITE 
> again.  Damn.  Finally, stuff starts to appear, but there is still a 
> lot of WHITE.
>
> What should happen:  Not sure.  UX experts must know.  But maybe start 
> black and stay black where possible, or at least some subdued shade. 
> Dark in a bright room is not so bad.  Bright in a dark room is a killer.

I can't see this becoming a high priority item, but submit away.   I 
suggest that you not use the term 'blindness'.

> Hiding  controls
>
> On my Mac, command-shift-U hides the user interface controls.  It also 
> zoomz in, which is distracting and also defeats the purpose of making 
> more screen visible.
>
> What I expect.  Controls disappear, nothing else changes.

I have not used that feature much, but I agree that the current behavior 
isn't right, so create the issue.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] codereview site upgraded

[Oz Linden (Scott Lawrence)]

I've upgraded codereview.secondlife.com to version 1.6.3 of 
ReviewBoard.  Let me know if this causes any problems...

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: storm-1686: add the "Neck" and "Avatar Center" attach points to the Torso choices in context menus

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/522/
---

Review request for Viewer.


Description
---

The original change for adding these new points put them in a new group, which 
was then not also implemented in the code.  The simplest way to add them to the 
context menus (both when right clicking on either the avatar or an in-world 
object) is to put them in the Torso group.


This addresses bug storm-1686.
http://jira.secondlife.com/browse/storm-1686


Diffs
-

  indra/newview/character/avatar_lad.xml a984f7ffeb4b 

Diff: http://codereview.secondlife.com/r/522/diff/diff


Testing
---

Put things on and took them off again using the context menus.


Thanks,

Oz Linden

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: storm-1686: add the "Neck" and "Avatar Center" attach points to the Torso choices in context menus

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/522/#review1103
---

Ship it!


The torso group makes semantically sense for these two new points, anyway, I 
think.

- Boroondas Gupte


On Dec. 1, 2011, 10:20 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/522/
> ---
> 
> (Updated Dec. 1, 2011, 10:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> The original change for adding these new points put them in a new group, 
> which was then not also implemented in the code.  The simplest way to add 
> them to the context menus (both when right clicking on either the avatar or 
> an in-world object) is to put them in the Torso group.
> 
> 
> This addresses bug storm-1686.
> http://jira.secondlife.com/browse/storm-1686
> 
> 
> Diffs
> -
> 
>   indra/newview/character/avatar_lad.xml a984f7ffeb4b 
> 
> Diff: http://codereview.secondlife.com/r/522/diff/diff
> 
> 
> Testing
> ---
> 
> Put things on and took them off again using the context menus.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Callum Prentice]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/#review1104
---

Ship it!


Looks good. Nice job overall bringing the pieces together and excellent test 
plan.


indra/newview/llvieweraudio.cpp


Minor point - maybe a warning where you define the fade in/out times that 
they should not be zero, even for testing.


- Callum Prentice


On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
> ---
> 
> (Updated Nov. 23, 2011, 5:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Audio fading in has been added for when a music stream starts.  Audio fading 
> out has been added for when there is a change in the music stream that is 
> playing.
> 
> Two dead files have been eliminated.
> 
> An existing bug in how music was not being paused correctly has been fixed.
> 
> When you are teleporting you will hear the music stream from the place you 
> are leaving.  This is a change in behavior; previously the music stream was 
> stopped when the teleport progress bar was being displayed.
> 
> This code change affects several areas where music is started or stopped.  
> The new code has evolved significantly, so please look for things that might 
> not "make sense."
> 
> 
> This addresses bug STORM-591.
> http://jira.secondlife.com/browse/STORM-591
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/lloverlaybar.h 8b455c1b7a5e 
>   indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
>   indra/newview/llvieweraudio.h 8b455c1b7a5e 
>   indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
>   indra/newview/llviewermedia.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/520/diff/diff
> 
> 
> Testing
> ---
> 
> See the massive test plan in the jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Callum Prentice]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/#review1105
---

Ship it!


Ship It!

- Callum Prentice


On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
> ---
> 
> (Updated Nov. 23, 2011, 5:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Audio fading in has been added for when a music stream starts.  Audio fading 
> out has been added for when there is a change in the music stream that is 
> playing.
> 
> Two dead files have been eliminated.
> 
> An existing bug in how music was not being paused correctly has been fixed.
> 
> When you are teleporting you will hear the music stream from the place you 
> are leaving.  This is a change in behavior; previously the music stream was 
> stopped when the teleport progress bar was being displayed.
> 
> This code change affects several areas where music is started or stopped.  
> The new code has evolved significantly, so please look for things that might 
> not "make sense."
> 
> 
> This addresses bug STORM-591.
> http://jira.secondlife.com/browse/STORM-591
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/lloverlaybar.h 8b455c1b7a5e 
>   indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
>   indra/newview/llvieweraudio.h 8b455c1b7a5e 
>   indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
>   indra/newview/llviewermedia.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/520/diff/diff
> 
> 
> Testing
> ---
> 
> See the massive test plan in the jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges