[openssl-commits] Fixed: openssl/openssl#6120 (OpenSSL_1_1_0-stable - e749896)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6120
Status: Fixed

Duration: 37 minutes and 12 seconds
Commit: e749896 (OpenSSL_1_1_0-stable)
Author: Andy Polyakov
Message: rand/randfile.c: treat empty string in RAND_file_name as error.

Suggested in GH#1589.

Reviewed-by: Rich Salz 
(cherry picked from commit 7dc0ad4d6dca81a003be7fa1fbd58a55f4be8646)

View the changeset: 
https://github.com/openssl/openssl/compare/7b368cd6d964...e7498968e229

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161720862

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2023 (oss_constify_api - 6c6c097)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2023
Status: Still Failing

Duration: 36 minutes and 45 seconds
Commit: 6c6c097 (oss_constify_api)
Author: FdaSilvaYY
Message: Fix msie_hack compilation hack...

 from previous commit.

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/864c83d96423...6c6c097089f5

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161757807

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Errored: openssl/openssl#6119 (master - 7dc0ad4)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6119
Status: Errored

Duration: 36 minutes and 24 seconds
Commit: 7dc0ad4 (master)
Author: Andy Polyakov
Message: rand/randfile.c: treat empty string in RAND_file_name as error.

Suggested in GH#1589.

Reviewed-by: Rich Salz 

View the changeset: 
https://github.com/openssl/openssl/compare/776e15f9393a...7dc0ad4d6dca

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161720564

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2021 (oss-vpm-rework - e9ec483)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2021
Status: Still Failing

Duration: 46 minutes and 37 seconds
Commit: e9ec483 (oss-vpm-rework)
Author: FdaSilvaYY
Message: Reduce X509_VERIFY_PARAM_new/X509_VERIFY_PARAM_free code amount

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/0512adb80742...e9ec48303029

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161755102

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Errored: FdaSilvaYY/openssl#2022 (oss_constify_api - 864c83d)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2022
Status: Errored

Duration: 5 minutes and 59 seconds
Commit: 864c83d (oss_constify_api)
Author: FdaSilvaYY
Message: Fix msie_hack compilation hack...

 from previous commit.

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/094a3dcc1dd5...864c83d96423

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161755598

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Errored: openssl/openssl#6118 (OpenSSL_1_0_2-stable - 006a788)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6118
Status: Errored

Duration: 22 minutes and 51 seconds
Commit: 006a788 (OpenSSL_1_0_2-stable)
Author: Dr. Stephen Henson
Message: Make message buffer slightly larger than message.

Grow TLS/DTLS 16 bytes more than strictly necessary as a precaution against
OOB reads. In most cases this will have no effect because the message buffer
will be large enough already.

Reviewed-by: Matt Caswell 

View the changeset: 
https://github.com/openssl/openssl/compare/62841a2350f7...006a788c84e5

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161717687

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2020 (const-app-options - a75d659)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2020
Status: Still Failing

Duration: 42 minutes and 21 seconds
Commit: a75d659 (const-app-options)
Author: FdaSilvaYY
Message: Constify char* input parameters in apps/ca code

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/7218c19ee083...a75d6591bcb3

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161754855

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Fixed: openssl/openssl#6115 (OpenSSL_1_1_0-stable - 7b368cd)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6115
Status: Fixed

Duration: 44 minutes and 55 seconds
Commit: 7b368cd (OpenSSL_1_1_0-stable)
Author: Rich Salz
Message: Dcoument -alpn flag

Reviewed-by: Richard Levitte 
(cherry picked from commit 776e15f9393a9e3083bec60a8da376ce2fe1e97e)

View the changeset: 
https://github.com/openssl/openssl/compare/bf0404fe4afe...7b368cd6d964

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161660115

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2019 (fix-ca-buf-usage - 13aeb3d)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2019
Status: Still Failing

Duration: 40 minutes and 29 seconds
Commit: 13aeb3d (fix-ca-buf-usage)
Author: FdaSilvaYY
Message: Introduce PATH_MAX and NAME_MAX

 to define the certificate filename storage buffer.

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/349ebc550f46...13aeb3d6cc4e

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161754474

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Fixed: openssl/openssl#6115 (master - 776e15f)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6115
Status: Fixed

Duration: 1 hour, 34 minutes, and 38 seconds
Commit: 776e15f (master)
Author: Rich Salz
Message: Dcoument -alpn flag

Reviewed-by: Richard Levitte 

View the changeset: 
https://github.com/openssl/openssl/compare/6fcace45bda1...776e15f9393a

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161660088

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2018 (check_bn_wexpand_retcode - cad4895)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2018
Status: Still Failing

Duration: 56 minutes and 15 seconds
Commit: cad4895 (check_bn_wexpand_retcode)
Author: FdaSilvaYY
Message: Add missing checks on BN_copy return value

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/239397d92ea3...cad489529990

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161754222

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2017 (master - 372025c)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2017
Status: Still Failing

Duration: 34 minutes and 50 seconds
Commit: 372025c (master)
Author: FdaSilvaYY
Message: Clean whitespaces on line ending

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/5182123cc4a1...372025c54b65

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161754077

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Still Failing: FdaSilvaYY/openssl#2016 (oss_builds_options_check - e48d06b)

[Travis CI]

Build Update for FdaSilvaYY/openssl
-

Build: #2016
Status: Still Failing

Duration: 2 hours, 19 minutes, and 52 seconds
Commit: e48d06b (oss_builds_options_check)
Author: FdaSilvaYY
Message: Add a full no-* options build

View the changeset: 
https://github.com/FdaSilvaYY/openssl/compare/667db9ac412c...e48d06b55fcf

View the full build log and details: 
https://travis-ci.org/FdaSilvaYY/openssl/builds/161751896

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Build completed: openssl 1.0.1302

[AppVeyor]

Build openssl 1.0.1302 completed



Commit 6c6c097089 by FdaSilvaYY on 9/21/2016 9:23 PM:

Fix msie_hack compilation hack...


Configure your notification preferences

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Build failed: openssl 1.0.1301

[AppVeyor]

Build openssl 1.0.1301 failed


Commit 864c83d964 by FdaSilvaYY on 9/21/2016 9:18 PM:

Fix msie_hack compilation hack...


Configure your notification preferences

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Fixed: openssl/openssl#6113 (OpenSSL_1_1_0-stable - bf0404f)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6113
Status: Fixed

Duration: 2 hours, 11 minutes, and 15 seconds
Commit: bf0404f (OpenSSL_1_1_0-stable)
Author: Rich Salz
Message: GH1555: Don't bump size on realloc failure

Reviewed-by: Richard Levitte 
(cherry picked from commit 6fcace45bda108ad4d3f95261494dd479720d92c)

View the changeset: 
https://github.com/openssl/openssl/compare/64d1cc09f912...bf0404fe4afe

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161647874

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Fixed: openssl/openssl#6112 (master - 6fcace4)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6112
Status: Fixed

Duration: 17 minutes and 53 seconds
Commit: 6fcace4 (master)
Author: Rich Salz
Message: GH1555: Don't bump size on realloc failure

Reviewed-by: Richard Levitte 

View the changeset: 
https://github.com/openssl/openssl/compare/4588cb444355...6fcace45bda1

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161647739

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Andy Polyakov]

The branch OpenSSL_1_1_0-stable has been updated
   via  db610cb29cd2658c4feb60f4899856f0ac5e9dab (commit)
  from  df6b5e29ffea2d5a3e08de92fb765fdb21c7a21e (commit)


- Log -
commit db610cb29cd2658c4feb60f4899856f0ac5e9dab
Author: Andy Polyakov 
Date:   Wed Sep 21 22:05:12 2016 +0200

CHANGES: mention removal of solaris-x86-cc.

Reviewed-by: Rich Salz 

---

Summary of changes:
 CHANGES | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/CHANGES b/CHANGES
index 8b0e21f..9fc7bfb 100644
--- a/CHANGES
+++ b/CHANGES
@@ -4,7 +4,14 @@
 
  Changes between 1.1.0 and 1.1.0a [xx XXX ]
 
-  *)
+  *) solaris-x86-cc, i.e. 32-bit configuration with vendor compiler,
+ had to be removed. Primary reason is that vendor assembler can't
+ assemble our modules with -KPIC flag. As result it, assembly
+ support, was not even available as option. But its lack means
+ lack of side-channel resistant code, which is incompatible with
+ security by todays standards. Fortunately gcc is readily available
+ prepackaged option, which we firmly point at...
+ [Andy Polyakov]
 
  Changes between 1.0.2h and 1.1.0  [25 Aug 2016]
 
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_0_1-stable update

[Dr . Stephen Henson]

The branch OpenSSL_1_0_1-stable has been updated
   via  151adf2e5cc23284a059e0f155505006a1c9fad9 (commit)
  from  bb1a4866034255749ac578adb06a76335fc117b1 (commit)


- Log -
commit 151adf2e5cc23284a059e0f155505006a1c9fad9
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 20:19:31 2016 +0100

update default dependency options

Reviewed-by: Rich Salz 

---

Summary of changes:
 Configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Configure b/Configure
index 93c4cc1..6a50cb1 100755
--- a/Configure
+++ b/Configure
@@ -741,7 +741,7 @@ my @experimental = ();
 
 # This is what $depflags will look like with the above defaults
 # (we need this to see if we should advise the user to run "make depend"):
-my $default_depflags = " -DOPENSSL_NO_EC_NISTP_64_GCC_128 -DOPENSSL_NO_GMP 
-DOPENSSL_NO_JPAKE -DOPENSSL_NO_MD2 -DOPENSSL_NO_RC5 -DOPENSSL_NO_RFC3779 
-DOPENSSL_NO_SCTP -DOPENSSL_NO_STORE -DOPENSSL_NO_UNIT_TEST";
+my $default_depflags = " -DOPENSSL_NO_EC_NISTP_64_GCC_128 -DOPENSSL_NO_GMP 
-DOPENSSL_NO_JPAKE -DOPENSSL_NO_MD2 -DOPENSSL_NO_RC5 -DOPENSSL_NO_RFC3779 
-DOPENSSL_NO_SCTP -DOPENSSL_NO_SSL2 -DOPENSSL_NO_STORE -DOPENSSL_NO_UNIT_TEST 
-DOPENSSL_NO_WEAK_SSL_CIPHERS";
 
 # Explicit "no-..." options will be collected in %disabled along with the 
defaults.
 # To remove something from %disabled, use "enable-foo" (unless it's 
experimental).
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Build completed: openssl master.5444

[AppVeyor]

Build openssl master.5444 completed



Commit 6fcace45bd by Rich Salz on 9/21/2016 2:40 PM:

GH1555: Don't bump size on realloc failure


Configure your notification preferences

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Matt Caswell]

The branch OpenSSL_1_1_0-stable has been updated
   via  df6b5e29ffea2d5a3e08de92fb765fdb21c7a21e (commit)
   via  4b390b6c3f8df925dc92a3dd6b022baa9a2f4650 (commit)
  from  f757ce2a3df9c16c2ddbf83bf1725f6a89bccade (commit)


- Log -
commit df6b5e29ffea2d5a3e08de92fb765fdb21c7a21e
Author: Matt Caswell 
Date:   Mon Sep 19 11:57:07 2016 +0100

Excessive allocation of memory in dtls1_preprocess_fragment()

This issue is very similar to CVE-2016-6307 described in the previous
commit. The underlying defect is different but the security analysis and
impacts are the same except that it impacts DTLS.

A DTLS message includes 3 bytes for its length in the header for the
message.
This would allow for messages up to 16Mb in length. Messages of this length
are excessive and OpenSSL includes a check to ensure that a peer is sending
reasonably sized messages in order to avoid too much memory being consumed
to service a connection. A flaw in the logic of version 1.1.0 means that
memory for the message is allocated too early, prior to the excessive
message length check. Due to way memory is allocated in OpenSSL this could
mean an attacker could force up to 21Mb to be allocated to service a
connection. This could lead to a Denial of Service through memory
exhaustion. However, the excessive message length check still takes place,
and this would cause the connection to immediately fail. Assuming that the
application calls SSL_free() on the failed conneciton in a timely manner
then the 21Mb of allocated memory will then be immediately freed again.
Therefore the excessive memory allocation will be transitory in nature.
This then means that there is only a security impact if:

1) The application does not call SSL_free() in a timely manner in the
event that the connection fails
or
2) The application is working in a constrained environment where there
is very little free memory
or
3) The attacker initiates multiple connection attempts such that there
are multiple connections in a state where memory has been allocated for
the connection; SSL_free() has not yet been called; and there is
insufficient memory to service the multiple requests.

Except in the instance of (1) above any Denial Of Service is likely to
be transitory because as soon as the connection fails the memory is
subsequently freed again in the SSL_free() call. However there is an
increased risk during this period of application crashes due to the lack
of memory - which would then mean a more serious Denial of Service.

This issue does not affect TLS users.

Issue was reported by Shi Lei (Gear Team, Qihoo 360 Inc.).

CVE-2016-6308

Reviewed-by: Richard Levitte 
(cherry picked from commit 48c054fec3506417b2598837b8062aae7114c200)

commit 4b390b6c3f8df925dc92a3dd6b022baa9a2f4650
Author: Matt Caswell 
Date:   Mon Sep 19 11:39:21 2016 +0100

Excessive allocation of memory in tls_get_message_header()

A TLS message includes 3 bytes for its length in the header for the message.
This would allow for messages up to 16Mb in length. Messages of this length
are excessive and OpenSSL includes a check to ensure that a peer is sending
reasonably sized messages in order to avoid too much memory being consumed
to service a connection. A flaw in the logic of version 1.1.0 means that
memory for the message is allocated too early, prior to the excessive
message length check. Due to way memory is allocated in OpenSSL this could
mean an attacker could force up to 21Mb to be allocated to service a
connection. This could lead to a Denial of Service through memory
exhaustion. However, the excessive message length check still takes place,
and this would cause the connection to immediately fail. Assuming that the
application calls SSL_free() on the failed conneciton in a timely manner
then the 21Mb of allocated memory will then be immediately freed again.
Therefore the excessive memory allocation will be transitory in nature.
This then means that there is only a security impact if:

1) The application does not call SSL_free() in a timely manner in the
event that the connection fails
or
2) The application is working in a constrained environment where there
is very little free memory
or
3) The attacker initiates multiple connection attempts such that there
are multiple connections in a state where memory has been allocated for
the connection; SSL_free() has not yet been called; and there is
insufficient memory to service the multiple requests.

Except in the instance of (1) above any Denial Of Service is likely to
be transitory because as soon as the 

[openssl-commits] [openssl] master update

[Matt Caswell]

The branch master has been updated
   via  48c054fec3506417b2598837b8062aae7114c200 (commit)
   via  c1ef7c971d0bbf117c3c80f65b5875e2e7b024b1 (commit)
  from  41bff723c6784cc846054a4fd4add6dbec8c2c64 (commit)


- Log -
commit 48c054fec3506417b2598837b8062aae7114c200
Author: Matt Caswell 
Date:   Mon Sep 19 11:57:07 2016 +0100

Excessive allocation of memory in dtls1_preprocess_fragment()

This issue is very similar to CVE-2016-6307 described in the previous
commit. The underlying defect is different but the security analysis and
impacts are the same except that it impacts DTLS.

A DTLS message includes 3 bytes for its length in the header for the
message.
This would allow for messages up to 16Mb in length. Messages of this length
are excessive and OpenSSL includes a check to ensure that a peer is sending
reasonably sized messages in order to avoid too much memory being consumed
to service a connection. A flaw in the logic of version 1.1.0 means that
memory for the message is allocated too early, prior to the excessive
message length check. Due to way memory is allocated in OpenSSL this could
mean an attacker could force up to 21Mb to be allocated to service a
connection. This could lead to a Denial of Service through memory
exhaustion. However, the excessive message length check still takes place,
and this would cause the connection to immediately fail. Assuming that the
application calls SSL_free() on the failed conneciton in a timely manner
then the 21Mb of allocated memory will then be immediately freed again.
Therefore the excessive memory allocation will be transitory in nature.
This then means that there is only a security impact if:

1) The application does not call SSL_free() in a timely manner in the
event that the connection fails
or
2) The application is working in a constrained environment where there
is very little free memory
or
3) The attacker initiates multiple connection attempts such that there
are multiple connections in a state where memory has been allocated for
the connection; SSL_free() has not yet been called; and there is
insufficient memory to service the multiple requests.

Except in the instance of (1) above any Denial Of Service is likely to
be transitory because as soon as the connection fails the memory is
subsequently freed again in the SSL_free() call. However there is an
increased risk during this period of application crashes due to the lack
of memory - which would then mean a more serious Denial of Service.

This issue does not affect TLS users.

Issue was reported by Shi Lei (Gear Team, Qihoo 360 Inc.).

CVE-2016-6308

Reviewed-by: Richard Levitte 

commit c1ef7c971d0bbf117c3c80f65b5875e2e7b024b1
Author: Matt Caswell 
Date:   Mon Sep 19 11:39:21 2016 +0100

Excessive allocation of memory in tls_get_message_header()

A TLS message includes 3 bytes for its length in the header for the message.
This would allow for messages up to 16Mb in length. Messages of this length
are excessive and OpenSSL includes a check to ensure that a peer is sending
reasonably sized messages in order to avoid too much memory being consumed
to service a connection. A flaw in the logic of version 1.1.0 means that
memory for the message is allocated too early, prior to the excessive
message length check. Due to way memory is allocated in OpenSSL this could
mean an attacker could force up to 21Mb to be allocated to service a
connection. This could lead to a Denial of Service through memory
exhaustion. However, the excessive message length check still takes place,
and this would cause the connection to immediately fail. Assuming that the
application calls SSL_free() on the failed conneciton in a timely manner
then the 21Mb of allocated memory will then be immediately freed again.
Therefore the excessive memory allocation will be transitory in nature.
This then means that there is only a security impact if:

1) The application does not call SSL_free() in a timely manner in the
event that the connection fails
or
2) The application is working in a constrained environment where there
is very little free memory
or
3) The attacker initiates multiple connection attempts such that there
are multiple connections in a state where memory has been allocated for
the connection; SSL_free() has not yet been called; and there is
insufficient memory to service the multiple requests.

Except in the instance of (1) above any Denial Of Service is likely to
be transitory because as soon as the connection fails the memory is
subsequently freed again in the SSL_free() call. However 

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Andy Polyakov]

The branch OpenSSL_1_1_0-stable has been updated
   via  f757ce2a3df9c16c2ddbf83bf1725f6a89bccade (commit)
  from  1fdeda4cc994845998c9f017d300e6aecc7b5128 (commit)


- Log -
commit f757ce2a3df9c16c2ddbf83bf1725f6a89bccade
Author: Andy Polyakov 
Date:   Thu Sep 1 21:36:13 2016 +0200

Configure: clarify and refine -static.

Reviewed-by: Richard Levitte 
(cherry picked from commit 047d97afd97520eae268f6d8a36fbf9a0239a994)

---

Summary of changes:
 Configure | 17 +
 1 file changed, 17 insertions(+)

diff --git a/Configure b/Configure
index e919066..04efe67 100755
--- a/Configure
+++ b/Configure
@@ -66,6 +66,22 @@ my $usage="Usage: Configure [no- ...] 
[enable- ...] [-Dxxx] [-lx
 # no-sse2  disables IA-32 SSE2 code, above option implies no-sse2
 # no-   build without specified algorithm (rsa, idea, rc5, ...)
 # - + compiler options are passed through
+# -static   while -static is also a pass-through compiler option (and
+#   as such is limited to environments where it's actually
+#   meaningful), it triggers a number configuration options,
+#   namely no-dso, no-pic, no-shared and no-threads. It is
+#   argued that the only reason to produce statically linked
+#   binaries (and in context it means executables linked with
+#   -static flag, and not just executables linked with static
+#   libcrypto.a) is to eliminate dependency on specific run-time,
+#   a.k.a. libc version. The mentioned config options are meant
+#   to achieve just that. Unfortunately on Linux it's impossible
+#   to eliminate the dependency completely for openssl executable
+#   because of getaddrinfo and gethostbyname calls, which can
+#   invoke dynamically loadable library facility anyway to meet
+#   the lookup requests. For this reason on Linux statically
+#   linked openssl executable has rather debugging value than
+#   production quality.
 #
 # DEBUG_SAFESTACK use type-safe stacks to enforce type-safety on stack items
 #  provided to stack calls. Generates unique stack functions for
@@ -715,6 +731,7 @@ foreach (@argvcopy)
elsif (/^-static$/)
{
$libs.=$_." ";
+   $disabled{"dso"} = "forced";
$disabled{"pic"} = "forced";
$disabled{"shared"} = "forced";
$disabled{"threads"} = "forced";
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Matt Caswell]

The branch OpenSSL_1_1_0-stable has been updated
   via  1fdeda4cc994845998c9f017d300e6aecc7b5128 (commit)
  from  6915f39e68f02ad08a635516d46e72bbf0379914 (commit)


- Log -
commit 1fdeda4cc994845998c9f017d300e6aecc7b5128
Author: Matt Caswell 
Date:   Wed Sep 21 15:49:28 2016 +0100

Don't leak on an OPENSSL_realloc() failure

If OPENSSL_sk_insert() calls OPENSSL_realloc() and it fails, it was leaking
the originally allocated memory.

Reviewed-by: Rich Salz 
(cherry picked from commit 41bff723c6784cc846054a4fd4add6dbec8c2c64)

---

Summary of changes:
 crypto/stack/stack.c | 16 ++--
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/crypto/stack/stack.c b/crypto/stack/stack.c
index 1d01936..43ddf30 100644
--- a/crypto/stack/stack.c
+++ b/crypto/stack/stack.c
@@ -126,6 +126,7 @@ int OPENSSL_sk_insert(OPENSSL_STACK *st, const void *data, 
int loc)
 
 if (st->num_alloc <= (size_t)(st->num + 1)) {
 size_t doub_num_alloc = st->num_alloc * 2;
+const char **tmpdata;
 
 /* Overflow checks */
 if (doub_num_alloc < st->num_alloc)
@@ -135,17 +136,12 @@ int OPENSSL_sk_insert(OPENSSL_STACK *st, const void 
*data, int loc)
 if (doub_num_alloc > SIZE_MAX / sizeof(char *))
 return 0;
 
-st->data = OPENSSL_realloc((char *)st->data,
-   sizeof(char *) * doub_num_alloc);
-if (st->data == NULL) {
-/*
- * Reset these counters to prevent subsequent operations on
- * (now non-existing) heap memory
- */
-st->num_alloc = 0;
-st->num = 0;
+tmpdata = OPENSSL_realloc((char *)st->data,
+  sizeof(char *) * doub_num_alloc);
+if (tmpdata == NULL)
 return 0;
-}
+
+st->data = tmpdata;
 st->num_alloc = doub_num_alloc;
 }
 if ((loc >= st->num) || (loc < 0)) {
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Matt Caswell]

The branch master has been updated
   via  41bff723c6784cc846054a4fd4add6dbec8c2c64 (commit)
  from  af58be768ebb690f78530f796e92b8ae5c9a4401 (commit)


- Log -
commit 41bff723c6784cc846054a4fd4add6dbec8c2c64
Author: Matt Caswell 
Date:   Wed Sep 21 15:49:28 2016 +0100

Don't leak on an OPENSSL_realloc() failure

If OPENSSL_sk_insert() calls OPENSSL_realloc() and it fails, it was leaking
the originally allocated memory.

Reviewed-by: Rich Salz 

---

Summary of changes:
 crypto/stack/stack.c | 16 ++--
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/crypto/stack/stack.c b/crypto/stack/stack.c
index 1d01936..43ddf30 100644
--- a/crypto/stack/stack.c
+++ b/crypto/stack/stack.c
@@ -126,6 +126,7 @@ int OPENSSL_sk_insert(OPENSSL_STACK *st, const void *data, 
int loc)
 
 if (st->num_alloc <= (size_t)(st->num + 1)) {
 size_t doub_num_alloc = st->num_alloc * 2;
+const char **tmpdata;
 
 /* Overflow checks */
 if (doub_num_alloc < st->num_alloc)
@@ -135,17 +136,12 @@ int OPENSSL_sk_insert(OPENSSL_STACK *st, const void 
*data, int loc)
 if (doub_num_alloc > SIZE_MAX / sizeof(char *))
 return 0;
 
-st->data = OPENSSL_realloc((char *)st->data,
-   sizeof(char *) * doub_num_alloc);
-if (st->data == NULL) {
-/*
- * Reset these counters to prevent subsequent operations on
- * (now non-existing) heap memory
- */
-st->num_alloc = 0;
-st->num = 0;
+tmpdata = OPENSSL_realloc((char *)st->data,
+  sizeof(char *) * doub_num_alloc);
+if (tmpdata == NULL)
 return 0;
-}
+
+st->data = tmpdata;
 st->num_alloc = doub_num_alloc;
 }
 if ((loc >= st->num) || (loc < 0)) {
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Matt Caswell]

The branch OpenSSL_1_1_0-stable has been updated
   via  6915f39e68f02ad08a635516d46e72bbf0379914 (commit)
  from  e7498968e229a4ec27702a3703826873a279a07b (commit)


- Log -
commit 6915f39e68f02ad08a635516d46e72bbf0379914
Author: Matt Caswell 
Date:   Wed Sep 21 14:07:31 2016 +0100

Don't allow too many consecutive warning alerts

Certain warning alerts are ignored if they are received. This can mean that
no progress will be made if one peer continually sends those warning alerts.
Implement a count so that we abort the connection if we receive too many.

Issue reported by Shi Lei.

Reviewed-by: Rich Salz 
(cherry picked from commit af58be768ebb690f78530f796e92b8ae5c9a4401)

---

Summary of changes:
 include/openssl/ssl.h |  1 +
 ssl/record/rec_layer_d1.c | 16 
 ssl/record/rec_layer_s3.c | 16 
 ssl/record/record.h   |  2 ++
 ssl/record/record_locl.h  |  2 ++
 ssl/ssl_err.c |  1 +
 6 files changed, 38 insertions(+)

diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h
index 41cb36e..440b9a0 100644
--- a/include/openssl/ssl.h
+++ b/include/openssl/ssl.h
@@ -2482,6 +2482,7 @@ int ERR_load_SSL_strings(void);
 # define SSL_R_TLS_HEARTBEAT_PENDING  366
 # define SSL_R_TLS_ILLEGAL_EXPORTER_LABEL 367
 # define SSL_R_TLS_INVALID_ECPOINTFORMAT_LIST 157
+# define SSL_R_TOO_MANY_WARN_ALERTS   409
 # define SSL_R_UNABLE_TO_FIND_ECDH_PARAMETERS 314
 # define SSL_R_UNABLE_TO_FIND_PUBLIC_KEY_PARAMETERS   239
 # define SSL_R_UNABLE_TO_LOAD_SSL3_MD5_ROUTINES   242
diff --git a/ssl/record/rec_layer_d1.c b/ssl/record/rec_layer_d1.c
index cd582f3..2455c2b 100644
--- a/ssl/record/rec_layer_d1.c
+++ b/ssl/record/rec_layer_d1.c
@@ -443,6 +443,14 @@ int dtls1_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 }
 }
 
+/*
+ * Reset the count of consecutive warning alerts if we've got a non-empty
+ * record that isn't an alert.
+ */
+if (SSL3_RECORD_get_type(rr) != SSL3_RT_ALERT
+&& SSL3_RECORD_get_length(rr) != 0)
+s->rlayer.alert_count = 0;
+
 /* we now have a packet which can be read and processed */
 
 if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
@@ -722,6 +730,14 @@ int dtls1_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 
 if (alert_level == SSL3_AL_WARNING) {
 s->s3->warn_alert = alert_descr;
+
+s->rlayer.alert_count++;
+if (s->rlayer.alert_count == MAX_WARN_ALERT_COUNT) {
+al = SSL_AD_UNEXPECTED_MESSAGE;
+SSLerr(SSL_F_DTLS1_READ_BYTES, SSL_R_TOO_MANY_WARN_ALERTS);
+goto f_err;
+}
+
 if (alert_descr == SSL_AD_CLOSE_NOTIFY) {
 #ifndef OPENSSL_NO_SCTP
 /*
diff --git a/ssl/record/rec_layer_s3.c b/ssl/record/rec_layer_s3.c
index 46870c0..abde9d4 100644
--- a/ssl/record/rec_layer_s3.c
+++ b/ssl/record/rec_layer_s3.c
@@ -1063,6 +1063,14 @@ int ssl3_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 } while (num_recs == 0);
 rr = [curr_rec];
 
+/*
+ * Reset the count of consecutive warning alerts if we've got a non-empty
+ * record that isn't an alert.
+ */
+if (SSL3_RECORD_get_type(rr) != SSL3_RT_ALERT
+&& SSL3_RECORD_get_length(rr) != 0)
+s->rlayer.alert_count = 0;
+
 /* we now have a packet which can be read and processed */
 
 if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
@@ -1333,6 +1341,14 @@ int ssl3_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 if (alert_level == SSL3_AL_WARNING) {
 s->s3->warn_alert = alert_descr;
 SSL3_RECORD_set_read(rr);
+
+s->rlayer.alert_count++;
+if (s->rlayer.alert_count == MAX_WARN_ALERT_COUNT) {
+al = SSL_AD_UNEXPECTED_MESSAGE;
+SSLerr(SSL_F_SSL3_READ_BYTES, SSL_R_TOO_MANY_WARN_ALERTS);
+goto f_err;
+}
+
 if (alert_descr == SSL_AD_CLOSE_NOTIFY) {
 s->shutdown |= SSL_RECEIVED_SHUTDOWN;
 return (0);
diff --git a/ssl/record/record.h b/ssl/record/record.h
index a093aed..3e1530f 100644
--- a/ssl/record/record.h
+++ b/ssl/record/record.h
@@ -178,6 +178,8 @@ typedef struct record_layer_st {
 unsigned char write_sequence[SEQ_NUM_SIZE];
 /* Set to true if this is the first record in a connection */
 unsigned int is_first_record;
+/* Count of the number of consecutive warning alerts received */
+unsigned int alert_count;
 DTLS_RECORD_LAYER *d;
 } RECORD_LAYER;
 
diff --git a/ssl/record/record_locl.h 

[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

[Matt Caswell]

The branch OpenSSL_1_0_2-stable has been updated
   via  22646a075e75991b4e8f5d67171e45a6aead5b48 (commit)
  from  006a788c84e541c8920dd2ad85fb62b52185c519 (commit)


- Log -
commit 22646a075e75991b4e8f5d67171e45a6aead5b48
Author: Matt Caswell 
Date:   Wed Sep 21 14:48:16 2016 +0100

Don't allow too many consecutive warning alerts

Certain warning alerts are ignored if they are received. This can mean that
no progress will be made if one peer continually sends those warning alerts.
Implement a count so that we abort the connection if we receive too many.

Issue reported by Shi Lei.

Reviewed-by: Rich Salz 

---

Summary of changes:
 ssl/d1_pkt.c   | 15 +++
 ssl/s3_pkt.c   | 15 +++
 ssl/ssl.h  |  1 +
 ssl/ssl_locl.h |  4 
 4 files changed, 35 insertions(+)

diff --git a/ssl/d1_pkt.c b/ssl/d1_pkt.c
index df2e42e..7a02459 100644
--- a/ssl/d1_pkt.c
+++ b/ssl/d1_pkt.c
@@ -951,6 +951,13 @@ int dtls1_read_bytes(SSL *s, int type, unsigned char *buf, 
int len, int peek)
 goto start;
 }
 
+/*
+ * Reset the count of consecutive warning alerts if we've got a non-empty
+ * record that isn't an alert.
+ */
+if (rr->type != SSL3_RT_ALERT && rr->length != 0)
+s->cert->alert_count = 0;
+
 /* we now have a packet which can be read and processed */
 
 if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
@@ -1217,6 +1224,14 @@ int dtls1_read_bytes(SSL *s, int type, unsigned char 
*buf, int len, int peek)
 
 if (alert_level == SSL3_AL_WARNING) {
 s->s3->warn_alert = alert_descr;
+
+s->cert->alert_count++;
+if (s->cert->alert_count == MAX_WARN_ALERT_COUNT) {
+al = SSL_AD_UNEXPECTED_MESSAGE;
+SSLerr(SSL_F_DTLS1_READ_BYTES, SSL_R_TOO_MANY_WARN_ALERTS);
+goto f_err;
+}
+
 if (alert_descr == SSL_AD_CLOSE_NOTIFY) {
 #ifndef OPENSSL_NO_SCTP
 /*
diff --git a/ssl/s3_pkt.c b/ssl/s3_pkt.c
index df124cf..be37ef0 100644
--- a/ssl/s3_pkt.c
+++ b/ssl/s3_pkt.c
@@ -1229,6 +1229,13 @@ int ssl3_read_bytes(SSL *s, int type, unsigned char 
*buf, int len, int peek)
 return (ret);
 }
 
+/*
+ * Reset the count of consecutive warning alerts if we've got a non-empty
+ * record that isn't an alert.
+ */
+if (rr->type != SSL3_RT_ALERT && rr->length != 0)
+s->cert->alert_count = 0;
+
 /* we now have a packet which can be read and processed */
 
 if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
@@ -1443,6 +1450,14 @@ int ssl3_read_bytes(SSL *s, int type, unsigned char 
*buf, int len, int peek)
 
 if (alert_level == SSL3_AL_WARNING) {
 s->s3->warn_alert = alert_descr;
+
+s->cert->alert_count++;
+if (s->cert->alert_count == MAX_WARN_ALERT_COUNT) {
+al = SSL_AD_UNEXPECTED_MESSAGE;
+SSLerr(SSL_F_SSL3_READ_BYTES, SSL_R_TOO_MANY_WARN_ALERTS);
+goto f_err;
+}
+
 if (alert_descr == SSL_AD_CLOSE_NOTIFY) {
 s->shutdown |= SSL_RECEIVED_SHUTDOWN;
 return (0);
diff --git a/ssl/ssl.h b/ssl/ssl.h
index 2638755..90aeb0c 100644
--- a/ssl/ssl.h
+++ b/ssl/ssl.h
@@ -3107,6 +3107,7 @@ void ERR_load_SSL_strings(void);
 # define SSL_R_TLS_INVALID_ECPOINTFORMAT_LIST 157
 # define SSL_R_TLS_PEER_DID_NOT_RESPOND_WITH_CERTIFICATE_LIST 233
 # define SSL_R_TLS_RSA_ENCRYPTED_VALUE_LENGTH_IS_WRONG234
+# define SSL_R_TOO_MANY_WARN_ALERTS   409
 # define SSL_R_TRIED_TO_USE_UNSUPPORTED_CIPHER235
 # define SSL_R_UNABLE_TO_DECODE_DH_CERTS  236
 # define SSL_R_UNABLE_TO_DECODE_ECDH_CERTS313
diff --git a/ssl/ssl_locl.h b/ssl/ssl_locl.h
index e358031..6df725f 100644
--- a/ssl/ssl_locl.h
+++ b/ssl/ssl_locl.h
@@ -591,6 +591,8 @@ typedef struct {
  */
 # define SSL_EXT_FLAG_SENT   0x2
 
+# define MAX_WARN_ALERT_COUNT5
+
 typedef struct {
 custom_ext_method *meths;
 size_t meths_count;
@@ -698,6 +700,8 @@ typedef struct cert_st {
 unsigned char *alpn_proposed;   /* server */
 unsigned int alpn_proposed_len;
 int alpn_sent;  /* client */
+/* Count of the number of consecutive warning alerts received */
+unsigned int alert_count;
 } CERT;
 
 typedef struct sess_cert_st {
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Matt Caswell]

The branch master has been updated
   via  af58be768ebb690f78530f796e92b8ae5c9a4401 (commit)
  from  7dc0ad4d6dca81a003be7fa1fbd58a55f4be8646 (commit)


- Log -
commit af58be768ebb690f78530f796e92b8ae5c9a4401
Author: Matt Caswell 
Date:   Wed Sep 21 14:07:31 2016 +0100

Don't allow too many consecutive warning alerts

Certain warning alerts are ignored if they are received. This can mean that
no progress will be made if one peer continually sends those warning alerts.
Implement a count so that we abort the connection if we receive too many.

Issue reported by Shi Lei.

Reviewed-by: Rich Salz 

---

Summary of changes:
 include/openssl/ssl.h |  1 +
 ssl/record/rec_layer_d1.c | 16 
 ssl/record/rec_layer_s3.c | 16 
 ssl/record/record.h   |  2 ++
 ssl/record/record_locl.h  |  2 ++
 ssl/ssl_err.c |  1 +
 6 files changed, 38 insertions(+)

diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h
index 183296c..d127c76 100644
--- a/include/openssl/ssl.h
+++ b/include/openssl/ssl.h
@@ -2485,6 +2485,7 @@ int ERR_load_SSL_strings(void);
 # define SSL_R_TLS_HEARTBEAT_PENDING  366
 # define SSL_R_TLS_ILLEGAL_EXPORTER_LABEL 367
 # define SSL_R_TLS_INVALID_ECPOINTFORMAT_LIST 157
+# define SSL_R_TOO_MANY_WARN_ALERTS   409
 # define SSL_R_UNABLE_TO_FIND_ECDH_PARAMETERS 314
 # define SSL_R_UNABLE_TO_FIND_PUBLIC_KEY_PARAMETERS   239
 # define SSL_R_UNABLE_TO_LOAD_SSL3_MD5_ROUTINES   242
diff --git a/ssl/record/rec_layer_d1.c b/ssl/record/rec_layer_d1.c
index cd582f3..2455c2b 100644
--- a/ssl/record/rec_layer_d1.c
+++ b/ssl/record/rec_layer_d1.c
@@ -443,6 +443,14 @@ int dtls1_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 }
 }
 
+/*
+ * Reset the count of consecutive warning alerts if we've got a non-empty
+ * record that isn't an alert.
+ */
+if (SSL3_RECORD_get_type(rr) != SSL3_RT_ALERT
+&& SSL3_RECORD_get_length(rr) != 0)
+s->rlayer.alert_count = 0;
+
 /* we now have a packet which can be read and processed */
 
 if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
@@ -722,6 +730,14 @@ int dtls1_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 
 if (alert_level == SSL3_AL_WARNING) {
 s->s3->warn_alert = alert_descr;
+
+s->rlayer.alert_count++;
+if (s->rlayer.alert_count == MAX_WARN_ALERT_COUNT) {
+al = SSL_AD_UNEXPECTED_MESSAGE;
+SSLerr(SSL_F_DTLS1_READ_BYTES, SSL_R_TOO_MANY_WARN_ALERTS);
+goto f_err;
+}
+
 if (alert_descr == SSL_AD_CLOSE_NOTIFY) {
 #ifndef OPENSSL_NO_SCTP
 /*
diff --git a/ssl/record/rec_layer_s3.c b/ssl/record/rec_layer_s3.c
index 46870c0..abde9d4 100644
--- a/ssl/record/rec_layer_s3.c
+++ b/ssl/record/rec_layer_s3.c
@@ -1063,6 +1063,14 @@ int ssl3_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 } while (num_recs == 0);
 rr = [curr_rec];
 
+/*
+ * Reset the count of consecutive warning alerts if we've got a non-empty
+ * record that isn't an alert.
+ */
+if (SSL3_RECORD_get_type(rr) != SSL3_RT_ALERT
+&& SSL3_RECORD_get_length(rr) != 0)
+s->rlayer.alert_count = 0;
+
 /* we now have a packet which can be read and processed */
 
 if (s->s3->change_cipher_spec /* set when we receive ChangeCipherSpec,
@@ -1333,6 +1341,14 @@ int ssl3_read_bytes(SSL *s, int type, int *recvd_type, 
unsigned char *buf,
 if (alert_level == SSL3_AL_WARNING) {
 s->s3->warn_alert = alert_descr;
 SSL3_RECORD_set_read(rr);
+
+s->rlayer.alert_count++;
+if (s->rlayer.alert_count == MAX_WARN_ALERT_COUNT) {
+al = SSL_AD_UNEXPECTED_MESSAGE;
+SSLerr(SSL_F_SSL3_READ_BYTES, SSL_R_TOO_MANY_WARN_ALERTS);
+goto f_err;
+}
+
 if (alert_descr == SSL_AD_CLOSE_NOTIFY) {
 s->shutdown |= SSL_RECEIVED_SHUTDOWN;
 return (0);
diff --git a/ssl/record/record.h b/ssl/record/record.h
index a093aed..3e1530f 100644
--- a/ssl/record/record.h
+++ b/ssl/record/record.h
@@ -178,6 +178,8 @@ typedef struct record_layer_st {
 unsigned char write_sequence[SEQ_NUM_SIZE];
 /* Set to true if this is the first record in a connection */
 unsigned int is_first_record;
+/* Count of the number of consecutive warning alerts received */
+unsigned int alert_count;
 DTLS_RECORD_LAYER *d;
 } RECORD_LAYER;
 
diff --git a/ssl/record/record_locl.h b/ssl/record/record_locl.h
index 52e59e4..b69afd8 100644
--- 

[openssl-commits] [openssl] OpenSSL_1_0_1-stable update

[Dr . Stephen Henson]

The branch OpenSSL_1_0_1-stable has been updated
   via  bb1a4866034255749ac578adb06a76335fc117b1 (commit)
   via  8289755d54e4cf34d502c630613d1dba60e30830 (commit)
   via  aa388af1e18988894a48b8f64ae994eaa4366d5d (commit)
  from  52e623c4cb06fffa9d5e75c60b34b4bc130b12e9 (commit)


- Log -
commit bb1a4866034255749ac578adb06a76335fc117b1
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 13:26:01 2016 +0100

Make message buffer slightly larger than message.

Grow TLS/DTLS 16 bytes more than strictly necessary as a precaution against
OOB reads. In most cases this will have no effect because the message buffer
will be large enough already.

Reviewed-by: Matt Caswell 
(cherry picked from commit 006a788c84e541c8920dd2ad85fb62b52185c519)

commit 8289755d54e4cf34d502c630613d1dba60e30830
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 12:54:13 2016 +0100

Use SSL3_HM_HEADER_LENGTH instead of 4.

Reviewed-by: Matt Caswell 
(cherry picked from commit bc9563f83d28342b5ec0073ec12d9e581e4f3317)

commit aa388af1e18988894a48b8f64ae994eaa4366d5d
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 12:57:01 2016 +0100

Remove unnecessary check.

The overflow check will never be triggered because the
the n2l3 result is always less than 2^24.

Reviewed-by: Matt Caswell 
(cherry picked from commit 709ec8b3848e2ac201b86f49c5561debb8572ccd)

---

Summary of changes:
 ssl/d1_both.c |  5 -
 ssl/s3_both.c | 35 ---
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/ssl/d1_both.c b/ssl/d1_both.c
index ae292c4..0cf1e49 100644
--- a/ssl/d1_both.c
+++ b/ssl/d1_both.c
@@ -577,9 +577,12 @@ static int dtls1_preprocess_fragment(SSL *s, struct 
hm_header_st *msg_hdr,
 /*
  * msg_len is limited to 2^24, but is effectively checked against max
  * above
+ *
+ * Make buffer slightly larger than message length as a precaution
+ * against small OOB reads e.g. CVE-2016-6306
  */
 if (!BUF_MEM_grow_clean
-(s->init_buf, msg_len + DTLS1_HM_HEADER_LENGTH)) {
+(s->init_buf, msg_len + DTLS1_HM_HEADER_LENGTH + 16)) {
 SSLerr(SSL_F_DTLS1_PREPROCESS_FRAGMENT, ERR_R_BUF_LIB);
 return SSL_AD_INTERNAL_ERROR;
 }
diff --git a/ssl/s3_both.c b/ssl/s3_both.c
index c51fc6e..d798d83 100644
--- a/ssl/s3_both.c
+++ b/ssl/s3_both.c
@@ -427,21 +427,22 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, 
long max, int *ok)
 }
 *ok = 1;
 s->state = stn;
-s->init_msg = s->init_buf->data + 4;
+s->init_msg = s->init_buf->data + SSL3_HM_HEADER_LENGTH;
 s->init_num = (int)s->s3->tmp.message_size;
 return s->init_num;
 }
 
 p = (unsigned char *)s->init_buf->data;
 
-if (s->state == st1) {  /* s->init_num < 4 */
+if (s->state == st1) {  /* s->init_num < SSL3_HM_HEADER_LENGTH */
 int skip_message;
 
 do {
-while (s->init_num < 4) {
+while (s->init_num < SSL3_HM_HEADER_LENGTH) {
 i = s->method->ssl_read_bytes(s, SSL3_RT_HANDSHAKE,
   [s->init_num],
-  4 - s->init_num, 0);
+  SSL3_HM_HEADER_LENGTH -
+  s->init_num, 0);
 if (i <= 0) {
 s->rwstate = SSL_READING;
 *ok = 0;
@@ -465,12 +466,13 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, 
long max, int *ok)
 
 if (s->msg_callback)
 s->msg_callback(0, s->version, SSL3_RT_HANDSHAKE,
-p, 4, s, s->msg_callback_arg);
+p, SSL3_HM_HEADER_LENGTH, s,
+s->msg_callback_arg);
 }
 }
 while (skip_message);
 
-/* s->init_num == 4 */
+/* s->init_num == SSL3_HM_HEADER_LENGTH */
 
 if ((mt >= 0) && (*p != mt)) {
 al = SSL_AD_UNEXPECTED_MESSAGE;
@@ -497,19 +499,20 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, 
long max, int *ok)
 SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);
 goto f_err;
 }
-if (l > (INT_MAX - 4)) { /* BUF_MEM_grow takes an 'int' parameter */
-al = SSL_AD_ILLEGAL_PARAMETER;
-SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);
-goto f_err;
-}
-if (l && !BUF_MEM_grow_clean(s->init_buf, (int)l 

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Andy Polyakov]

The branch OpenSSL_1_1_0-stable has been updated
   via  e7498968e229a4ec27702a3703826873a279a07b (commit)
   via  13af417ba4f6b826833d4b1f6caa39c4e0013d6f (commit)
   via  098dc9be439e5bc3625e01c4092bedc072498da9 (commit)
  from  7b368cd6d964da817cd1de85fc0cae74372e0966 (commit)


- Log -
commit e7498968e229a4ec27702a3703826873a279a07b
Author: Andy Polyakov 
Date:   Tue Sep 20 17:08:03 2016 +0200

rand/randfile.c: treat empty string in RAND_file_name as error.

Suggested in GH#1589.

Reviewed-by: Rich Salz 
(cherry picked from commit 7dc0ad4d6dca81a003be7fa1fbd58a55f4be8646)

commit 13af417ba4f6b826833d4b1f6caa39c4e0013d6f
Author: Andy Polyakov 
Date:   Tue Sep 20 17:06:58 2016 +0200

rand/randfile.c: rationalize __OpenBSD__ code path.

Reviewed-by: Rich Salz 
(cherry picked from commit ba8fa4e53a35a0c46d1e0e81a4d270a026fac2b9)

commit 098dc9be439e5bc3625e01c4092bedc072498da9
Author: Andy Polyakov 
Date:   Tue Sep 20 16:59:32 2016 +0200

rand/randfile.c: restore fallback to $HOME for non-setuid programs.

Reported in GH#1589, but solution is different from suggested.

Reviewed-by: Rich Salz 
(cherry picked from commit 799c1293fcf412db64dcc8a09a6b11cc755914dc)

---

Summary of changes:
 crypto/rand/randfile.c | 18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/crypto/rand/randfile.c b/crypto/rand/randfile.c
index 7aeb871..c96383a 100644
--- a/crypto/rand/randfile.c
+++ b/crypto/rand/randfile.c
@@ -316,12 +316,14 @@ const char *RAND_file_name(char *buf, size_t size)
 }
 }
 #else
-if (OPENSSL_issetugid() == 0) {
-s = getenv("RANDFILE");
-} else {
+if (OPENSSL_issetugid() != 0) {
 use_randfile = 0;
-if (OPENSSL_issetugid() == 0)
+} else {
+s = getenv("RANDFILE");
+if (s == NULL || *s == '\0') {
+use_randfile = 0;
 s = getenv("HOME");
+}
 }
 #endif
 #ifdef DEFAULT_HOME
@@ -355,14 +357,10 @@ const char *RAND_file_name(char *buf, size_t size)
  * available.
  */
 
-if (!buf[0])
-if (OPENSSL_strlcpy(buf, "/dev/arandom", size) >= size) {
-return NULL;
-}
-if (stat(buf, ) == -1)
+if (!buf[0] || stat(buf, ) == -1)
 if (OPENSSL_strlcpy(buf, "/dev/arandom", size) >= size) {
 return NULL;
 }
 #endif
-return buf;
+return buf[0] ? buf : NULL;
 }
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Andy Polyakov]

The branch master has been updated
   via  7dc0ad4d6dca81a003be7fa1fbd58a55f4be8646 (commit)
   via  ba8fa4e53a35a0c46d1e0e81a4d270a026fac2b9 (commit)
   via  799c1293fcf412db64dcc8a09a6b11cc755914dc (commit)
  from  776e15f9393a9e3083bec60a8da376ce2fe1e97e (commit)


- Log -
commit 7dc0ad4d6dca81a003be7fa1fbd58a55f4be8646
Author: Andy Polyakov 
Date:   Tue Sep 20 17:08:03 2016 +0200

rand/randfile.c: treat empty string in RAND_file_name as error.

Suggested in GH#1589.

Reviewed-by: Rich Salz 

commit ba8fa4e53a35a0c46d1e0e81a4d270a026fac2b9
Author: Andy Polyakov 
Date:   Tue Sep 20 17:06:58 2016 +0200

rand/randfile.c: rationalize __OpenBSD__ code path.

Reviewed-by: Rich Salz 

commit 799c1293fcf412db64dcc8a09a6b11cc755914dc
Author: Andy Polyakov 
Date:   Tue Sep 20 16:59:32 2016 +0200

rand/randfile.c: restore fallback to $HOME for non-setuid programs.

Reported in GH#1589, but solution is different from suggested.

Reviewed-by: Rich Salz 

---

Summary of changes:
 crypto/rand/randfile.c | 18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/crypto/rand/randfile.c b/crypto/rand/randfile.c
index 7aeb871..c96383a 100644
--- a/crypto/rand/randfile.c
+++ b/crypto/rand/randfile.c
@@ -316,12 +316,14 @@ const char *RAND_file_name(char *buf, size_t size)
 }
 }
 #else
-if (OPENSSL_issetugid() == 0) {
-s = getenv("RANDFILE");
-} else {
+if (OPENSSL_issetugid() != 0) {
 use_randfile = 0;
-if (OPENSSL_issetugid() == 0)
+} else {
+s = getenv("RANDFILE");
+if (s == NULL || *s == '\0') {
+use_randfile = 0;
 s = getenv("HOME");
+}
 }
 #endif
 #ifdef DEFAULT_HOME
@@ -355,14 +357,10 @@ const char *RAND_file_name(char *buf, size_t size)
  * available.
  */
 
-if (!buf[0])
-if (OPENSSL_strlcpy(buf, "/dev/arandom", size) >= size) {
-return NULL;
-}
-if (stat(buf, ) == -1)
+if (!buf[0] || stat(buf, ) == -1)
 if (OPENSSL_strlcpy(buf, "/dev/arandom", size) >= size) {
 return NULL;
 }
 #endif
-return buf;
+return buf[0] ? buf : NULL;
 }
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

[Dr . Stephen Henson]

The branch OpenSSL_1_0_2-stable has been updated
   via  006a788c84e541c8920dd2ad85fb62b52185c519 (commit)
   via  bc9563f83d28342b5ec0073ec12d9e581e4f3317 (commit)
   via  709ec8b3848e2ac201b86f49c5561debb8572ccd (commit)
  from  62841a2350f76a5207376d581acec319196447d7 (commit)


- Log -
commit 006a788c84e541c8920dd2ad85fb62b52185c519
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 13:26:01 2016 +0100

Make message buffer slightly larger than message.

Grow TLS/DTLS 16 bytes more than strictly necessary as a precaution against
OOB reads. In most cases this will have no effect because the message buffer
will be large enough already.

Reviewed-by: Matt Caswell 

commit bc9563f83d28342b5ec0073ec12d9e581e4f3317
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 12:54:13 2016 +0100

Use SSL3_HM_HEADER_LENGTH instead of 4.

Reviewed-by: Matt Caswell 

commit 709ec8b3848e2ac201b86f49c5561debb8572ccd
Author: Dr. Stephen Henson 
Date:   Wed Sep 21 12:57:01 2016 +0100

Remove unnecessary check.

The overflow check will never be triggered because the
the n2l3 result is always less than 2^24.

Reviewed-by: Matt Caswell 

---

Summary of changes:
 ssl/d1_both.c |  5 -
 ssl/s3_both.c | 35 ---
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/ssl/d1_both.c b/ssl/d1_both.c
index 46c70d8..9bc6153 100644
--- a/ssl/d1_both.c
+++ b/ssl/d1_both.c
@@ -581,9 +581,12 @@ static int dtls1_preprocess_fragment(SSL *s, struct 
hm_header_st *msg_hdr,
 /*
  * msg_len is limited to 2^24, but is effectively checked against max
  * above
+ *
+ * Make buffer slightly larger than message length as a precaution
+ * against small OOB reads e.g. CVE-2016-6306
  */
 if (!BUF_MEM_grow_clean
-(s->init_buf, msg_len + DTLS1_HM_HEADER_LENGTH)) {
+(s->init_buf, msg_len + DTLS1_HM_HEADER_LENGTH + 16)) {
 SSLerr(SSL_F_DTLS1_PREPROCESS_FRAGMENT, ERR_R_BUF_LIB);
 return SSL_AD_INTERNAL_ERROR;
 }
diff --git a/ssl/s3_both.c b/ssl/s3_both.c
index 4b636b0..054ded1 100644
--- a/ssl/s3_both.c
+++ b/ssl/s3_both.c
@@ -356,21 +356,22 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, 
long max, int *ok)
 }
 *ok = 1;
 s->state = stn;
-s->init_msg = s->init_buf->data + 4;
+s->init_msg = s->init_buf->data + SSL3_HM_HEADER_LENGTH;
 s->init_num = (int)s->s3->tmp.message_size;
 return s->init_num;
 }
 
 p = (unsigned char *)s->init_buf->data;
 
-if (s->state == st1) {  /* s->init_num < 4 */
+if (s->state == st1) {  /* s->init_num < SSL3_HM_HEADER_LENGTH */
 int skip_message;
 
 do {
-while (s->init_num < 4) {
+while (s->init_num < SSL3_HM_HEADER_LENGTH) {
 i = s->method->ssl_read_bytes(s, SSL3_RT_HANDSHAKE,
   [s->init_num],
-  4 - s->init_num, 0);
+  SSL3_HM_HEADER_LENGTH -
+  s->init_num, 0);
 if (i <= 0) {
 s->rwstate = SSL_READING;
 *ok = 0;
@@ -394,12 +395,13 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, 
long max, int *ok)
 
 if (s->msg_callback)
 s->msg_callback(0, s->version, SSL3_RT_HANDSHAKE,
-p, 4, s, s->msg_callback_arg);
+p, SSL3_HM_HEADER_LENGTH, s,
+s->msg_callback_arg);
 }
 }
 while (skip_message);
 
-/* s->init_num == 4 */
+/* s->init_num == SSL3_HM_HEADER_LENGTH */
 
 if ((mt >= 0) && (*p != mt)) {
 al = SSL_AD_UNEXPECTED_MESSAGE;
@@ -415,19 +417,20 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, 
long max, int *ok)
 SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);
 goto f_err;
 }
-if (l > (INT_MAX - 4)) { /* BUF_MEM_grow takes an 'int' parameter */
-al = SSL_AD_ILLEGAL_PARAMETER;
-SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);
-goto f_err;
-}
-if (l && !BUF_MEM_grow_clean(s->init_buf, (int)l + 4)) {
+/*
+ * Make buffer slightly larger than message length as a precaution
+ * against small OOB reads e.g. CVE-2016-6306
+ */
+if (l
+&& 

[openssl-commits] Fixed: openssl/openssl#6110 (master - 4588cb4)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6110
Status: Fixed

Duration: 4 minutes and 48 seconds
Commit: 4588cb4 (master)
Author: Rich Salz
Message: Revert "Constify code about X509_VERIFY_PARAM"

This reverts commit 81f9ce1e1965e0e33db6d2391285c4c1b6af0434.

Reviewed-by: Matt Caswell 

View the changeset: 
https://github.com/openssl/openssl/compare/780bbb96bf51...4588cb444355

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161646582

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Fixed: openssl/openssl#6108 (master - 780bbb9)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6108
Status: Fixed

Duration: 31 minutes and 12 seconds
Commit: 780bbb9 (master)
Author: Richard Levitte
Message: test/x509aux.c: Fix argv loop

There are cases when argc is more trustable than proper argv termination.
Since we trust argc in all other test programs, we might as well treat it
the same way in this program.

Reviewed-by: Matt Caswell 

View the changeset: 
https://github.com/openssl/openssl/compare/3c106325292d...780bbb96bf51

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161640962

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Fixed: openssl/openssl#6107 (master - 3c10632)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6107
Status: Fixed

Duration: 41 minutes and 14 seconds
Commit: 3c10632 (master)
Author: Matt Caswell
Message: make update and fix some associated mis-matched error codes

Reviewed-by: Richard Levitte 

View the changeset: 
https://github.com/openssl/openssl/compare/1ff7425d6130...3c106325292d

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161626720

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Rich Salz]

The branch OpenSSL_1_1_0-stable has been updated
   via  7b368cd6d964da817cd1de85fc0cae74372e0966 (commit)
  from  bf0404fe4afe9ed1e09e11b2b8f82b9ec127de91 (commit)


- Log -
commit 7b368cd6d964da817cd1de85fc0cae74372e0966
Author: Rich Salz 
Date:   Wed Sep 21 10:59:15 2016 -0400

Dcoument -alpn flag

Reviewed-by: Richard Levitte 
(cherry picked from commit 776e15f9393a9e3083bec60a8da376ce2fe1e97e)

---

Summary of changes:
 doc/apps/s_client.pod | 9 +++--
 doc/apps/s_server.pod | 9 +++--
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/doc/apps/s_client.pod b/doc/apps/s_client.pod
index 34dcd29..7ad9811 100644
--- a/doc/apps/s_client.pod
+++ b/doc/apps/s_client.pod
@@ -95,6 +95,7 @@ B B
 [B<-rand file(s)>]
 [B<-serverinfo types>]
 [B<-status>]
+[B<-alpn protocols>]
 [B<-nextprotoneg protocols>]
 [B<-ct|noct>]
 [B<-ctlogfile>]
@@ -472,9 +473,13 @@ file.
 sends a certificate status request to the server (OCSP stapling). The server
 response (if any) is printed out.
 
-=item B<-nextprotoneg protocols>
+=item B<-alpn protocols>, B<-nextprotoneg protocols>
 
-enable Next Protocol Negotiation TLS extension and provide a list of
+these flags enable the 
+Enable the Application-Layer Protocol Negotiation or Next Protocol
+Negotiation extension, respectively. ALPN is the IETF standard and
+replaces NPN.
+The B list is a
 comma-separated protocol names that the client should advertise
 support for. The list should contain most wanted protocols first.
 Protocol names are printable ASCII strings, for example "http/1.1" or
diff --git a/doc/apps/s_server.pod b/doc/apps/s_server.pod
index bf4a4ab..b0d7888 100644
--- a/doc/apps/s_server.pod
+++ b/doc/apps/s_server.pod
@@ -100,6 +100,7 @@ B B
 [B<-status_verbose>]
 [B<-status_timeout nsec>]
 [B<-status_url url>]
+[B<-alpn protocols>]
 [B<-nextprotoneg protocols>]
 
 =head1 DESCRIPTION
@@ -471,9 +472,13 @@ Sets a fallback responder URL to use if no responder URL 
is present in the
 server certificate. Without this option an error is returned if the server
 certificate does not contain a responder address.
 
-=item B<-nextprotoneg protocols>
+=item B<-alpn protocols>, B<-nextprotoneg protocols>
 
-Enable Next Protocol Negotiation TLS extension and provide a
+these flags enable the 
+Enable the Application-Layer Protocol Negotiation or Next Protocol
+Negotiation extension, respectively. ALPN is the IETF standard and
+replaces NPN.
+The B list is a
 comma-separated list of supported protocol names.
 The list should contain most wanted protocols first.
 Protocol names are printable ASCII strings, for example "http/1.1" or
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Jenkins build is back to normal : master_make_errors #1992

[openssl . sanity]

See 

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

[Rich Salz]

The branch OpenSSL_1_0_2-stable has been updated
   via  ceb7342dab3ab0827b3e13dd9a367d31c7bc3f43 (commit)
  from  9583e4166d02e160873daaaceb2f8dfe62e49659 (commit)


- Log -
commit ceb7342dab3ab0827b3e13dd9a367d31c7bc3f43
Author: Rich Salz 
Date:   Fri Sep 9 10:52:59 2016 -0400

GH1555: Don't bump size on realloc failure

Reviewed-by: Richard Levitte 
(cherry picked from commit 6fcace45bda108ad4d3f95261494dd479720d92c)

---

Summary of changes:
 crypto/lhash/lhash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/lhash/lhash.c b/crypto/lhash/lhash.c
index 53c5c13..f20353a 100644
--- a/crypto/lhash/lhash.c
+++ b/crypto/lhash/lhash.c
@@ -335,8 +335,8 @@ static void expand(_LHASH *lh)
 n = (LHASH_NODE **)OPENSSL_realloc(lh->b,
(int)(sizeof(LHASH_NODE *) * j));
 if (n == NULL) {
-/*  fputs("realloc error in lhash",stderr); */
 lh->error++;
+lh->num_nodes--;
 lh->p = 0;
 return;
 }
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Rich Salz]

The branch OpenSSL_1_1_0-stable has been updated
   via  bf0404fe4afe9ed1e09e11b2b8f82b9ec127de91 (commit)
  from  64d1cc09f912fdc92b12588cc9ad189978051a3e (commit)


- Log -
commit bf0404fe4afe9ed1e09e11b2b8f82b9ec127de91
Author: Rich Salz 
Date:   Fri Sep 9 10:52:59 2016 -0400

GH1555: Don't bump size on realloc failure

Reviewed-by: Richard Levitte 
(cherry picked from commit 6fcace45bda108ad4d3f95261494dd479720d92c)

---

Summary of changes:
 crypto/lhash/lhash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/lhash/lhash.c b/crypto/lhash/lhash.c
index 19c6d2c..adde832 100644
--- a/crypto/lhash/lhash.c
+++ b/crypto/lhash/lhash.c
@@ -213,8 +213,8 @@ static int expand(OPENSSL_LHASH *lh)
 j = (int)lh->num_alloc_nodes * 2;
 n = OPENSSL_realloc(lh->b, (int)(sizeof(OPENSSL_LH_NODE *) * j));
 if (n == NULL) {
-/* fputs("realloc error in lhash",stderr); */
 lh->error++;
+lh->num_nodes--;
 lh->p = 0;
 return 0;
 }
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Rich Salz]

The branch master has been updated
   via  6fcace45bda108ad4d3f95261494dd479720d92c (commit)
  from  4588cb4443552f1d251a637b48f39d891051ee1c (commit)


- Log -
commit 6fcace45bda108ad4d3f95261494dd479720d92c
Author: Rich Salz 
Date:   Fri Sep 9 10:52:59 2016 -0400

GH1555: Don't bump size on realloc failure

Reviewed-by: Richard Levitte 

---

Summary of changes:
 crypto/lhash/lhash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/lhash/lhash.c b/crypto/lhash/lhash.c
index 19c6d2c..adde832 100644
--- a/crypto/lhash/lhash.c
+++ b/crypto/lhash/lhash.c
@@ -213,8 +213,8 @@ static int expand(OPENSSL_LHASH *lh)
 j = (int)lh->num_alloc_nodes * 2;
 n = OPENSSL_realloc(lh->b, (int)(sizeof(OPENSSL_LH_NODE *) * j));
 if (n == NULL) {
-/* fputs("realloc error in lhash",stderr); */
 lh->error++;
+lh->num_nodes--;
 lh->p = 0;
 return 0;
 }
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Rich Salz]

The branch master has been updated
   via  4588cb4443552f1d251a637b48f39d891051ee1c (commit)
  from  780bbb96bf514f0b4013e9c5725614ba5153c497 (commit)


- Log -
commit 4588cb4443552f1d251a637b48f39d891051ee1c
Author: Rich Salz 
Date:   Wed Sep 21 10:37:03 2016 -0400

Revert "Constify code about X509_VERIFY_PARAM"

This reverts commit 81f9ce1e1965e0e33db6d2391285c4c1b6af0434.

Reviewed-by: Matt Caswell 

---

Summary of changes:
 crypto/x509/x509_vpm.c | 4 ++--
 doc/crypto/X509_VERIFY_PARAM_set_flags.pod | 4 ++--
 doc/ssl/SSL_set1_host.pod  | 2 +-
 include/openssl/ssl.h  | 2 +-
 include/openssl/x509_vfy.h | 4 ++--
 ssl/ssl_lib.c  | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/crypto/x509/x509_vpm.c b/crypto/x509/x509_vpm.c
index 2ea39c8..05c7852 100644
--- a/crypto/x509/x509_vpm.c
+++ b/crypto/x509/x509_vpm.c
@@ -301,7 +301,7 @@ int X509_VERIFY_PARAM_clear_flags(X509_VERIFY_PARAM *param,
 return 1;
 }
 
-unsigned long X509_VERIFY_PARAM_get_flags(const X509_VERIFY_PARAM *param)
+unsigned long X509_VERIFY_PARAM_get_flags(X509_VERIFY_PARAM *param)
 {
 return param->flags;
 }
@@ -396,7 +396,7 @@ void X509_VERIFY_PARAM_set_hostflags(X509_VERIFY_PARAM 
*param,
 param->hostflags = flags;
 }
 
-const char *X509_VERIFY_PARAM_get0_peername(const X509_VERIFY_PARAM *param)
+char *X509_VERIFY_PARAM_get0_peername(X509_VERIFY_PARAM *param)
 {
 return param->peername;
 }
diff --git a/doc/crypto/X509_VERIFY_PARAM_set_flags.pod 
b/doc/crypto/X509_VERIFY_PARAM_set_flags.pod
index 528a53a..2800cd4 100644
--- a/doc/crypto/X509_VERIFY_PARAM_set_flags.pod
+++ b/doc/crypto/X509_VERIFY_PARAM_set_flags.pod
@@ -12,7 +12,7 @@ X509_VERIFY_PARAM_set_flags, X509_VERIFY_PARAM_clear_flags, 
X509_VERIFY_PARAM_ge
 unsigned long flags);
  int X509_VERIFY_PARAM_clear_flags(X509_VERIFY_PARAM *param,
 unsigned long flags);
- unsigned long X509_VERIFY_PARAM_get_flags(const X509_VERIFY_PARAM *param);
+ unsigned long X509_VERIFY_PARAM_get_flags(X509_VERIFY_PARAM *param);
 
  int X509_VERIFY_PARAM_set_purpose(X509_VERIFY_PARAM *param, int purpose);
  int X509_VERIFY_PARAM_set_trust(X509_VERIFY_PARAM *param, int trust);
@@ -37,7 +37,7 @@ X509_VERIFY_PARAM_set_flags, X509_VERIFY_PARAM_clear_flags, 
X509_VERIFY_PARAM_ge
  const char *name, size_t namelen);
  void X509_VERIFY_PARAM_set_hostflags(X509_VERIFY_PARAM *param,
   unsigned int flags);
- const char *X509_VERIFY_PARAM_get0_peername(const X509_VERIFY_PARAM *param);
+ char *X509_VERIFY_PARAM_get0_peername(X509_VERIFY_PARAM *param);
  int X509_VERIFY_PARAM_set1_email(X509_VERIFY_PARAM *param,
  const char *email, size_t emaillen);
  int X509_VERIFY_PARAM_set1_ip(X509_VERIFY_PARAM *param,
diff --git a/doc/ssl/SSL_set1_host.pod b/doc/ssl/SSL_set1_host.pod
index d254fe7..3339a0e 100644
--- a/doc/ssl/SSL_set1_host.pod
+++ b/doc/ssl/SSL_set1_host.pod
@@ -12,7 +12,7 @@ SSL server verification parameters
  int SSL_set1_host(SSL *s, const char *hostname);
  int SSL_add1_host(SSL *s, const char *hostname);
  void SSL_set_hostflags(SSL *s, unsigned int flags);
- const char *SSL_get0_peername(const SSL *s);
+ const char *SSL_get0_peername(SSL *s);
 
 =head1 DESCRIPTION
 
diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h
index 5355c83..183296c 100644
--- a/include/openssl/ssl.h
+++ b/include/openssl/ssl.h
@@ -1493,7 +1493,7 @@ __owur int SSL_set_trust(SSL *s, int trust);
 
 __owur int SSL_set1_host(SSL *s, const char *hostname);
 __owur int SSL_add1_host(SSL *s, const char *hostname);
-__owur const char *SSL_get0_peername(const SSL *s);
+__owur const char *SSL_get0_peername(SSL *s);
 void SSL_set_hostflags(SSL *s, unsigned int flags);
 
 __owur int SSL_CTX_dane_enable(SSL_CTX *ctx);
diff --git a/include/openssl/x509_vfy.h b/include/openssl/x509_vfy.h
index 12984f0..cab8005 100644
--- a/include/openssl/x509_vfy.h
+++ b/include/openssl/x509_vfy.h
@@ -453,7 +453,7 @@ int X509_VERIFY_PARAM_set_flags(X509_VERIFY_PARAM *param,
 unsigned long flags);
 int X509_VERIFY_PARAM_clear_flags(X509_VERIFY_PARAM *param,
   unsigned long flags);
-unsigned long X509_VERIFY_PARAM_get_flags(const X509_VERIFY_PARAM *param);
+unsigned long X509_VERIFY_PARAM_get_flags(X509_VERIFY_PARAM *param);
 int X509_VERIFY_PARAM_set_purpose(X509_VERIFY_PARAM *param, int purpose);
 int X509_VERIFY_PARAM_set_trust(X509_VERIFY_PARAM *param, int trust);
 void X509_VERIFY_PARAM_set_depth(X509_VERIFY_PARAM *param, int depth);
@@ -470,7 +470,7 @@ int 

[openssl-commits] Broken: openssl/openssl#6104 (OpenSSL_1_1_0-stable - 6bdd263)

[Travis CI]

Build Update for openssl/openssl
-

Build: #6104
Status: Broken

Duration: 44 minutes and 4 seconds
Commit: 6bdd263 (OpenSSL_1_1_0-stable)
Author: Matt Caswell
Message: Fix a missing NULL check in dsa_builtin_paramgen

We should check the last BN_CTX_get() call to ensure that it isn't NULL
before we try and use any of the allocated BIGNUMs.

Issue reported by Shi Lei.

Reviewed-by: Richard Levitte 
(cherry picked from commit 1ff7425d6130380bb00d3e64739633a4b21b11a3)

View the changeset: 
https://github.com/openssl/openssl/compare/cade32643209...6bdd2637daa8

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/161613036

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Matt Caswell]

The branch master has been updated
   via  3c106325292d30fad32b0dd4cdf2f2ec613461b1 (commit)
  from  1ff7425d6130380bb00d3e64739633a4b21b11a3 (commit)


- Log -
commit 3c106325292d30fad32b0dd4cdf2f2ec613461b1
Author: Matt Caswell 
Date:   Wed Sep 21 14:05:42 2016 +0100

make update and fix some associated mis-matched error codes

Reviewed-by: Richard Levitte 

---

Summary of changes:
 include/openssl/ssl.h| 1 +
 ssl/ssl_err.c| 2 ++
 ssl/statem/statem_dtls.c | 6 +++---
 ssl/statem/statem_lib.c  | 2 +-
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h
index 234a25e..5355c83 100644
--- a/include/openssl/ssl.h
+++ b/include/openssl/ssl.h
@@ -2220,6 +2220,7 @@ int ERR_load_SSL_strings(void);
 # define SSL_F_TLS1_SET_SERVER_SIGALGS335
 # define SSL_F_TLS_CLIENT_KEY_EXCHANGE_POST_WORK  354
 # define SSL_F_TLS_CONSTRUCT_CERTIFICATE_REQUEST  372
+# define SSL_F_TLS_CONSTRUCT_CHANGE_CIPHER_SPEC   427
 # define SSL_F_TLS_CONSTRUCT_CKE_DHE  404
 # define SSL_F_TLS_CONSTRUCT_CKE_ECDHE405
 # define SSL_F_TLS_CONSTRUCT_CKE_GOST 406
diff --git a/ssl/ssl_err.c b/ssl/ssl_err.c
index 7f94ca6..bba7cdb 100644
--- a/ssl/ssl_err.c
+++ b/ssl/ssl_err.c
@@ -239,6 +239,8 @@ static ERR_STRING_DATA SSL_str_functs[] = {
  "tls_client_key_exchange_post_work"},
 {ERR_FUNC(SSL_F_TLS_CONSTRUCT_CERTIFICATE_REQUEST),
  "tls_construct_certificate_request"},
+{ERR_FUNC(SSL_F_TLS_CONSTRUCT_CHANGE_CIPHER_SPEC),
+ "tls_construct_change_cipher_spec"},
 {ERR_FUNC(SSL_F_TLS_CONSTRUCT_CKE_DHE), "tls_construct_cke_dhe"},
 {ERR_FUNC(SSL_F_TLS_CONSTRUCT_CKE_ECDHE), "tls_construct_cke_ecdhe"},
 {ERR_FUNC(SSL_F_TLS_CONSTRUCT_CKE_GOST), "tls_construct_cke_gost"},
diff --git a/ssl/statem/statem_dtls.c b/ssl/statem/statem_dtls.c
index f892f0f..7c8437a 100644
--- a/ssl/statem/statem_dtls.c
+++ b/ssl/statem/statem_dtls.c
@@ -877,7 +877,7 @@ int dtls_construct_change_cipher_spec(SSL *s)
 
 if (!WPACKET_init(, s->init_buf)
 || !WPACKET_put_bytes_u8(, SSL3_MT_CCS)) {
-SSLerr(SSL_F_TLS_CONSTRUCT_FINISHED, ERR_R_INTERNAL_ERROR);
+SSLerr(SSL_F_DTLS_CONSTRUCT_CHANGE_CIPHER_SPEC, ERR_R_INTERNAL_ERROR);
 goto err;
 }
 
@@ -888,7 +888,7 @@ int dtls_construct_change_cipher_spec(SSL *s)
 s->d1->next_handshake_write_seq++;
 
 if (!WPACKET_put_bytes_u16(, s->d1->handshake_write_seq)) {
-SSLerr(SSL_F_TLS_CONSTRUCT_FINISHED, ERR_R_INTERNAL_ERROR);
+SSLerr(SSL_F_DTLS_CONSTRUCT_CHANGE_CIPHER_SPEC, 
ERR_R_INTERNAL_ERROR);
 goto err;
 }
 
@@ -896,7 +896,7 @@ int dtls_construct_change_cipher_spec(SSL *s)
 }
 
 if (!WPACKET_finish()) {
-SSLerr(SSL_F_TLS_CONSTRUCT_FINISHED, ERR_R_INTERNAL_ERROR);
+SSLerr(SSL_F_DTLS_CONSTRUCT_CHANGE_CIPHER_SPEC, ERR_R_INTERNAL_ERROR);
 goto err;
 }
 
diff --git a/ssl/statem/statem_lib.c b/ssl/statem/statem_lib.c
index 3ffe4e5..6f13ec0 100644
--- a/ssl/statem/statem_lib.c
+++ b/ssl/statem/statem_lib.c
@@ -276,7 +276,7 @@ int tls_construct_change_cipher_spec(SSL *s)
 || !WPACKET_finish()) {
 WPACKET_cleanup();
 ossl_statem_set_error(s);
-SSLerr(SSL_F_TLS_CONSTRUCT_FINISHED, ERR_R_INTERNAL_ERROR);
+SSLerr(SSL_F_TLS_CONSTRUCT_CHANGE_CIPHER_SPEC, ERR_R_INTERNAL_ERROR);
 ssl3_send_alert(s, SSL3_AL_FATAL, SSL_AD_INTERNAL_ERROR);
 return 0;
 }
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_0_1-stable update

[Dr . Stephen Henson]

The branch OpenSSL_1_0_1-stable has been updated
   via  52e623c4cb06fffa9d5e75c60b34b4bc130b12e9 (commit)
  from  515a0105652a1b84d712b4d162cf859c02bf5450 (commit)


- Log -
commit 52e623c4cb06fffa9d5e75c60b34b4bc130b12e9
Author: Dr. Stephen Henson 
Date:   Sat Sep 17 12:36:58 2016 +0100

Fix small OOB reads.

In ssl3_get_client_certificate, ssl3_get_server_certificate and
ssl3_get_certificate_request check we have enough room
before reading a length.

Thanks to Shi Lei (Gear Team, Qihoo 360 Inc.) for reporting these bugs.

CVE-2016-6306

Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(cherry picked from commit ff553f837172ecb2b5c8eca257ec3c5619a4b299)

---

Summary of changes:
 ssl/s3_clnt.c | 11 +++
 ssl/s3_srvr.c |  6 ++
 2 files changed, 17 insertions(+)

diff --git a/ssl/s3_clnt.c b/ssl/s3_clnt.c
index 9e5875f..40ca13d 100644
--- a/ssl/s3_clnt.c
+++ b/ssl/s3_clnt.c
@@ -1143,6 +1143,12 @@ int ssl3_get_server_certificate(SSL *s)
 goto f_err;
 }
 for (nc = 0; nc < llen;) {
+if (nc + 3 > llen) {
+al = SSL_AD_DECODE_ERROR;
+SSLerr(SSL_F_SSL3_GET_SERVER_CERTIFICATE,
+   SSL_R_CERT_LENGTH_MISMATCH);
+goto f_err;
+}
 n2l3(p, l);
 if ((l + nc + 3) > llen) {
 al = SSL_AD_DECODE_ERROR;
@@ -2072,6 +2078,11 @@ int ssl3_get_certificate_request(SSL *s)
 }
 
 for (nc = 0; nc < llen;) {
+if (nc + 2 > llen) {
+ssl3_send_alert(s, SSL3_AL_FATAL, SSL_AD_DECODE_ERROR);
+SSLerr(SSL_F_SSL3_GET_CERTIFICATE_REQUEST, SSL_R_CA_DN_TOO_LONG);
+goto err;
+}
 n2s(p, l);
 if ((l + nc + 2) > llen) {
 if ((s->options & SSL_OP_NETSCAPE_CA_DN_BUG))
diff --git a/ssl/s3_srvr.c b/ssl/s3_srvr.c
index 591b13e..4f1a2e9 100644
--- a/ssl/s3_srvr.c
+++ b/ssl/s3_srvr.c
@@ -3234,6 +3234,12 @@ int ssl3_get_client_certificate(SSL *s)
 goto f_err;
 }
 for (nc = 0; nc < llen;) {
+if (nc + 3 > llen) {
+al = SSL_AD_DECODE_ERROR;
+SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,
+   SSL_R_CERT_LENGTH_MISMATCH);
+goto f_err;
+}
 n2l3(p, l);
 if ((l + nc + 3) > llen) {
 al = SSL_AD_DECODE_ERROR;
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

[Dr . Stephen Henson]

The branch OpenSSL_1_0_2-stable has been updated
   via  ff553f837172ecb2b5c8eca257ec3c5619a4b299 (commit)
  from  d0cbaa2f3a36a3359ee979f0262f0ff514630509 (commit)


- Log -
commit ff553f837172ecb2b5c8eca257ec3c5619a4b299
Author: Dr. Stephen Henson 
Date:   Sat Sep 17 12:36:58 2016 +0100

Fix small OOB reads.

In ssl3_get_client_certificate, ssl3_get_server_certificate and
ssl3_get_certificate_request check we have enough room
before reading a length.

Thanks to Shi Lei (Gear Team, Qihoo 360 Inc.) for reporting these bugs.

CVE-2016-6306

Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 

---

Summary of changes:
 ssl/s3_clnt.c | 11 +++
 ssl/s3_srvr.c |  6 ++
 2 files changed, 17 insertions(+)

diff --git a/ssl/s3_clnt.c b/ssl/s3_clnt.c
index 36833f7..d2afaa5 100644
--- a/ssl/s3_clnt.c
+++ b/ssl/s3_clnt.c
@@ -1216,6 +1216,12 @@ int ssl3_get_server_certificate(SSL *s)
 goto f_err;
 }
 for (nc = 0; nc < llen;) {
+if (nc + 3 > llen) {
+al = SSL_AD_DECODE_ERROR;
+SSLerr(SSL_F_SSL3_GET_SERVER_CERTIFICATE,
+   SSL_R_CERT_LENGTH_MISMATCH);
+goto f_err;
+}
 n2l3(p, l);
 if ((l + nc + 3) > llen) {
 al = SSL_AD_DECODE_ERROR;
@@ -2171,6 +2177,11 @@ int ssl3_get_certificate_request(SSL *s)
 }
 
 for (nc = 0; nc < llen;) {
+if (nc + 2 > llen) {
+ssl3_send_alert(s, SSL3_AL_FATAL, SSL_AD_DECODE_ERROR);
+SSLerr(SSL_F_SSL3_GET_CERTIFICATE_REQUEST, SSL_R_CA_DN_TOO_LONG);
+goto err;
+}
 n2s(p, l);
 if ((l + nc + 2) > llen) {
 if ((s->options & SSL_OP_NETSCAPE_CA_DN_BUG))
diff --git a/ssl/s3_srvr.c b/ssl/s3_srvr.c
index 7c19753..01ccd5d 100644
--- a/ssl/s3_srvr.c
+++ b/ssl/s3_srvr.c
@@ -3220,6 +3220,12 @@ int ssl3_get_client_certificate(SSL *s)
 goto f_err;
 }
 for (nc = 0; nc < llen;) {
+if (nc + 3 > llen) {
+al = SSL_AD_DECODE_ERROR;
+SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE,
+   SSL_R_CERT_LENGTH_MISMATCH);
+goto f_err;
+}
 n2l3(p, l);
 if ((l + nc + 3) > llen) {
 al = SSL_AD_DECODE_ERROR;
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Build failed in Jenkins: master_make_errors #1991

[openssl . sanity]

See 

Changes:

[Matt Caswell] Fix a missing NULL check in dsa_builtin_paramgen

--
Started by upstream project "master_basic" build number 2107
originally caused by:
 Started by an SCM change
Building on master in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Done
Cloning the remote Git repository
Cloning repository https://github.com/openssl/openssl.git
 > git init  
 > # timeout=10
Fetching upstream changes from https://github.com/openssl/openssl.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/openssl/openssl.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/openssl/openssl.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/openssl/openssl.git # 
 > timeout=10
Fetching upstream changes from https://github.com/openssl/openssl.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/openssl/openssl.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 1ff7425d6130380bb00d3e64739633a4b21b11a3 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1ff7425d6130380bb00d3e64739633a4b21b11a3
 > git rev-list f3ff481f318b10a223d6157bde9645e1797487c5 # timeout=10
[master_make_errors] $ /bin/sh -xe /tmp/hudson3148828734816815482.sh
+ ./config
Operating system: x86_64-whatever-linux2
Configuring OpenSSL version 1.1.1-dev (0x0x10101000L)
no-asan [default]  OPENSSL_NO_ASAN
no-crypto-mdebug [default]  OPENSSL_NO_CRYPTO_MDEBUG
no-crypto-mdebug-backtrace [default]  OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE
no-ec_nistp_64_gcc_128 [default]  OPENSSL_NO_EC_NISTP_64_GCC_128
no-egd  [default]  OPENSSL_NO_EGD
no-fuzz-afl [default]  OPENSSL_NO_FUZZ_AFL
no-fuzz-libfuzzer [default]  OPENSSL_NO_FUZZ_LIBFUZZER
no-heartbeats   [default]  OPENSSL_NO_HEARTBEATS
no-md2  [default]  OPENSSL_NO_MD2 (skip dir)
no-msan [default]  OPENSSL_NO_MSAN
no-rc5  [default]  OPENSSL_NO_RC5 (skip dir)
no-sctp [default]  OPENSSL_NO_SCTP
no-ssl-trace[default]  OPENSSL_NO_SSL_TRACE
no-ssl3 [default]  OPENSSL_NO_SSL3
no-ssl3-method  [default]  OPENSSL_NO_SSL3_METHOD
no-ubsan[default]  OPENSSL_NO_UBSAN
no-unit-test[default]  OPENSSL_NO_UNIT_TEST
no-weak-ssl-ciphers [default]  OPENSSL_NO_WEAK_SSL_CIPHERS
no-zlib [default] 
no-zlib-dynamic [default] 
Configuring for linux-x86_64

PERL  =/usr/bin/perl
PERLVERSION   =5.16.3 for x86_64-linux-thread-multi
HASHBANGPERL  =/usr/bin/env perl
CC=gcc
CFLAG =-Wall -O3 -pthread -m64 -DL_ENDIAN  -Wa,--noexecstack
DEFINES   =DSO_DLFCN HAVE_DLFCN_H NDEBUG OPENSSL_THREADS 
OPENSSL_NO_STATIC_ENGINE OPENSSL_PIC OPENSSL_IA32_SSE2 OPENSSL_BN_ASM_MONT 
OPENSSL_BN_ASM_MONT5 OPENSSL_BN_ASM_GF2m SHA1_ASM SHA256_ASM SHA512_ASM RC4_ASM 
MD5_ASM AES_ASM VPAES_ASM BSAES_ASM GHASH_ASM ECP_NISTZ256_ASM POLY1305_ASM
EX_LIBS   =-ldl 
+ make depend
+ make errors
( cd .; /usr/bin/perl util/ck_errf.pl -strict */*.c */*/*.c )
FATAL: error discrepancy
ssl/statem/statem_dtls.c:880:dtls_construct_change_cipher_spec:tls_construct_finished
ssl/statem/statem_dtls.c:891:dtls_construct_change_cipher_spec:tls_construct_finished
ssl/statem/statem_dtls.c:899:dtls_construct_change_cipher_spec:tls_construct_finished
ssl/statem/statem_lib.c:279:tls_construct_change_cipher_spec:tls_construct_finished
make: *** [errors] Error 1
Build step 'Execute shell' marked build as failure
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

[Matt Caswell]

The branch OpenSSL_1_1_0-stable has been updated
   via  6bdd2637daa862706598d04ae2750a920ebee0ae (commit)
  from  cade326432099f60c08a8004ce694eedcd5c500b (commit)


- Log -
commit 6bdd2637daa862706598d04ae2750a920ebee0ae
Author: Matt Caswell 
Date:   Wed Sep 14 13:27:59 2016 +0100

Fix a missing NULL check in dsa_builtin_paramgen

We should check the last BN_CTX_get() call to ensure that it isn't NULL
before we try and use any of the allocated BIGNUMs.

Issue reported by Shi Lei.

Reviewed-by: Richard Levitte 
(cherry picked from commit 1ff7425d6130380bb00d3e64739633a4b21b11a3)

---

Summary of changes:
 crypto/dsa/dsa_gen.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c
index 3dac550..11f422e 100644
--- a/crypto/dsa/dsa_gen.c
+++ b/crypto/dsa/dsa_gen.c
@@ -100,6 +100,9 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t 
qbits,
 p = BN_CTX_get(ctx);
 test = BN_CTX_get(ctx);
 
+if (test == NULL)
+goto err;
+
 if (!BN_lshift(test, BN_value_one(), bits - 1))
 goto err;
 
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

[Matt Caswell]

The branch OpenSSL_1_0_2-stable has been updated
   via  d0cbaa2f3a36a3359ee979f0262f0ff514630509 (commit)
  from  a5e55f62975c0f978eb348763a1de0cd923f0d77 (commit)


- Log -
commit d0cbaa2f3a36a3359ee979f0262f0ff514630509
Author: Matt Caswell 
Date:   Wed Sep 14 13:27:59 2016 +0100

Fix a missing NULL check in dsa_builtin_paramgen

We should check the last BN_CTX_get() call to ensure that it isn't NULL
before we try and use any of the allocated BIGNUMs.

Issue reported by Shi Lei.

Reviewed-by: Richard Levitte 
(cherry picked from commit 1ff7425d6130380bb00d3e64739633a4b21b11a3)

---

Summary of changes:
 crypto/dsa/dsa_gen.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c
index f6de684..1fce0f8 100644
--- a/crypto/dsa/dsa_gen.c
+++ b/crypto/dsa/dsa_gen.c
@@ -185,6 +185,9 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t 
qbits,
 p = BN_CTX_get(ctx);
 test = BN_CTX_get(ctx);
 
+if (test == NULL)
+goto err;
+
 if (!BN_lshift(test, BN_value_one(), bits - 1))
 goto err;
 
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] [openssl] master update

[Matt Caswell]

The branch master has been updated
   via  1ff7425d6130380bb00d3e64739633a4b21b11a3 (commit)
  from  f3ff481f318b10a223d6157bde9645e1797487c5 (commit)


- Log -
commit 1ff7425d6130380bb00d3e64739633a4b21b11a3
Author: Matt Caswell 
Date:   Wed Sep 14 13:27:59 2016 +0100

Fix a missing NULL check in dsa_builtin_paramgen

We should check the last BN_CTX_get() call to ensure that it isn't NULL
before we try and use any of the allocated BIGNUMs.

Issue reported by Shi Lei.

Reviewed-by: Richard Levitte 

---

Summary of changes:
 crypto/dsa/dsa_gen.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c
index 3dac550..11f422e 100644
--- a/crypto/dsa/dsa_gen.c
+++ b/crypto/dsa/dsa_gen.c
@@ -100,6 +100,9 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t 
qbits,
 p = BN_CTX_get(ctx);
 test = BN_CTX_get(ctx);
 
+if (test == NULL)
+goto err;
+
 if (!BN_lshift(test, BN_value_one(), bits - 1))
 goto err;
 
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

[openssl-commits] Build failed in Jenkins: master_make_errors #1990

[openssl . sanity]

See 

Changes:

[Matt Caswell] Convert Finished construction to WPACKET

[Matt Caswell] Convert CCS construction to WPACKET

[Matt Caswell] Convert WPACKET_put_bytes to use convenience macros

[Richard Levitte] Fixup BIO demos for OpenSSL 1.1.x

[Richard Levitte] Fixup BIO demos for OpenSSL 1.1.x

[Richard Levitte] Fixup BIO demos for OpenSSL 1.1.x

[Richard Levitte] Don't ignore Makefiles in demos/

[Richard Levitte] Crude Makefile for demos/bio/

[Richard Levitte] Crude VMS build files for demos/bio/

[Richard Levitte] Documentation fixup; no more ECDHParameters

[Richard Levitte] apps/apps.c: include sys/socket.h to declare recv()

[rsalz] RT3669: dgst can only sign/verify one file.

[Richard Levitte] Quiet compiler warning about uninitialised variable

[Richard Levitte] util/dofile.pl: report if a template couldn't be loaded

[Richard Levitte] descrip.mms.tmpl: in obj2bin, make sure an empty @deps means 
no empty

[Richard Levitte] VMS: add [.util]shlib_wrap.exe and its build instructions

--
Started by upstream project "master_basic" build number 2106
originally caused by:
 Started by an SCM change
Building on master in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Done
Cloning the remote Git repository
Cloning repository https://github.com/openssl/openssl.git
 > git init  
 > # timeout=10
Fetching upstream changes from https://github.com/openssl/openssl.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/openssl/openssl.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/openssl/openssl.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/openssl/openssl.git # 
 > timeout=10
Fetching upstream changes from https://github.com/openssl/openssl.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/openssl/openssl.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision f3ff481f318b10a223d6157bde9645e1797487c5 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f3ff481f318b10a223d6157bde9645e1797487c5
 > git rev-list 418a18a2deddc0b0d6181de0008219c899ca6ddf # timeout=10
[master_make_errors] $ /bin/sh -xe /tmp/hudson5886687341472149298.sh
+ ./config
Operating system: x86_64-whatever-linux2
Configuring OpenSSL version 1.1.1-dev (0x0x10101000L)
no-asan [default]  OPENSSL_NO_ASAN
no-crypto-mdebug [default]  OPENSSL_NO_CRYPTO_MDEBUG
no-crypto-mdebug-backtrace [default]  OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE
no-ec_nistp_64_gcc_128 [default]  OPENSSL_NO_EC_NISTP_64_GCC_128
no-egd  [default]  OPENSSL_NO_EGD
no-fuzz-afl [default]  OPENSSL_NO_FUZZ_AFL
no-fuzz-libfuzzer [default]  OPENSSL_NO_FUZZ_LIBFUZZER
no-heartbeats   [default]  OPENSSL_NO_HEARTBEATS
no-md2  [default]  OPENSSL_NO_MD2 (skip dir)
no-msan [default]  OPENSSL_NO_MSAN
no-rc5  [default]  OPENSSL_NO_RC5 (skip dir)
no-sctp [default]  OPENSSL_NO_SCTP
no-ssl-trace[default]  OPENSSL_NO_SSL_TRACE
no-ssl3 [default]  OPENSSL_NO_SSL3
no-ssl3-method  [default]  OPENSSL_NO_SSL3_METHOD
no-ubsan[default]  OPENSSL_NO_UBSAN
no-unit-test[default]  OPENSSL_NO_UNIT_TEST
no-weak-ssl-ciphers [default]  OPENSSL_NO_WEAK_SSL_CIPHERS
no-zlib [default] 
no-zlib-dynamic [default] 
Configuring for linux-x86_64

PERL  =/usr/bin/perl
PERLVERSION   =5.16.3 for x86_64-linux-thread-multi
HASHBANGPERL  =/usr/bin/env perl
CC=gcc
CFLAG =-Wall -O3 -pthread -m64 -DL_ENDIAN  -Wa,--noexecstack
DEFINES   =DSO_DLFCN HAVE_DLFCN_H NDEBUG OPENSSL_THREADS 
OPENSSL_NO_STATIC_ENGINE OPENSSL_PIC OPENSSL_IA32_SSE2 OPENSSL_BN_ASM_MONT 
OPENSSL_BN_ASM_MONT5 OPENSSL_BN_ASM_GF2m SHA1_ASM SHA256_ASM SHA512_ASM RC4_ASM 
MD5_ASM AES_ASM VPAES_ASM BSAES_ASM GHASH_ASM ECP_NISTZ256_ASM POLY1305_ASM
EX_LIBS   =-ldl 
+ make depend
+ make errors
( cd .; /usr/bin/perl util/ck_errf.pl -strict */*.c */*/*.c )
FATAL: error discrepancy
ssl/statem/statem_dtls.c:880:dtls_construct_change_cipher_spec:tls_construct_finished
ssl/statem/statem_dtls.c:891:dtls_construct_change_cipher_spec:tls_construct_finished
ssl/statem/statem_dtls.c:899:dtls_construct_change_cipher_spec:tls_construct_finished
ssl/statem/statem_lib.c:279:tls_construct_change_cipher_spec:tls_construct_finished
make: *** [errors] Error 1
Build step 'Execute shell' marked build as failure