Coverity Scan: Analysis completed for openssl/openssl

2022-09-15 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DoPq4_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeHwDUH1X2NrUg7kfBV6QaUUb-2BUQ2DNABTXKGbbvIYA2tYbXTTo9ai8Xj0EZfjc0uBJcEraEYenyaTm7vnWuoTjiTZSGDVYx4nxKoPyCWKfacADHIbJrP-2F742LFtDiuvE4pEpZTGHsIr-2BwfpLOsGHTBj6mWh2ksW6KxmUDDReZrlXklPCWSVONYk-2FYINJlm0bPc-3D

Build ID: 480011

Analysis Summary:
   New defects found: 0
   Defects eliminated: 0



[openssl/openssl] 4a84c5: test: make unit tests FIPS provider version aware

2022-09-15 Thread Pauli
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 4a84c54dbe9bbe88fb8138794163e5d04c5bc411
  
https://github.com/openssl/openssl/commit/4a84c54dbe9bbe88fb8138794163e5d04c5bc411
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/testutil.h
M test/testutil/provider.c

  Log Message:
  ---
  test: make unit tests FIPS provider version aware

Fixes #19171

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit eaac0584db6e7452fdb627502527fb0678bb9a93)


  Commit: 8462f5d441a3d61810118bb1a548dc0a0152b188
  
https://github.com/openssl/openssl/commit/8462f5d441a3d61810118bb1a548dc0a0152b188
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/evp_test.c

  Log Message:
  ---
  evp_test: allow FIPS provider version based escapes in evp_test

Also fix a number of regressions when run against the 3.0.0 FIPS provider
that result from bug fixes.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit 54a7bbedf43a1ade98c8f47eb8896d75f3db0165)


  Commit: 5eabf8e5548607a317b41a437806bb075947d0fa
  
https://github.com/openssl/openssl/commit/5eabf8e5548607a317b41a437806bb075947d0fa
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/recipes/30-test_evp_data/evpciph_des3_common.txt

  Log Message:
  ---
  TDES: fix test with old FIPS provider

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit 4d0249c2d1d0f81c211354d8a36738595936fad8)


  Commit: e520991371cab8418995586df55f5ab3dfd3d044
  
https://github.com/openssl/openssl/commit/e520991371cab8418995586df55f5ab3dfd3d044
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/recipes/30-test_evp_data/evppkey_ffdhe.txt

  Log Message:
  ---
  Fix default padding regression against 3.0.0 FIPS provider

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit 9684335839fcdeac06d21b06628c4c37117b5478)


  Commit: c2f8d715e54d0f82f0a27fd69b85fd52578d89b8
  
https://github.com/openssl/openssl/commit/c2f8d715e54d0f82f0a27fd69b85fd52578d89b8
  Author: Tomáš Mráz 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M crypto/evp/p_lib.c

  Log Message:
  ---
  EVP_PKEY_eq: regain compatibility with the 3.0.0 FIPS provider

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit c342004e07fd2c03a672f79353d13554fe0ffdaf)


  Commit: 65759e35afa545835910ea85582522c01087fde3
  
https://github.com/openssl/openssl/commit/65759e35afa545835910ea85582522c01087fde3
  Author: Tomas Mraz 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/build.info
M test/endecode_test.c
M test/evp_test.c
A test/fips_version_test.c
M test/recipes/25-test_verify.t
M test/testutil.h
M test/testutil/provider.c

  Log Message:
  ---
  With fips provider 3.0.0 skip tests related to explicit curves handling

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit e1289d90d0069ea1c3ea8ae80bfc3916077ec24e)


  Commit: 1ab630794dfef98f83b59b5e18981dc3223bb1bf
  
https://github.com/openssl/openssl/commit/1ab630794dfef98f83b59b5e18981dc3223bb1bf
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
A .github/workflows/fips-old.yml

  Log Message:
  ---
  Add CI to test old FIPS provider versions

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)

(cherry picked from commit 65080a3e1ebced54af838481e6d40e1c0cb7991e)


Compare: https://github.com/openssl/openssl/compare/1ed89de84f6e...1ab630794dfe


[openssl/openssl] eaac05: test: make unit tests FIPS provider version aware

2022-09-15 Thread Pauli
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: eaac0584db6e7452fdb627502527fb0678bb9a93
  
https://github.com/openssl/openssl/commit/eaac0584db6e7452fdb627502527fb0678bb9a93
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/testutil.h
M test/testutil/provider.c

  Log Message:
  ---
  test: make unit tests FIPS provider version aware

Fixes #19171

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)


  Commit: 54a7bbedf43a1ade98c8f47eb8896d75f3db0165
  
https://github.com/openssl/openssl/commit/54a7bbedf43a1ade98c8f47eb8896d75f3db0165
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/evp_test.c

  Log Message:
  ---
  evp_test: allow FIPS provider version based escapes in evp_test

Also fix a number of regressions when run against the 3.0.0 FIPS provider
that result from bug fixes.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)


  Commit: 4d0249c2d1d0f81c211354d8a36738595936fad8
  
https://github.com/openssl/openssl/commit/4d0249c2d1d0f81c211354d8a36738595936fad8
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/recipes/30-test_evp_data/evpciph_des3_common.txt

  Log Message:
  ---
  TDES: fix test with old FIPS provider

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)


  Commit: 9684335839fcdeac06d21b06628c4c37117b5478
  
https://github.com/openssl/openssl/commit/9684335839fcdeac06d21b06628c4c37117b5478
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/recipes/30-test_evp_data/evppkey_ffdhe.txt

  Log Message:
  ---
  Fix default padding regression against 3.0.0 FIPS provider

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)


  Commit: c342004e07fd2c03a672f79353d13554fe0ffdaf
  
https://github.com/openssl/openssl/commit/c342004e07fd2c03a672f79353d13554fe0ffdaf
  Author: Tomáš Mráz 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M crypto/evp/p_lib.c

  Log Message:
  ---
  EVP_PKEY_eq: regain compatibility with the 3.0.0 FIPS provider

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19201)


  Commit: e1289d90d0069ea1c3ea8ae80bfc3916077ec24e
  
https://github.com/openssl/openssl/commit/e1289d90d0069ea1c3ea8ae80bfc3916077ec24e
  Author: Tomas Mraz 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
M test/build.info
M test/endecode_test.c
M test/evp_test.c
A test/fips_version_test.c
M test/recipes/25-test_verify.t
M test/testutil.h
M test/testutil/provider.c

  Log Message:
  ---
  With fips provider 3.0.0 skip tests related to explicit curves handling

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19201)


  Commit: 65080a3e1ebced54af838481e6d40e1c0cb7991e
  
https://github.com/openssl/openssl/commit/65080a3e1ebced54af838481e6d40e1c0cb7991e
  Author: Pauli 
  Date:   2022-09-16 (Fri, 16 Sep 2022)

  Changed paths:
A .github/workflows/fips-old.yml

  Log Message:
  ---
  Add CI to test old FIPS provider versions

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19201)


Compare: https://github.com/openssl/openssl/compare/edb271ee5d68...65080a3e1ebc


[openssl/openssl] 1ed89d: Fix a typo in the function name

2022-09-15 Thread Akshat Maheshwari
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 1ed89de84f6e7b346c34c88ce4589216611ee505
  
https://github.com/openssl/openssl/commit/1ed89de84f6e7b346c34c88ce4589216611ee505
  Author: Akshat Maheshwari 
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
M doc/man3/X509_STORE_add_cert.pod

  Log Message:
  ---
  Fix a typo in the function name

X509_STORE_load_locations_ex() calls X509_STORE_load_file_ex() and 
X509_STORE_load_path(), there's no such function name as X509_STORE_load_dir().

CLA: trivial

Reviewed-by: Shane Lontis 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19202)

(cherry picked from commit edb271ee5d68f31260da37e9ad5ed2f9f4dd7274)




[openssl/openssl] edb271: Fix a typo in the function name

2022-09-15 Thread Akshat Maheshwari
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: edb271ee5d68f31260da37e9ad5ed2f9f4dd7274
  
https://github.com/openssl/openssl/commit/edb271ee5d68f31260da37e9ad5ed2f9f4dd7274
  Author: Akshat Maheshwari 
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
M doc/man3/X509_STORE_add_cert.pod

  Log Message:
  ---
  Fix a typo in the function name

X509_STORE_load_locations_ex() calls X509_STORE_load_file_ex() and 
X509_STORE_load_path(), there's no such function name as X509_STORE_load_dir().

CLA: trivial

Reviewed-by: Shane Lontis 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19202)




[openssl/openssl] 48963f: Add support for PBE using hmacWithSM3

2022-09-15 Thread K1
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 48963ff6d0d07648e09e63d2dca9fb6069241f42
  
https://github.com/openssl/openssl/commit/48963ff6d0d07648e09e63d2dca9fb6069241f42
  Author: K1 
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
M crypto/evp/evp_pbe.c
M crypto/objects/obj_dat.h
M crypto/objects/obj_mac.num
M crypto/objects/objects.txt
M fuzz/oids.txt
M include/openssl/obj_mac.h
A test/recipes/25-test_pkcs8.t

  Log Message:
  ---
  Add support for PBE using hmacWithSM3

Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19204)




[openssl/openssl] d83c46: util/wrap.pl.in: Use parentheses so `kill` gets al...

2022-09-15 Thread Richard Levitte
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: d83c465754ab4bfeb33718ad5ac851388079daba
  
https://github.com/openssl/openssl/commit/d83c465754ab4bfeb33718ad5ac851388079daba
  Author: Richard Levitte 
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
M util/wrap.pl.in

  Log Message:
  ---
  util/wrap.pl.in: Use parentheses so `kill` gets all its arguments

In perl, this may be ambiguous:

fn (expr1), expr2

Is the comma (which may be `=>` just as well in this case) a separator
between arguments to `fn`, or is it the comma operator, separating the
expressions `fn(expr1)` and `expr2`?  It appears that in this particular
case, perl takes the existing parentheses to mean the latter.  When the
former was intended, extra parentheses are required.

Fixes #19209

Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19211)

(cherry picked from commit ef6d6e452dc57ef4a55d7a6ec0693be650009bb5)




[openssl/openssl] ef6d6e: util/wrap.pl.in: Use parentheses so `kill` gets al...

2022-09-15 Thread Richard Levitte
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: ef6d6e452dc57ef4a55d7a6ec0693be650009bb5
  
https://github.com/openssl/openssl/commit/ef6d6e452dc57ef4a55d7a6ec0693be650009bb5
  Author: Richard Levitte 
  Date:   2022-09-15 (Thu, 15 Sep 2022)

  Changed paths:
M util/wrap.pl.in

  Log Message:
  ---
  util/wrap.pl.in: Use parentheses so `kill` gets all its arguments

In perl, this may be ambiguous:

fn (expr1), expr2

Is the comma (which may be `=>` just as well in this case) a separator
between arguments to `fn`, or is it the comma operator, separating the
expressions `fn(expr1)` and `expr2`?  It appears that in this particular
case, perl takes the existing parentheses to mean the latter.  When the
former was intended, extra parentheses are required.

Fixes #19209

Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19211)