Coverity Scan: Analysis completed for openssl/openssl

2022-11-14 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DaY6v_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeFadAHBEVSgNL8Dsh58N5388ELGaxsbYpDXLmG0A60uhJD-2BVDq2mKP7Eris26l0M7rvMBbMt9nrC8I5QmYosbAIlCo5oyJr5Z-2B8HSw7U-2BDfDSZscje3JBDjEbWcmJsKO3N4yBJSTCFAaS0Dmt4-2B7Q8bs-2BK6SEwn-2BvhENH97vdnUQoxRe7hGLZS-2FeNJXPy72WlQ-3D

Build ID: 493752

Analysis Summary:
   New defects found: 0
   Defects eliminated: 0



[openssl/openssl] 00cd06: test: add two comparision options to fips version ...

2022-11-14 Thread Pauli
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 00cd0627252a3159cde4818d4763103af19dad82
  
https://github.com/openssl/openssl/commit/00cd0627252a3159cde4818d4763103af19dad82
  Author: Pauli 
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
M test/testutil.h
M test/testutil/provider.c

  Log Message:
  ---
  test: add two comparision options to fips version test utility code

Reviewed-by: Tomas Mraz 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19665)


  Commit: c3e8128befa7b4d8463d13d35eafdaf950531c43
  
https://github.com/openssl/openssl/commit/c3e8128befa7b4d8463d13d35eafdaf950531c43
  Author: Pauli 
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
M test/recipes/03-test_fipsinstall.t

  Log Message:
  ---
  fipsinstall test: skip PCT DSA signature test for new providers

Reviewed-by: Tomas Mraz 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19665)


Compare: https://github.com/openssl/openssl/compare/bb0190e8a4d4...c3e8128befa7


[openssl/openssl] 3d004c: Use the same encryption growth macro consistently

2022-11-14 Thread Matt Caswell
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 3d004cefec5135a3b080dc898d7f7d5452ef309f
  
https://github.com/openssl/openssl/commit/3d004cefec5135a3b080dc898d7f7d5452ef309f
  Author: Matt Caswell 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M ssl/record/rec_layer_s3.c

  Log Message:
  ---
  Use the same encryption growth macro consistently

We had two different macros for calculating the potential growth due to
encryption. The macro we use for allocating the underlying buffer should be
the same one that we use for reserving bytes for encryption growth.

Also if we are adding the MAC independently of the cipher algorithm then
the encryption growth will not include that MAC so we should remove it
from the amount of bytes that we reserve for that growth. Otherwise we
might exceed our buffer size and the WPACKET_reserve operation will
fail.

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19264)




[openssl/openssl] bb0190: Use the same encryption growth macro consistently

2022-11-14 Thread Matt Caswell
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: bb0190e8a4d43d06a8ba6e6fca68571b4c3361a5
  
https://github.com/openssl/openssl/commit/bb0190e8a4d43d06a8ba6e6fca68571b4c3361a5
  Author: Matt Caswell 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M ssl/record/rec_layer_s3.c

  Log Message:
  ---
  Use the same encryption growth macro consistently

We had two different macros for calculating the potential growth due to
encryption. The macro we use for allocating the underlying buffer should be
the same one that we use for reserving bytes for encryption growth.

Also if we are adding the MAC independently of the cipher algorithm then
the encryption growth will not include that MAC so we should remove it
from the amount of bytes that we reserve for that growth. Otherwise we
might exceed our buffer size and the WPACKET_reserve operation will
fail.

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19264)

(cherry picked from commit 3d004cefec5135a3b080dc898d7f7d5452ef309f)




[openssl/openssl] 1aef13: apps/speed.c: add verifying if fdopen returns NULL

2022-11-14 Thread Vinz2008
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 1aef13c0bdb907ac55fbcc9ba69abc86e1921324
  
https://github.com/openssl/openssl/commit/1aef13c0bdb907ac55fbcc9ba69abc86e1921324
  Author: Vinz2008 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M apps/speed.c

  Log Message:
  ---
  apps/speed.c: add verifying if fdopen returns NULL

Reviewed-by: Todd Short 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19651)

(cherry picked from commit c9a542e41837ea65671dcd75c448d7113d34a4fd)




[openssl/openssl] c9a542: apps/speed.c: add verifying if fdopen returns NULL

2022-11-14 Thread Vinz2008
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: c9a542e41837ea65671dcd75c448d7113d34a4fd
  
https://github.com/openssl/openssl/commit/c9a542e41837ea65671dcd75c448d7113d34a4fd
  Author: Vinz2008 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M apps/speed.c

  Log Message:
  ---
  apps/speed.c: add verifying if fdopen returns NULL

Reviewed-by: Todd Short 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19651)




[openssl/openssl] a05e2a: apps/speed.c: add verifying if fdopen returns NULL

2022-11-14 Thread Vinz2008
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: a05e2aa54887474f7b02387fe7c8902f0ad76179
  
https://github.com/openssl/openssl/commit/a05e2aa54887474f7b02387fe7c8902f0ad76179
  Author: Vinz2008 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M apps/speed.c

  Log Message:
  ---
  apps/speed.c: add verifying if fdopen returns NULL

Reviewed-by: Todd Short 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19651)

(cherry picked from commit c9a542e41837ea65671dcd75c448d7113d34a4fd)




[openssl/openssl] d55fc0: Add thread pool design document (phase 1)

2022-11-14 Thread Hugo Landau
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: d55fc027b9af85b1054cdbc017046a9070935086
  
https://github.com/openssl/openssl/commit/d55fc027b9af85b1054cdbc017046a9070935086
  Author: Hugo Landau 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
A doc/designs/thread-api.md

  Log Message:
  ---
  Add thread pool design document (phase 1)

Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19455)




[openssl/openssl] 732435: Resolve a TODO in ssl3_dispatch_alert

2022-11-14 Thread Matt Caswell
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 732435026b0141063084fb68c076bc1c9fd9bee8
  
https://github.com/openssl/openssl/commit/732435026b0141063084fb68c076bc1c9fd9bee8
  Author: Matt Caswell 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M ssl/d1_msg.c
M ssl/record/rec_layer_d1.c
M ssl/record/rec_layer_s3.c
M ssl/s3_lib.c
M ssl/s3_msg.c
M ssl/ssl_lib.c
M ssl/ssl_local.h

  Log Message:
  ---
  Resolve a TODO in ssl3_dispatch_alert

Properly handle the case where there is pending write data and we want
to send an alert.

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19550)


  Commit: cbf965b4f3ba8567624767239aebe4d04c62558a
  
https://github.com/openssl/openssl/commit/cbf965b4f3ba8567624767239aebe4d04c62558a
  Author: Matt Caswell 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M test/sslapitest.c

  Log Message:
  ---
  Test SSL_shutdown() with async writes

As well as SSL_shutdown() itself this excercises the async write paths
in ssl3_dispatch_alert().

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19550)


Compare: https://github.com/openssl/openssl/compare/6f3072212c2d...cbf965b4f3ba


[openssl/openssl] bbf902: QUIC Receive Stream Management

2022-11-14 Thread Tomáš Mráz
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: bbf902c34a90435bacea8a551ac39a559c8df6b2
  
https://github.com/openssl/openssl/commit/bbf902c34a90435bacea8a551ac39a559c8df6b2
  Author: Tomas Mraz 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
A include/internal/quic_record_rx_wrap.h
A include/internal/quic_sf_list.h
M include/internal/quic_stream.h
M ssl/quic/build.info
M ssl/quic/quic_record_rx.c
M ssl/quic/quic_record_rx_wrap.c
R ssl/quic/quic_record_rx_wrap.h
A ssl/quic/quic_rstream.c
M ssl/quic/quic_rx_depack.c
A ssl/quic/quic_sf_list.c
A ssl/quic/quic_sstream.c
R ssl/quic/quic_stream.c
M test/quic_stream_test.c

  Log Message:
  ---
  QUIC Receive Stream Management

Added SFRAME_LIST structure and QUIC_RSTREAM object to
manage received stream data.

Reviewed-by: Matt Caswell 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/19351)


  Commit: e77396f6f508f604b69f795e624896c427fe8b06
  
https://github.com/openssl/openssl/commit/e77396f6f508f604b69f795e624896c427fe8b06
  Author: Tomas Mraz 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M include/internal/quic_stream.h
M ssl/quic/quic_rstream.c
M ssl/quic/quic_sf_list.c
M test/quic_stream_test.c

  Log Message:
  ---
  QUIC Receive Stream Management: Call QUIC flow control

Reviewed-by: Matt Caswell 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/19351)


  Commit: a17c713a7ad394b08646bbb0f0ba1a16e1cc8799
  
https://github.com/openssl/openssl/commit/a17c713a7ad394b08646bbb0f0ba1a16e1cc8799
  Author: Tomas Mraz 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M include/internal/quic_sf_list.h
M include/internal/quic_ssl.h
M include/internal/quic_stream.h
M ssl/quic/quic_impl.c
M ssl/quic/quic_local.h
M ssl/quic/quic_rstream.c
M ssl/quic/quic_rx_depack.c
M ssl/quic/quic_sf_list.c

  Log Message:
  ---
  Plug the QUIC_RSTREAM to the RX depacketizer

Reviewed-by: Matt Caswell 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/19351)


  Commit: 6f3072212c2d56cae598bc1d180b2673b3df9be0
  
https://github.com/openssl/openssl/commit/6f3072212c2d56cae598bc1d180b2673b3df9be0
  Author: Tomas Mraz 
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
M doc/designs/quic-design/stream-receive-buffers.md

  Log Message:
  ---
  Update Stream Receive Buffers design document with implementation details

Reviewed-by: Matt Caswell 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/19351)


Compare: https://github.com/openssl/openssl/compare/aa197f36a886...6f3072212c2d