Coverity Scan: Analysis completed for openssl/openssl

2022-12-05 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DAxF7_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeFz64wQe-2BD-2BLIp28vg997fB3kOeAt3-2FqAT138laAH3PBz45bgfIUAZQa9I-2B9sscilNhxSENho1JK7GIDczcQg9ZuHHpjGpg59j47YMp93B4IZU9z4D0F3pMqL-2Bt7rqAX2l4ahJFUIhXTtIwCLzfjQ1QxHdmEUhwnz7g6Xl-2Bwr0CW5fIBg-2FGZeu2cb6S8NtMkR8-3D

Build ID: 498608

Analysis Summary:
   New defects found: 0
   Defects eliminated: 0



[openssl/openssl] 5812a2: Fix the checks in rsautl_main

2022-12-05 Thread Peiwei Hu
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 5812a2d282a76e83a95ea19aa08e89ba0571b182
  
https://github.com/openssl/openssl/commit/5812a2d282a76e83a95ea19aa08e89ba0571b182
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/rsautl.c

  Log Message:
  ---
  Fix the checks in rsautl_main

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)

(cherry picked from commit 4c3fadfe57b94f71fa83786726046b8833997c7c)


  Commit: 18e45bd9eade832d3ab575f48fcf1f22695939b8
  
https://github.com/openssl/openssl/commit/18e45bd9eade832d3ab575f48fcf1f22695939b8
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/crmf/crmf_lib.c
M test/evp_extra_test.c

  Log Message:
  ---
  Fix the check of EVP_PKEY_decrypt_init

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)

(cherry picked from commit b794476df71441a6d30740ab9fadcc0f6d18d3d6)


  Commit: 544758738dad2c0db6b236ba395905e671a252e8
  
https://github.com/openssl/openssl/commit/544758738dad2c0db6b236ba395905e671a252e8
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/s_server.c
M crypto/bio/bf_buff.c
M crypto/bio/bf_lbuf.c
M ssl/ssl_lib.c

  Log Message:
  ---
  Fix the check of BIO_set_write_buffer_size and BIO_set_read_buffer_size

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)

(cherry picked from commit 25d02f333b9a5531fa88db294f69a8347f275858)


Compare: https://github.com/openssl/openssl/compare/17345cf10f97...544758738dad


[openssl/openssl] 6a858e: Fix the checks in rsautl_main

2022-12-05 Thread Peiwei Hu
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 6a858e9f5967ae28dcdf7d4dcf52327f173d9517
  
https://github.com/openssl/openssl/commit/6a858e9f5967ae28dcdf7d4dcf52327f173d9517
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/rsautl.c

  Log Message:
  ---
  Fix the checks in rsautl_main

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)

(cherry picked from commit 4c3fadfe57b94f71fa83786726046b8833997c7c)


  Commit: bdb66dd4c560561d2b56d03954c6c8836102271c
  
https://github.com/openssl/openssl/commit/bdb66dd4c560561d2b56d03954c6c8836102271c
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/crmf/crmf_lib.c
M test/evp_extra_test.c

  Log Message:
  ---
  Fix the check of EVP_PKEY_decrypt_init

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)

(cherry picked from commit b794476df71441a6d30740ab9fadcc0f6d18d3d6)


  Commit: cca2d261d594972d1a29ed836b6cf3463dad2680
  
https://github.com/openssl/openssl/commit/cca2d261d594972d1a29ed836b6cf3463dad2680
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/s_server.c
M crypto/bio/bf_buff.c
M crypto/bio/bf_lbuf.c
M ssl/ssl_lib.c

  Log Message:
  ---
  Fix the check of BIO_set_write_buffer_size and BIO_set_read_buffer_size

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)

(cherry picked from commit 25d02f333b9a5531fa88db294f69a8347f275858)


Compare: https://github.com/openssl/openssl/compare/2fcf42c062cf...cca2d261d594


[openssl/openssl] 4c3fad: Fix the checks in rsautl_main

2022-12-05 Thread Peiwei Hu
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 4c3fadfe57b94f71fa83786726046b8833997c7c
  
https://github.com/openssl/openssl/commit/4c3fadfe57b94f71fa83786726046b8833997c7c
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/rsautl.c

  Log Message:
  ---
  Fix the checks in rsautl_main

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)


  Commit: b794476df71441a6d30740ab9fadcc0f6d18d3d6
  
https://github.com/openssl/openssl/commit/b794476df71441a6d30740ab9fadcc0f6d18d3d6
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/crmf/crmf_lib.c
M test/evp_extra_test.c

  Log Message:
  ---
  Fix the check of EVP_PKEY_decrypt_init

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)


  Commit: 25d02f333b9a5531fa88db294f69a8347f275858
  
https://github.com/openssl/openssl/commit/25d02f333b9a5531fa88db294f69a8347f275858
  Author: Peiwei Hu 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/s_server.c
M crypto/bio/bf_buff.c
M crypto/bio/bf_lbuf.c
M ssl/ssl_lib.c

  Log Message:
  ---
  Fix the check of BIO_set_write_buffer_size and BIO_set_read_buffer_size

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19819)


Compare: https://github.com/openssl/openssl/compare/12c20c5486b6...25d02f333b9a


[openssl/openssl] 31efcf: Fix the ceiling on how much encryption growth we c...

2022-12-05 Thread Matt Caswell
  Branch: refs/heads/OpenSSL_1_1_1-stable
  Home:   https://github.com/openssl/openssl
  Commit: 31efcf2c872f8f4d09ad5209ccbf1ada73436775
  
https://github.com/openssl/openssl/commit/31efcf2c872f8f4d09ad5209ccbf1ada73436775
  Author: Matt Caswell 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M ssl/record/rec_layer_s3.c

  Log Message:
  ---
  Fix the ceiling on how much encryption growth we can have

Stitched ciphersuites can grow by more during encryption than the code
allowed for. We fix the calculation and add an assert to check we go it
right.

Also if we are adding the MAC independently of the cipher algorithm then
the encryption growth will not include that MAC so we should remove it
from the amount of bytes that we reserve for that growth. Otherwise we
might exceed our buffer size and the WPACKET_reserve operation will
fail.

Note that this is not a security issue. Even though we can overflow the
amount of bytes reserved in the WPACKET for the encryption, the underlying
buffer is still big enough.

Reviewed-by: Tomas Mraz 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/19585)




[openssl/openssl] 2fcf42: Drop a spurious printf in evp_test.c

2022-12-05 Thread Matt Caswell
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 2fcf42c062cf4aca157f0bd30e7a03f0ed752600
  
https://github.com/openssl/openssl/commit/2fcf42c062cf4aca157f0bd30e7a03f0ed752600
  Author: Matt Caswell 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M test/evp_test.c

  Log Message:
  ---
  Drop a spurious printf in evp_test.c

A spurious printf was added to evp_test.c - probably for debugging
purposes. This actually causes runtime errors in some cases because the
name being printed can be NULL.

Fixes #19814

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19820)

(cherry picked from commit 12c20c5486b6440a9b667c93f130a8fdea029b81)




[openssl/openssl] 12c20c: Drop a spurious printf in evp_test.c

2022-12-05 Thread Matt Caswell
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 12c20c5486b6440a9b667c93f130a8fdea029b81
  
https://github.com/openssl/openssl/commit/12c20c5486b6440a9b667c93f130a8fdea029b81
  Author: Matt Caswell 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M test/evp_test.c

  Log Message:
  ---
  Drop a spurious printf in evp_test.c

A spurious printf was added to evp_test.c - probably for debugging
purposes. This actually causes runtime errors in some cases because the
name being printed can be NULL.

Fixes #19814

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19820)




[openssl/openssl] 3c5303: Sync CHANGES.md and NEWS.md with 3.1 release

2022-12-05 Thread Tomáš Mráz
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 3c53032a13fe48421e04d6314ad473f24dbb08a8
  
https://github.com/openssl/openssl/commit/3c53032a13fe48421e04d6314ad473f24dbb08a8
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M CHANGES.md
M NEWS.md

  Log Message:
  ---
  Sync CHANGES.md and NEWS.md with 3.1 release

Reviewed-by: Matt Caswell 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/19808)




[openssl/openssl] 0510f7: ossl_kdf_ctx_create(): Check for NULL KDF being fe...

2022-12-05 Thread Tomáš Mráz
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 0510f79265bf18fea5f13c1391a12397339db8b7
  
https://github.com/openssl/openssl/commit/0510f79265bf18fea5f13c1391a12397339db8b7
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/hpke/hpke_util.c

  Log Message:
  ---
  ossl_kdf_ctx_create(): Check for NULL KDF being fetched

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19784)


  Commit: 910221454bfcabf1917fa65462f4cae48be5a624
  
https://github.com/openssl/openssl/commit/910221454bfcabf1917fa65462f4cae48be5a624
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/hpke/hpke.c

  Log Message:
  ---
  hpke_aead_enc/dec(): Refactor to pass in OSSL_HPKE_CTX *

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19784)


  Commit: d9ed3068df038811211b1f9c9f2f4ee2a6840aa3
  
https://github.com/openssl/openssl/commit/d9ed3068df038811211b1f9c9f2f4ee2a6840aa3
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/hpke/hpke.c
M test/hpke_test.c

  Log Message:
  ---
  Refactoring some operations to avoid repeated calls

Fetch the EVP_CIPHER for aead in OSSL_HPKE_CTX_new()
to avoid re-fetching on each aead operation.

Save kem/kdf/aead_info in OSSL_HPKE_CTX.

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19784)


  Commit: 36b4d7a69836fdf0ede1ea00879b26047bf93056
  
https://github.com/openssl/openssl/commit/36b4d7a69836fdf0ede1ea00879b26047bf93056
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M crypto/hpke/hpke_util.c
M test/hpke_test.c

  Log Message:
  ---
  hpke: fix tests with disabled chacha20 or poly1305

Reviewed-by: Matt Caswell 
Reviewed-by: Shane Lontis 
(Merged from https://github.com/openssl/openssl/pull/19784)


Compare: https://github.com/openssl/openssl/compare/d861bc03ee2e...36b4d7a69836


[openssl/openssl] f02942: Fix build on NonStop

2022-12-05 Thread Tomáš Mráz
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: f0294208d112ec20d8782f367b4c47b01be185e2
  
https://github.com/openssl/openssl/commit/f0294208d112ec20d8782f367b4c47b01be185e2
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/speed.c

  Log Message:
  ---
  Fix build on NonStop

Fixes #19810

Reviewed-by: Tim Hudson 
Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: Richard Levitte 
(Merged from https://github.com/openssl/openssl/pull/19811)

(cherry picked from commit d861bc03ee2ea9945f2a52f04548398ea0b92f94)




[openssl/openssl] d861bc: Fix build on NonStop

2022-12-05 Thread Tomáš Mráz
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: d861bc03ee2ea9945f2a52f04548398ea0b92f94
  
https://github.com/openssl/openssl/commit/d861bc03ee2ea9945f2a52f04548398ea0b92f94
  Author: Tomas Mraz 
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
M apps/speed.c

  Log Message:
  ---
  Fix build on NonStop

Fixes #19810

Reviewed-by: Tim Hudson 
Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: Richard Levitte 
(Merged from https://github.com/openssl/openssl/pull/19811)