Re: [openssl/openssl] 6332f4: CI: add GCC 11

2022-06-26 Thread Dr Paul Dale
This was a force push to remove the "CLA: trivial" lines in the commit 
messages.
The CLA lines were missed by the reviewers and I merged them earlier 
today.  The author quickly submitted an ICLA once I realised and 
mentioned it.



Pauli


On 27/6/22 12:18, pauli wrote:

   Branch: refs/heads/master
   Home:   https://github.openssl.org/openssl/openssl
   Commit: 6332f4c4a2c153869b169d250d9736962abe12c6
   
https://github.openssl.org/openssl/openssl/commit/6332f4c4a2c153869b169d250d9736962abe12c6
   Author: Sam James 
   Date:   2022-06-27 (Mon, 27 Jun 2022)

   Changed paths:
 M .github/workflows/compiler-zoo.yml

   Log Message:
   ---
   CI: add GCC 11

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/18639)


   Commit: 712c13c57b97e2e25ca23048f3ba6f50115cacd7
   
https://github.openssl.org/openssl/openssl/commit/712c13c57b97e2e25ca23048f3ba6f50115cacd7
   Author: Sam James 
   Date:   2022-06-27 (Mon, 27 Jun 2022)

   Changed paths:
 M .github/workflows/compiler-zoo.yml

   Log Message:
   ---
   CI: Upgrade to Ubuntu 22.04 to add GCC 12, Clang 13, Clang 14

Notably, this might have caught #18225, as Clang 14 wasn't - and is not yet
until this commit - in OpenSSL's CI.

It makes sense to ensure CI tests compilers used in newer Linux distributions:
* Fedora 36 ships with GCC 12
* Ubuntu 22.04 ships with Clang 14

We switch from 'ubuntu-latest' (which can change meaning but currently points
to ubuntu-20.04) to ubuntu-20.04 for the older existing compilers, and
ubuntu-22.04 for the newer ones added by this commit.

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/18639)


   Commit: 6162a2402d6b47c597c271bfb6a67d64bf183383
   
https://github.openssl.org/openssl/openssl/commit/6162a2402d6b47c597c271bfb6a67d64bf183383
   Author: Sam James 
   Date:   2022-06-27 (Mon, 27 Jun 2022)

   Changed paths:
 M test/test_test.c

   Log Message:
   ---
   test: placate Clang's --Wbitwise-instead-of-logical

```
test/test_test.c:58:9: note: cast one or both operands to int to silence this 
warning
test/test_test.c:58:9: error: use of bitwise '|' with boolean operands 
[-Werror,-Wbitwise-instead-of-logical]
 if (!TEST(1, TEST_uint_eq(3u, 3u))
 ^~
test/test_test.c:58:9: note: cast one or both operands to int to silence this 
warning
```

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/18639)


Compare: 
https://github.openssl.org/openssl/openssl/compare/1a645b98a212...6162a2402d6b





[openssl/openssl] 6332f4: CI: add GCC 11

2022-06-26 Thread pauli
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 6332f4c4a2c153869b169d250d9736962abe12c6
  
https://github.openssl.org/openssl/openssl/commit/6332f4c4a2c153869b169d250d9736962abe12c6
  Author: Sam James 
  Date:   2022-06-27 (Mon, 27 Jun 2022)

  Changed paths:
M .github/workflows/compiler-zoo.yml

  Log Message:
  ---
  CI: add GCC 11

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/18639)


  Commit: 712c13c57b97e2e25ca23048f3ba6f50115cacd7
  
https://github.openssl.org/openssl/openssl/commit/712c13c57b97e2e25ca23048f3ba6f50115cacd7
  Author: Sam James 
  Date:   2022-06-27 (Mon, 27 Jun 2022)

  Changed paths:
M .github/workflows/compiler-zoo.yml

  Log Message:
  ---
  CI: Upgrade to Ubuntu 22.04 to add GCC 12, Clang 13, Clang 14

Notably, this might have caught #18225, as Clang 14 wasn't - and is not yet
until this commit - in OpenSSL's CI.

It makes sense to ensure CI tests compilers used in newer Linux distributions:
* Fedora 36 ships with GCC 12
* Ubuntu 22.04 ships with Clang 14

We switch from 'ubuntu-latest' (which can change meaning but currently points
to ubuntu-20.04) to ubuntu-20.04 for the older existing compilers, and
ubuntu-22.04 for the newer ones added by this commit.

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/18639)


  Commit: 6162a2402d6b47c597c271bfb6a67d64bf183383
  
https://github.openssl.org/openssl/openssl/commit/6162a2402d6b47c597c271bfb6a67d64bf183383
  Author: Sam James 
  Date:   2022-06-27 (Mon, 27 Jun 2022)

  Changed paths:
M test/test_test.c

  Log Message:
  ---
  test: placate Clang's --Wbitwise-instead-of-logical

```
test/test_test.c:58:9: note: cast one or both operands to int to silence this 
warning
test/test_test.c:58:9: error: use of bitwise '|' with boolean operands 
[-Werror,-Wbitwise-instead-of-logical]
if (!TEST(1, TEST_uint_eq(3u, 3u))
^~
test/test_test.c:58:9: note: cast one or both operands to int to silence this 
warning
```

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/18639)


Compare: 
https://github.openssl.org/openssl/openssl/compare/1a645b98a212...6162a2402d6b