Re: SHOWSTOPPER BUG [ANNOUNCE] OpenSSL 0.9.5 beta2 available

[Franz Sirl]

Am Son, 27 Feb 2000 schrieb Richard Levitte:
The second beta release of OpenSSL 0.9.5 is now available from the
OpenSSL FTP site URL: ftp://ftp.openssl.org/source/.  This is the
final beta.  If it's all working, the release won't differ except for
the version number.

The release of OpenSSL 0.9.5 is scheduled for Monday 2000-02-28.
To make sure that it will work correctly, please test this version
(especially on less common platforms), and report any problems to
[EMAIL PROTECTED].


Hi,

it seems you just introduced a va_arg handling bug in beta2, remember you have
to pass a promoted type to va_arg, so va_arg(xyz, short int) is invalid C code.

gcc-2.96 errors out with:

b_print.c: In function `dopr':
b_print.c:295: `short int' is promoted to `int' when passed through `...'
b_print.c:295: (so you should pass `int' not `short int' to `va_arg')
b_print.c:319: `short unsigned int' is promoted to `int' when passed through `...'
b_print.c:319: (so you should pass `int' not `unsigned short int' to `va_arg')

The attached patch fixes that.

Franz.

--- openssl-0.9.5beta2/crypto/bio/b_print.c~Sun Feb 27 05:15:36 2000
+++ openssl-0.9.5beta2/crypto/bio/b_print.c Sun Feb 27 12:20:47 2000
@@ -292,7 +292,7 @@ dopr(
 case 'i':
 switch (cflags) {
 case DP_C_SHORT:
-value = va_arg(args, short int);
+value = (short int) va_arg(args, int);
 break;
 case DP_C_LONG:
 value = va_arg(args, long int);
@@ -315,8 +315,8 @@ dopr(
 flags |= DP_F_UNSIGNED;
 switch (cflags) {
 case DP_C_SHORT:
-value = va_arg(args,
-unsigned short int);
+value = (unsigned short int) va_arg(args,
+unsigned int);
 break;
 case DP_C_LONG:
 value = (LLONG) va_arg(args,
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [ANNOUNCE] OpenSSL 0.9.5 beta1 available

[Franz Sirl]

At 18:45 24.02.00 , Ulf Moeller wrote:
The first beta release of OpenSSL 0.9.5 is now available from the
OpenSSL FTP site URL: ftp://ftp.openssl.org/source/.

The release of OpenSSL 0.9.5 is scheduled for next Monday.  To make
sure that it will work correctly, please test this version (especially
on less common platforms), and report any problems to
[EMAIL PROTECTED].

Built and tested OK on Linux/PPC, glibc-2.1.3, gcc-2.95.2:

OpenSSL 0.9.5beta1 24 Feb 2000
built on: Fri Feb 25 05:55:53 MST 2000
platform: linux-ppc
options:  bn(64,32) md2(int) rc4(ptr,int) des(idx,cisc,4,long) idea(int) 
blowfish(idx)
compiler: gcc -DB_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -Wall


Just one minor nit, please incorporate this patch, cause gcc knows about 
longlong:

diff -u Configure.~1~ Configure
--- Configure.~1~   Wed Feb 23 15:45:22 2000
+++ Configure   Fri Feb 25 05:53:17 2000
@@ -270,7 +270,7 @@
  "debug-linux-elf","gcc:-DREF_CHECK -DBN_CTX_DEBUG -DCRYPTO_MDEBUG 
-DL_ENDIAN -DTERMIO -g -m486 -Wall::-D_REENTRANT:-lefence:BN_LLONG 
$x86_gcc_des $x86_gcc_opts:$x86_elf_asm",
  "linux-aout",  "gcc:-DL_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -m486 
-Wall::(unknown)::BN_LLONG $x86_gcc_des $x86_gcc_opts:$x86_out_asm",
  "linux-mips",   "gcc:-DL_ENDIAN -DTERMIO -O3 -fomit-frame-pointer 
-Wall::(unknown)::BN_LLONG:::",
-"linux-ppc","gcc:-DB_ENDIAN -DTERMIO -O3 -fomit-frame-pointer 
-Wall::(unknown)",
+"linux-ppc","gcc:-DB_ENDIAN -DTERMIO -O3 -fomit-frame-pointer 
-Wall::(unknown)::BN_LLONG:::",
  "NetBSD-sparc","gcc:-DTERMIOS -O3 -fomit-frame-pointer -mv8 -Wall 
-DB_ENDIAN::(unknown)::BN_LLONG MD2_CHAR RC4_INDEX DES_UNROLL:::",
  "NetBSD-m68",  "gcc:-DTERMIOS -O3 -fomit-frame-pointer -Wall 
-DB_ENDIAN::(unknown)::BN_LLONG MD2_CHAR RC4_INDEX DES_UNROLL:::",
  "NetBSD-x86",  "gcc:-DTERMIOS -O3 -fomit-frame-pointer -m486 
-Wall::(unknown)::BN_LLONG $x86_gcc_des $x86_gcc_opts:",

Thanks,
Franz.

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]