Re: [openssl-dev] [openssl.org #4698] PEM parsing incorrect; whitespace in PEM crashes parser

[Salz, Rich via RT]

Well, it is a SHOULD not a MUST.  But point taken it could be (much) better :)


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4698
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4697] Bug in 1.1.0 (lost compatibility with previous releases)

[Salz, Rich via RT]

I think you are reading too much into Viktor's words.  From my perspective he 
was proposing a work-around, nothing more.

Yeah, what we did is sub-optimal.  Not the first time, won't be the last :)

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4697
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4676] Error converting to p12 crt

[Salz, Rich via RT]

You did not cut/paste the command line properly because you wrote "-in -inkey" 
which is wrong.  Or maybe that is your error?



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4676
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4686] [BUG] Failure to compile if HAVE_CRYPTODEV is defined in OpenSSL 1.0.2i

[Salz, Rich via RT]

We have a fix waiting for internal review; see GitHub issue 1546.



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4686
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4684] Potential problem with OPENSSL_cleanse

[Salz, Rich via RT]

We do have assembler versions for most CPI's.

Closing ticket.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4684
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4668] Enhancement request: website: support proper titles

[Salz, Rich via RT]

> Errr, yes. That's because all pages include the same header, which has:
> 
> OpenSSL
> 
> I thought that was by design...

No, it was because the person who rebuilt the web doesn't know much about the 
web.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4668
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4669] Enhancement request: let dgst support multiple files

[Salz, Rich via RT]

Yeah, something like that for 1.0.2; simpler for 1.1.0.  I'll do it.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4669
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4668] Enhancement request: website: support proper titles

[Salz, Rich via RT]

There is a bug.  Navigate around and then right-click on the back button.  All 
the pages just say openssl.
Re-opening.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4668
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4668] Enhancement request: website: support proper titles

[Salz, Rich via RT]

Can you please provide some concrete examples, so I know what to look for and 
fix?  (I'm kinda slow sometimes)
Thanks!



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4668
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [openssl.org #4662] overflow check missing on BIO_new_file

[Salz, Rich via RT]

From: Sunil Singh [mailto:ekodevelop...@gmail.com]
Sent: Saturday, August 27, 2016 2:42 AM
To: Salz, Rich; openssl-secur...@openssl.org
Subject: Re: [openssl-security] Multiple issue with BIO_new_file Internal 
function (potential stack overflow/Crash)


I don't think its right to say that its not a security bug, if somebody pass a 
huge filename string which results is _alloca failure obviously its leads to 
stack overflow

on the same grounds i can lightly compare it to malloc and not checking its 
return value?

Input to function can come from any place why do you think its should not be 
validated?

Also if i agrees with you  i can say simply strlen(...) is also valid then but 
its depreciated by MSFT and other strlen_l(...) is provided which  accept size

For you  convenience  check this
http://linux.die.net/man/3/alloca

http://stackoverflow.com/questions/1018853/why-is-the-use-of-alloca-not-considered-good-practice

Also previously i provided already MSFT link which clearly mentions about its 
usage

Thanks


On Fri, Aug 26, 2016 at 10:44 PM, Salz, Rich 
> wrote:
This is not a security bug; an application program could mis-use the API.

Thanks for looking at the code!

--
Senior Architect, Akamai Technologies
IM: richs...@jabber.at Twitter: RichSalz

From: Sunil Singh 
[mailto:ekodevelop...@gmail.com]
Sent: Friday, August 26, 2016 1:09 PM
To: openssl-secur...@openssl.org
Subject: [openssl-security] Multiple issue with BIO_new_file Internal function 
(potential stack overflow/Crash)

Hello,

While working on the program of 
https://hackerone.com/ibb-openssl
 this was found

Report Below:-

Function Design issue

1. in BIO_new_file no check of  filename param
2. in internal function call
static FILE *file_fopen(const char *filename, const char *mode)

again no check of filename  param

3. At   WCHAR *wfilename = _alloca(sz * sizeof(WCHAR))
Refer to 
https://msdn.microsoft.com/en-us/library/wb1s57t5.aspx

 for proper use of  _alloca  it must be guarded  can cause stack overflow in 
case stack memory not fulfilled  and again  no return value(wfilename ) is 
checked


Thanks,
Sunil Singh


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4662
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4651] [BUG] malloc_failure in ASN1_D2I_READ_BIO with large smime encoded file

[Salz, Rich via RT]

Try it, it will be a huge invasive change.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4651
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4644] bug: cert verification always examining entire chain

[Salz, Rich via RT]

> Why do you have to trust root CAs? Why can't you trust at a lower level, e.g.
> an intermediate CA or even a leaf certificate that is not a CA at all?

I said CA's, not root CA's.

As Viktor pointed out, this doesn't work in 1.0.1

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4644
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4602] Missing accessors

[Salz, Rich via RT]

I am not sure what to suggest.  This conversation is bouncing across two ticket 
systems and is all about a legacy certificate format that is, what, outdated 
since 2002?

I am hard-pressed to see why OpenSSL 1.1 has to do anything other than what 
Richard proposed.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4602
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4602] Missing accessors

[Salz, Rich via RT]

> That's exactly what we currently do, we provide a verification callback, but
> we do need to be able to set the failing cert in a chain for that.

Stick it in EXDAT?

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4602
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4602] Missing accessors

[Salz, Rich via RT]

Perhaps the GRID folks can just write their own validation routine completely?




-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4602
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4622] OpenSSL doesn't recognise pre-rfc3820 proxy certs

[Salz, Rich via RT]

And now, with subject clearly stated, I think we should not do this.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4622
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4620] OCSP_basic_verify() question/comment

[Salz, Rich via RT]

> OCSP responses do not seem to include the intermediate certificates so they
> have to be acquired in other ways.   I have been doing this and adding them
> to the certificate stack handed to OCSP_basic_verify().

Perhaps adding them to X509_STORE or STORE_CTX directly?

> I am relatively new to this so I may be incorrect; however, it seems to me
> that the certificates in the cert argument should be added to the
> X509_STORE_CTX.

If you need to add certificates to validate a chain, it seems safer to 
explicitly add them to the store, not implicitly.



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4620
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4614] pthread_once and malloc failures

[Salz, Rich via RT]

Previously we've changed return-types from void to int.  If there's still time, 
that seems like the thing to do here.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4614
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4613] openssl RSA key: verify error 1.0.1t

[Salz, Rich via RT]

Can you use a more recent version?  1.0.1 is end of life and only getting 
security fixes (and then only for the rest of the year).

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4613
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4611] PKCS12_create() not thread-safe for ECDSA

[Salz, Rich via RT]

> These APIs are documented as thread safe, and should not change the
> internal flags of the pkey without proper locking.

Where is that?

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4611
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4609] Configure does not honor requests for ld.gold

[Salz, Rich via RT]

I don't know what you expect us to do.  We don't use the LD variable.



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4609
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4602] Missing accessors

[Salz, Rich via RT]

I think we should ask kurt to ask the original reporter what they need to do.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4602
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4606] Resolved: BUG: Windows Startup Code in OpenSSL RAND_poll() Is Ineffective

[Salz, Rich via RT]

I don't know what 1.1 beta source you downloaded.  The code on GitHub is the 
latest version of what will be 1.1  It *is* fixed, just later than the version 
you downloaded.



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4606
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4601] install_sw does not honor --openssldir

[Salz, Rich via RT]

> I don't want either of them. I only want to install the library in the 
> directory of
> my choosing :)

#! /bin/sh
make $* && cp *.a $MYDIR

Less flippantly, not everything is supported :)


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4601
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4589] Resolved: simplifying writing code that is 1.0.x and 1.1.x compatible

[Salz, Rich via RT]

> and you will not accept pull requests that do that?

So far, the team is not interested in doing that.  Features are not added to 
stable branches.  But, for myself, I would like to see something like a GitHub 
repo that built on top of 1.0.2 and made the 1.1 API's available. I think that 
for most of them it should not be too hard.

> what about Debian CVE-2008-0166 like scenario?

So far that kind of thing seems unlikely, but maybe I'm missing the point your 
trying to make?



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4589
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4587] openssl on arm linux run err!

[Salz, Rich via RT]

 
> Also, under the x86 no problem.Now how to solve this problem?

The same way you debug any C problem.  Start by running it under the debugger?



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4587
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4589] Resolved: simplifying writing code that is 1.0.x and 1.1.x compatible

[Salz, Rich via RT]

> But obviously I was expecting too much...

Sorry you're not pleased.  Not sure what to say -- you get what you pay for?  
Maybe someone will come up with a "openssl-102-compat" package?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4589
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4587] openssl on arm linux run err!

[Salz, Rich via RT]

> Guess problem is caused by the CPU architecture.The same example, arm
> and x86 result is different.hope to receive your reply very much!

Yes it probably is.

What did you change to make it compile?

The demo's are mostly old and broken, and in the next release most of them are 
gone.  Looks in apps/s_client.c, for example.  This is currently not likely to 
get fixed without a lot of detail.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4587
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4592] [docs] SSL_set_app_data() returns 'int', not 'void'

[Salz, Rich via RT]

You missed SSL_CTX_set_app_data :)
I'll fix this as part of another doc fix which is being reviewed now.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4592
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4587] openssl on arm linux run err!

[Salz, Rich via RT]

Is this using 1.0.1?
Please try to do it with 1.0.2 or master.



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4587
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4580] "openssl verify -CAfile cacerts.pem cert.pem" fails if cacerts.pem is ordered in certain ways

[Salz, Rich via RT]

Yes, it should not crash.  But without more information it is hard/impossible 
to debug.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4580
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4580] "openssl verify -CAfile cacerts.pem cert.pem" fails if cacerts.pem is ordered in certain ways

[Salz, Rich via RT]

Having a mix of experied and unexpired certificates in the trust store for the 
same issuer/key seems to be undefined.  I am not sure this is a bug.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4580
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4581] [1.0.2] Running tests in parallel results in failure

[Salz, Rich via RT]

This is not supported.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4581
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4579] Bug - libcrypto.a null pointer dereference bug

[Salz, Rich via RT]

Need more information, like a full backtrace and how to reproduce it.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4579
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4545] Crash in crypto/rand/md_rand.c

[Salz, Rich via RT]

Sending mail re-opens the ticket.

Rats, wish it was fixed.  Going to need something to more easily reproduce it, 
I guess. 

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4545
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4576] X25519, ECPKParameters_print

[Salz, Rich via RT]

I don't think this will get fixed for 1.1


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4576
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4545] Resolved: Crash in crypto/rand/md_rand.c

[Salz, Rich via RT]

Ah, didn't realize you needed it in 1.0.2; will backport shortl.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4545
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4558] Performance issue with DTLS packet reassembly

[Salz, Rich via RT]

> It still seems like pqueue out to be excised from the source base and replace
> with something simpler.

Agree.

Could you go to Github and open an issue on this?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4558
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4362] chacha-x86.pl has stricter aliasing requirements than other files

[Salz, Rich via RT]

Not defined means we make no  guarantees.  OpenSSL can depend on what it knows 
to be true.  In the next release we can revisit this.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4362
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4038] SSLv2 session reuse is broken on the 1.0.2 branch

[Salz, Rich via RT]

So are we still fixing SSLv2 bugs?  Or are they too low on the priority list?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4038
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4571] SegFault when OBJ_create is called from multiple threads (despite setting up locking_function)

[Salz, Rich via RT]

> That's fine with me, though, it might bite someone in the future. Is there any
> documentation or site listing which funcs would be thread-safe? (if this is
> offtopic, please let me know, and we'll simply end the thread)

Please take it to openssl-dev mailing list.  It's a good discussion to have!


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4571
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4568] Enhancement request: Capability vector accessor function for arm and ppc

[Salz, Rich via RT]

Doesn't it make more sense to have a single API that returns the 
platform-specific flags?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4568
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4552] Bug report: hex string is too long, problem in set_hex()?

[Salz, Rich via RT]

> If the size multiplier is changed to, say, 4, then the problem goes away with
> no apparent ill effects. Reading the code for set_hex() and its caller, it 
> does
> not appear that the size multiplier is related to a buffer size or some other
> limitation.

Yes it is, it's the size of the buffer to hold the converted text->binary 
string.  Changing the multiplier will overwrite data buffers.

There was a bug where it got the size calculation wrong, I think.  But this is 
not a bug as reported.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4552
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4457] apps/apps.c and apps/ocsp.c needs for fd_set

[Salz, Rich via RT]

Since it 'just works' for now, maybe remove the 1.1 milestone?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4457
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #3502] nameConstraints bypass bug

[Salz, Rich via RT]

I completely agree that nameconstraints are going to become a bigger deal, 
likely in the next 12-24 months, and certainly during the peak usage time of 
OpenSSL 1.1



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=3502
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #3502] nameConstraints bypass bug

[Salz, Rich via RT]

> Note that other implementations treated this as a bug and fixed it a long time
> ago.

What other implementations, and what did they do?  Always treating a CN as a 
DNS name?  We can't.

> I'm not sure what "deprecated" and "mandated" mean in the openssl
> context.  If openssl actually de-implemented CN-as-hostname and actually
> mandated SAN, that would solve the nameConstraints bypass bug in grand
> style.

Applications can do that now by setting the right flag, as Viktor pointed out.  
I think it's too late to make the default change for 1.1

> How about this for a heuristic:  If nameConstraints are in effect, then the
> validator MUST NOT accept the CN as a DNS name.  This seems like the least
> the validator could do, in light of the aforementioned deprecation.

Probably.
 
>  -- The problem is not solved until bad guys are
>   /required/ to use SAN;

Applications can make that happen now.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=3502
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #1298] OpenSSL bug in libcrypto.so:RAND_poll() crashes apache2 @ startup

[Salz, Rich via RT]

It's probably not an issue because the number of file descriptors has increased 
on the native O/S's.  But "file descriptor exhaustion" is still an issue for 
RNG's (google it) and we should keep it in mind for the future.  What's the 
best way to do that?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=1298
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4522] Update to openssl.spec supplied with 1.0.1s

[Salz, Rich via RT]

1.0.1 is at end-of life and is only getting security fixes for the rest of the 
year.
1.0.2 is LTS and maybe this needs to be ported there (and master) as well?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4522
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4524] [BUG] TLS 1.2 handshake hangs for TLS 1.0 only hosts

[Salz, Rich via RT]

> Since this is a MS IIS 7.0 server I would argue that it'd be in the interest 
> of
> openssl to handle the situation rather than accept this scenario - since IIS 
> is
> likely powering more than a few hosts?

It's a known bug, and openssl can work-around the bug by configuring as 
described.





-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4524
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4518] OpenSSL-1.1.0-pre5 RSA_set0_key and related RSA_get0_*, RSA_set0_*, DSA_set0_* and DSA_get0_* problems

[Salz, Rich via RT]

That code is still wrong.  Once you "get0" something you can only look at it.  
You cannot pass it off to a "set0" function.  Get0 gives you a pointer that 
*you do not own* and *set0* takes a pointer that you DO own and are giving 
away.  You can't give away something that isn't yours :)

The error is thinking that "my_e" is yours; it's not.  As documtend.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4518
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4518] OpenSSL-1.1.0-pre5 RSA_set0_key and related RSA_get0_*, RSA_set0_*, DSA_set0_* and DSA_get0_* problems

[Salz, Rich via RT]

> RSA_get0_key(rsa, n, e, NULL); /* note this is a GET0 */
> /* other stuff done, such as calculating d */ RSA_set0_key(rsa, n, e, d);
> 
> rsa is left with n and e pointing to unallocated storage.

That code is incorrect.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4518
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4518] OpenSSL-1.1.0-pre5 RSA_set0_key and related RSA_get0_*, RSA_set0_*, DSA_set0_* and DSA_get0_* problems

[Salz, Rich via RT]

> I can live with it.
> The only solution without some type of change was :
> 
>  RSA_set0_key(rsa, n, e, NULL);
>  /* other stuff done, such as calculating d */
>  n_new = BN_dup(n);
>  e_new = BN_dup(e);
>  RSA_set0_key(rsa, n_new, e_new, d);
> 
> It is really gross, and is not intuitive.

Do the dup calls before the RSA_set0_key call.  Once that function returns, you 
have lost all rights to use n and e :)  Or perhaps do this:
RSA_set0_key(rsa, BN_dup(n), BN_dup(e), NULL);

> Since you all appear to not want to support individual calls to set0 and get0
> for each BIGNUM, a developer of other code is faced with a major rewrite of
> existing code just to work with OpenSSL-1.1.0-pre5.

I understand your frustration about having to change code.  But I think major 
rewrite is a bit of an overstatement.

> [S]o to maintain a code base that can be compiled with OpenSSL version
> 0.9.7 through 1.1.0 with only a few #if OPENSSL_VERSION_NUMBER we are
> taking an approach to convert the code to the 1.1.0 API and create defines
> and macros for the older versions of OpenSSL in a header file The
> introduction of these *_get0_* *_set0_* have complicated the process even
> more, requiring us to inline versions of them for the older versions of
> OpenSSL.

We would love to see such a compatibility "get ready for 1.1" facility, and if 
there were a git repo we could point to, we would gladly do so.

"Our code builds with every version of OpenSSL for the past 20 years" is kind 
of a neat thing to say, but outside of bragging rights, I'm not sure it's worth 
the effort.  But it's your code, not ours, so do what you want :)


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4518
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4519] [openssl.org bug #993] New bug report

[Salz, Rich via RT]

> Thanks for registering, when I can expect first your feedback on this bug?

This is a mostly volunteer open source project.  So hopefully soon is the best 
you can expect.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4519
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4521] openssl GCM ordering

[Salz, Rich via RT]

Why do you want GCM then?



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4521
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [openssl.org #4518] OpenSSL-1.1.0-pre5 RSA_set0_key and related RSA_get0_*, RSA_set0_*, DSA_set0_* and DSA_get0_* problems

[Salz, Rich via RT]

> Yes, but this difference adds convenience, IMHO. My preference is this:
> RSA_set0_key(rsa, n, e, d); with any parameter (except for rsa :) potentially
> NULL.

This defeats a main point: partial construction is a bad thing.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4518
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4519] [openssl.org bug #993] New bug report

[Salz, Rich via RT]

> Should I make similar in https://rt.openssl.org/ or it is enough to have in
> github.com?

We prefer bug reports in RT, not as issues.  PR's on GitHub are fine.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4519
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4518] OpenSSL-1.1.0-pre5 RSA_set0_key and related RSA_get0_*, RSA_set0_*, DSA_set0_* and DSA_get0_* problems

[Salz, Rich via RT]

No, he means setting the same value twice.  For example, making this change:
If (r=->n != n) BN_free(r->n);
If(r->e != e) BN_free(r->e);
If (r->d != d) BN_free(r->d);

I agree it shouldn't happen, but do we want to protect against that?  I could 
be convinced either way.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4518
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4518] OpenSSL-1.1.0-pre5 RSA_set0_key and related RSA_get0_*, RSA_set0_*, DSA_set0_* and DSA_get0_* problems

[Salz, Rich via RT]

> Would not a set of routines like:
> BIGNUM* RSA_get0_key_n(RSA *rsa);
> int RSA_set0_key_n(RSA *rsa, BIGNUM *n); (A set for: n, e, d, p, q, idmp1,
> idmq1, iqmp) be much more backward compatible?

We had discussed this in the team, and decided that it was better to have a 
single API that took all the piece-parts, rather than being able to set the 
individual components. It's conceptually simpler to gather what you need and 
then create a key, rather than everyone having to constantly check to see if 
all the necessary fields have been set.

> If nothing else, all the RSA_set0 routines should test if the same pointer
> value is being replaced if so do not free it.
> 
> The same logic need to be done for all the RSA_set0_* functions as well as
> the DSA_set0_* functions.

That seems like a bug we should fix.
--  
Senior Architect, Akamai Technologies
IM: richs...@jabber.at Twitter: RichSalz



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4518
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4514] [BUG] PKCS12_key_gen_uni() crashes when used with Blake

[Salz, Rich via RT]

Okay, re-open

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4514
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

[Salz, Rich via RT]

We use strdup because none of the openssl machinery (error stack, etc) might be 
set up yet.

The comment a few lines above says this!


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4489
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4472] [PATCH] alllowing wrap mode using enc command

[Salz, Rich via RT]

> the 3 'raw128*.dec' should be the same as 'raw128.dat'
> the 2 'raw192*.dec' should be the same as 'raw192.dat'
> and finally, 'raw256-256.dec' should be the same as 'raw256.dat'.

And not surprisingly, all the tests pass :)  I will make this work with our 
perl-based test framework.

> FYI I will soon report a new/updated patch with other bugs and oddities fixes
> for the enc command.
> I am still testing them, but in a few hours it should be ready.

Open a new ticket.  Or better yet a GitHub pull request if you can do that :)

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4472
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [openssl.org #4475] RE: [openssl.org #4476] PATCH: fix cast-alignment of "struct lhash_st *"

[Salz, Rich via RT]

> Not necessarily.  A union might be more comprehensive.

Better point :)


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4475
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [openssl.org #4476] PATCH: fix cast-alignment of "struct lhash_st *"

[Salz, Rich via RT]

This looks like a good change.

> This clears what looks to be hundreds of alignment related warnings like
> below.
> 
> $ git diff include/openssl/lhash.h
> diff --git a/include/openssl/lhash.h b/include/openssl/lhash.h index
> 2edd738..5da5054 100644
> --- a/include/openssl/lhash.h
> +++ b/include/openssl/lhash.h
> @@ -180,7 +180,7 @@ void lh_node_usage_stats_bio(const _LHASH *lh, BIO
> *out);  # define LHASH_OF(type) struct lhash_st_##type
> 
>  # define DEFINE_LHASH_OF(type) \
> -LHASH_OF(type) { int dummy; }; \
> +LHASH_OF(type) { unsigned long dummy; }; \
>  static ossl_inline LHASH_OF(type) * \
>  lh_##type##_new(unsigned long (*hfn)(const type *), \
>  int (*cfn)(const type *, const type *)) \

Does changing it to "void *dummy" also work?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4476
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #3676] Resolved: [PATCH] Export ASN1 templates for DH and ECDH groups

[Salz, Rich via RT]

> Will the missing export for DHparameters still be fixed for 1.1?

It was:

commit 599eccfcbf8d77eb7c89b6338fdc39a7531a9f82
Author: Rich Salz 
Date:   Wed Mar 9 20:56:43 2016 -0500



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=3676
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4473] Compile errors when compiling with C++ compiler

[Salz, Rich via RT]

> So I guess I should ask... Is using OpenSSL in a C++ program supported
> configuration?

Sure, as much as anything is "supported" in an open source project.

That's not a flip answer.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4473
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4473] Compile errors when compiling with C++ compiler

[Salz, Rich via RT]

> The configuration should only be avoided/abandoned due to technical
> reasons, and not philosophical principals.

Lack of resources and interest.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4473
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4461] No rule to make target 'crypto/include/internal/blake2_locl.h'

[Salz, Rich via RT]

> $ make depend && make clean && make
> ...
> 
> No rule to make target 'crypto/include/internal/blake2_locl.h'

Shouldn't that be clean ; make depend?

At any rate, yes, some header files moved around.  Old dependencies are out of 
date ...


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4461
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4169] openssl-1.0.2e build still recommends deprecated (unnecessary?) `make depend`, returns numerous warnings abt not finding stddef.h

[Salz, Rich via RT]

> In order build openssl 1.0.2g
> 
>   use `make depend` when prompted -- i.e., do NOT ignore the advice
>   but DO ignore the 1000's of lines of output, and just proceed to
> subsequent `make`
> 
> And that resultant build is considered a reliable build.
> 
> Is that correct?

Yes.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4169
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4169] openssl-1.0.2e build still recommends deprecated (unnecessary?) `make depend`, returns numerous warnings abt not finding stddef.h

[Salz, Rich via RT]

> We're obviously not communicating.

No, sorry.

> 'make clean', without 'make depend' does NOT build.
> 
> using 'make depend' BUILDS, but not without 1000's of lines of 'warnings'.

Ignore them.  'make depend' attempts to optimize dependencies so that only 
what's needed is built.  In this particular case it's more trouble than it's 
worth.

A future update to 1.0.2 might just remove that.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4169
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4169] openssl-1.0.2e build still recommends deprecated (unnecessary?) `make depend`, returns numerous warnings abt not finding stddef.h

[Salz, Rich via RT]

 
> Here, atm, I've no working path to a 'clean' (warning/error-free) build.

Yes, 'make clean' is just as good as 'make depend'


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4169
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4429] Cannot decrypt RC4-encrypted CMS object

[Salz, Rich via RT]

> Otherwise it would not have been possible to encrypt with RC4 with "openssl
> cms -rc4 -encrypt", would it?

It wasn't clear that it was the same version of openssl :)


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4429
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4429] Cannot decrypt RC4-encrypted CMS object

[Salz, Rich via RT]

Did you enable RC4 when you built openssl?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4429
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4410] [PATCH] add calculation of M1, M2 in srp, based on 1_0_2g(Internet mail)

[Salz, Rich via RT]

Sorry, no, it's too late to get this into 1.1

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4410
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4409] bug OpenSSL 1.0.1p 9 Jul 2015

[Salz, Rich via RT]

256 encryption?  You mean SHA-256?  That's a digest, not encryption. 

My guess, without more information like reproducible test, or a packet dump, is 
that the client is configured to only use an earlier version of TLS/SSL, which 
did not define SHA256 in its crypto-suites.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4409
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4410] [PATCH] add calculation of M1, M2 in srp, based on 1_0_2g

[Salz, Rich via RT]

We need a little more explanation.

Is this a new feature?  Being added to 1.0.2? (That won't be accepted, only 
fixes go into released branches.)  Or is this something that was dropped and 
should be restored?

Unfortunately, the 1.1 freeze deadline is in 24 hours.  This won't make it into 
1.1 unless it is a bug-fix.

I also noticed that there is no documentation of these new functions.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4410
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4409] bug OpenSSL 1.0.1p 9 Jul 2015

[Salz, Rich via RT]

> I am a bit confused, as on our server the openssl version is   OpenSSL
> 1.0.1e-fips 11 Feb 2013
> 
> I am not quite sure why a more recent version of openssl ( 1.0.1p 9 Jul
> 2015 ) does not support sha256.


 SHA-256 is in 1.0.1  You said you had issues and asked what to upgrade to, I 
gave a recommendation.

Perhaps you're trying to use a different TLS version?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4409
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4276] AutoReply: Possible bug - ts -verify -digest, error:ts_rsp_verify.c:291:

[Salz, Rich via RT]

TS is not a high priority for the OpenSSL team.  A month is not a long time.  
We are busy right now working on the next release.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4276
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4401] [PATCH] plug potential memory leak(s) in OpenSSL 1.1 pre 4 in 'ec_lib.c'

[Salz, Rich via RT]

> No, you got that right, NULL being 'safe' to free varies with OS. 

Except we mandate ANSI C which means it's portable :)

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4401
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4401] [PATCH] plug potential memory leak(s) in OpenSSL 1.1 pre 4 in 'ec_lib.c'

[Salz, Rich via RT]

> +   if (dest->mont_data != NULL)
> +   BN_MONT_CTX_free(dest->mont_data);

Free routines don't need to check for non-NULL.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4401
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #3163] [PATCH] DSTU-4145-2002 engine implementation

[Salz, Rich via RT]

Can you make a PR for that?  Or just post a diff to objects.txt?



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=3163
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #2363] bug: memory allocated by DH_new() may never be free()ed

[Salz, Rich via RT]

Roumen, you're right.  Does the leak go away when the cleanup_all_ex_data is 
called?



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=2363
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [openssl.org #4359] Duplicate n2l, etc., macros

[Salz, Rich via RT]

>From discussion in GH 664 with Rob Percival.  The issue of repeatd macros came 
>up.


Thanks. I've just looked at merging all of the various definitions of those 
macros and it's not pretty - not all of the definitions match. There's a bug in 
some of the definitions in ssl_locl.h ('c' is not bracketed) and some of the 
defintions in idea_lcl.h appear to have blatantly dishonest comments above them:
/* NOTE - c is not incremented as per n2l */
#define n2ln(c,l1,l2,n) { \
c+=n; \
...



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4359
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [openssl.org #4337] SEGV Fault in the DES_fcrypt

[Salz, Rich via RT]

From: Rafał Buczko [mailto:rafal.buczk...@gmail.com]
Sent: Monday, February 22, 2016 8:45 PM
To: openssl-secur...@openssl.org
Subject: [openssl-security] SEGV Fault in the DES_fcrypt

Hi :),

There is a segmentation fault, in function DES_fcrypt (file: 
openssl/fcrypt.c:120)

x = ret[0] = ((salt[0] == '\0') ? 'A' : salt[0]);
Eswap0 = con_salt[x] << 2;
x = ret[1] = ((salt[1] == '\0') ? 'A' : salt[1]);
Eswap1 = con_salt[x] << 6;

, which happens to happend when salt input string contains some unusual chars 
like Ý, © ... (char values from 128 to 255)
OS: Ubuntu 15.10 x86_64

Code:
#include 
int main()
{
  char ret_buff[14];
  //char *DES_fcrypt(const char *buf, const char *salt, char *ret)
  DES_fcrypt("bca76;23", "ÝÝ", ret_buff);
  return 0;
}

This is my first report, so please be understanding about any incomprehension.

Best Regards
Rafal :).

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4337
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4290] HMAC_Init_ex() return bug

[Salz, Rich via RT]

Still waiting to see from anyone else if it's a non-mac issue.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4290
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4320] [Patch] OpenSSL 1.1.0-pre3: "unable to load Key" error in PEM_get_EVP_CIPHER_INFO()

[Salz, Rich via RT]

>   *header = c;
> +header++;

Header isn't used after that assignment.  How does this line change anything?


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4320
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4175] Add new macro or PKCS7 flag to disable the check for both data and content

[Salz, Rich via RT]

> If you say that removing the #ifdef instead of removing the whole code block
> that it contained was a mistake, then I shall take you at your word and 
> refrain
> from harping on *too* much about how naughty it was to have a functional
> change hidden away in a commit which simply entitled itself "Memory leak
> fixes", without even any acknowledgement of the change in the body of the
> commit comment :)

Feel free to dock my pay :)

Looks good.

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4175
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4290] HMAC_Init_ex() return bug

[Salz, Rich via RT]

Is anyone non a non-Mac seeing this?

I'm beginning to think compiler bug.



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4290
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4289] OpenSSL 1.0.2f serious bug in Win32 makefiles, easy to fix, solution provided

[Salz, Rich via RT]

> What is the status of this bug? Will it be fixed in the next release (1.0.2f
> /1.1.0) ?

yes

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4289
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #2275] CVS HEAD: BIO b_sock: ioctl(FIONBIO) is not available everywhere; completed BIO_socket_nbio() so the #ifdef clutter in apps/* and other spots can be discarded aft

[Salz, Rich via RT]

So now you want to open a PR to fix apps/s_client,server? :)


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=2275
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4075] Enhancement request: Camellia ECDHE+GCM suites

[Salz, Rich via RT]

> over 40% of Alexa top 1 million TLS enabled servers enable Camellia

That's different than actual use, as you know.
 
> I don't see it mentioned anywhere in documentation, especially not in
> ciphers(1) man page. So, is it not so severe, or should the Camellia be
> removed from DEFAULT?

It probably will be.

I think the bottom line is that nobody on the team is enthusiastic, or even 
willing, to put into the work to add and support it.  And nobody is wiling to 
put it into the codebase these days without an internal commitment to support 
it. 

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4075
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4075] Enhancement request: Camellia ECDHE+GCM suites

[Salz, Rich via RT]

> I'm still years away from having enough crypto/C programming experience,
> what in particular should I be working on?

Read the link.


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4075
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #2021] sni bug

[Salz, Rich via RT]

> A correct logic is one single function(the code of check and parse combined)
> that collects the values of extensions and then treat them calls callbacks in 
> a
> defined order.

Yes, but right now we've got what we've got :)
 
> Actually it seems that you could influence the server behavoiur if you change
> the order of extensions in the clienthello.

Probably.

> sni first or last for example.
> That makes server application code difficult.

Yes.  It would be great to have a single function that got all parsed 
extensions.  Sadly, I don't know if we'll get it fixed before the final 
API-change deadline. :(


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=2021
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4075] Enhancement request: Camellia ECDHE+GCM suites

[Salz, Rich via RT]

> I said I would be willing to help, but got no reply on how best to ramp up on
> developing a stable addition likely to be accepted by the dev team.

There's no hard-and-fast rules.  We recently added some text: 
https://openssl.org/community/getting-started.html

But again, for the specific request here, someone from the dev team has to be 
willing to do it.

If it's really important, well, someone can always start a fork.  Or work on 
making it an external ENGINE, like GOST.
 


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4075
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4175] Add new macro or PKCS7 flag to disable the check for both data and content

[Salz, Rich via RT]

And update the PR to say that it also closes this ticket :)



-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4175
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4075] Enhancement request: Camellia ECDHE+GCM suites

[Salz, Rich via RT]

I missed a link: https://github.com/openssl/openssl/issues/320

Nobody is pressuring us.  I am sure you mean that in a kind and concerned way, 
and are not trying to be insulting.

If you can find someone on the openssl-dev team who is willing to take on the 
work, then it could go into OpenSSL.  Otherwise, consider implementing it as an 
external engine (like GOST), or do your own downstream fork.



-
http://rt.openssl.org/Ticket/Display.html?id=4075

Please log in as guest with password guest if prompted

___
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #2712] Be more liberal when trying to recognize the XMPP starttls headers

[Salz, Rich via RT]

>  Doesn't seem that way. Not present on VMS, and I can't find it on MDSN
> either.

So what I'd have to do is downcase the string and do strstr on all lowercase.  
Might be reasonable




-
http://rt.openssl.org/Ticket/Display.html?id=2712

Please log in as guest with password guest if prompted

___
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4075] Enhancement request: Camellia ECDHE+GCM suites

[Salz, Rich via RT]

> That's all we get, a one-liner, no explanation, no rationale, response?

Take a look at some of the discussion here:
https://github.com/openssl/openssl/pull/374
https://github.com/openssl/openssl/pull/154
https://github.com/openssl/openssl/pull/148

I would suggest that if you want to continue the discussion, do it on 
openssl-dev with a new subject line (so it doesn't get threaded into this RT 
ticket)


___
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #2460] OCSP server uses only IP6

[Salz, Rich via RT]

> I'm not sure what you think.  But all the apps currently only create 1 socket,
> which on some OSes could mean that it's IPv6 (or
> IPv4) only.  It needs more work.

Yes, I meant to close the window not the ticket :)  Re-opened.



-
http://rt.openssl.org/Ticket/Display.html?id=2460

Please log in as guest with password guest if prompted

___
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #3203] Normalize PFS key exchange labels

[Salz, Rich via RT]

> do you think there are pieces that aren't yet merged?  have you tried using
> the common names with 1.0.2 and they don't work?

Nope, I was just reading through all the tickets to do some basic triage.

I will close this one.  Thanks !


___
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl-dev] [openssl.org #4290] HMAC_Init_ex() return bug

[Salz, Rich via RT]

> I’m running OS X 10.11.3 and OpenSSL 1.0.206

I cannot reproduce this.  Did you build from source, or is that a 
vendor-provided version?  The ".206" isn't part of our release naming.  Did you 
mean 1.0.2f?  Do you have a sample program to show the error?


___
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev