RE: [openssl.org #853] serial/index file handling broken on Windows in 0.9.7d

2004-03-30 Thread Steven Reddie 
Hi Richard,

Sorry for the delay.  The snapshot from after you asked me to test it the
first time (openssl-0.9.7-stable-SNAP-20040327) passed my tests.

Thanks,

Steven

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Behalf Of Richard Levitte via RT
Sent: Wednesday, 31 March 2004 7:15 AM
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: [openssl.org #853] serial/index file handling broken on Windows in
0.9.7d 



Hello,

I would very much like to know if my fix worked, so I can close this 
ticket.

[levitte - Thu Mar 25 21:10:19 2004]:

 I think I fixed the problem by moving the definition of Win32_rename()
 to the end of apps.c.  Please check tomorrow's 0.9.7 snapshot and come 
 back to me with any feedback (even hoorays :-)).
 
 [EMAIL PROTECTED] - Mon Mar 22 17:17:44 2004]:
 
  Re: openssl-dev thread: New CA index subfiles (.attr, .attr.new, .
 attr.old,
  .new)
   
  OpenSSL 0.9.7d introduces a bug on Windows in the openssl executable
 in
  relation to the renaming of temporary serial and index files.  The
 renames
  are failing since the special WIN32_rename() function (which removes
 the
  destination file before the rename) is not being used on Windows due
 to the
  rename macro being undefined before it is used.  I think the problem
 was
  introduced when the serial/index file handling code was tacked onto
 the end
  of apps.c.  With similar code in a separate module previously the
 undef was
  not having such an effect.  I've verified that redefining rename by
 copying
  line 140 of apps.h and inserting it after line 353 of apps.c fixes
all 
 of
  the problems with serial and index files that I was experiencing:
   
  apps.c:352   #undef rename
  apps.c:353   return rename(from, to);
  apps.h:140   #define rename(from,to) WIN32_rename((from),(to))
   
  Regards,
   
  Steven
  
 


-- 
Richard Levitte
[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: [openssl.org #853] serial/index file handling broken on Windows in 0.9.7d

2004-03-30 Thread Richard Levitte - VMS Whacker 
In message [EMAIL PROTECTED] on Wed, 31 Mar 2004 12:57:48 +1000, Steven Reddie 
[EMAIL PROTECTED] said:

smr Sorry for the delay.  The snapshot from after you asked me to test it the
smr first time (openssl-0.9.7-stable-SNAP-20040327) passed my tests.

Thanks.

-
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte   \ Tunnlandsvägen 52 \ [EMAIL PROTECTED]
[EMAIL PROTECTED]  \ S-168 36  BROMMA  \ T: +46-708-26 53 44
\  SWEDEN   \
Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See http://www.stacken.kth.se/~levitte/mail/ for more info.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

[openssl.org #853] serial/index file handling broken on Windows in 0.9.7d

2004-03-30 Thread Richard Levitte via RT 

Steven Reddie has now confirmed, on openssl-dev, that this issue is 
resolved.

Thanks, Steve.  Ticket resolved.

[levitte - Tue Mar 30 23:14:37 2004]:

 I would very much like to know if my fix worked, so I can close this
 ticket.

-- 
Richard Levitte
[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

[openssl.org #853] serial/index file handling broken on Windows in 0.9.7d

2004-03-22 Thread Steven Reddie via RT 

Re: openssl-dev thread: New CA index subfiles (.attr, .attr.new, .attr.old,
.new)
 
OpenSSL 0.9.7d introduces a bug on Windows in the openssl executable in
relation to the renaming of temporary serial and index files.  The renames
are failing since the special WIN32_rename() function (which removes the
destination file before the rename) is not being used on Windows due to the
rename macro being undefined before it is used.  I think the problem was
introduced when the serial/index file handling code was tacked onto the end
of apps.c.  With similar code in a separate module previously the undef was
not having such an effect.  I've verified that redefining rename by copying
line 140 of apps.h and inserting it after line 353 of apps.c fixes all of
the problems with serial and index files that I was experiencing:
 
apps.c:352   #undef rename
apps.c:353   return rename(from, to);
apps.h:140   #define rename(from,to) WIN32_rename((from),(to))
 
Regards,
 
Steven

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]