Preferred method: email patches or pull requests?
I've got a pile of small test/build system commits pending in the following pull requests: test/testutil.h test registry macros https://github.com/openssl/openssl/pull/144 Build environment updates https://github.com/openssl/openssl/pull/145 Should I trickle them into openssl-dev a patch-at-a-time instead? Thanks, Mike __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
Re: Preferred method: email patches or pull requests?
On Wed, Jul 09, 2014 at 01:34:07PM -0400, Mike Bland wrote: I've got a pile of small test/build system commits pending in the following pull requests: test/testutil.h test registry macros https://github.com/openssl/openssl/pull/144 Build environment updates https://github.com/openssl/openssl/pull/145 Should I trickle them into openssl-dev a patch-at-a-time instead? Please create an RT ticket. I think having the link to the github pull request in it should be enough. Kurt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
Re: Preferred method: email patches or pull requests?
Is there some form of review process for changes? Paul On 2014-07-09 18:40, Kurt Roeckx wrote: On Wed, Jul 09, 2014 at 01:34:07PM -0400, Mike Bland wrote: I've got a pile of small test/build system commits pending in the following pull requests: test/testutil.h test registry macros https://github.com/openssl/openssl/pull/144 Build environment updates https://github.com/openssl/openssl/pull/145 Should I trickle them into openssl-dev a patch-at-a-time instead? Please create an RT ticket. I think having the link to the github pull request in it should be enough. Kurt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org -- ++ Please give generously to Great Ormond Street Hospital, London, UK A specialist hospital for sick children who need every penny! Great Ormond Street Hospital Children's Charity (GOSHCC) website: http://www.gosh.org/ ++ __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
Re: Preferred method: email patches or pull requests?
On Wed, Jul 09, 2014 at 07:00:46PM +0100, Paul Morriss wrote: Is there some form of review process for changes? It's described here: http://wiki.openssl.org/index.php/Defect_and_Feature_Review_Process Kurt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
