Re: Macintosh Port diffs

1999-09-04 Thread Bodo Moeller 

Andy Polyakov [EMAIL PROTECTED]:

 -#include sys/types.h
 -#include sys/stat.h
 +
 +#ifndef macintosh
 +#  include sys/types.h
 +#  include sys/stat.h
 +#endif

 [...] I'd suggest to replace #ifdef macintosh with #ifdef MAC_OS

 Maybe MAC_OS is not quite an appropriate symbol,
 Maybe... How about MAC_OS_pre_X then?
 as things change with MacOS X.
 Do they:-) Did you know that it comes without X11?

Sure.  But it comes with sys/types.h and sys/stat.h, which is what
these patches are about.  (Also it comes with built-in deadlocks --
if you believe the package design: The toothed wheels are so arranged
that they cannot turn at all because between pairs of neighbouring large
wheels there's often a small one that touches both, meaning that it would
have to turn clockwise and counterclockwise at the same time if the
large wheels were moved.)
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Macintosh Port diffs

1999-09-03 Thread Bodo Moeller 

Andy Polyakov [EMAIL PROTECTED]:

 -#include sys/types.h
 -#include sys/stat.h
 +
 +#ifndef macintosh
 +#  include sys/types.h
 +#  include sys/stat.h
 +#endif

 [...] I'd suggest to replace #ifdef macintosh with #ifdef MAC_OS
 and put something like following into e_os.h:

 #if defined(__MWERKS__)  defined(macintosh)
 # if macintosh==1
 #  define MAC_OS
 # endif
 #endif

Maybe MAC_OS is not quite an appropriate symbol, as things change
with MacOS X.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]

Re: Macintosh Port diffs

1999-09-03 Thread Rich Salz 

  and put something like following into e_os.h:
 
  #if defined(__MWERKS__)  defined(macintosh)
  # if macintosh==1
  #  define MAC_OS
  # endif
  #endif

That is a very bad way to do things.

Use feature tests in your code -- HAVE_SYS_TIME, HAVE_STRCASECMP,
etc.  Then in a single place (like e_os.h), test on the platform
and set the feature macros.

__
OpenSSL Project http://www.openssl.org
Development Mailing List   [EMAIL PROTECTED]
Automated List Manager   [EMAIL PROTECTED]