Re: Stale PR stats @May01
On Fri, May 1, 2020 at 6:19 PM Mark J Cox wrote: > On Fri, May 1, 2020 at 3:30 PM Dmitry Belyavsky wrote: > .. > > And I also got an idea that ping comment leaves PRs out of this > statistics :) > > Thanks! The script is designed to ignore the automated pings that it > creates itself so they themselves don't reset the dates and > artificially stop things being stale. Instead they will hopefully > nudge folks into taking some action that will actually stop the PRs > being stale :)) > Well, I see some Catch-22 elements here... -- SY, Dmitry Belyavsky
Re: Stale PR stats @May01
On Fri, May 1, 2020 at 3:30 PM Dmitry Belyavsky wrote: .. > And I also got an idea that ping comment leaves PRs out of this statistics :) Thanks! The script is designed to ignore the automated pings that it creates itself so they themselves don't reset the dates and artificially stop things being stale. Instead they will hopefully nudge folks into taking some action that will actually stop the PRs being stale :)) Mark
Re: Stale PR stats @May01
Dear Mark, Many thanks for your efforts! And I also got an idea that ping comment leaves PRs out of this statistics :) On Fri, May 1, 2020 at 10:53 AM Mark J Cox wrote: > Last month I started a script to ping stale PRs that were in certain > states. The script has also been collecting statistics (trending and > snapshot). I intend to post this monthly and after a few months with > trends and commentary. > > PRs that have not had any updates in the last 30 days and are not WIP: > > all ( 148 issues, median 188 days) of which: > > failed CI ( 23 issues, median 175 days) > deferred after 1.1.1 ( 41 issues, median 188 days) > cla required ( 19 issues, median 422 days) > waiting for reporter ( 15 issues, median 275 days) > waiting for review ( 1 issues, median 38 days) > waiting for OMC ( 2 issues, median 112.0 days) > waiting for OTC ( 1 issues, median 84 days) > all other ( 46 issues, median 239.5 days) > > So, ignoring deferred issues too you could summarise this as: > > Stale PRs waiting for us to do something: 27 (last months: 29) > Stale PRs waiting for the reporter to do something: 34 (last months: > 37) > Stale PRs with unclear next action: 46 (last months: 42) > > Over time I hope we can triage the "all other" PRs with labels so we > know what the next action is on each one. > > Details: > > failed CI ( 23 issues, median 175 days) > > 11349 branch: master, reviewed:commented days:43 > 11327 reviewed:commented days:48 > 11288 branch: master, reviewed:commented days:51 > 11257 branch: 1.1.1, branch: master, reviewed:approved days:49 > 11195 branch: 1.1.1, branch: master, reviewed:commented days:38 > 11151 days:60 > 10626 days:66 > 10556 days:147 > 10465 days:164 > 9926 days:226 > 9603 days:226 > 9155 reviewed:commented days:100 > 8955 branch: 1.1.1, branch: master, reviewed:dismissed days:175 > 8687 reviewed:commented days:210 > 8389 days:415 > 8115 reviewed:commented days:48 > 7921 reviewed:commented days:419 > 7914 reviewed:approved days:478 > 7380 reviewed:commented days:566 > 7051 milestone:Assessed, reviewed:commented days:615 > 6074 milestone:Assessed, reviewed:commented days:658 > 4992 milestone:Assessed, reviewed:commented days:188 > 4486 milestone:Assessed, days:658 > > waiting for reporter ( 15 issues, median 275 days) > > 11310 reviewed:changes_requested days:43 > 10887 branch: master, reviewed:changes_requested days:37 > 10590 reviewed:changes_requested days:115 > 9677 branch: master, reviewed:changes_requested days:32 > 9575 reviewed:changes_requested days:262 > 9461 reviewed:changes_requested days:275 > 9427 reviewed:changes_requested days:282 > 9243 reviewed:changes_requested days:284 > 9240 reviewed:changes_requested days:309 > 8992 reviewed:changes_requested days:226 > 8962 reviewed:changes_requested days:44 > 8730 reviewed:changes_requested days:323 > 8674 reviewed:changes_requested days:378 > 7961 reviewed:changes_requested days:480 > 7432 reviewed:changes_requested days:559 > > waiting for OMC ( 2 issues, median 112.0 days) > > 10786 approval: done, branch: 1.1.1, branch: master, hold: need > omc decision, reviewed:approved days:52 > 10195 branch: master, hold: need omc decision, reviewed:commented > days:172 > > waiting for OTC ( 1 issues, median 84 days) > > 8300 approval: otc review pending, branch: 1.1.1, branch: master, > hold: need otc decision, reviewed:approved days:84 > > waiting for review ( 1 issues, median 38 days) > > 10587 approval: review pending, branch: 1.1.1, branch: master, > reviewed:commented days:38 > > all other ( 46 issues, median 239.5 days) > > 11398 approval: done, branch: master, reviewed:approved days:35 > 11312 days:47 > 11277 resolved: not a bug, days:50 > 11260 reviewed:commented days:55 > 11154 days:66 > 5 days:56 > 11057 days:80 > 10884 days:102 > 10818 days:108 > 10570 reviewed:commented days:124 > 10541 days:139 > 10338 reviewed:commented days:179 > 10320 branch: 1.1.1, branch: master, reviewed:commented days:170 > 10298 days:183 > 10268 days:185 > 10037 days:147 > 9655 days:157 > 9554 days:266 > 9421 branch: 1.1.1, branch: master, reviewed:approved days:121 > 9223 branch: master, reviewed:commented days:83 > 9206 days:314 > 9051 reviewed:commented days:177 > 8956 days:336 > 8920 days:213 > 8908 days:351 > 8862 days:330 > 8835 days:370 > 8743 branch: master, days:381 > 8668 days:392 > 8455 days:394 > 8420 days:395 > 8333 days:430 > 8309 branch: master, reviewed:commented days:316 > 8024 reviewed:commented days:81 > 7688 days:516 > 7615 days:520 > 7454 reviewed:commented days:471 > 7274 reviewed:approved days:322 > 7
Re: Stale PR stats @May01
This is great transparency info. Failed CI's are a problem since it's often the fault of timeouts, or sometimes master is broken. Any thoughts on how to handle that? >So, ignoring deferred issues too you could summarise this as: Stale PRs waiting for us to do something: 27 (last months: 29) Stale PRs waiting for the reporter to do something: 34 (last months: 37) Stale PRs with unclear next action: 46 (last months: 42) It would be great to see median days on those, too.
Re: Stale PR stats @May01
This is really nice! Thanks Mark. Matt On 01/05/2020 08:52, Mark J Cox wrote: > Last month I started a script to ping stale PRs that were in certain > states. The script has also been collecting statistics (trending and > snapshot). I intend to post this monthly and after a few months with > trends and commentary. > > PRs that have not had any updates in the last 30 days and are not WIP: > > all ( 148 issues, median 188 days) of which: > > failed CI ( 23 issues, median 175 days) > deferred after 1.1.1 ( 41 issues, median 188 days) > cla required ( 19 issues, median 422 days) > waiting for reporter ( 15 issues, median 275 days) > waiting for review ( 1 issues, median 38 days) > waiting for OMC ( 2 issues, median 112.0 days) > waiting for OTC ( 1 issues, median 84 days) > all other ( 46 issues, median 239.5 days) > > So, ignoring deferred issues too you could summarise this as: > > Stale PRs waiting for us to do something: 27 (last months: 29) > Stale PRs waiting for the reporter to do something: 34 (last months: 37) > Stale PRs with unclear next action: 46 (last months: 42) > > Over time I hope we can triage the "all other" PRs with labels so we > know what the next action is on each one. > > Details: > > failed CI ( 23 issues, median 175 days) > > 11349 branch: master, reviewed:commented days:43 > 11327 reviewed:commented days:48 > 11288 branch: master, reviewed:commented days:51 > 11257 branch: 1.1.1, branch: master, reviewed:approved days:49 > 11195 branch: 1.1.1, branch: master, reviewed:commented days:38 > 11151 days:60 > 10626 days:66 > 10556 days:147 > 10465 days:164 > 9926 days:226 > 9603 days:226 > 9155 reviewed:commented days:100 > 8955 branch: 1.1.1, branch: master, reviewed:dismissed days:175 > 8687 reviewed:commented days:210 > 8389 days:415 > 8115 reviewed:commented days:48 > 7921 reviewed:commented days:419 > 7914 reviewed:approved days:478 > 7380 reviewed:commented days:566 > 7051 milestone:Assessed, reviewed:commented days:615 > 6074 milestone:Assessed, reviewed:commented days:658 > 4992 milestone:Assessed, reviewed:commented days:188 > 4486 milestone:Assessed, days:658 > > waiting for reporter ( 15 issues, median 275 days) > > 11310 reviewed:changes_requested days:43 > 10887 branch: master, reviewed:changes_requested days:37 > 10590 reviewed:changes_requested days:115 > 9677 branch: master, reviewed:changes_requested days:32 > 9575 reviewed:changes_requested days:262 > 9461 reviewed:changes_requested days:275 > 9427 reviewed:changes_requested days:282 > 9243 reviewed:changes_requested days:284 > 9240 reviewed:changes_requested days:309 > 8992 reviewed:changes_requested days:226 > 8962 reviewed:changes_requested days:44 > 8730 reviewed:changes_requested days:323 > 8674 reviewed:changes_requested days:378 > 7961 reviewed:changes_requested days:480 > 7432 reviewed:changes_requested days:559 > > waiting for OMC ( 2 issues, median 112.0 days) > > 10786 approval: done, branch: 1.1.1, branch: master, hold: need > omc decision, reviewed:approved days:52 > 10195 branch: master, hold: need omc decision, reviewed:commented days:172 > > waiting for OTC ( 1 issues, median 84 days) > > 8300 approval: otc review pending, branch: 1.1.1, branch: master, > hold: need otc decision, reviewed:approved days:84 > > waiting for review ( 1 issues, median 38 days) > > 10587 approval: review pending, branch: 1.1.1, branch: master, > reviewed:commented days:38 > > all other ( 46 issues, median 239.5 days) > > 11398 approval: done, branch: master, reviewed:approved days:35 > 11312 days:47 > 11277 resolved: not a bug, days:50 > 11260 reviewed:commented days:55 > 11154 days:66 > 5 days:56 > 11057 days:80 > 10884 days:102 > 10818 days:108 > 10570 reviewed:commented days:124 > 10541 days:139 > 10338 reviewed:commented days:179 > 10320 branch: 1.1.1, branch: master, reviewed:commented days:170 > 10298 days:183 > 10268 days:185 > 10037 days:147 > 9655 days:157 > 9554 days:266 > 9421 branch: 1.1.1, branch: master, reviewed:approved days:121 > 9223 branch: master, reviewed:commented days:83 > 9206 days:314 > 9051 reviewed:commented days:177 > 8956 days:336 > 8920 days:213 > 8908 days:351 > 8862 days:330 > 8835 days:370 > 8743 branch: master, days:381 > 8668 days:392 > 8455 days:394 > 8420 days:395 > 8333 days:430 > 8309 branch: master, reviewed:commented days:316 > 8024 reviewed:commented days:81 > 7688 days:516 > 7615 days:520 > 7454 reviewed:commented days:471 > 7274 reviewed:approved days:322 > 7225 reviewed:commented days:587 > 6725 milestone:Assessed, reviewed:approve
Stale PR stats @May01
Last month I started a script to ping stale PRs that were in certain states. The script has also been collecting statistics (trending and snapshot). I intend to post this monthly and after a few months with trends and commentary. PRs that have not had any updates in the last 30 days and are not WIP: all ( 148 issues, median 188 days) of which: failed CI ( 23 issues, median 175 days) deferred after 1.1.1 ( 41 issues, median 188 days) cla required ( 19 issues, median 422 days) waiting for reporter ( 15 issues, median 275 days) waiting for review ( 1 issues, median 38 days) waiting for OMC ( 2 issues, median 112.0 days) waiting for OTC ( 1 issues, median 84 days) all other ( 46 issues, median 239.5 days) So, ignoring deferred issues too you could summarise this as: Stale PRs waiting for us to do something: 27 (last months: 29) Stale PRs waiting for the reporter to do something: 34 (last months: 37) Stale PRs with unclear next action: 46 (last months: 42) Over time I hope we can triage the "all other" PRs with labels so we know what the next action is on each one. Details: failed CI ( 23 issues, median 175 days) 11349 branch: master, reviewed:commented days:43 11327 reviewed:commented days:48 11288 branch: master, reviewed:commented days:51 11257 branch: 1.1.1, branch: master, reviewed:approved days:49 11195 branch: 1.1.1, branch: master, reviewed:commented days:38 11151 days:60 10626 days:66 10556 days:147 10465 days:164 9926 days:226 9603 days:226 9155 reviewed:commented days:100 8955 branch: 1.1.1, branch: master, reviewed:dismissed days:175 8687 reviewed:commented days:210 8389 days:415 8115 reviewed:commented days:48 7921 reviewed:commented days:419 7914 reviewed:approved days:478 7380 reviewed:commented days:566 7051 milestone:Assessed, reviewed:commented days:615 6074 milestone:Assessed, reviewed:commented days:658 4992 milestone:Assessed, reviewed:commented days:188 4486 milestone:Assessed, days:658 waiting for reporter ( 15 issues, median 275 days) 11310 reviewed:changes_requested days:43 10887 branch: master, reviewed:changes_requested days:37 10590 reviewed:changes_requested days:115 9677 branch: master, reviewed:changes_requested days:32 9575 reviewed:changes_requested days:262 9461 reviewed:changes_requested days:275 9427 reviewed:changes_requested days:282 9243 reviewed:changes_requested days:284 9240 reviewed:changes_requested days:309 8992 reviewed:changes_requested days:226 8962 reviewed:changes_requested days:44 8730 reviewed:changes_requested days:323 8674 reviewed:changes_requested days:378 7961 reviewed:changes_requested days:480 7432 reviewed:changes_requested days:559 waiting for OMC ( 2 issues, median 112.0 days) 10786 approval: done, branch: 1.1.1, branch: master, hold: need omc decision, reviewed:approved days:52 10195 branch: master, hold: need omc decision, reviewed:commented days:172 waiting for OTC ( 1 issues, median 84 days) 8300 approval: otc review pending, branch: 1.1.1, branch: master, hold: need otc decision, reviewed:approved days:84 waiting for review ( 1 issues, median 38 days) 10587 approval: review pending, branch: 1.1.1, branch: master, reviewed:commented days:38 all other ( 46 issues, median 239.5 days) 11398 approval: done, branch: master, reviewed:approved days:35 11312 days:47 11277 resolved: not a bug, days:50 11260 reviewed:commented days:55 11154 days:66 5 days:56 11057 days:80 10884 days:102 10818 days:108 10570 reviewed:commented days:124 10541 days:139 10338 reviewed:commented days:179 10320 branch: 1.1.1, branch: master, reviewed:commented days:170 10298 days:183 10268 days:185 10037 days:147 9655 days:157 9554 days:266 9421 branch: 1.1.1, branch: master, reviewed:approved days:121 9223 branch: master, reviewed:commented days:83 9206 days:314 9051 reviewed:commented days:177 8956 days:336 8920 days:213 8908 days:351 8862 days:330 8835 days:370 8743 branch: master, days:381 8668 days:392 8455 days:394 8420 days:395 8333 days:430 8309 branch: master, reviewed:commented days:316 8024 reviewed:commented days:81 7688 days:516 7615 days:520 7454 reviewed:commented days:471 7274 reviewed:approved days:322 7225 reviewed:commented days:587 6725 milestone:Assessed, reviewed:approved days:330 6518 milestone:Assessed, reviewed:approved days:681 6516 branch: 1.1.1, branch: master, milestone:Assessed, days:681 6448 milestone:Assessed, days:188 6219 milestone:Assessed, reviewed:approved days:719 5427 branch: master, milestone:Assessed, reviewed:commented days:481 4487 milestone:Assessed, days:65