Re: [Openstack] Comparing roles - case (in)sensitivity
+1 to downcasing -Original Message- From: Timothy Daly ti...@yahoo-inc.com Sent: Friday, June 8, 2012 7:49pm To: Johannes Erdfelt johan...@erdfelt.com Cc: openstack@lists.launchpad.net openstack@lists.launchpad.net Subject: Re: [Openstack] Comparing roles - case (in)sensitivity On Jun 8, 2012, at 4:16 PM, Johannes Erdfelt wrote: On Fri, Jun 08, 2012, Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? Not to speak for Kiall, but I'll make the argument that there is no value in treating admin, Admin, and admIn separately. It can only lead to confusion and frustration of the people who use OpenStack. These values are intended for people and people generally expect case-insensitive matching. Yes, it's the same word for people, but it's not the same bytes for computers. How shall we coexist in peace? Downcase everything and it won't come up. :) Cheers, Tim ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
[Openstack] OSAPI: Tenant Ids in URI
Hey Everyone, Yesterday, I merge prop'd a branch that adds the tenant id to all request uris, as is to spec. It also removes the ability to use the 'X-Auth-Project-Id' header in requests other than authentication requests. This may have implications since some custom v1.1 bindings and test suites may be broken if not updated to account for this. This does not break bindings that use the 'X-Server-Management-Url' header (such as nova client), as the tenant id would be included. We've done plenty of testing on the branch but encourage others to find problems. BUG: https://bugs.launchpad.net/nova/+bug/829512 MP: https://code.launchpad.net/~rackspace-titan/nova/tenant-id-in-uri/+merge/70930 Thanks, Alex ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
[Openstack] Jenkins - nova-pylint-errors
I've been working on cleaning up pylint errors and have a concern regarding:
E1101: %s %r has no %r member
Used when a variable is accessed for an unexistent member.
97 (59%) of the 169 errors in the nova pylint errors job on jenkins are of the
type E1101. 82/97 are located under the sqlalchemy directory. This is (mostly)
because pylint doesn't understand most of the ways classes and functions in the
database code are getting members even though they are by no means incorrect.
One example that pylint complains about is this:
nova/db/sqlalchemy/api.py
Class 'Network' has no 'fixed_ips' member
1322@require_admin_context
1323def network_get_by_instance(_context, instance_id):
1324session = get_session()
1325rv = session.query(models.Network).\
1326 filter_by(deleted=False).\
! 1327 join(models.Network.fixed_ips).\
1328 filter_by(instance_id=instance_id).\
1329 filter_by(deleted=False).\
1330 first()
But Network does have the attribute fixed_ips because it is created here:
nova/db/sqlalchemy/models.py
536: network = relationship(Network, backref=backref('fixed_ips'))
What do you guys think about setting jenkins to ignore E1101 or at least ignore
it for nova/db/sqlalchemy? If we ever want to get our pylint errors down to
zero so we can start enforcing it, we need to either do something like above or
insert pylint ignore statements throughout all the code where the error is not
really an error.
___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Jenkins - nova-pylint-errors
Hey Vish,
I may be missing something but when I test with pylint locally, I am using the
pylintrc located in trunk. The only cleanup I am doing is derived directly from
looking at the nova-pylint-errors job on Jenkins.
Alex
-Original Message-
From: Vishvananda Ishaya vishvana...@gmail.com
Sent: Monday, June 6, 2011 11:42am
To: Alex Meade alex.me...@rackspace.com
Cc: openstack@lists.launchpad.net
Subject: Re: [Openstack] Jenkins - nova-pylint-errors
Hey alex,
Justin came up with a pretty reasonable set of defaults for pylint that tends
to only show real error messages. It is the nova-pylint-errors job in jenkins.
It looks like this error has already been removed from the list (although
there is another one there about medatada #690)
Perhaps you should start your cleanup by fixing the ones still showing up in
that job rather than the default pylint output?
Vish
On Jun 6, 2011, at 6:08 AM, Alex Meade wrote:
I've been working on cleaning up pylint errors and have a concern regarding:
E1101: %s %r has no %r member
Used when a variable is accessed for an unexistent member.
97 (59%) of the 169 errors in the nova pylint errors job on jenkins are of
the type E1101. 82/97 are located under the sqlalchemy directory. This is
(mostly) because pylint doesn't understand most of the ways classes and
functions in the database code are getting members even though they are by no
means incorrect.
One example that pylint complains about is this:
nova/db/sqlalchemy/api.py
Class 'Network' has no 'fixed_ips' member
1322@require_admin_context
1323def network_get_by_instance(_context, instance_id):
1324session = get_session()
1325rv = session.query(models.Network).\
1326 filter_by(deleted=False).\
! 1327 join(models.Network.fixed_ips).\
1328 filter_by(instance_id=instance_id).\
1329 filter_by(deleted=False).\
1330 first()
But Network does have the attribute fixed_ips because it is created here:
nova/db/sqlalchemy/models.py
536: network = relationship(Network, backref=backref('fixed_ips'))
What do you guys think about setting jenkins to ignore E1101 or at least
ignore it for nova/db/sqlalchemy? If we ever want to get our pylint errors
down to zero so we can start enforcing it, we need to either do something
like above or insert pylint ignore statements throughout all the code where
the error is not really an error.
___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp
