Re: [Openstack] Comparing roles - case (in)sensitivity
On Tue, Jun 12, 2012 at 3:09 AM, Brian Waldon brian.wal...@rackspace.com wrote: So it sounds like we're going with case-insensitive string comparison for role names. There's already a patch in review for Glance, but it sounds like we'll need to get something up for Swift. Thanks for the input, guys! I have logged the bug here : https://bugs.launchpad.net/keystone/+bug/1013120 we'll address that when the middleware will be moved from keystone to core swift (soon hopefully). Chmouel. ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
- Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519. It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? My vote is that we make Glance case-insensitive. I think I may be the one that changed Nova to be case-insensitive as well as I had some real head scratchers with 'admin' vs. 'Admin' at one point. To me allowing roles will just get too confusing if we allow case sensitive comparisons. Dan Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
So it sounds like we're going with case-insensitive string comparison for role names. There's already a patch in review for Glance, but it sounds like we'll need to get something up for Swift. Thanks for the input, guys! Brian On Jun 8, 2012, at 8:27 PM, Dolph Mathews wrote: Role *names* are a human-interface element (arbitrarily defined by users for organizational purposes) and humans would intuitively compare them with case insensitivity (they're comparing organizational meaning, not strings)... if we're going to bother comparing them in code, I'd prefer it to be done with case-insensitivity to avoid confusion. However, the machine-readable identifier is really intended to be the Role ID (UUID, etc) from keystone. -Dolph Mathews On Jun 8, 2012, at 6:35 PM, Christopher B Ferris chris...@us.ibm.com wrote: case-insensitive - why would 'Admin' and 'admin' be different? Sure, a role is represented by a string, but why does that string need to be case sensitive? I'd think that if you had distinct roles attributed to 'Admin' and 'admin' that that would lead to confusion. Cheers, Christopher Ferris IBM Distinguished Engineer, CTO Industry and Cloud Standards Member, IBM Academy of Technology IBM Software Group, Standards Strategy email: chris...@us.ibm.com Twitter: christo4ferris phone: +1 508 234 2986 -openstack-bounces+chrisfer=us.ibm@lists.launchpad.net wrote: - To: Kiall Mac Innes ki...@managedit.ie From: Brian Waldon Sent by: openstack-bounces+chrisfer=us.ibm@lists.launchpad.net Date: 06/08/2012 07:21PM Cc: openstack@lists.launchpad.net \(openstack@lists.launchpad.net\) openstack@lists.launchpad.net Subject: Re: [Openstack] Comparing roles - case (in)sensitivity I guess I'm looking at this from more of a purist development point of view: 'Admin' and 'admin' just can't be equal. If I think of this as comparing roles, where a role is an abstract concept, case-insensitivity makes more sense. A string is simply being used to represent the role, where the intent of the role is what really needs to be compared. My goal here is to get everybody on board with a single approach and apply it across all projects. I don't *really* care too much which approach we take. Waldon On Jun 8, 2012, at 3:27 PM, Kiall Mac Innes wrote: Sure - The most obvious reason is human error leading to a security hole. E.g. Accidently assigning a user Admin when you really meant to assign admin. Treating roles as case insensitive helps prevent this kind of human error. What advantages does allowing distinct Admin and admin roles provide? Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:20 p.m., Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? On Jun 8, 2012, at 3:18 PM, Kiall Mac Innes wrote: No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:16 p.m., Brian Waldon brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https
[Openstack] Comparing roles - case (in)sensitivity
tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519. It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
I vote for case-sensitive too. PS: The keystone middleware to swift is case sensitive to roles as well. On Fri, Jun 8, 2012 at 11:57 PM, Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
Explicit is better than implicit. Case-sensitive. On Fri, Jun 8, 2012 at 2:50 PM, Brian Waldon brian.wal...@rackspace.com wrote: tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519. It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:16 p.m., Brian Waldon brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
Can you explain why? On Jun 8, 2012, at 3:18 PM, Kiall Mac Innes wrote: No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:16 p.m., Brian Waldon brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
I guess I'm looking at this from more of a purist development point of view: 'Admin' and 'admin' just can't be equal. If I think of this as comparing roles, where a role is an abstract concept, case-insensitivity makes more sense. A string is simply being used to represent the role, where the intent of the role is what really needs to be compared. My goal here is to get everybody on board with a single approach and apply it across all projects. I don't *really* care too much which approach we take. Waldon On Jun 8, 2012, at 3:27 PM, Kiall Mac Innes wrote: Sure - The most obvious reason is human error leading to a security hole. E.g. Accidently assigning a user Admin when you really meant to assign admin. Treating roles as case insensitive helps prevent this kind of human error. What advantages does allowing distinct Admin and admin roles provide? Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:20 p.m., Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? On Jun 8, 2012, at 3:18 PM, Kiall Mac Innes wrote: No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:16 p.m., Brian Waldon brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
I'm going to be the counter opinion here, but I don't really see a benefit in the case-sensitivity from a user perspective… Will a user ever want a scenario where they have/can have an Admin and an admin role (and maybe even an adMIN role)? I could certainly be missing a lot of context here, but I tend to think of role names a human identifiers, and case sensitive human groups doesn't seem to serve much human purpose here where Admin and admin are not the same role... John Postlethwait Nebula, Inc. 206-999-4492 On Friday, June 8, 2012 at 3:08 PM, Zach Borboa wrote: Explicit is better than implicit. Case-sensitive. On Fri, Jun 8, 2012 at 2:50 PM, Brian Waldon brian.wal...@rackspace.com (mailto:brian.wal...@rackspace.com) wrote: tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519. It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net (mailto:openstack@lists.launchpad.net) Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net (mailto:openstack@lists.launchpad.net) Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
On Fri, Jun 08, 2012, Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? Not to speak for Kiall, but I'll make the argument that there is no value in treating admin, Admin, and admIn separately. It can only lead to confusion and frustration of the people who use OpenStack. These values are intended for people and people generally expect case-insensitive matching. JE ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
case-insensitive - why would 'Admin' and 'admin' be different? Sure, a role is represented by a string, but why does that string need to be case sensitive?I'd think that if you had distinct roles attributed to 'Admin' and 'admin' that that would lead to confusion.Cheers,Christopher FerrisIBM Distinguished Engineer, CTO Industry and Cloud StandardsMember, IBM Academy of TechnologyIBM Software Group, Standards Strategyemail: chris...@us.ibm.comTwitter: christo4ferrisphone: +1 508 234 2986-openstack-bounces+chrisfer=us.ibm@lists.launchpad.net wrote: -To: Kiall Mac Innes ki...@managedit.ieFrom: Brian Waldon <brian.wal...@rackspace.com>Sent by: openstack-bounces+chrisfer=us.ibm@lists.launchpad.netDate: 06/08/2012 07:21PMCc: "openstack@lists.launchpad.net \(openstack@lists.launchpad.net\)" openstack@lists.launchpad.netSubject: Re: [Openstack] Comparing roles - case (in)sensitivityI guess I'm looking at this from more of a purist development point of view: 'Admin' and 'admin' just can't be equal. If I think of this as comparing roles, where a role is an abstract concept, case-insensitivity makes more sense. A string is simply being used to represent the role, where the intent of the role is what really needs to be compared.My goal here is to get everybody on board with a single approach and apply it across all projects. I don't *really* care too much which approach we take.WaldonOn Jun 8, 2012, at 3:27 PM, Kiall Mac Innes wrote:Sure - The most obvious reason is human error leading to a security hole. E.g. Accidently assigning a user "Admin" when you really meant to assign "admin".Treating roles as case insensitive helps prevent this kind of human error.What advantages does allowing distinct "Admin" and "admin" roles provide?Thanks, KiallSent from my phone. On Jun 8, 2012 11:20 p.m., "Brian Waldon" brian.wal...@rackspace.com wrote: Can you explain why?On Jun 8, 2012, at 3:18 PM, Kiall Mac Innes wrote:No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, KiallSent from my phone. On Jun 8, 2012 11:16 p.m., "Brian Waldon" brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise?On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote:What's the argument for allowing both, for example, "admin", "Admin" and "admIn" roles?This seems like one place where case insensitive makes the most sense.Thanks, KiallSent from my phone. On Jun 8, 2012 11:01 p.m., "Joseph Suh" j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: "Brian Waldon" brian.wal...@rackspace.com To: "openstack@lists.launchpad.net (openstack@lists.launchpad.net)" openstack@lists.launchpad.netSent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivitytl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less workThoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___Mailing list: https://launchpad.net/~openstackPost to : openstack@lists.launchpad.netUnsubscribe : https://launchpad.net/~openstackMore help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
I would actually like to see us downcase, (ASCII downcase, anyway), the role names when they are created. Then we will not get into trouble when interfacing with case-insensitive systems -- the question of case will never come up. Case sensitive comparisons are less code and run faster, so they should be preferred for that reason. People will tend to write case sensitive code without thinking about it, so a policy of case-insensitive comparison could lead to a world with more bugs. I think case and security are mostly orthogonal. Cheers, Tim On Jun 8, 2012, at 3:34 PM, Brian Waldon wrote: I guess I'm looking at this from more of a purist development point of view: 'Admin' and 'admin' just can't be equal. If I think of this as comparing roles, where a role is an abstract concept, case-insensitivity makes more sense. A string is simply being used to represent the role, where the intent of the role is what really needs to be compared. My goal here is to get everybody on board with a single approach and apply it across all projects. I don't *really* care too much which approach we take. Waldon On Jun 8, 2012, at 3:27 PM, Kiall Mac Innes wrote: Sure - The most obvious reason is human error leading to a security hole. E.g. Accidently assigning a user Admin when you really meant to assign admin. Treating roles as case insensitive helps prevent this kind of human error. What advantages does allowing distinct Admin and admin roles provide? Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:20 p.m., Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? On Jun 8, 2012, at 3:18 PM, Kiall Mac Innes wrote: No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:16 p.m., Brian Waldon brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
On Jun 8, 2012, at 4:16 PM, Johannes Erdfelt wrote: On Fri, Jun 08, 2012, Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? Not to speak for Kiall, but I'll make the argument that there is no value in treating admin, Admin, and admIn separately. It can only lead to confusion and frustration of the people who use OpenStack. These values are intended for people and people generally expect case-insensitive matching. Yes, it's the same word for people, but it's not the same bytes for computers. How shall we coexist in peace? Downcase everything and it won't come up. :) Cheers, Tim ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
+1 to downcasing -Original Message- From: Timothy Daly ti...@yahoo-inc.com Sent: Friday, June 8, 2012 7:49pm To: Johannes Erdfelt johan...@erdfelt.com Cc: openstack@lists.launchpad.net openstack@lists.launchpad.net Subject: Re: [Openstack] Comparing roles - case (in)sensitivity On Jun 8, 2012, at 4:16 PM, Johannes Erdfelt wrote: On Fri, Jun 08, 2012, Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? Not to speak for Kiall, but I'll make the argument that there is no value in treating admin, Admin, and admIn separately. It can only lead to confusion and frustration of the people who use OpenStack. These values are intended for people and people generally expect case-insensitive matching. Yes, it's the same word for people, but it's not the same bytes for computers. How shall we coexist in peace? Downcase everything and it won't come up. :) Cheers, Tim ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Comparing roles - case (in)sensitivity
Role *names* are a human-interface element (arbitrarily defined by users for organizational purposes) and humans would intuitively compare them with case insensitivity (they're comparing organizational meaning, not strings)... if we're going to bother comparing them in code, I'd prefer it to be done with case-insensitivity to avoid confusion. However, the machine-readable identifier is really intended to be the Role ID (UUID, etc) from keystone. -Dolph Mathews On Jun 8, 2012, at 6:35 PM, Christopher B Ferris chris...@us.ibm.com wrote: case-insensitive - why would 'Admin' and 'admin' be different? Sure, a role is represented by a string, but why does that string need to be case sensitive? I'd think that if you had distinct roles attributed to 'Admin' and 'admin' that that would lead to confusion. Cheers, Christopher Ferris IBM Distinguished Engineer, CTO Industry and Cloud Standards Member, IBM Academy of Technology IBM Software Group, Standards Strategy email: chris...@us.ibm.com Twitter: christo4ferris phone: +1 508 234 2986 -openstack-bounces+chrisfer=us.ibm@lists.launchpad.net wrote: - To: Kiall Mac Innes ki...@managedit.ie From: Brian Waldon Sent by: openstack-bounces+chrisfer=us.ibm@lists.launchpad.net Date: 06/08/2012 07:21PM Cc: openstack@lists.launchpad.net \(openstack@lists.launchpad.net\) openstack@lists.launchpad.net Subject: Re: [Openstack] Comparing roles - case (in)sensitivity I guess I'm looking at this from more of a purist development point of view: 'Admin' and 'admin' just can't be equal. If I think of this as comparing roles, where a role is an abstract concept, case-insensitivity makes more sense. A string is simply being used to represent the role, where the intent of the role is what really needs to be compared. My goal here is to get everybody on board with a single approach and apply it across all projects. I don't *really* care too much which approach we take. Waldon On Jun 8, 2012, at 3:27 PM, Kiall Mac Innes wrote: Sure - The most obvious reason is human error leading to a security hole. E.g. Accidently assigning a user Admin when you really meant to assign admin. Treating roles as case insensitive helps prevent this kind of human error. What advantages does allowing distinct Admin and admin roles provide? Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:20 p.m., Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? On Jun 8, 2012, at 3:18 PM, Kiall Mac Innes wrote: No, I'm suggesting they should all be treated as a single role. I.e. roles should be case insensitive. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:16 p.m., Brian Waldon brian.wal...@rackspace.com wrote: I'm suggesting we support only a single representation of a role across all projects: 'admin', 'Admin', and 'admIn' would be three separate roles. Are you suggesting otherwise? On Jun 8, 2012, at 3:14 PM, Kiall Mac Innes wrote: What's the argument for allowing both, for example, admin, Admin and admIn roles? This seems like one place where case insensitive makes the most sense. Thanks, Kiall Sent from my phone. On Jun 8, 2012 11:01 p.m., Joseph Suh j...@isi.edu wrote: I'd vote case-sensitive. Joseph (w) 703-248-6160 (c) 571-340-2434 (f) 703-812-3712 3811 N. Fairfax Drive Suite 200 Arlington, VA, 22203, USA http://www.east.isi.edu/~jsuh - Original Message - From: Brian Waldon brian.wal...@rackspace.com To: openstack@lists.launchpad.net (openstack@lists.launchpad.net) openstack@lists.launchpad.net Sent: Friday, June 8, 2012 5:50:45 PM Subject: [Openstack] Comparing roles - case (in)sensitivity tl;dr - Should we compare roles as case-sensitive or case-insensitive? I vote case-sensitive. This bug was recently filed in Glance: https://bugs.launchpad.net/glance/+bug/1010519 . It points out that Nova and Keystone are both case-insensitive when it comes to role comparison, yet Glance *is* case sensitive. I'm in favor of moving other projects to a case-sensitive approach for two main reasons: 1) If a role is a string, and comparing strings is inherently case-sensitive, then role comparison would logically be case-sensitive 2) I get to do less work Thoughts? Brian Waldon ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack
