Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
2011/2/25 Salvatore Orlando salvatore.orla...@eu.citrix.com: I realized my previous mail was a bit unclear... I meant to say can we avoid showing branches which are proposed to merge into something different than lp:nova? Sure. On lp:nova's page[1], it says: 34 branches proposed for merging into this one. 34 branches is a link to a page[2] that shows merge proposals for lp:nova. [1]: https://code.launchpad.net/~hudson-openstack/nova/trunk (or run bzr lp-open lp:nova) [2]: https://code.launchpad.net/~hudson-openstack/nova/trunk/+activereviews -- Soren Hansen Ubuntu Developer http://www.ubuntu.com/ OpenStack Developer http://www.openstack.org/ ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
On Fri, Feb 25, 2011 at 11:07 PM, Ewan Mellor ewan.mel...@eu.citrix.com wrote: This is all great stuff Jay, but it's going to get lost if it's just in email. http://wiki.openstack.org/LifeWithBzrAndLaunchpad has some of this on, but it's nothing like as clear and succinct as you've got it below. Cheers. Could someone break out a how peer reviews work wiki page, and put this content on it? We really need these things to be nice clear steps so that everyone knows what to expect. Sure. I don't want to step on anything termie was doing, though. Andy, did you have a link to the wiki page you were putting together about reviewing? I'll add some thoughts to that. -jay -Original Message- From: openstack-bounces+ewan.mellor=citrix@lists.launchpad.net [mailto:openstack-bounces+ewan.mellor=citrix@lists.launchpad.net] On Behalf Of Jay Pipes Sent: 25 February 2011 10:07 To: openstack@lists.launchpad.net Subject: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress! Hey all, The backlog on code reviews continues to mount: https://code.launchpad.net/nova/+activereviews One thing that would REALLY help reviewers is the following: If you receive one or more reviews that have asked for fixes to your branch (Needs Fixing), and you agree to these fixes, please do the following: * Write a quick comment on the merge proposal acknowledging the review and stating you are working on fixing the branch * Set the merge proposal status to Work In Progress When you do this, your branch gets removed from the list of merge proposals that reviewers need to review (the link above), which helps reviewers to identify which branches are truly in need of review and which branches are actually being worked on after reviews. After you make the changes to your branch, please do the following: * bzr push your changes to Launchpad * Go to your merge proposal and set the status back to Needs Review This will trigger: * Launchpad to regenerate the diff that is displayed for your branch * Launchpad to email all prior reviewers to let them know they need to re-review your branch Doing these simple steps will make reviewing dramatically easier; the side-effect of that is reviews will be quicker and we can get through this backlog. Thanks for listening, jay ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
On Fri, Feb 25, 2011 at 1:16 PM, Justin Santa Barbara jus...@fathomdb.com wrote: Good call Jay - I'll do my best to remember to do this! Why are branches with unmerged pre-reqs showing up in that list? If reviewers are working from that list, that just seems to be creating extra work, which you probably don't need! That's just how Launchpad is, unfortunately. I know of no way to keep LP from displaying branches with merge proposals having pre-requisite branches that are unmerged :( -jay ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
Is there at least a way for not showing branches which are not proposed for merge into lp:nova? Salvatore -Original Message- From: openstack-bounces+salvatore.orlando=eu.citrix@lists.launchpad.net [mailto:openstack-bounces+salvatore.orlando=eu.citrix@lists.launchpad.net] On Behalf Of Jay Pipes Sent: 25 February 2011 18:21 To: Justin Santa Barbara Cc: openstack@lists.launchpad.net Subject: Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress! On Fri, Feb 25, 2011 at 1:16 PM, Justin Santa Barbara jus...@fathomdb.com wrote: Good call Jay - I'll do my best to remember to do this! Why are branches with unmerged pre-reqs showing up in that list? If reviewers are working from that list, that just seems to be creating extra work, which you probably don't need! That's just how Launchpad is, unfortunately. I know of no way to keep LP from displaying branches with merge proposals having pre-requisite branches that are unmerged :( -jay ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
I realized my previous mail was a bit unclear... I meant to say can we avoid showing branches which are proposed to merge into something different than lp:nova? -Original Message- From: openstack-bounces+salvatore.orlando=eu.citrix@lists.launchpad.net [mailto:openstack-bounces+salvatore.orlando=eu.citrix@lists.launchpad.net] On Behalf Of Salvatore Orlando Sent: 25 February 2011 18:23 To: Jay Pipes; Justin Santa Barbara Cc: openstack@lists.launchpad.net Subject: Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress! Is there at least a way for not showing branches which are not proposed for merge into lp:nova? Salvatore -Original Message- From: openstack-bounces+salvatore.orlando=eu.citrix@lists.launchpad.net [mailto:openstack-bounces+salvatore.orlando=eu.citrix@lists.launchpad.net] On Behalf Of Jay Pipes Sent: 25 February 2011 18:21 To: Justin Santa Barbara Cc: openstack@lists.launchpad.net Subject: Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress! On Fri, Feb 25, 2011 at 1:16 PM, Justin Santa Barbara jus...@fathomdb.com wrote: Good call Jay - I'll do my best to remember to do this! Why are branches with unmerged pre-reqs showing up in that list? If reviewers are working from that list, that just seems to be creating extra work, which you probably don't need! That's just how Launchpad is, unfortunately. I know of no way to keep LP from displaying branches with merge proposals having pre-requisite branches that are unmerged :( -jay ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
On Fri, Feb 25, 2011 at 1:23 PM, Salvatore Orlando salvatore.orla...@eu.citrix.com wrote: Is there at least a way for not showing branches which are not proposed for merge into lp:nova? Another excellent question. And unfortunately, no, there isn't :( I'll file it as a wishlist bug on Launchpad. Cheers, jay ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!
I have filed a bug with Launchpad that asks for enhancements for both of your issues: https://bugs.launchpad.net/launchpad/+bug/725163 Cheers! jay On Fri, Feb 25, 2011 at 1:25 PM, Jay Pipes jaypi...@gmail.com wrote: On Fri, Feb 25, 2011 at 1:23 PM, Salvatore Orlando salvatore.orla...@eu.citrix.com wrote: Is there at least a way for not showing branches which are not proposed for merge into lp:nova? Another excellent question. And unfortunately, no, there isn't :( I'll file it as a wishlist bug on Launchpad. Cheers, jay ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
