Re: [openstack-dev] [Cinder] Request for J3 FFE - add reset-state function for backups
Jay Bryant wrote: It isn't a huge change. I am ok with it if we can get the issues addressed. Especially Duncan's concern. Given the gate backlog, if it's not already in-flight, I fear that it would push too much down into the stabilization period and delay RC1. At this point, unless it's critical to the success of the release (like, it completes a feature that is 99% there, or it increases consistency by plugging a feature gap, or it fixes a potential security vulnerability), I would rather avoid adding exceptions. Could you explain why adding reset-state function for backups absolutely needs to be in Juno ? Feels like a nice-to-have to me, and I fear we are past that point now. -- Thierry Carrez (ttx) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] Request for J3 FFE - add reset-state function for backups
On 12 September 2014 09:54, Thierry Carrez thie...@openstack.org wrote: At this point, unless it's critical to the success of the release (like, it completes a feature that is 99% there, or it increases consistency by plugging a feature gap, or it fixes a potential security vulnerability), I would rather avoid adding exceptions. Could you explain why adding reset-state function for backups absolutely needs to be in Juno ? Feels like a nice-to-have to me, and I fear we are past that point now. 1. It is 99% done, we've been reviewing the patch and fixing niggles for a while now 2. We have equivalent features for volumes and snapshots (the other two entities in cinder with state) and they are heavily used in production 3. The alternative is getting admins to go editing the DB directly (which is what we do now) and the logic for doing so is extremely hard to get right I'm a strong supporter of this feature, and I just gave the patch its first +2 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] Request for J3 FFE - add reset-state function for backups
Duncan Thomas wrote: On 12 September 2014 09:54, Thierry Carrez thie...@openstack.org wrote: At this point, unless it's critical to the success of the release (like, it completes a feature that is 99% there, or it increases consistency by plugging a feature gap, or it fixes a potential security vulnerability), I would rather avoid adding exceptions. Could you explain why adding reset-state function for backups absolutely needs to be in Juno ? Feels like a nice-to-have to me, and I fear we are past that point now. 1. It is 99% done, we've been reviewing the patch and fixing niggles for a while now 2. We have equivalent features for volumes and snapshots (the other two entities in cinder with state) and they are heavily used in production 3. The alternative is getting admins to go editing the DB directly (which is what we do now) and the logic for doing so is extremely hard to get right I'm a strong supporter of this feature, and I just gave the patch its first +2 OK, it feels like a good consistency/usability thing to get in-release rather than past-release. If it can get all the +2s required today (and John's approval), I won't object to it. -- Thierry Carrez (ttx) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] Request for J3 FFE - add reset-state function for backups
On 12:23 Tue 09 Sep , yunling wrote: Hi Cinder Folks,I would like to request a FFE for add reset-state function for backups[1][2].The spec of add reset-state function for backups has been reviewed and merged[2]. These code changes have been well tested and are not very complex[3]. I would appreciate any consideration for an FFE.Thanks, It looks like the current review has some comments that are waiting too be addressed now. -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] Request for J3 FFE - add reset-state function for backups
It isn't a huge change. I am ok with it if we can get the issues addressed. Especially Duncan's concern. On Sep 11, 2014 12:17 PM, Mike Perez thin...@gmail.com wrote: On 12:23 Tue 09 Sep , yunling wrote: Hi Cinder Folks,I would like to request a FFE for add reset-state function for backups[1][2].The spec of add reset-state function for backups has been reviewed and merged[2]. These code changes have been well tested and are not very complex[3]. I would appreciate any consideration for an FFE.Thanks, It looks like the current review has some comments that are waiting too be addressed now. -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Cinder] Request for J3 FFE - add reset-state function for backups
Hi Cinder Folks,I would like to request a FFE for add reset-state function for backups[1][2].The spec of add reset-state function for backups has been reviewed and merged[2]. These code changes have been well tested and are not very complex[3]. I would appreciate any consideration for an FFE.Thanks,-ling-yun[1] https://blueprints.launchpad.net/cinder/+spec/support-reset-state-for-backup[2] https://review.openstack.org/#/c/98316/[3] https://review.openstack.org/#/c/116849/ ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
