Re: [openstack-dev] [FFE][requirements] Bump ansible-runner u-c to 1.0.5

2018-07-31 Thread Jakub Libosvar
On 31/07/2018 18:46, Matthew Thode wrote:
> On 18-07-31 17:30:02, Jakub Libosvar wrote:
>> Hi all,
>>
>> I want to ask for FFE at this time to bump upper-constraint version of
>> ansible-runner library from 1.0.4 to 1.0.5.
>>
>> Reason: ansible-runner 1.0.4 has an issue when running with currently
>> used eventlet version because of missing select.poll() in eventlet [1].
>> The fix [2] is present in 1.0.5 ansible-runner version.
>>
>> Impact: networking-ansible project uses Neutron project and
>> ansible-runner together and Neutron monkey patches code with eventlet.
>> This fails all operations at networking-ansible.
>>
>> Statement: networking-ansible is the only project using ansible-runner
>> in OpenStack world [3] so if we release Rocky with 1.0.4, the only
>> project using it becomes useless. Bumping the version at this later
>> stage will not affect any other project beside networking-ansible.
>>
>> [1] https://github.com/ansible/ansible-runner/issues/90
>> [2]
>> https://github.com/ansible/ansible-runner/commit/5608e786eb96408658604e75ef3db3c9a6b39308
>> [3] http://codesearch.openstack.org/?q=ansible-runner=nope==
> 
> Looks good, you may want to update the minimum in networking-ansible,
> but lgtm otherwise.
> 
> | networking-ansible | requirements.txt|5 | ansible-runner>=1.0.3 
> # Apache-2.0 |

Yep, thanks for reminder. I've done that here
https://review.openstack.org/#/c/587475/ where the workaround was removed.

Jakub
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [FFE][requirements] Bump ansible-runner u-c to 1.0.5

2018-07-31 Thread Matthew Thode
On 18-07-31 17:30:02, Jakub Libosvar wrote:
> Hi all,
> 
> I want to ask for FFE at this time to bump upper-constraint version of
> ansible-runner library from 1.0.4 to 1.0.5.
> 
> Reason: ansible-runner 1.0.4 has an issue when running with currently
> used eventlet version because of missing select.poll() in eventlet [1].
> The fix [2] is present in 1.0.5 ansible-runner version.
> 
> Impact: networking-ansible project uses Neutron project and
> ansible-runner together and Neutron monkey patches code with eventlet.
> This fails all operations at networking-ansible.
> 
> Statement: networking-ansible is the only project using ansible-runner
> in OpenStack world [3] so if we release Rocky with 1.0.4, the only
> project using it becomes useless. Bumping the version at this later
> stage will not affect any other project beside networking-ansible.
> 
> [1] https://github.com/ansible/ansible-runner/issues/90
> [2]
> https://github.com/ansible/ansible-runner/commit/5608e786eb96408658604e75ef3db3c9a6b39308
> [3] http://codesearch.openstack.org/?q=ansible-runner=nope==

Looks good, you may want to update the minimum in networking-ansible,
but lgtm otherwise.

| networking-ansible | requirements.txt|5 | ansible-runner>=1.0.3 # 
Apache-2.0 |

-- 
Matthew Thode (prometheanfire)


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [FFE][requirements] Bump ansible-runner u-c to 1.0.5

2018-07-31 Thread Jakub Libosvar
Hi all,

I want to ask for FFE at this time to bump upper-constraint version of
ansible-runner library from 1.0.4 to 1.0.5.

Reason: ansible-runner 1.0.4 has an issue when running with currently
used eventlet version because of missing select.poll() in eventlet [1].
The fix [2] is present in 1.0.5 ansible-runner version.

Impact: networking-ansible project uses Neutron project and
ansible-runner together and Neutron monkey patches code with eventlet.
This fails all operations at networking-ansible.

Statement: networking-ansible is the only project using ansible-runner
in OpenStack world [3] so if we release Rocky with 1.0.4, the only
project using it becomes useless. Bumping the version at this later
stage will not affect any other project beside networking-ansible.

Thanks for consideration.

Jakub


[1] https://github.com/ansible/ansible-runner/issues/90
[2]
https://github.com/ansible/ansible-runner/commit/5608e786eb96408658604e75ef3db3c9a6b39308
[3] http://codesearch.openstack.org/?q=ansible-runner=nope==

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev