Re: [openstack-dev] [Horizon] [tests] [dsvm] Tests failed because of timeout during the images upload

2015-06-16 Thread Timur Sufiev
Timur,

If old jQuery code (not AngularJS) is still used for processing 'Create
Image' form, then the spinner is shown just before submitting the form
contents [1] and hidden right after the request completes [2] in case the
form is being redrawn or the whole page is redrawn in case of redirect -
which in case of Image means that it was successfully created. Speaking of
your scenario it should be redirect. It could mean that either the request
to server takes too long, or the redirect doesn't redraw the page.

[1]
https://github.com/openstack/horizon/blob/2f7a2dd891396f848278dc1bc2216e5720b602f6/horizon/static/horizon/js/horizon.modals.js#L229
[2]
https://github.com/openstack/horizon/blob/2f7a2dd891396f848278dc1bc2216e5720b602f6/horizon/static/horizon/js/horizon.modals.js#L232
[3]
https://github.com/openstack/horizon/blob/2f7a2dd891396f848278dc1bc2216e5720b602f6/horizon/static/horizon/js/horizon.modals.js#L245

On Tue, Jun 16, 2015 at 12:31 PM Matthias Runge mru...@redhat.com wrote:

 On 16/06/15 11:20, Timur Nurlygayanov wrote:

  In this method integration tests try to upload image by the following
  link [4]:
  http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-uec.tar.gz
 

 Imho it would be better to host this somewhere internal in infra rather
 than getting it from the net.

 Wouldn't that be an option for improvement? It would even make tests
 more reliable.

 Matthias


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [Horizon] [tests] [dsvm] Tests failed because of timeout during the images upload

2015-06-16 Thread Timur Nurlygayanov
Hi team,

I investigated the latest failed Horizon integration dsvm jobs [1] and
found that many of them failed because of timeouts during the upload of
image (in function 'create_image' [2]), on step '_wait_till_spinner_disappears'
[3], where we wait while 'div.*modal-backdrop*' will disappear.
In this method integration tests try to upload image by the following link
[4]:
http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-uec.tar.gz

In fact, 'div.*modal-backdrop*' exists because dashboard hags more than 10
seconds on 'loading' screen [5] during the images upload.

I tried to reproduce this on my local environment but it doesn't
reproduced, and I can't find the root of this issue based and the code
review.

Do we have ideas how we can debug and fix it? In fact, it is not issue with
Horizon integration tests, looks like it is issue with Horizon code/bugs.
Probably someone already tried to fix the issue?

Thank you!

[1] https://review.openstack.org/#/c/157367/ ,
https://review.openstack.org/#/c/173885/ ,
https://review.openstack.org/#/c/185191/ ,
https://review.openstack.org/#/c/181095/ ,
https://review.openstack.org/#/c/186295/ and others.
[2]
https://github.com/openstack/horizon/blob/2f7a2dd891396f848278dc1bc2216e5720b602f6/openstack_dashboard/test/integration_tests/pages/project/compute/imagespage.py#L69
[3]
https://github.com/openstack/horizon/blob/2f7a2dd891396f848278dc1bc2216e5720b602f6/openstack_dashboard/test/integration_tests/pages/project/compute/imagespage.py#L94
[4]
https://github.com/openstack/horizon/blob/0d8c175d652ed3d19bfb02d16752f33c5de044bb/openstack_dashboard/test/integration_tests/horizon.conf#L33
[5] http://i.imgur.com/zpWpCfb.png?1


-- 

Timur,
Senior QA Engineer
OpenStack Projects
Mirantis Inc
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] [tests] [dsvm] Tests failed because of timeout during the images upload

2015-06-16 Thread Matthias Runge

On 16/06/15 11:20, Timur Nurlygayanov wrote:


In this method integration tests try to upload image by the following
link [4]:
http://download.cirros-cloud.net/0.3.1/cirros-0.3.1-x86_64-uec.tar.gz



Imho it would be better to host this somewhere internal in infra rather 
than getting it from the net.


Wouldn't that be an option for improvement? It would even make tests 
more reliable.


Matthias


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev