Re: [openstack-dev] [Horizon] Support for Django 1.6

2013-12-23 Thread Thomas Goirand
On 12/20/2013 04:39 PM, Matthias Runge wrote:
 On 12/19/2013 04:45 PM, Thomas Goirand wrote:
 Hi,

 Sid has Django 1.6. Is it planned to add support for it? I currently
 don't know what to do with the Horizon package, as it's currently
 broken... :(

 Thomas
 Yes, there are two patches available, one for horizon[1] and one for
 django_openstack_auth[2]
 
 If both are in, we can start gating on django-1.6 as well.
 
 [1] https://review.openstack.org/#/c/58947/
 [2] https://review.openstack.org/#/c/58561/
 
 Matthias

Hi Matthias,

Thanks a lot for these pointers. I tried patching openstack-auth. While
it did work in Wheezy (with Django 1.4), all the 80 unit tests are
failing in Sid, with the following error:

ImportError: No module named defaults

while trying to do:

from django.conf.urls.defaults import patterns, url

Is there anything that I missed? Maybe a missing Django python module?

Cheers,

Thomas


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Support for Django 1.6

2013-12-23 Thread Tim Schnell
On 12/23/13 5:02 AM, Thomas Goirand z...@debian.org wrote:


On 12/20/2013 04:39 PM, Matthias Runge wrote:
 On 12/19/2013 04:45 PM, Thomas Goirand wrote:
 Hi,

 Sid has Django 1.6. Is it planned to add support for it? I currently
 don't know what to do with the Horizon package, as it's currently
 broken... :(

 Thomas
 Yes, there are two patches available, one for horizon[1] and one for
 django_openstack_auth[2]
 
 If both are in, we can start gating on django-1.6 as well.
 
 [1] https://review.openstack.org/#/c/58947/
 [2] https://review.openstack.org/#/c/58561/
 
 Matthias

Hi Matthias,

Thanks a lot for these pointers. I tried patching openstack-auth. While
it did work in Wheezy (with Django 1.4), all the 80 unit tests are
failing in Sid, with the following error:

ImportError: No module named defaults

while trying to do:

from django.conf.urls.defaults import patterns, url

Is there anything that I missed? Maybe a missing Django python module?

It looks like the defaults module has been removed in Django 1.6. It was
deprecated in Django 1.4. You should be able to just change these imports
to:

from django.conf.urls import patterns, url

https://docs.djangoproject.com/en/dev/releases/1.4/#django-conf-urls-defaul
ts


-Tim

Cheers,

Thomas


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Support for Django 1.6

2013-12-23 Thread Thomas Goirand
On 12/23/2013 11:23 PM, Tim Schnell wrote:
 It looks like the defaults module has been removed in Django 1.6. It was
 deprecated in Django 1.4. You should be able to just change these imports
 to:
 
 from django.conf.urls import patterns, url
 
 https://docs.djangoproject.com/en/dev/releases/1.4/#django-conf-urls-defaul
 ts
 
 
 -Tim

Indeed, this was the problem. Thanks Tim, I have been able to upload the
package to Sid, without breaking Wheezy backport, thanks to this. \o/

Thomas Goirand (zigo)


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Support for Django 1.6

2013-12-20 Thread Matthias Runge
On 12/19/2013 04:45 PM, Thomas Goirand wrote:
 Hi,
 
 Sid has Django 1.6. Is it planned to add support for it? I currently
 don't know what to do with the Horizon package, as it's currently
 broken... :(
 
 Thomas
Yes, there are two patches available, one for horizon[1] and one for
django_openstack_auth[2]

If both are in, we can start gating on django-1.6 as well.

[1] https://review.openstack.org/#/c/58947/
[2] https://review.openstack.org/#/c/58561/

Matthias

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [Horizon] Support for Django 1.6

2013-12-19 Thread Thomas Goirand
Hi,

Sid has Django 1.6. Is it planned to add support for it? I currently
don't know what to do with the Horizon package, as it's currently
broken... :(

Thomas

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] Support for Django 1.6

2013-12-19 Thread Jeremy Stanley
On 2013-12-19 23:45:09 +0800 (+0800), Thomas Goirand wrote:
 Sid has Django 1.6. Is it planned to add support for it? I currently
 don't know what to do with the Horizon package, as it's currently
 broken... :(

You probably want to follow
https://blueprints.launchpad.net/horizon/+spec/django-1point6 and
pitch in on reviews, patches or discussions related to this work if
it is important to you.
-- 
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev