[openstack-dev] [Ironic] ilo driver need to submit a code change in nova ironic driver

2014-02-24 Thread Faizan Barmawer
Hi All,

I am currently working on ilo driver for ironic project.
As part of this implementation and to integrate with nova ironic driver (
https://review.openstack.org/#/c/51328/) we need to make changes to
driver.py and ironic_driver_fields.py files, to pass down ilo driver
specific fields to the ironic node. Since nova ironic driver code review
still in progress and not yet integrated into openstack, we have not
included this piece of code in the ilo driver code review patch (
https://review.openstack.org/#/c/73787/).

We need your suggestion on delivering this part of ilo driver code change
in nova ironic driver.
- Should we wait for the completion of nova ironic driver and then raise a
defect to submit these changes? or
- should we raise a defect now and submit for review, giving the dependency
on the nova ironic driver review? or
- Can we use the existing blueprint for ilo driver to raise a separate
review for this code change giving nova ironic driver as dependency?

Please suggest a better way of delivering these changes.

Thanks  Regards,
Barmawer
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Ironic] ilo driver need to submit a code change in nova ironic driver

2014-02-24 Thread Chris K
Hi Barmawer,

Currently the Ironic Nova driver is blocked from merging. The Ironic team
is working on getting all the pieces in place for our C.I. testing. At this
point I would say your best path is to create your patch with 51328 as a
dependency. Please note that the nova driver will most likely be going
through several more revisions as we get closer. This will mean that your
dependent patch will need to rebased as new Nova driver patches are pushed
up. This is very common, I am just pointing it out so that you can keep an
eye out for the [OUTDATED] tag on the review. Also please tag your
dependent patch with implements bp:deprecate-baremetal-driver this will
ensure your patch is added to the Blue Print, and make it clear that is
part of the deprecate-baremetal-driver patch set.


Chris Krelle


On Mon, Feb 24, 2014 at 6:05 AM, Faizan Barmawer
faizan.barma...@gmail.comwrote:

 Hi All,

 I am currently working on ilo driver for ironic project.
 As part of this implementation and to integrate with nova ironic driver (
 https://review.openstack.org/#/c/51328/) we need to make changes to
 driver.py and ironic_driver_fields.py files, to pass down ilo driver
 specific fields to the ironic node. Since nova ironic driver code review
 still in progress and not yet integrated into openstack, we have not
 included this piece of code in the ilo driver code review patch (
 https://review.openstack.org/#/c/73787/).

 We need your suggestion on delivering this part of ilo driver code change
 in nova ironic driver.
 - Should we wait for the completion of nova ironic driver and then raise a
 defect to submit these changes? or
 - should we raise a defect now and submit for review, giving the
 dependency on the nova ironic driver review? or
 - Can we use the existing blueprint for ilo driver to raise a separate
 review for this code change giving nova ironic driver as dependency?

 Please suggest a better way of delivering these changes.

 Thanks  Regards,
 Barmawer

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev