Re: [openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-07-04 Thread Amit Das
Perhaps Jenkins can display a better message to start with.

Being new to openstack, i had no clue on what was happening. However, the
fix was simple once understood.

The current message made me to think something was wrong with jenkins
environment setup.



Regards,
Amit
*CloudByte Inc.* 


On Fri, Jul 4, 2014 at 5:39 PM, Duncan Thomas 
wrote:

> On 30 June 2014 07:47, Steve Kowalik  wrote:
> > Personally, I think generating and comparing a sample config every build
> > is daft, and a sample configuration should be generated during sdist or
> > something.
>
> This argument has gone back and forth several times.
>
> There is definite value to a reviewer in seeing the sample conf
> changes - it is usually the first thing I look for with a change, to
> get a feel what what has been done and look for obvious back
> compatibility issue, of which there have been lots.
>
> Gating on it in its current form is clearly broken since it doesn't
> take into account the libraries from OSLO might have changed things.
> Ideally jenkins would, after installing all the deps, git checkout the
> parent, generate the conf, checkout the change, generate the conf and
> post up the diffs, but coding that up is tricky.
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-07-04 Thread Duncan Thomas
On 30 June 2014 07:47, Steve Kowalik  wrote:
> Personally, I think generating and comparing a sample config every build
> is daft, and a sample configuration should be generated during sdist or
> something.

This argument has gone back and forth several times.

There is definite value to a reviewer in seeing the sample conf
changes - it is usually the first thing I look for with a change, to
get a feel what what has been done and look for obvious back
compatibility issue, of which there have been lots.

Gating on it in its current form is clearly broken since it doesn't
take into account the libraries from OSLO might have changed things.
Ideally jenkins would, after installing all the deps, git checkout the
parent, generate the conf, checkout the change, generate the conf and
post up the diffs, but coding that up is tricky.

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-07-04 Thread Amit Das
Thanks a lot.

The recommendations worked fine.

Regards,
Amit
*CloudByte Inc.* 


On Fri, Jul 4, 2014 at 3:34 PM, Yuriy Taraday  wrote:

> On Fri, Jul 4, 2014 at 12:57 PM, Amit Das  wrote:
>
>> Hi All,
>>
>> I can see a lot of cinder gerrit commits that pass through the
>> gate-cinder-python26 & gate-cinder-python27 successfully.
>>
>> ref - https://github.com/openstack/cinder/commits/master
>>
>> Whereas its not the case for my patch
>> https://review.openstack.org/#/c/102511/.
>>
>> I updated the master & rebased that to my branch before doing a gerrit
>> review.
>>
>> Am i missing any steps ?
>>
>
> Does 'tox -e py26' works on your local machine? It should fail just as one
> in the gate.
> You should follow instructions it provides in log just before
> 'InvocationError' - run tools/config/generate_sample.sh.
> The issue is that you've added some options to your driver but didn't
> update etc/cinder/cinder.conf.sample.
> After generating new sample you should verify its diff (git diff
> etc/cinder/cinder.conf.sample) and add it to your commit.
>
>
> --
>
> Kind regards, Yuriy.
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-07-04 Thread Yuriy Taraday
On Fri, Jul 4, 2014 at 12:57 PM, Amit Das  wrote:

> Hi All,
>
> I can see a lot of cinder gerrit commits that pass through the
> gate-cinder-python26 & gate-cinder-python27 successfully.
>
> ref - https://github.com/openstack/cinder/commits/master
>
> Whereas its not the case for my patch
> https://review.openstack.org/#/c/102511/.
>
> I updated the master & rebased that to my branch before doing a gerrit
> review.
>
> Am i missing any steps ?
>

Does 'tox -e py26' works on your local machine? It should fail just as one
in the gate.
You should follow instructions it provides in log just before
'InvocationError' - run tools/config/generate_sample.sh.
The issue is that you've added some options to your driver but didn't
update etc/cinder/cinder.conf.sample.
After generating new sample you should verify its diff (git diff
etc/cinder/cinder.conf.sample) and add it to your commit.


-- 

Kind regards, Yuriy.
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-07-04 Thread Amit Das
Hi All,

I can see a lot of cinder gerrit commits that pass through the
gate-cinder-python26 & gate-cinder-python27 successfully.

ref - https://github.com/openstack/cinder/commits/master

Whereas its not the case for my patch
https://review.openstack.org/#/c/102511/.

I updated the master & rebased that to my branch before doing a gerrit
review.

Am i missing any steps ?

Regards,
Amit
*CloudByte Inc.* 


On Mon, Jun 30, 2014 at 12:17 PM, Steve Kowalik 
wrote:

> On 30/06/14 16:37, Amit Das wrote:
> > I have been facing below issues at gate-cinder-python26 &
> > gate-cinder-python27 after uploading my patch.
> >
> > I assume this to be an infrastructure issue than an issue with my patch.
> > Can someone please confirm ?
> >
> > .
> > 2014-06-30 05:41:57.704 | check_uptodate.sh: cinder.conf.sample is not
> > up to date.
>
> This usually means that Oslo (the common libraries used by many
> projects) has added an configuration option. It's in fact a problem with
> cinder, in that they need to make sure the sample configuration file is
> up to date, but it will affect all patches until it is fixed. I'm sure
> it will get sorted out quickly.
>
> Personally, I think generating and comparing a sample config every build
> is daft, and a sample configuration should be generated during sdist or
> something.
>
> Cheers,
> --
> Steve
> "Stop breathing down my neck!"
> "My breathing is merely a simulation."
> "So is my neck! Stop it anyway."
>  - EMH vs EMH, USS Prometheus
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-06-29 Thread Steve Kowalik
On 30/06/14 16:37, Amit Das wrote:
> I have been facing below issues at gate-cinder-python26 &
> gate-cinder-python27 after uploading my patch.
> 
> I assume this to be an infrastructure issue than an issue with my patch.
> Can someone please confirm ?
> 
> .
> 2014-06-30 05:41:57.704 | check_uptodate.sh: cinder.conf.sample is not
> up to date.

This usually means that Oslo (the common libraries used by many
projects) has added an configuration option. It's in fact a problem with
cinder, in that they need to make sure the sample configuration file is
up to date, but it will affect all patches until it is fixed. I'm sure
it will get sorted out quickly.

Personally, I think generating and comparing a sample config every build
is daft, and a sample configuration should be generated during sdist or
something.

Cheers,
-- 
Steve
"Stop breathing down my neck!"
"My breathing is merely a simulation."
"So is my neck! Stop it anyway."
 - EMH vs EMH, USS Prometheus

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [Jenkins] [Cinder] InvocationError in gate-cinder-python26 & python27

2014-06-29 Thread Amit Das
Hi Stackers,

I have been facing below issues at gate-cinder-python26 &
gate-cinder-python27 after uploading my patch.

I assume this to be an infrastructure issue than an issue with my patch.
Can someone please confirm ?

.
2014-06-30 05:41:57.704 | check_uptodate.sh: cinder.conf.sample is not up
to date.
2014-06-30 05:41:57.704 | check_uptodate.sh: Please run
/home/jenkins/workspace/gate-cinder-python26/tools/config/generate_sample.sh.
2014-06-30 05:41:57.705 | ERROR: InvocationError:
'/home/jenkins/workspace/gate-cinder-python26/tools/config/check_uptodate.sh'
2014-06-30 05:41:57.705 | ___ summary

2014-06-30 05:41:57.705 | ERROR:   py26: commands failed
2014-06-30 05:41:57.707 | + result=1
2014-06-30 05:41:57.708 | + echo 'Begin pip freeze output from test
virtualenv:'
2014-06-30 05:41:57.708 | Begin pip freeze output from test virtualenv:
2014-06-30 05:41:57.708 | + echo
==
2014-06-30 05:41:57.708 |
==
2014-06-30 05:41:57.708 | + .tox/py26/bin/pip freeze
.


This is my patch url - https://review.openstack.org/#/c/102511/

I have even raised a bug against this -
https://bugs.launchpad.net/openstack-ci/+bug/1334623

Regards,
Amit
*CloudByte Inc.* 
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev