Re: [openstack-dev] [Kolla] DocImpact in reviews
I don't think we can really expect new contributors to understand all the magic flags. This isn't a typical problem - typically DocImpact is used correctly. But it is the responsibility of the core reviewers to make sure that new contributors aren't needlessly wasting time by triggering triages of incorrectly used flags. Regards -steve From: "Vikram Hosakote (vhosakot)" <vhosa...@cisco.com<mailto:vhosa...@cisco.com>> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Date: Monday, March 7, 2016 at 8:04 PM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Subject: Re: [openstack-dev] [Kolla] DocImpact in reviews Good point. I think this should be caught during code review. Regards, Vikram Hosakote IRC: vhosakot From: Swapnil Kulkarni <m...@coolsvap.net<mailto:m...@coolsvap.net>> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Date: Monday, March 7, 2016 at 1:40 AM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Subject: [openstack-dev] [Kolla] DocImpact in reviews Hello, I was triaging some of the bugs reported to Kolla and I found a couple of bugs [1] [2] created due to incorrect usage of DocImpact[1] tag in reviews. The DocImapct tag should only be used in case if you have done some change which requires following two, 1) Update in some existing documentation 2) Add some new documentation which are not addressed in the current changeset where you are adding the DocImapct. [1] https://wiki.openstack.org/wiki/Documentation/DocImpact [2] https://bugs.launchpad.net/kolla/+bug/1553291 [3] https://bugs.launchpad.net/kolla/+bug/1553405 Best Regards, Swapnil Kulkarni irc : coolsvap __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Kolla] DocImpact in reviews
Good point. I think this should be caught during code review. Regards, Vikram Hosakote IRC: vhosakot From: Swapnil Kulkarni <m...@coolsvap.net<mailto:m...@coolsvap.net>> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Date: Monday, March 7, 2016 at 1:40 AM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Subject: [openstack-dev] [Kolla] DocImpact in reviews Hello, I was triaging some of the bugs reported to Kolla and I found a couple of bugs [1] [2] created due to incorrect usage of DocImpact[1] tag in reviews. The DocImapct tag should only be used in case if you have done some change which requires following two, 1) Update in some existing documentation 2) Add some new documentation which are not addressed in the current changeset where you are adding the DocImapct. [1] https://wiki.openstack.org/wiki/Documentation/DocImpact [2] https://bugs.launchpad.net/kolla/+bug/1553291 [3] https://bugs.launchpad.net/kolla/+bug/1553405 Best Regards, Swapnil Kulkarni irc : coolsvap __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Kolla] DocImpact in reviews
Hello, I was triaging some of the bugs reported to Kolla and I found a couple of bugs [1] [2] created due to incorrect usage of DocImpact[1] tag in reviews. The DocImapct tag should only be used in case if you have done some change which requires following two, 1) Update in some existing documentation 2) Add some new documentation which are not addressed in the current changeset where you are adding the DocImapct. [1] https://wiki.openstack.org/wiki/Documentation/DocImpact [2] https://bugs.launchpad.net/kolla/+bug/1553291 [3] https://bugs.launchpad.net/kolla/+bug/1553405 Best Regards, Swapnil Kulkarni irc : coolsvap __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
