Re: [openstack-dev] [Mistral] Renaming action types
Haah :) Honestly, I don’t like it. “invoke” doesn’t seem to be carrying any
useful information here. And “invoke_mistral” looks completely confusing since
it’s not clear it’s related with HTTP.
Renat Akhmerov
@ Mirantis Inc.
On 27 Feb 2014, at 23:42, Manas Kelshikar wrote:
> How about ...
>
> invoke_http & invoke_mistral to fit the verb_noun pattern.
>
>
> On Wed, Feb 26, 2014 at 6:04 AM, Renat Akhmerov
> wrote:
> Ooh, I was wrong. Sorry. We use dash naming. We have “on-success”, “on-error”
> and so forth.
>
> Please let us know if you see other inconsistencies.
>
> Thanks
>
> Renat Akhmerov
> @ Mirantis Inc.
>
>
>
> On 26 Feb 2014, at 21:00, Renat Akhmerov wrote:
>
> > Thanks Jay.
> >
> > Regarding underscore naming. If you meant using underscore naming for
> > “createVM” and “novaURL” then yes, “createVM” is just a task name and it’s
> > a user preference. The same about “novaURL” which will be defined by users.
> > As for keywords, seemingly we follow underscore naming.
> >
> > Renat Akhmerov
> > @ Mirantis Inc.
> >
> >
> >
> > On 26 Feb 2014, at 17:58, Jay Pipes wrote:
> >
> >> On Wed, 2014-02-26 at 14:38 +0700, Renat Akhmerov wrote:
> >>> Folks,
> >>>
> >>> I’m proposing to rename these two action types REST_API and
> >>> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words “REST” and “API”
> >>> don’t look correct to me, if you look at
> >>>
> >>>
> >>> Services:
> >>> Nova:
> >>> type: REST_API
> >>> parameters:
> >>> baseUrl: {$.novaURL}
> >>> actions:
> >>> createVM:
> >>> parameters:
> >>> url: /servers/{$.vm_id}
> >>> method: POST
> >>>
> >>> There’s no information about “REST” or “API” here. It’s just a spec
> >>> how to form an HTTP request.
> >>
> >> +1 on HTTP and MISTRAL_HTTP.
> >>
> >> On an unrelated note, would it be possible to use under_score_naming
> >> instead of camelCase naming?
> >>
> >> Best,
> >> -jay
> >>
> >>
> >>
> >> ___
> >> OpenStack-dev mailing list
> >> OpenStack-dev@lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
How about ...
invoke_http & invoke_mistral to fit the verb_noun pattern.
On Wed, Feb 26, 2014 at 6:04 AM, Renat Akhmerov wrote:
> Ooh, I was wrong. Sorry. We use dash naming. We have "on-success",
> "on-error" and so forth.
>
> Please let us know if you see other inconsistencies.
>
> Thanks
>
> Renat Akhmerov
> @ Mirantis Inc.
>
>
>
> On 26 Feb 2014, at 21:00, Renat Akhmerov wrote:
>
> > Thanks Jay.
> >
> > Regarding underscore naming. If you meant using underscore naming for
> "createVM" and "novaURL" then yes, "createVM" is just a task name and it's
> a user preference. The same about "novaURL" which will be defined by users.
> As for keywords, seemingly we follow underscore naming.
> >
> > Renat Akhmerov
> > @ Mirantis Inc.
> >
> >
> >
> > On 26 Feb 2014, at 17:58, Jay Pipes wrote:
> >
> >> On Wed, 2014-02-26 at 14:38 +0700, Renat Akhmerov wrote:
> >>> Folks,
> >>>
> >>> I'm proposing to rename these two action types REST_API and
> >>> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words "REST" and "API"
> >>> don't look correct to me, if you look at
> >>>
> >>>
> >>> Services:
> >>> Nova:
> >>> type: REST_API
> >>> parameters:
> >>> baseUrl: {$.novaURL}
> >>> actions:
> >>> createVM:
> >>> parameters:
> >>> url: /servers/{$.vm_id}
> >>> method: POST
> >>>
> >>> There's no information about "REST" or "API" here. It's just a spec
> >>> how to form an HTTP request.
> >>
> >> +1 on HTTP and MISTRAL_HTTP.
> >>
> >> On an unrelated note, would it be possible to use under_score_naming
> >> instead of camelCase naming?
> >>
> >> Best,
> >> -jay
> >>
> >>
> >>
> >> ___
> >> OpenStack-dev mailing list
> >> OpenStack-dev@lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
Ooh, I was wrong. Sorry. We use dash naming. We have “on-success”, “on-error”
and so forth.
Please let us know if you see other inconsistencies.
Thanks
Renat Akhmerov
@ Mirantis Inc.
On 26 Feb 2014, at 21:00, Renat Akhmerov wrote:
> Thanks Jay.
>
> Regarding underscore naming. If you meant using underscore naming for
> “createVM” and “novaURL” then yes, “createVM” is just a task name and it’s a
> user preference. The same about “novaURL” which will be defined by users. As
> for keywords, seemingly we follow underscore naming.
>
> Renat Akhmerov
> @ Mirantis Inc.
>
>
>
> On 26 Feb 2014, at 17:58, Jay Pipes wrote:
>
>> On Wed, 2014-02-26 at 14:38 +0700, Renat Akhmerov wrote:
>>> Folks,
>>>
>>> I’m proposing to rename these two action types REST_API and
>>> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words “REST” and “API”
>>> don’t look correct to me, if you look at
>>>
>>>
>>> Services:
>>> Nova:
>>> type: REST_API
>>> parameters:
>>> baseUrl: {$.novaURL}
>>> actions:
>>> createVM:
>>> parameters:
>>> url: /servers/{$.vm_id}
>>> method: POST
>>>
>>> There’s no information about “REST” or “API” here. It’s just a spec
>>> how to form an HTTP request.
>>
>> +1 on HTTP and MISTRAL_HTTP.
>>
>> On an unrelated note, would it be possible to use under_score_naming
>> instead of camelCase naming?
>>
>> Best,
>> -jay
>>
>>
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
Thanks Jay.
Regarding underscore naming. If you meant using underscore naming for
“createVM” and “novaURL” then yes, “createVM” is just a task name and it’s a
user preference. The same about “novaURL” which will be defined by users. As
for keywords, seemingly we follow underscore naming.
Renat Akhmerov
@ Mirantis Inc.
On 26 Feb 2014, at 17:58, Jay Pipes wrote:
> On Wed, 2014-02-26 at 14:38 +0700, Renat Akhmerov wrote:
>> Folks,
>>
>> I’m proposing to rename these two action types REST_API and
>> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words “REST” and “API”
>> don’t look correct to me, if you look at
>>
>>
>> Services:
>> Nova:
>>type: REST_API
>>parameters:
>> baseUrl: {$.novaURL}
>>actions:
>> createVM:
>>parameters:
>> url: /servers/{$.vm_id}
>> method: POST
>>
>> There’s no information about “REST” or “API” here. It’s just a spec
>> how to form an HTTP request.
>
> +1 on HTTP and MISTRAL_HTTP.
>
> On an unrelated note, would it be possible to use under_score_naming
> instead of camelCase naming?
>
> Best,
> -jay
>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
On Wed, 2014-02-26 at 14:38 +0700, Renat Akhmerov wrote:
> Folks,
>
> I’m proposing to rename these two action types REST_API and
> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words “REST” and “API”
> don’t look correct to me, if you look at
>
>
> Services:
> Nova:
> type: REST_API
> parameters:
> baseUrl: {$.novaURL}
> actions:
> createVM:
> parameters:
> url: /servers/{$.vm_id}
> method: POST
>
> There’s no information about “REST” or “API” here. It’s just a spec
> how to form an HTTP request.
+1 on HTTP and MISTRAL_HTTP.
On an unrelated note, would it be possible to use under_score_naming
instead of camelCase naming?
Best,
-jay
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
Hm.. I see your point. Generally, I like short names but expressive enough to
understand what it is. VERB_NOUN would be good but nothing decent comes to my
mind regarding HTTP :)
If you guys have any suggestions you’re welcome.
Renat Akhmerov
@ Mirantis Inc.
On 26 Feb 2014, at 16:33, Dmitri Zimine wrote:
> +1
>
> Should we use VERB_NOUN pattern? Or relax it for some obvious? I can't figure
> a good VERB_NOUN for HTTP. REQUEST_HTTP is dull.
>
> BTW it's interesting that we assume that a service can contain only actions
> of the same type.
>
> DZ>
>
> On Feb 26, 2014, at 1:10 AM, Nikolay Makhotkin
> wrote:
>
>> Agree, I don't see any thing that makes sense with words 'REST' and 'API'
>> too.
>>
>>
>> On Wed, Feb 26, 2014 at 11:38 AM, Renat Akhmerov
>> wrote:
>> Folks,
>>
>> I’m proposing to rename these two action types REST_API and MISTRAL_REST_API
>> to HTTP and MISTRAL_HTTP. Words “REST” and “API” don’t look correct to me,
>> if you look at
>>
>> Services:
>> Nova:
>> type: REST_API
>> parameters:
>> baseUrl: {$.novaURL}
>> actions:
>> createVM:
>> parameters:
>> url: /servers/{$.vm_id}
>> method: POST
>>
>> There’s no information about “REST” or “API” here. It’s just a spec how to
>> form an HTTP request.
>>
>> Thoughts?
>>
>> Renat Akhmerov
>> @ Mirantis Inc.
>>
>>
>>
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>>
>>
>> --
>> Best Regards,
>> Nikolay
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
+1
Should we use VERB_NOUN pattern? Or relax it for some obvious? I can't figure a
good VERB_NOUN for HTTP. REQUEST_HTTP is dull.
BTW it's interesting that we assume that a service can contain only actions of
the same type.
DZ>
On Feb 26, 2014, at 1:10 AM, Nikolay Makhotkin wrote:
> Agree, I don't see any thing that makes sense with words 'REST' and 'API' too.
>
>
> On Wed, Feb 26, 2014 at 11:38 AM, Renat Akhmerov
> wrote:
> Folks,
>
> I’m proposing to rename these two action types REST_API and MISTRAL_REST_API
> to HTTP and MISTRAL_HTTP. Words “REST” and “API” don’t look correct to me, if
> you look at
>
> Services:
> Nova:
> type: REST_API
> parameters:
> baseUrl: {$.novaURL}
> actions:
> createVM:
> parameters:
> url: /servers/{$.vm_id}
> method: POST
>
> There’s no information about “REST” or “API” here. It’s just a spec how to
> form an HTTP request.
>
> Thoughts?
>
> Renat Akhmerov
> @ Mirantis Inc.
>
>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> --
> Best Regards,
> Nikolay
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Mistral] Renaming action types
Agree, I don't see any thing that makes sense with words 'REST' and 'API'
too.
On Wed, Feb 26, 2014 at 11:38 AM, Renat Akhmerov wrote:
> Folks,
>
> I'm proposing to rename these two action types REST_API and
> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words "REST" and "API" don't
> look correct to me, if you look at
>
> Services:
> Nova:
> type: REST_API
> parameters:
> baseUrl: {$.novaURL}
> actions:
> createVM:
> parameters:
> url: /servers/{$.vm_id}
> method: POST
>
> There's no information about "REST" or "API" here. It's just a spec how to
> form an HTTP request.
>
> Thoughts?
>
> Renat Akhmerov
> @ Mirantis Inc.
>
>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
--
Best Regards,
Nikolay
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Mistral] Renaming action types
Folks,
I’m proposing to rename these two action types REST_API and MISTRAL_REST_API to
HTTP and MISTRAL_HTTP. Words “REST” and “API” don’t look correct to me, if you
look at
Services:
Nova:
type: REST_API
parameters:
baseUrl: {$.novaURL}
actions:
createVM:
parameters:
url: /servers/{$.vm_id}
method: POST
There’s no information about “REST” or “API” here. It’s just a spec how to form
an HTTP request.
Thoughts?
Renat Akhmerov
@ Mirantis Inc.
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
