Re: [openstack-dev] [Neutron] [horizon] Netaddr 0.7.16 and gate breakage

2015-08-31 Thread Sean Dague
Horizon also needs to backport this change -
https://jenkins07.openstack.org/job/gate-horizon-python27/4803/console

https://review.openstack.org/#/c/198089/ is a stable/kilo patch failing
on the same test failure.

-Sean

On 08/31/2015 10:48 AM, Akihiro Motoki wrote:
> For Horizon, the fix is now in the gate queue.
> https://review.openstack.org/#/c/218786/
> It only skips the related test, but the failing test is specific to
> vendor plugin implementation
> and we can explore the fix later.
> 
> Regarding the stable releases, Horizon may also need the similar version
> cap for what we did for Neutron.
> I will check it.
> 
> Akihiro
> 
> 2015-08-31 20:54 GMT+09:00 Sean Dague  >:
> 
> On 08/31/2015 06:48 AM, Ihar Hrachyshka wrote:
> >> On 31 Aug 2015, at 08:19, Kevin Benton  > wrote:
> >>
> >> Even if this version is fixed for valid_mac, it appears the netaddr 
> authors made the decision to make a backwards incompatible change WRT to the 
> 'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and /32. 
> This means that all future versions of netaddr will be incompatible with the 
> current releases of Neutron.
> >>
> >> I have a fix for master here: 
> https://review.openstack.org/#/c/218723/, but we will need to cap
> netaddr in global requirements for kilo and juno and then consider
> back-porting the changes. Additionally, we should probably release a
> note indicating that upgrading netaddr is disastrous for all
> released versions of openstack using Neutron.
> >>
> >> Cheers
> >
> > For Juno, we already cap the version of the library to <= 0.7.13. As 
> for kilo, I pushed the following change: 
> https://review.openstack.org/#/c/218805/
> 
> This looks like it's tanking Horizon unit tests as well -
> 
> http://logs.openstack.org/00/207800/1/gate/gate-horizon-python27/980e8a1/console.html#_2015-08-31_11_36_16_378
> 
> -Sean
> 
> --
> Sean Dague
> http://dague.net
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
Sean Dague
http://dague.net

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] [horizon] Netaddr 0.7.16 and gate breakage

2015-08-31 Thread Ihar Hrachyshka
> On 31 Aug 2015, at 16:48, Akihiro Motoki  wrote:
> 
> For Horizon, the fix is now in the gate queue.
> https://review.openstack.org/#/c/218786/
> It only skips the related test, but the failing test is specific to vendor 
> plugin implementation
> and we can explore the fix later.
> 
> Regarding the stable releases, Horizon may also need the similar version cap 
> for what we did for Neutron.
> I will check it.
> 
> Akihiro
> 
> 2015-08-31 20:54 GMT+09:00 Sean Dague :
> On 08/31/2015 06:48 AM, Ihar Hrachyshka wrote:
> >> On 31 Aug 2015, at 08:19, Kevin Benton  wrote:
> >>
> >> Even if this version is fixed for valid_mac, it appears the netaddr 
> >> authors made the decision to make a backwards incompatible change WRT to 
> >> the 'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and 
> >> /32. This means that all future versions of netaddr will be incompatible 
> >> with the current releases of Neutron.
> >>
> >> I have a fix for master here: https://review.openstack.org/#/c/218723/, 
> >> but we will need to cap netaddr in global requirements for kilo and juno 
> >> and then consider back-porting the changes. Additionally, we should 
> >> probably release a note indicating that upgrading netaddr is disastrous 
> >> for all released versions of openstack using Neutron.
> >>
> >> Cheers
> >
> > For Juno, we already cap the version of the library to <= 0.7.13. As for 
> > kilo, I pushed the following change: 
> > https://review.openstack.org/#/c/218805/
> 
> This looks like it's tanking Horizon unit tests as well -
> http://logs.openstack.org/00/207800/1/gate/gate-horizon-python27/980e8a1/console.html#_2015-08-31_11_36_16_378
> 
> -Sean


Note that in Neutron, we need to backport the real fix into stable/kilo [1] 
before master to pass grenade job. Otherwise, Neutron itself may be fine 
without capping the version in global requirements, but if horizon folks think 
they don’t want to cherry-pick their fix to stable/kilo, then I am fine to 
proceed with the cap.

[1]: https://review.openstack.org/#/c/218852/

Ihar


signature.asc
Description: Message signed with OpenPGP using GPGMail
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] [horizon] Netaddr 0.7.16 and gate breakage

2015-08-31 Thread Timur Sufiev
Given that Horizon unit test breakage was introduced simultaneously with
the breakage of 2 integration tests, the latter ones have the same nature.
Thus integration tests are going to fail until the related Neutron patch is
merged.

On Mon, Aug 31, 2015 at 5:50 PM Akihiro Motoki  wrote:

> For Horizon, the fix is now in the gate queue.
> https://review.openstack.org/#/c/218786/
> It only skips the related test, but the failing test is specific to vendor
> plugin implementation
> and we can explore the fix later.
>
> Regarding the stable releases, Horizon may also need the similar version
> cap for what we did for Neutron.
> I will check it.
>
> Akihiro
>
> 2015-08-31 20:54 GMT+09:00 Sean Dague :
>
>> On 08/31/2015 06:48 AM, Ihar Hrachyshka wrote:
>> >> On 31 Aug 2015, at 08:19, Kevin Benton  wrote:
>> >>
>> >> Even if this version is fixed for valid_mac, it appears the netaddr
>> authors made the decision to make a backwards incompatible change WRT to
>> the 'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and
>> /32. This means that all future versions of netaddr will be incompatible
>> with the current releases of Neutron.
>> >>
>> >> I have a fix for master here: https://review.openstack.org/#/c/218723/,
>> but we will need to cap netaddr in global requirements for kilo and juno
>> and then consider back-porting the changes. Additionally, we should
>> probably release a note indicating that upgrading netaddr is disastrous for
>> all released versions of openstack using Neutron.
>> >>
>> >> Cheers
>> >
>> > For Juno, we already cap the version of the library to <= 0.7.13. As
>> for kilo, I pushed the following change:
>> https://review.openstack.org/#/c/218805/
>>
>> This looks like it's tanking Horizon unit tests as well -
>>
>> http://logs.openstack.org/00/207800/1/gate/gate-horizon-python27/980e8a1/console.html#_2015-08-31_11_36_16_378
>>
>> -Sean
>>
>> --
>> Sean Dague
>> http://dague.net
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] [horizon] Netaddr 0.7.16 and gate breakage

2015-08-31 Thread Akihiro Motoki
For Horizon, the fix is now in the gate queue.
https://review.openstack.org/#/c/218786/
It only skips the related test, but the failing test is specific to vendor
plugin implementation
and we can explore the fix later.

Regarding the stable releases, Horizon may also need the similar version
cap for what we did for Neutron.
I will check it.

Akihiro

2015-08-31 20:54 GMT+09:00 Sean Dague :

> On 08/31/2015 06:48 AM, Ihar Hrachyshka wrote:
> >> On 31 Aug 2015, at 08:19, Kevin Benton  wrote:
> >>
> >> Even if this version is fixed for valid_mac, it appears the netaddr
> authors made the decision to make a backwards incompatible change WRT to
> the 'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and
> /32. This means that all future versions of netaddr will be incompatible
> with the current releases of Neutron.
> >>
> >> I have a fix for master here: https://review.openstack.org/#/c/218723/,
> but we will need to cap netaddr in global requirements for kilo and juno
> and then consider back-porting the changes. Additionally, we should
> probably release a note indicating that upgrading netaddr is disastrous for
> all released versions of openstack using Neutron.
> >>
> >> Cheers
> >
> > For Juno, we already cap the version of the library to <= 0.7.13. As for
> kilo, I pushed the following change:
> https://review.openstack.org/#/c/218805/
>
> This looks like it's tanking Horizon unit tests as well -
>
> http://logs.openstack.org/00/207800/1/gate/gate-horizon-python27/980e8a1/console.html#_2015-08-31_11_36_16_378
>
> -Sean
>
> --
> Sean Dague
> http://dague.net
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] [horizon] Netaddr 0.7.16 and gate breakage

2015-08-31 Thread Sean Dague
On 08/31/2015 06:48 AM, Ihar Hrachyshka wrote:
>> On 31 Aug 2015, at 08:19, Kevin Benton  wrote:
>>
>> Even if this version is fixed for valid_mac, it appears the netaddr authors 
>> made the decision to make a backwards incompatible change WRT to the 
>> 'broadcast' attribute on IPNetwork objects that have CIDRs of /31 and /32. 
>> This means that all future versions of netaddr will be incompatible with the 
>> current releases of Neutron.
>>
>> I have a fix for master here: https://review.openstack.org/#/c/218723/, but 
>> we will need to cap netaddr in global requirements for kilo and juno and 
>> then consider back-porting the changes. Additionally, we should probably 
>> release a note indicating that upgrading netaddr is disastrous for all 
>> released versions of openstack using Neutron.
>>
>> Cheers
> 
> For Juno, we already cap the version of the library to <= 0.7.13. As for 
> kilo, I pushed the following change: https://review.openstack.org/#/c/218805/

This looks like it's tanking Horizon unit tests as well -
http://logs.openstack.org/00/207800/1/gate/gate-horizon-python27/980e8a1/console.html#_2015-08-31_11_36_16_378

-Sean

-- 
Sean Dague
http://dague.net

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev