Re: [openstack-dev] [Nova] All I want for Christmas is one more +2 ...
On 12/12/2013 8:22 AM, Day, Phil wrote: Hi Cores, The “Stop, Rescue, and Delete should give guest a chance to shutdown” change https://review.openstack.org/#/c/35303/ was approved a couple of days ago, but failed to merge because the RPC version had moved on. Its rebased and sitting there with one +2 and a bunch of +1s -would be really nice if it could land before it needs another rebase please ? Thanks Phil ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Since this is happening to others that are requesting reviews in the mailing list, even on patches with several +1s and a +2, and it's way after the fact, I'm going to link this: http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html Maybe we should update the blurb here also to say 'in IRC' to nix any confusion about the mailing list. https://wiki.openstack.org/wiki/ReviewChecklist#Notes_for_Non-Core_Developers -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] All I want for Christmas is one more +2 ...
I've had to rebase this a couple of times since to keep ahead of RPC version numbers - sitting there with a +1 from Jenkins at the moment: https://review.openstack.org/#/c/35303/ Phil -Original Message- From: Russell Bryant [mailto:rbry...@redhat.com] Sent: 12 December 2013 14:38 To: openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] [Nova] All I want for Christmas is one more +2 ... On 12/12/2013 09:22 AM, Day, Phil wrote: Hi Cores, The Stop, Rescue, and Delete should give guest a chance to shutdown change https://review.openstack.org/#/c/35303/ was approved a couple of days ago, but failed to merge because the RPC version had moved on. Its rebased and sitting there with one +2 and a bunch of +1s -would be really nice if it could land before it needs another rebase please ? Approved. FWIW, I'm fine with folks approving with a single +2 for cases where a patch is approved but needed a simple rebase. This happens pretty often. We even have a script that generates a list of patches still open that were previously approved: http://russellbryant.net/openstack-stats/nova-openapproved.txt -- Russell Bryant ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Nova] All I want for Christmas is one more +2 ...
Hi Cores, The Stop, Rescue, and Delete should give guest a chance to shutdown change https://review.openstack.org/#/c/35303/ was approved a couple of days ago, but failed to merge because the RPC version had moved on. Its rebased and sitting there with one +2 and a bunch of +1s -would be really nice if it could land before it needs another rebase please ? Thanks Phil ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] All I want for Christmas is one more +2 ...
On 12/12/2013 09:22 AM, Day, Phil wrote: Hi Cores, The “Stop, Rescue, and Delete should give guest a chance to shutdown” change https://review.openstack.org/#/c/35303/ was approved a couple of days ago, but failed to merge because the RPC version had moved on. Its rebased and sitting there with one +2 and a bunch of +1s -would be really nice if it could land before it needs another rebase please ? Approved. FWIW, I'm fine with folks approving with a single +2 for cases where a patch is approved but needed a simple rebase. This happens pretty often. We even have a script that generates a list of patches still open that were previously approved: http://russellbryant.net/openstack-stats/nova-openapproved.txt -- Russell Bryant ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
